gocardless_pro 1.0.5 → 1.1.0

data/lib/gocardless_pro/services/refunds_service.rb

@@ -1,10 +1,11 @@
 require_relative './base_service'
+require 'uri'
 
 # encoding: utf-8
 #
-# WARNING: Do not edit by hand, this file was generated by Crank:
+# This client is automatically generated from a template and JSON schema definition.
+# See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.
 #
-#   https://github.com/gocardless/crank
 
 module GoCardlessPro
   module Services
@@ -44,7 +45,7 @@ module GoCardlessPro
         Resources::Refund.new(unenvelope_body(response.body), response)
       end
 
-      # Returns a [cursor-paginated](#overview-cursor-pagination) list of your
+      # Returns a [cursor-paginated](#api-usage-cursor-pagination) list of your
       # refunds.
       # Example URL: /refunds
       # @param options [Hash] parameters as a hash, under a params key.
@@ -117,12 +118,12 @@ module GoCardlessPro
         'refunds'
       end
 
-      # take a URL with placeholder params and substitute them out for the acutal value
+      # take a URL with placeholder params and substitute them out for the actual value
       # @param url [String] the URL with placeholders in
-      # @param param_map [Hash] a hash of placeholders and their actual values
+      # @param param_map [Hash] a hash of placeholders and their actual values (which will be escaped)
       def sub_url(url, param_map)
         param_map.reduce(url) do |new_url, (param, value)|
-          new_url.gsub(":#{param}", value)
+          new_url.gsub(":#{param}", URI.escape(value))
         end
       end
     end

data/lib/gocardless_pro/services/subscriptions_service.rb

@@ -1,10 +1,11 @@
 require_relative './base_service'
+require 'uri'
 
 # encoding: utf-8
 #
-# WARNING: Do not edit by hand, this file was generated by Crank:
+# This client is automatically generated from a template and JSON schema definition.
+# See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.
 #
-#   https://github.com/gocardless/crank
 
 module GoCardlessPro
   module Services
@@ -26,7 +27,7 @@ module GoCardlessPro
         Resources::Subscription.new(unenvelope_body(response.body), response)
       end
 
-      # Returns a [cursor-paginated](#overview-cursor-pagination) list of your
+      # Returns a [cursor-paginated](#api-usage-cursor-pagination) list of your
       # subscriptions.
       # Example URL: /subscriptions
       # @param options [Hash] parameters as a hash, under a params key.
@@ -122,12 +123,12 @@ module GoCardlessPro
         'subscriptions'
       end
 
-      # take a URL with placeholder params and substitute them out for the acutal value
+      # take a URL with placeholder params and substitute them out for the actual value
       # @param url [String] the URL with placeholders in
-      # @param param_map [Hash] a hash of placeholders and their actual values
+      # @param param_map [Hash] a hash of placeholders and their actual values (which will be escaped)
       def sub_url(url, param_map)
         param_map.reduce(url) do |new_url, (param, value)|
-          new_url.gsub(":#{param}", value)
+          new_url.gsub(":#{param}", URI.escape(value))
         end
       end
     end

data/lib/gocardless_pro/version.rb

@@ -4,5 +4,5 @@ end
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '1.0.5'
+  VERSION = '1.1.0'
 end

data/lib/gocardless_pro.rb

@@ -1,8 +1,7 @@
 # encoding: utf-8
 #
-# WARNING: Do not edit by hand, this file was generated by Crank:
-#
-#   https://github.com/gocardless/crank
+# This client is automatically generated from a template and JSON schema definition.
+# See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.
 #
 
 require 'json'

data/spec/resources/creditor_spec.rb

@@ -29,11 +29,15 @@ describe GoCardlessPro::Resources::Creditor do
 
         },
 
+        'logo_url' => 'logo_url-input',
+
         'name' => 'name-input',
 
         'postal_code' => 'postal_code-input',
 
-        'region' => 'region-input'
+        'region' => 'region-input',
+
+        'scheme_identifiers' => 'scheme_identifiers-input'
 
       }
     end
@@ -61,11 +65,15 @@ describe GoCardlessPro::Resources::Creditor do
 
       expect(resource.links.default_sek_payout_account).to eq('default_sek_payout_account-input')
 
+      expect(resource.logo_url).to eq('logo_url-input')
+
       expect(resource.name).to eq('name-input')
 
       expect(resource.postal_code).to eq('postal_code-input')
 
       expect(resource.region).to eq('region-input')
+
+      expect(resource.scheme_identifiers).to eq('scheme_identifiers-input')
     end
 
     it 'can handle new attributes without erroring' do

data/spec/resources/event_spec.rb

@@ -19,6 +19,8 @@ describe GoCardlessPro::Resources::Event do
 
           'new_customer_bank_account' => 'new_customer_bank_account-input',
 
+          'new_mandate' => 'new_mandate-input',
+
           'organisation' => 'organisation-input',
 
           'parent_event' => 'parent_event-input',
@@ -57,6 +59,8 @@ describe GoCardlessPro::Resources::Event do
 
       expect(resource.links.new_customer_bank_account).to eq('new_customer_bank_account-input')
 
+      expect(resource.links.new_mandate).to eq('new_mandate-input')
+
       expect(resource.links.organisation).to eq('organisation-input')
 
       expect(resource.links.parent_event).to eq('parent_event-input')

data/spec/resources/mandate_spec.rb

@@ -13,7 +13,11 @@ describe GoCardlessPro::Resources::Mandate do
 
           'creditor' => 'creditor-input',
 
-          'customer_bank_account' => 'customer_bank_account-input'
+          'customer' => 'customer-input',
+
+          'customer_bank_account' => 'customer_bank_account-input',
+
+          'new_mandate' => 'new_mandate-input'
 
         },
 
@@ -41,8 +45,12 @@ describe GoCardlessPro::Resources::Mandate do
 
       expect(resource.links.creditor).to eq('creditor-input')
 
+      expect(resource.links.customer).to eq('customer-input')
+
       expect(resource.links.customer_bank_account).to eq('customer_bank_account-input')
 
+      expect(resource.links.new_mandate).to eq('new_mandate-input')
+
       expect(resource.metadata).to eq('metadata-input')
 
       expect(resource.next_possible_charge_date).to eq('next_possible_charge_date-input')

data/spec/resources/subscription_spec.rb

@@ -7,8 +7,6 @@ describe GoCardlessPro::Resources::Subscription do
 
         'amount' => 'amount-input',
 
-        'count' => 'count-input',
-
         'created_at' => 'created_at-input',
 
         'currency' => 'currency-input',
@@ -51,8 +49,6 @@ describe GoCardlessPro::Resources::Subscription do
 
       expect(resource.amount).to eq('amount-input')
 
-      expect(resource.count).to eq('count-input')
-
       expect(resource.created_at).to eq('created_at-input')
 
       expect(resource.currency).to eq('currency-input')

data/spec/services/creditor_bank_accounts_service_spec.rb

@@ -301,6 +301,14 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#disable' do

data/spec/services/creditors_service_spec.rb

@@ -21,9 +21,11 @@ describe GoCardlessPro::Services::CreditorsService do
           'created_at' => 'created_at-input',
           'id' => 'id-input',
           'links' => 'links-input',
+          'logo_url' => 'logo_url-input',
           'name' => 'name-input',
           'postal_code' => 'postal_code-input',
-          'region' => 'region-input'
+          'region' => 'region-input',
+          'scheme_identifiers' => 'scheme_identifiers-input'
         }
       end
 
@@ -41,9 +43,11 @@ describe GoCardlessPro::Services::CreditorsService do
                 'created_at' => 'created_at-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
+                'logo_url' => 'logo_url-input',
                 'name' => 'name-input',
                 'postal_code' => 'postal_code-input',
-                'region' => 'region-input'
+                'region' => 'region-input',
+                'scheme_identifiers' => 'scheme_identifiers-input'
               }
             }
           )
@@ -61,9 +65,11 @@ describe GoCardlessPro::Services::CreditorsService do
                   'created_at' => 'created_at-input',
                   'id' => 'id-input',
                   'links' => 'links-input',
+                  'logo_url' => 'logo_url-input',
                   'name' => 'name-input',
                   'postal_code' => 'postal_code-input',
-                  'region' => 'region-input'
+                  'region' => 'region-input',
+                  'scheme_identifiers' => 'scheme_identifiers-input'
                 }
 
             }.to_json,
@@ -118,9 +124,11 @@ describe GoCardlessPro::Services::CreditorsService do
               'created_at' => 'created_at-input',
               'id' => 'id-input',
               'links' => 'links-input',
+              'logo_url' => 'logo_url-input',
               'name' => 'name-input',
               'postal_code' => 'postal_code-input',
-              'region' => 'region-input'
+              'region' => 'region-input',
+              'scheme_identifiers' => 'scheme_identifiers-input'
             }],
             meta: {
               cursors: {
@@ -150,11 +158,15 @@ describe GoCardlessPro::Services::CreditorsService do
 
         expect(get_list_response.records.first.id).to eq('id-input')
 
+        expect(get_list_response.records.first.logo_url).to eq('logo_url-input')
+
         expect(get_list_response.records.first.name).to eq('name-input')
 
         expect(get_list_response.records.first.postal_code).to eq('postal_code-input')
 
         expect(get_list_response.records.first.region).to eq('region-input')
+
+        expect(get_list_response.records.first.scheme_identifiers).to eq('scheme_identifiers-input')
       end
 
       it 'exposes the cursors for before and after' do
@@ -180,9 +192,11 @@ describe GoCardlessPro::Services::CreditorsService do
             'created_at' => 'created_at-input',
             'id' => 'id-input',
             'links' => 'links-input',
+            'logo_url' => 'logo_url-input',
             'name' => 'name-input',
             'postal_code' => 'postal_code-input',
-            'region' => 'region-input'
+            'region' => 'region-input',
+            'scheme_identifiers' => 'scheme_identifiers-input'
           }],
           meta: {
             cursors: { after: 'AB345' },
@@ -206,9 +220,11 @@ describe GoCardlessPro::Services::CreditorsService do
             'created_at' => 'created_at-input',
             'id' => 'id-input',
             'links' => 'links-input',
+            'logo_url' => 'logo_url-input',
             'name' => 'name-input',
             'postal_code' => 'postal_code-input',
-            'region' => 'region-input'
+            'region' => 'region-input',
+            'scheme_identifiers' => 'scheme_identifiers-input'
           }],
           meta: {
             limit: 2,
@@ -248,9 +264,11 @@ describe GoCardlessPro::Services::CreditorsService do
                 'created_at' => 'created_at-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
+                'logo_url' => 'logo_url-input',
                 'name' => 'name-input',
                 'postal_code' => 'postal_code-input',
-                'region' => 'region-input'
+                'region' => 'region-input',
+                'scheme_identifiers' => 'scheme_identifiers-input'
               }
             }.to_json,
             headers: { 'Content-Type' => 'application/json' }
@@ -284,9 +302,11 @@ describe GoCardlessPro::Services::CreditorsService do
               'created_at' => 'created_at-input',
               'id' => 'id-input',
               'links' => 'links-input',
+              'logo_url' => 'logo_url-input',
               'name' => 'name-input',
               'postal_code' => 'postal_code-input',
-              'region' => 'region-input'
+              'region' => 'region-input',
+              'scheme_identifiers' => 'scheme_identifiers-input'
             }
           }.to_json,
           headers: { 'Content-Type' => 'application/json' }
@@ -311,6 +331,14 @@ describe GoCardlessPro::Services::CreditorsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do
@@ -334,9 +362,11 @@ describe GoCardlessPro::Services::CreditorsService do
               'created_at' => 'created_at-input',
               'id' => 'id-input',
               'links' => 'links-input',
+              'logo_url' => 'logo_url-input',
               'name' => 'name-input',
               'postal_code' => 'postal_code-input',
-              'region' => 'region-input'
+              'region' => 'region-input',
+              'scheme_identifiers' => 'scheme_identifiers-input'
             }
           }.to_json,
           headers: { 'Content-Type' => 'application/json' }

data/spec/services/customer_bank_accounts_service_spec.rb

@@ -301,6 +301,14 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do

data/spec/services/customers_service_spec.rb

@@ -363,6 +363,14 @@ describe GoCardlessPro::Services::CustomersService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do

data/spec/services/events_service_spec.rb

@@ -189,5 +189,13 @@ describe GoCardlessPro::Services::EventsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 end

data/spec/services/mandates_service_spec.rb

@@ -291,6 +291,14 @@ describe GoCardlessPro::Services::MandatesService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do

data/spec/services/payments_service_spec.rb

@@ -311,6 +311,14 @@ describe GoCardlessPro::Services::PaymentsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do

data/spec/services/payouts_service_spec.rb

@@ -203,5 +203,13 @@ describe GoCardlessPro::Services::PayoutsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 end

data/spec/services/redirect_flows_service_spec.rb

@@ -171,6 +171,14 @@ describe GoCardlessPro::Services::RedirectFlowsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#complete' do

data/spec/services/refunds_service_spec.rb

@@ -271,6 +271,14 @@ describe GoCardlessPro::Services::RefundsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do

data/spec/services/subscriptions_service_spec.rb

@@ -14,7 +14,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
         {
 
           'amount' => 'amount-input',
-          'count' => 'count-input',
           'created_at' => 'created_at-input',
           'currency' => 'currency-input',
           'day_of_month' => 'day_of_month-input',
@@ -40,7 +39,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
               'subscriptions' => {
 
                 'amount' => 'amount-input',
-                'count' => 'count-input',
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'day_of_month' => 'day_of_month-input',
@@ -66,7 +64,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
                 {
 
                   'amount' => 'amount-input',
-                  'count' => 'count-input',
                   'created_at' => 'created_at-input',
                   'currency' => 'currency-input',
                   'day_of_month' => 'day_of_month-input',
@@ -129,7 +126,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
             'subscriptions' => [{
 
               'amount' => 'amount-input',
-              'count' => 'count-input',
               'created_at' => 'created_at-input',
               'currency' => 'currency-input',
               'day_of_month' => 'day_of_month-input',
@@ -162,8 +158,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
 
         expect(get_list_response.records.first.amount).to eq('amount-input')
 
-        expect(get_list_response.records.first.count).to eq('count-input')
-
         expect(get_list_response.records.first.created_at).to eq('created_at-input')
 
         expect(get_list_response.records.first.currency).to eq('currency-input')
@@ -209,7 +203,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
           'subscriptions' => [{
 
             'amount' => 'amount-input',
-            'count' => 'count-input',
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'day_of_month' => 'day_of_month-input',
@@ -241,7 +234,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
           'subscriptions' => [{
 
             'amount' => 'amount-input',
-            'count' => 'count-input',
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'day_of_month' => 'day_of_month-input',
@@ -289,7 +281,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
               'subscriptions' => {
 
                 'amount' => 'amount-input',
-                'count' => 'count-input',
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'day_of_month' => 'day_of_month-input',
@@ -331,7 +322,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
             'subscriptions' => {
 
               'amount' => 'amount-input',
-              'count' => 'count-input',
               'created_at' => 'created_at-input',
               'currency' => 'currency-input',
               'day_of_month' => 'day_of_month-input',
@@ -371,6 +361,14 @@ describe GoCardlessPro::Services::SubscriptionsService do
         expect(get_response).to be_nil
       end
     end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
   end
 
   describe '#update' do
@@ -387,7 +385,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
             'subscriptions' => {
 
               'amount' => 'amount-input',
-              'count' => 'count-input',
               'created_at' => 'created_at-input',
               'currency' => 'currency-input',
               'day_of_month' => 'day_of_month-input',
@@ -429,7 +426,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
           'subscriptions' => {
 
             'amount' => 'amount-input',
-            'count' => 'count-input',
             'created_at' => 'created_at-input',
             'currency' => 'currency-input',
             'day_of_month' => 'day_of_month-input',
@@ -476,7 +472,6 @@ describe GoCardlessPro::Services::SubscriptionsService do
               'subscriptions' => {
 
                 'amount' => 'amount-input',
-                'count' => 'count-input',
                 'created_at' => 'created_at-input',
                 'currency' => 'currency-input',
                 'day_of_month' => 'day_of_month-input',