gocardless_pro 1.0.0 → 1.0.1

data/spec/resources/customer_spec.rb

@@ -64,7 +64,7 @@ describe GoCardlessPro::Resources::Customer do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -125,6 +125,13 @@ describe GoCardlessPro::Resources::Customer do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/event_spec.rb

@@ -54,7 +54,7 @@ describe GoCardlessPro::Resources::Event do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -103,6 +103,18 @@ describe GoCardlessPro::Resources::Event do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/mandate_pdf_spec.rb

@@ -16,7 +16,7 @@ describe GoCardlessPro::Resources::MandatePdf do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -29,6 +29,13 @@ describe GoCardlessPro::Resources::MandatePdf do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/mandate_spec.rb

@@ -46,7 +46,7 @@ describe GoCardlessPro::Resources::Mandate do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -87,6 +87,18 @@ describe GoCardlessPro::Resources::Mandate do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/payment_spec.rb

@@ -62,7 +62,7 @@ describe GoCardlessPro::Resources::Payment do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -119,6 +119,18 @@ describe GoCardlessPro::Resources::Payment do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/payout_spec.rb

@@ -42,7 +42,7 @@ describe GoCardlessPro::Resources::Payout do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -79,6 +79,18 @@ describe GoCardlessPro::Resources::Payout do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/redirect_flow_spec.rb

@@ -22,6 +22,10 @@ describe GoCardlessPro::Resources::RedirectFlow do
           
             "creditor" => "creditor-input",
           
+            "customer" => "customer-input",
+          
+            "customer_bank_account" => "customer_bank_account-input",
+          
             "mandate" => "mandate-input",
           
         },
@@ -46,7 +50,7 @@ describe GoCardlessPro::Resources::RedirectFlow do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -65,6 +69,10 @@ describe GoCardlessPro::Resources::RedirectFlow do
          
            expect(resource.links.creditor).to eq("creditor-input")
          
+           expect(resource.links.customer).to eq("customer-input")
+         
+           expect(resource.links.customer_bank_account).to eq("customer_bank_account-input")
+         
            expect(resource.links.mandate).to eq("mandate-input")
          
        
@@ -87,6 +95,18 @@ describe GoCardlessPro::Resources::RedirectFlow do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/refund_spec.rb

@@ -36,7 +36,7 @@ describe GoCardlessPro::Resources::Refund do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -67,6 +67,18 @@ describe GoCardlessPro::Resources::Refund do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/resources/subscription_spec.rb

@@ -80,7 +80,7 @@ describe GoCardlessPro::Resources::Subscription do
       }
     end
 
-    it "can be initialized from an uneveloped response" do
+    it "can be initialized from an unenveloped response" do
       resource = described_class.new(data)
       
        
@@ -155,6 +155,18 @@ describe GoCardlessPro::Resources::Subscription do
        
     end
 
+    it "can handle new attributes without erroring" do
+      data["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+
+    
+    it "can handle new link attributes without erroring" do
+      data["links"]["foo"] = "bar"
+      expect { described_class.new(data) }.to_not raise_error
+    end
+    
+
     describe "#to_h" do
       it "returns a hash representing the resource" do
         expect(described_class.new(data).to_h).to eq(data)

data/spec/services/bank_details_lookups_service_spec.rb

@@ -9,6 +9,7 @@ describe GoCardlessPro::Services::BankDetailsLookupsService do
 
   
   
+  
     
 
     
@@ -20,26 +21,29 @@ describe GoCardlessPro::Services::BankDetailsLookupsService do
           
           "available_debit_schemes" => "available_debit_schemes-input",
           "bank_name" => "bank_name-input",
+          "bic" => "bic-input",
           }
         end
 
         before do
-          stub_request(:post, /.*api.gocardless.com\/bank_details_lookups/).
+          stub_request(:post, %r(.*api.gocardless.com/bank_details_lookups)).
           with(
             body: {
-              bank_details_lookups: {
+              "bank_details_lookups" => {
                 
                 "available_debit_schemes" => "available_debit_schemes-input",
                 "bank_name" => "bank_name-input",
+                "bic" => "bic-input",
                 }
             }
           ).
           to_return(
             body: {
-              bank_details_lookups: {
+              "bank_details_lookups" => {
                 
                 "available_debit_schemes" => "available_debit_schemes-input",
                 "bank_name" => "bank_name-input",
+                "bic" => "bic-input",
                 }
             }.to_json,
             :headers => {'Content-Type' => 'application/json'}
@@ -55,7 +59,7 @@ describe GoCardlessPro::Services::BankDetailsLookupsService do
         let(:new_resource) { {} }
 
         before do
-          stub_request(:post, /.*api.gocardless.com\/bank_details_lookups/).to_return(
+          stub_request(:post, %r(.*api.gocardless.com/bank_details_lookups)).to_return(
             body: {
               error: {
                 type: 'validation_failed',

data/spec/services/creditor_bank_accounts_service_spec.rb

@@ -9,6 +9,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
   
   
+  
     
 
     
@@ -32,10 +33,10 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
         end
 
         before do
-          stub_request(:post, /.*api.gocardless.com\/creditor_bank_accounts/).
+          stub_request(:post, %r(.*api.gocardless.com/creditor_bank_accounts)).
           with(
             body: {
-              creditor_bank_accounts: {
+              "creditor_bank_accounts" => {
                 
                 "account_holder_name" => "account_holder_name-input",
                 "account_number_ending" => "account_number_ending-input",
@@ -52,7 +53,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
           ).
           to_return(
             body: {
-              creditor_bank_accounts: {
+              "creditor_bank_accounts" => {
                 
                 "account_holder_name" => "account_holder_name-input",
                 "account_number_ending" => "account_number_ending-input",
@@ -79,7 +80,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
         let(:new_resource) { {} }
 
         before do
-          stub_request(:post, /.*api.gocardless.com\/creditor_bank_accounts/).to_return(
+          stub_request(:post, %r(.*api.gocardless.com/creditor_bank_accounts)).to_return(
             body: {
               error: {
                 type: 'validation_failed',
@@ -109,9 +110,9 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
         subject(:get_list_response) { client.creditor_bank_accounts.list }
 
         before do
-          stub_request(:get, /.*api.gocardless.com\/creditor_bank_accounts/).to_return(
+          stub_request(:get, %r(.*api.gocardless.com/creditor_bank_accounts)).to_return(
             body: {
-              creditor_bank_accounts: [{
+              "creditor_bank_accounts" => [{
                 
                 "account_holder_name" => "account_holder_name-input",
                 "account_number_ending" => "account_number_ending-input",
@@ -190,9 +191,9 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
     describe "#all" do
       let!(:first_response_stub) do
-        stub_request(:get, /.*api.gocardless.com\/creditor_bank_accounts$/).to_return(
+        stub_request(:get, %r(.*api.gocardless.com/creditor_bank_accounts$)).to_return(
           body: {
-            creditor_bank_accounts: [{
+            "creditor_bank_accounts" => [{
               
               "account_holder_name" => "account_holder_name-input",
               "account_number_ending" => "account_number_ending-input",
@@ -215,9 +216,9 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
       end
 
       let!(:second_response_stub) do
-        stub_request(:get, /.*api.gocardless.com\/creditor_bank_accounts\?after=AB345/).to_return(
+        stub_request(:get, %r(.*api.gocardless.com/creditor_bank_accounts\?after=AB345)).to_return(
           body: {
-            creditor_bank_accounts: [{
+            "creditor_bank_accounts" => [{
               
               "account_holder_name" => "account_holder_name-input",
               "account_number_ending" => "account_number_ending-input",
@@ -258,11 +259,12 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
       context "passing in a custom header" do
         let!(:stub) do
-          stub_request(:get, /.*api.gocardless.com\/creditor_bank_accounts\/ID123/)
-          .with(headers: { 'Foo' => 'Bar' })
-          .to_return(
+          stub_url = "/creditor_bank_accounts/:identity".gsub(':identity', id)
+          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).
+          with(headers: { 'Foo' => 'Bar' }).
+          to_return(
             body: {
-              creditor_bank_accounts: {
+              "creditor_bank_accounts" => {
                 
                 "account_holder_name" => "account_holder_name-input",
                 "account_number_ending" => "account_number_ending-input",
@@ -294,9 +296,10 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
       context "when there is a creditor_bank_account to return" do
         before do
-          stub_request(:get, /.*api.gocardless.com\/creditor_bank_accounts\/ID123/).to_return(
+          stub_url = "/creditor_bank_accounts/:identity".gsub(':identity', id)
+          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).to_return(
             body: {
-              creditor_bank_accounts: {
+              "creditor_bank_accounts" => {
                 
                 "account_holder_name" => "account_holder_name-input",
                 "account_number_ending" => "account_number_ending-input",
@@ -321,7 +324,8 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
       context "when nothing is returned" do
         before do
-          stub_request(:get, /.*api.gocardless.com\/creditor_bank_accounts\/ID123/).to_return(
+          stub_url = "/creditor_bank_accounts/:identity".gsub(':identity', id)
+          stub_request(:get, %r(.*api.gocardless.com#{stub_url})).to_return(
             body: "",
             headers: { 'Content-Type' => 'application/json' }
           )
@@ -348,9 +352,9 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
       let!(:stub) do
         # /creditor_bank_accounts/%v/actions/disable
         stub_url = "/creditor_bank_accounts/:identity/actions/disable".gsub(':identity', resource_id)
-        stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+        stub_request(:post, %r(.*api.gocardless.com#{stub_url})).to_return(
           body: {
-            creditor_bank_accounts: {
+            "creditor_bank_accounts" => {
               
               "account_holder_name" => "account_holder_name-input",
               "account_number_ending" => "account_number_ending-input",
@@ -385,13 +389,13 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
         let!(:stub) do
           # /creditor_bank_accounts/%v/actions/disable
           stub_url = "/creditor_bank_accounts/:identity/actions/disable".gsub(':identity', resource_id)
-          stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+          stub_request(:post, %r(.*api.gocardless.com#{stub_url})).
           with(
             body: { foo: 'bar' },
             headers: { 'Foo' => 'Bar' }
           ).to_return(
             body: {
-              creditor_bank_accounts: {
+              "creditor_bank_accounts" => {
                 
                 "account_holder_name" => "account_holder_name-input",
                 "account_number_ending" => "account_number_ending-input",