gocardless 1.3.2 → 1.4.0

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.4.0 - October 29, 2012
+
+- Allow app id and secret to be set with environment variables
+- Relax the oauth dependency
+
 ## 1.3.2 - October 01, 2012
 
 - Fix filtering on sub resource methods, e.g. `merchant.bills(source_id: 'x')`

data/gocardless.gemspec

@@ -1,7 +1,7 @@
 require File.expand_path('../lib/gocardless/version', __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.add_runtime_dependency 'oauth2', '~> 0.7.1'
+  gem.add_runtime_dependency 'oauth2', '~> 0.7'
   gem.add_runtime_dependency 'multi_json', '~> 1.0'
 
   gem.add_development_dependency 'rspec', '~> 2.6'

data/lib/gocardless/client.rb

@@ -30,8 +30,8 @@ module GoCardless
 
     def initialize(args = {})
       Utils.symbolize_keys! args
-      @app_id = args[:app_id]
-      @app_secret = args[:app_secret]
+      @app_id = args.fetch(:app_id) { ENV['GOCARDLESS_APP_ID'] }
+      @app_secret = args.fetch(:app_secret) { ENV['GOCARDLESS_APP_SECRET'] }
       raise ClientError.new("You must provide an app_id") unless @app_id
       raise ClientError.new("You must provide an app_secret") unless @app_secret
 

data/lib/gocardless/version.rb

@@ -1,3 +1,3 @@
 module GoCardless
-  VERSION = '1.3.2'.freeze
+  VERSION = '1.4.0'.freeze
 end

data/spec/client_spec.rb

@@ -37,6 +37,13 @@ describe GoCardless::Client do
       end.should raise_exception(GoCardless::ClientError)
     end
 
+    it "does not raise an error if the credentials are provided as environment variables" do
+      ENV.expects(:[]).with('GOCARDLESS_APP_ID').returns(@app_id)
+      ENV.expects(:[]).with('GOCARDLESS_APP_SECRET').returns(@app_secret)
+
+      GoCardless::Client.new
+    end
+
     it "sets a merchant id if it's given" do
       client = GoCardless::Client.new({
         :app_id      => @app_id,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gocardless
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-01 00:00:00.000000000 Z
+date: 2012-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oauth2
@@ -19,7 +19,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -27,7 +27,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement