gocardless 0.1.2 → 0.1.3

data/CHANGELOG.md

@@ -0,0 +1,24 @@
+## 0.1.3 - February 22, 2012
+
+- Fix parameter encoding in `Client#new_merchant_url` (related to Faraday issue
+  #115)
+- Allow changing environment / base_url after client init
+
+
+## 0.1.2 - February 2, 2012
+
+- Add `webhook_valid?` method to `Client`
+- Make `confirm_resource` play nicely with `HashWithIndifferentAccess`
+- More RFC compliant parameter encoding
+
+
+## 0.1.1 - January 12, 2012
+
+- Add `name` to `Bill`
+- Add `state` support to `new_{subscription,pre_authorization,bill}_url`
+
+
+## 0.1.0 - November 23, 2011
+
+- Initial release
+

data/Gemfile

@@ -6,7 +6,7 @@ group :development do
   gem "guard", "~> 0.8.8"
   if RUBY_PLATFORM.downcase.include?("darwin")
     gem "guard-rspec", "~> 0.5.4"
-    gem "rb-fsevent", "~> 0.4.3.1"
-    gem "growl_notify", "~> 0.0.3"
+    gem "rb-fsevent", "~> 0.9"
+    gem "growl", "~> 1.0.3"
   end
 end

data/Rakefile

@@ -3,7 +3,8 @@ require 'rspec/core/rake_task'
 
 desc "Generate YARD documentation"
 YARD::Rake::YardocTask.new do |t|
-  t.files = ['lib/**/*.rb'].reject { |f| f.match(/seed|example/) }
+  files = ['lib/**/*.rb', '-', 'CHANGELOG.md', 'LICENSE']
+  t.files = files.reject { |f| f =~ /seed|example/ }
 end
 
 desc "Run the specs"

data/lib/gocardless/client.rb

@@ -53,6 +53,8 @@ module GoCardless
         :response_type => 'code',
         :scope => 'manage_merchant'
       }
+      # Faraday doesn't flatten params in this case (Faraday issue #115)
+      options = Hash[Utils.flatten_params(options)]
       @oauth_client.authorize_url(params.merge(options))
     end
     alias :new_merchant_url :authorize_url
@@ -250,7 +252,7 @@ module GoCardless
     # Validates the payload contents of a webhook request.
     #
     # @param [Hash] params the contents of payload of the webhook
-    # @return [boolean] true when valid, false otherwise
+    # @return [Boolean] true when valid, false otherwise
     def webhook_valid?(params)
       signature_valid?(params)
     end
@@ -261,14 +263,18 @@ module GoCardless
     #
     # @param [Symbol] method the HTTP method to use (e.g. +:get+, +:post+)
     # @param [String] path the path fragment of the URL
-    # @option [String] body the request body
-    # @option [Hash] params query string parameters
+    # @option [Hash] opts query string parameters
     def request(method, path, opts = {})
       raise ClientError, 'Access token missing' unless @access_token
+
       opts[:headers] = {} if opts[:headers].nil?
       opts[:headers]['Accept'] = 'application/json'
       opts[:headers]['Content-Type'] = 'application/json' unless method == :get
       opts[:body] = JSON.generate(opts[:data]) if !opts[:data].nil?
+
+      # Reset the URL in case the environment / base URL has been changed.
+      @oauth_client.site = self.class.base_url
+
       header_keys = opts[:headers].keys.map(&:to_s)
       if header_keys.map(&:downcase).include?('authorization')
         @oauth_client.request(method, path, opts)

data/lib/gocardless/version.rb

@@ -1,3 +1,3 @@
 module GoCardless
-  VERSION = '0.1.2'.freeze
+  VERSION = '0.1.3'.freeze
 end

data/spec/client_spec.rb

@@ -53,6 +53,13 @@ describe GoCardless::Client do
       query['redirect_uri'].first.should == @redirect_uri
       query['client_id'].first.should == @app_id
     end
+
+    it "encodes prefilling parameters correctly" do
+      params = {:merchant => {:user => {:email => "a@b.com"}}}
+      url = @client.authorize_url(params.merge(:redirect_uri => @redirect_uri))
+      encoded_key = GoCardless::Utils.percent_encode('merchant[user][email]')
+      URI.parse(url).query.should match /#{encoded_key}=a%40b\.com/
+    end
   end
 
   describe "#fetch_access_token" do
@@ -341,10 +348,10 @@ describe GoCardless::Client do
     end
 
     it "should include the redirect_uri in the URL query" do
-        params = { 'a' => '1', 'b' => '2', :redirect_uri => "http://www.google.com" }
-        url = @client.send(:new_limit_url, :subscription, params)
-        get_params(url)["redirect_uri"].should == "http://www.google.com"
-      end
+      params = { 'a' => '1', 'b' => '2', :redirect_uri => "http://www.google.com" }
+      url = @client.send(:new_limit_url, :subscription, params)
+      get_params(url)["redirect_uri"].should == "http://www.google.com"
+    end
 
     it "should add merchant_id to the limit" do
       url = @client.send(:new_limit_url, :subscription, {})

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: gocardless
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 800522045387967993
   prerelease: 
   segments: 
   - 0
   - 1
-  - 2
-  version: 0.1.2
+  - 3
+  version: 0.1.3
 platform: ruby
 authors: 
 - Harry Marr
@@ -16,8 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-02 00:00:00 +00:00
-default_executable: 
+date: 2012-02-22 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: oauth2
@@ -27,7 +26,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 15424071
+        hash: 2087324949208970369
         segments: 
         - 0
         - 5
@@ -45,7 +44,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 5
+        hash: 3211771947681907367
         segments: 
         - 1
         - 5
@@ -61,7 +60,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 15
+        hash: 4369430763100613689
         segments: 
         - 2
         - 6
@@ -76,7 +75,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 35
+        hash: 4175747960814336346
         segments: 
         - 0
         - 9
@@ -92,7 +91,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 5
+        hash: 3179421635518079399
         segments: 
         - 0
         - 7
@@ -108,7 +107,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        hash: 5
+        hash: 1606453007234795795
         segments: 
         - 3
         - 1
@@ -128,6 +127,7 @@ files:
 - .gitignore
 - .rspec
 - .travis.yml
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE
@@ -153,7 +153,6 @@ files:
 - spec/resource_spec.rb
 - spec/spec_helper.rb
 - spec/utils_spec.rb
-has_rdoc: true
 homepage: https://github.com/gocardless/gocardless-ruby
 licenses: []
 
@@ -167,7 +166,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 2002549777813010636
       segments: 
       - 0
       version: "0"
@@ -176,14 +175,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 2002549777813010636
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.12
 signing_key: 
 specification_version: 3
 summary: Ruby wrapper for the GoCardless API
@@ -195,3 +194,4 @@ test_files:
 - spec/resource_spec.rb
 - spec/spec_helper.rb
 - spec/utils_spec.rb
+has_rdoc: