go_to_param 1.0.0 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6fa16c7fe969b722bbc7f884c7b2f1b24df75bb7
-  data.tar.gz: 0e7c3acd3d434566ffeb201eb006a43765dad107
+SHA256:
+  metadata.gz: a8742769791ea66237e5decb3e329ed1c2b6a127f072378487b134f45cd8b7a9
+  data.tar.gz: cf8134a2f905e96b8e143c67ccae9f931d109c6c6570a6d46b64d4a329275904
 SHA512:
-  metadata.gz: bfccf03b703ea760d1b8ae8a81cd238052248b18f70e3044d76856577edbdc40f304602178d4716774427fde0579d0a19062e7bf1c401509fa401d85978e1ee0
-  data.tar.gz: 45575857ba7c020275d9f1384264b13a4c4892afaefc30864babf7b206197c2f6362b303bf872b8e3b129036d91a0edb546b8244d0a0c45114670371c5c1d26c
+  metadata.gz: 1366c2d13bb1cba9f3147eadaa3a092526f70da496a642162a4e0e54da880b095b99335f24a3214ef72dc1fea834a2d0208c801020fefa4218c889d9bfc791e8
+  data.tar.gz: c74471045b18e7f076df5eccd804d31e1198064aa8affdf89518af07b420955d96701bcb1469ef8709037e2d306d6589115ac16be9cfec66a054179527b355a9

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+
+## 1.1.2
+
+- Fix keyword parameter warning. Thanks to @olleolleolle!
+
+## 1.1.1
+
+- Don't raise exceptions if given hash params from hack attempts, such as: `go_to[foo]=bar`.
+
+## Earlier
+
+Sorry, no changelog available for earlier versions.

data/README.md

@@ -55,6 +55,8 @@ You can pass additional query parameters to include, which could be suitable if
 
 Note that these parameters always become transformed into a query string: if you're using Ruby on Rails, they won't be interpreted through your route definitions.
 
+You can, however, pass a Rails-style `anchor: "foo"` parameter to set the URL fragment (`/example#foo`).
+
 
 ### hidden_go_to_tag
 

data/lib/go_to_param/version.rb

@@ -1,3 +1,3 @@
 module GoToParam
-  VERSION = "1.0.0"
+  VERSION = "1.1.3"
 end

data/lib/go_to_param.rb

@@ -35,7 +35,7 @@ module GoToParam
   end
 
   def go_to_here_params(additional_query_params = {})
-    path = go_to_here_path(additional_query_params)
+    path = go_to_here_path(**additional_query_params)
 
     if path
       { go_to: path }
@@ -65,16 +65,19 @@ module GoToParam
     GoToParam.allowed_redirect_prefixes.any? { |prefix| go_to_param_value.start_with?(prefix) }
   end
 
-  def go_to_here_path(additional_query_params = {})
+  def go_to_here_path(anchor: nil, **additional_query_params)
     if request.get?
-      _go_to_add_query_string_from_hash(_go_to_fullpath, additional_query_params)
+      path_without_anchor = _go_to_add_query_string_from_hash(_go_to_fullpath, additional_query_params)
+      anchor ? path_without_anchor + "#" + anchor : path_without_anchor
     else
       nil
     end
   end
 
   def go_to_param_value
-    params[:go_to]
+    # We use `to_s` to avoid "not a string" type errors from hack attempts where a hash is passed, e.g. "go_to[foo]=bar".
+    value = params[:go_to].to_s
+    value == "" ? nil : value
   end
 
   # Named this way to avoid conflicts. TODO: http://thepugautomatic.com/2014/02/private-api/

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: go_to_param
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.3
 platform: ruby
 authors:
 - Henrik N
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-10 00:00:00.000000000 Z
+date: 2021-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -59,18 +59,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- Gemfile
+- CHANGELOG.md
 - README.md
-- Rakefile
-- go_to_param.gemspec
 - lib/go_to_param.rb
 - lib/go_to_param/version.rb
-- spec/go_to_param_spec.rb
 homepage: ''
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -86,10 +83,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 3.2.31
 signing_key: 
 specification_version: 4
 summary: Rails "go_to" redirection param utilities.
-test_files:
-- spec/go_to_param_spec.rb
+test_files: []

data/.gitignore

@@ -1,17 +0,0 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp

data/Gemfile

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in go_to_param.gemspec
-gemspec

data/Rakefile

@@ -1,6 +0,0 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
-task :default => :spec

data/go_to_param.gemspec

@@ -1,22 +0,0 @@
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'go_to_param/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = "go_to_param"
-  spec.version       = GoToParam::VERSION
-  spec.authors       = ["Henrik N"]
-  spec.email         = ["henrik@nyh.se"]
-  spec.summary       = %q{Rails "go_to" redirection param utilities.}
-  spec.homepage      = ""
-  spec.license       = "MIT"
-
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.3"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec"
-end

data/spec/go_to_param_spec.rb

@@ -1,160 +0,0 @@
-require_relative "../lib/go_to_param"
-
-class FakeController
-  attr_accessor :params, :view_context, :request
-
-  def self.helper_method(*methods)
-    @helper_methods = methods
-  end
-
-  def self.helper_methods
-    @helper_methods
-  end
-
-  include GoToParam
-end
-
-describe GoToParam do
-  after { GoToParam.reset_allowed_redirect_prefixes }
-
-  let(:controller) { FakeController.new }
-
-  describe "#hidden_go_to_tag" do
-    it "becomes a helper method" do
-      expect(FakeController.helper_methods).to include :hidden_go_to_tag
-    end
-
-    it "adds a hidden field tag" do
-      controller.params = { go_to: "/example", id: "1" }
-      view = double
-      controller.view_context = view
-
-      expect(view).to receive(:hidden_field_tag).with(:go_to, "/example")
-      controller.hidden_go_to_tag
-    end
-  end
-
-  describe "#hidden_go_to_here_tag" do
-    it "becomes a helper method" do
-      expect(FakeController.helper_methods).to include :hidden_go_to_here_tag
-    end
-
-    it "adds a hidden field tag" do
-      controller.request = double(get?: true, fullpath: "/example")
-      view = double
-      controller.view_context = view
-
-      expect(view).to receive(:hidden_field_tag).with(:go_to, "/example")
-      controller.hidden_go_to_here_tag
-    end
-
-    # Tested in more detail in #go_to_here_params.
-    it "accepts additional query parameters" do
-      controller.request = double(get?: true, fullpath: "/example?a=1")
-      view = double
-      controller.view_context = view
-
-      expect(view).to receive(:hidden_field_tag).with(:go_to, "/example?a=1&b=1+2")
-      controller.hidden_go_to_here_tag(b: "1 2")
-    end
-  end
-
-  describe "#go_to_params" do
-    it "becomes a helper method" do
-      expect(FakeController.helper_methods).to include :go_to_params
-    end
-
-    it "includes the go_to parameter" do
-      controller.params = { go_to: "/example", id: "1" }
-
-      expect(controller.go_to_params).to eq({ go_to: "/example" })
-    end
-
-    it "accepts additional parameters" do
-      controller.params = { go_to: "/example", id: "1" }
-
-      expect(controller.go_to_params(a: "b")).to eq({ go_to: "/example", a: "b" })
-    end
-  end
-
-  describe "#go_to_here_params" do
-    it "becomes a helper method" do
-      expect(FakeController.helper_methods).to include :go_to_here_params
-    end
-
-    it "gets the request path as the go_to parameter" do
-      controller.request = double(get?: true, fullpath: "/example")
-      expect(controller.go_to_here_params).to eq({ go_to: "/example" })
-    end
-
-    it "returns an empty hash for a non-GET request" do
-      controller.request = double(get?: false, fullpath: "/example")
-      expect(controller.go_to_here_params).to eq({})
-    end
-
-    it "accepts additional query parameters" do
-      controller.request = double(get?: true, fullpath: "/example")
-      expect(controller.go_to_here_params(foo: "1 2", bar: 3)).to eq({ go_to: "/example?foo=1+2&bar=3" })
-
-      # Handles pre-existing "?"
-      controller.request = double(get?: true, fullpath: "/example?foo")
-      expect(controller.go_to_here_params(bar: 3)).to eq({ go_to: "/example?foo&bar=3" })
-    end
-
-    it "makes sure the go_to path is valid UTF-8" do
-      weird_path = "\xE0\x80\x80weird\330stuff".force_encoding("ASCII-8BIT")
-      replacement = "\uFFFD"  # The Unicode "Replacement Character".
-
-      controller.request = double(get?: true, fullpath: weird_path)
-
-      go_to_value = controller.go_to_here_params[:go_to]
-
-      expect(go_to_value.encoding).to eq(Encoding::UTF_8)
-      expect(go_to_value).to eq("#{replacement}#{replacement}#{replacement}weird#{replacement}stuff")
-    end
-  end
-
-  describe "#go_to_path" do
-    it "becomes a helper method" do
-      expect(FakeController.helper_methods).to include :go_to_path
-    end
-
-    it "is the go_to parameter value" do
-      controller.params = { go_to: "/example", id: "1" }
-      expect(controller.go_to_path).to eq("/example")
-    end
-
-    it "is nil if the parameter value is not a relative path" do
-      controller.params = { go_to: "http://evil.com", id: "1" }
-      expect(controller.go_to_path).to be_nil
-    end
-
-    it "respects custom allowed redirect prefixes" do
-      GoToParam.allow_redirect_prefix("myapp://")
-
-      controller.params = { go_to: "myapp://", id: "1" }
-      expect(controller.go_to_path).to eq("myapp://")
-    end
-  end
-
-  describe "#go_to_path_or" do
-    it "becomes a helper method" do
-      expect(FakeController.helper_methods).to include :go_to_path_or
-    end
-
-    it "is the go_to parameter value" do
-      controller.params = { go_to: "/example", id: "1" }
-      expect(controller.go_to_path_or("/default")).to eq("/example")
-    end
-
-    it "falls back if the go_to param is blank" do
-      controller.params = { go_to: "", id: "1" }
-      expect(controller.go_to_path_or("/default")).to eq("/default")
-    end
-
-    it "falls back if the go_to param is not allowed" do
-      controller.params = { go_to: "http://evil.com", id: "1" }
-      expect(controller.go_to_path_or("/default")).to eq("/default")
-    end
-  end
-end