go_to_param 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f0ecdb8725a6803349e51b90dc85872681c6162
-  data.tar.gz: 09c706a18e0cfb180d606472bf9a8f459fa9c8f7
+  metadata.gz: 215153cc8a15d43896a220800cbd869135dcc05d
+  data.tar.gz: e0f6533003427b3167d444b64551343c95dbd1fe
 SHA512:
-  metadata.gz: 56b20be331349761df60822bf4232c19baaa3a4b20a8364fb78a650a09bbb6f928210cc265b436c2f4ade9cebb110d78ca33da96aa9173265e114f7c66ae941a
-  data.tar.gz: 0dcb8ece149ed00d4f82c66f3b4f9de940337377006b7fbc7716011b6a050f384ba59354c7091d80a7c5b77f6ac319031ab83f374a8e4ff61d054286d221bbf7
+  metadata.gz: 0d175624844e430d3a24c0221958677141e40503f8902f920cac9179e32f2effcee2e4a6a6ac65cc2379d64323e3bdb6d89815dda9ea61d47baf5f9f11163fca
+  data.tar.gz: f882c0c017e88fe25cba15d49b962e0cdd6f90b0120a43cad6b74afc916d6c63f2d4dc4763c1b7ab95c898b337a39a6b98d39f4ba2b5e0a3c8a20793d6cf7dbc

data/README.md

@@ -63,17 +63,17 @@ You can pass in additional parameters for the given path:
 <%= link_to("Reset password", password_reset_path(go_to_param(email: @email))) %>
 ```
 
-### go_to_path_or
+### go_to_path
 
 Finally use the `go_to` parameter.
 
-You must pass in a fallback path.
+You probably want to provide a fallback path:
 
 ``` ruby
 class SessionsController < ActionController::Base
   def create
     if logged_in?
-      redirect_to go_to_path_or(root_path)
+      redirect_to(go_to_path || root_path)
     end
   end
 end

data/lib/go_to_param/version.rb

@@ -1,3 +1,3 @@
 module GoToParam
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/go_to_param.rb

@@ -6,11 +6,11 @@ module GoToParam
   end
 
   def hidden_go_to_tag
-    view_context.hidden_field_tag :go_to, go_to_value
+    view_context.hidden_field_tag :go_to, go_to_path
   end
 
   def go_to_param(other_params = {})
-    { go_to: go_to_value }.merge(other_params)
+    { go_to: go_to_path }.merge(other_params)
   end
 
   def get_go_to_param
@@ -21,18 +21,18 @@ module GoToParam
     end
   end
 
-  def go_to_path_or(path)
+  def go_to_path
     # Avoid phishing redirects.
-    if go_to_value.to_s.start_with?("/")
-      go_to_value
+    if raw_go_to_param_value.to_s.start_with?("/")
+      raw_go_to_param_value
     else
-      path
+      nil
     end
   end
 
   private
 
-  def go_to_value
+  def go_to_param_value
     params[:go_to]
   end
 end

data/spec/{go_to_spec.rb → go_to_param_spec.rb}

@@ -63,21 +63,15 @@ describe GoToParam do
     end
   end
 
-  describe "#go_to_path_or" do
+  describe "#go_to_path" do
     it "is the go_to parameter value" do
       controller.params = { go_to: "/example", id: "1" }
-      controller.go_to_path_or("/default").should == "/example"
+      controller.go_to_path.should == "/example"
     end
 
-    it "falls back to the passed-in value without a parameter value" do
-      controller = FakeController.new
-      controller.params = { id: "1" }
-      controller.go_to_path_or("/default").should == "/default"
-    end
-
-    it "only allows relative paths" do
+    it "is nil if the parameter value is not a relative path" do
       controller.params = { go_to: "http://evil.com", id: "1" }
-      controller.go_to_path_or("/default").should == "/default"
+      controller.go_to_path.should be_nil
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: go_to_param
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Henrik N
@@ -66,7 +66,7 @@ files:
 - go_to_param.gemspec
 - lib/go_to_param.rb
 - lib/go_to_param/version.rb
-- spec/go_to_spec.rb
+- spec/go_to_param_spec.rb
 homepage: ''
 licenses:
 - MIT
@@ -92,5 +92,5 @@ signing_key:
 specification_version: 4
 summary: Rails "go_to" redirection param utilities.
 test_files:
-- spec/go_to_spec.rb
+- spec/go_to_param_spec.rb
 has_rdoc: