go_import 3.0.42 → 4.0.0

data/spec/helpers/serialize_helper_spec.rb

@@ -3,9 +3,9 @@ require 'go_import'
 
 describe GoImport::SerializeHelper do
 
-    describe "Serialize note" do
+    describe "Serialize history" do
         let(:serialized) {
-            n = GoImport::Note.new
+            n = GoImport::History.new
             n.text = "text"
             GoImport::SerializeHelper::serialize(n,-1)
         }
@@ -13,16 +13,16 @@ describe GoImport::SerializeHelper do
             serialized.should match(/<Text>[\n ]*text[\n ]*<\/Text>/)
         end
         it "should contain start tag" do
-            serialized.should match(/<Note>/)
+            serialized.should match(/<History>/)
         end
         it "should be utf-8" do
             serialized.encoding.should equal Encoding::UTF_8
         end
     end
 
-    describe "Serialize note with xml inside" do
+    describe "Serialize history with xml inside" do
         let(:serialized) {
-            n = GoImport::Note.new
+            n = GoImport::History.new
             n.text = "<text>"
             GoImport::SerializeHelper::serialize(n,-1)
         }
@@ -192,7 +192,7 @@ describe GoImport::SerializeHelper do
             serialized.should match(/Ankeborgs bibliotek/)
         end
         it "should have version" do
-            serialized.should match(/<GoImport Version='v2_0'/)
+            serialized.should match(/<GoImport Version='v3_0'/)
         end
         it "should be utf-8" do
             serialized.encoding.should equal Encoding::UTF_8

data/spec/helpers/shard_helper_spec.rb

@@ -49,9 +49,9 @@ describe GoImport::ShardHelper do
         end
 
         (1..10).each do |n|
-            note = GoImport::Note.new
-            note.text = "Important note"
-            model.add_note(note)
+            history = GoImport::History.new
+            history.text = "Important history"
+            model.add_history(history)
         end
 
         (1..10).each do |n|

data/spec/history_spec.rb

@@ -0,0 +1,150 @@
+require "spec_helper"
+require 'go_import'
+
+describe "History" do
+    let("history") {
+        GoImport::History.new
+    }
+
+    it "must have a text" do
+        history.validate.length.should be > 0
+    end
+
+    it "is valid when it has text, created_by and organization" do
+        # given
+        history.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        history.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
+        history.organization = GoImport::Organization.new({ :integration_id => "456", :heading => "Lundalogik" })
+
+        # when, then
+        history.validate.should eq ""
+    end
+
+    it "is valid when it has text, created_by and person" do
+        # given
+        history.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        history.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
+        history.person = GoImport::Person.new({ :integration_id => "456", :heading => "Billy Bob" })
+
+        # when, then
+        history.validate.should eq ""
+    end
+
+    it "is valid when it has text, created_by and deal" do
+        # given
+        history.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        history.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
+        history.deal = GoImport::Deal.new({ :integration_id => "456", :heading => "The new deal" })
+
+        # when, then
+        history.validate.should eq ""
+    end
+
+    it "is invalid if no history has no attached objects" do
+        # given
+        history.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        history.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
+
+        # when, then
+        history.validate.length.should be > 0
+    end
+
+    it "will set organization ref when organization is assigned" do
+        # given
+        org = GoImport::Organization.new({:integration_id => "123", :name => "Beagle Boys!"})
+
+        # when
+        history.organization = org
+
+        # then
+        history.organization.is_a?(GoImport::Organization).should eq true
+        history.instance_variable_get(:@organization_reference).is_a?(GoImport::OrganizationReference).should eq true
+    end
+
+    it "will set person ref when person is assigned" do
+        # given
+        person = GoImport::Person.new({:integration_id => "123" })
+        person.parse_name_to_firstname_lastname_se "Billy Bob"
+
+        # when
+        history.person = person
+
+        # then
+        history.person.is_a?(GoImport::Person).should eq true
+        history.instance_variable_get(:@person_reference).is_a?(GoImport::PersonReference).should eq true
+    end
+
+    it "will set coworker ref when coworker is assigned" do
+        # given
+        coworker = GoImport::Coworker.new({:integration_id => "123" })
+        coworker.parse_name_to_firstname_lastname_se "Billy Bob"
+
+        # when
+        history.created_by = coworker
+
+        # then
+        history.created_by.is_a?(GoImport::Coworker).should eq true
+        history.instance_variable_get(:@created_by_reference).is_a?(GoImport::CoworkerReference).should eq true
+    end
+
+    it "will set deal ref when deal is assigned" do
+        # given
+        deal = GoImport::Deal.new({:integration_id => "123" })
+        deal.name = "The new deal"
+
+        # when
+        history.deal = deal
+
+        # then
+        history.deal.is_a?(GoImport::Deal).should eq true
+        history.instance_variable_get(:@deal_reference).is_a?(GoImport::DealReference).should eq true
+    end
+
+    it "should have Comment as default classification" do
+        # then
+        history.classification.should eq GoImport::HistoryClassification::Comment
+    end
+
+    it "should not accept invalid classifications" do
+        # when, then
+        expect {
+            history.classification = "hubbabubba"
+        }.to raise_error(GoImport::InvalidHistoryClassificationError)
+    end
+
+    it "should remove form feed from text" do
+        # given
+        textWithFormFeed = "Text with form feed"
+        textWithoutFormFeed = "Text with form feed"
+
+        # when
+        history.text = textWithFormFeed
+
+        # then
+        history.text.should eq textWithoutFormFeed
+    end
+
+    it "should remove vertical tab from text" do
+        # given
+        textWithVerticalTab = "Text with \vvertical tab"
+        textWithoutVerticalTab = "Text with vertical tab"
+
+        # when
+        history.text = textWithVerticalTab
+
+        # then
+        history.text.should eq textWithoutVerticalTab
+    end
+
+    it "should remove backspace from text" do
+        # given
+        textWithBackSpace = "Text with \bbackspace"
+        textWithoutBackSpace = "Text with backspace"
+
+        # when
+        history.text = textWithBackSpace
+
+        # then
+        history.text.should eq textWithoutBackSpace
+    end    
+end

data/spec/rootmodel_spec.rb

@@ -107,7 +107,7 @@ describe "RootModel" do
 
     it "will only add organizations" do
         # given
-        not_an_organization = { :integration_id => "123", :name => "This is not a note"}
+        not_an_organization = { :integration_id => "123", :name => "This is not a history"}
 
         # when, then
         expect {
@@ -305,77 +305,77 @@ describe "RootModel" do
         }.to raise_error(GoImport::IntegrationIdIsRequiredError)
     end
 
-    it "will only add notes" do
+    it "will only add history" do
         # given
-        not_a_note = { :integration_id => "123", :text => "This is not a note"}
+        not_a_history = { :integration_id => "123", :text => "This is not a history"}
 
         # when, then
         expect {
-            rootmodel.add_note(not_a_note)
+            rootmodel.add_history(not_a_history)
         }.to raise_error(ArgumentError)
-        rootmodel.notes.length.should eq 0
+        rootmodel.histories.length.should eq 0
     end
 
-    it "will make note immutable after it has been added" do
+    it "will make history immutable after it has been added" do
         # given
-        note = GoImport::Note.new
-        note.text = "this is a note"
+        history = GoImport::History.new
+        history.text = "this is a history"
 
         # when
-        rootmodel.add_note(note)
+        rootmodel.add_history(history)
 
         # then
-        note.is_immutable.should eq true
+        history.is_immutable.should eq true
     end
 
-    it "can add a note from a new note" do
+    it "can add a history from a new history" do
         # given
-        note = GoImport::Note.new
-        note.integration_id = "123key"
-        note.text = "This is a note"
+        history = GoImport::History.new
+        history.integration_id = "123key"
+        history.text = "This is a history"
 
         # when
-        rootmodel.add_note(note)
+        rootmodel.add_history(history)
 
         # then
-        rootmodel.find_note_by_integration_id("123key").text.should eq "This is a note"
-        rootmodel.notes.length.should eq 1
+        rootmodel.find_history_by_integration_id("123key").text.should eq "This is a history"
+        rootmodel.histories.length.should eq 1
     end
 
-    it "will generate an integration id if the new note dont have one" do
+    it "will generate an integration id if the new history dont have one" do
         # given
-        note = GoImport::Note.new
-        note.text = "This is a note"
+        history = GoImport::History.new
+        history.text = "This is a history"
 
         # when
-        rootmodel.add_note(note)
+        rootmodel.add_history(history)
 
         # then
-        note.integration_id.length.should be > 0
+        history.integration_id.length.should be > 0
     end
 
-    it "will generate unique integration ids for each note" do
+    it "will generate unique integration ids for each history" do
         # given
-        note1 = GoImport::Note.new
-        note1.text = "This is a note"
+        history1 = GoImport::History.new
+        history1.text = "This is a history"
 
-        note2 = GoImport::Note.new
-        note2.text = "This is a different note"
+        history2 = GoImport::History.new
+        history2.text = "This is a different history"
 
         # when
-        rootmodel.add_note note1
-        rootmodel.add_note note2
+        rootmodel.add_history history1
+        rootmodel.add_history history2
 
         # then
-        note1.integration_id.should be != note2.integration_id
+        history1.integration_id.should be != history2.integration_id
     end
 
-    it "will not add a nil note" do
+    it "will not add a nil history" do
         # given, when
-        rootmodel.add_note(nil)
+        rootmodel.add_history(nil)
 
         # then
-        rootmodel.notes.length.should eq 0
+        rootmodel.histories.length.should eq 0
     end
 
     it "will not add a nil organization" do
@@ -431,25 +431,25 @@ describe "RootModel" do
         rootmodel.documents.files.length.should eq 1
     end
 
-    it "will not add a new note when the note is already added (same integration id)" do
+    it "will not add a new history when the history is already added (same integration id)" do
         # given
-        note = GoImport::Note.new({
+        history = GoImport::History.new({
                                       :integration_id => "123key",
-                                      :text => "This is a note"
+                                      :text => "This is a history"
                                   })
-        rootmodel.add_note(note)
-        rootmodel.notes.length.should eq 1
+        rootmodel.add_history(history)
+        rootmodel.histories.length.should eq 1
 
         # when, then
-        note2 = GoImport::Note.new({
+        history2 = GoImport::History.new({
                                        :integration_id => "123key",
-                                       :text => "This is another note"
+                                       :text => "This is another history"
                                    })
         expect {
-            rootmodel.add_note(note2)
+            rootmodel.add_history(history2)
         }.to raise_error(GoImport::AlreadyAddedError)
-        rootmodel.notes.length.should eq 1
-        rootmodel.find_note_by_integration_id("123key").text.should eq "This is a note"
+        rootmodel.histories.length.should eq 1
+        rootmodel.find_history_by_integration_id("123key").text.should eq "This is a history"
     end
 
     it "Will find a person by integration id" do
@@ -674,39 +674,39 @@ describe "RootModel" do
         result.should eq nil
     end
 
-    it "will find an note based on a property" do
+    it "will find an history based on a property" do
         # given
         organization = GoImport::Organization.new
         organization.name = "Hubba Bubba"
         organization.integration_id = "321"
         rootmodel.add_organization(organization)
 
-        note = GoImport::Note.new
-        note.text = "Hello!"
-        note.organization = organization
+        history = GoImport::History.new
+        history.text = "Hello!"
+        history.organization = organization
 
-        rootmodel.add_note(note)
+        rootmodel.add_history(history)
         # when
-        result = rootmodel.find_note{|n| n.text == "Hello!"}
+        result = rootmodel.find_history{|n| n.text == "Hello!"}
 
         # then
-        result.should eq note
+        result.should eq history
     end
 
-    it "will return nil if it doesn't find a note on a property" do
+    it "will return nil if it doesn't find a history on a property" do
         # given
         organization = GoImport::Organization.new
         organization.name = "Hubba Bubba"
         organization.integration_id = "321"
         rootmodel.add_organization(organization)
 
-        note = GoImport::Note.new
-        note.text = "Hello!"
-        note.organization = organization
+        history = GoImport::History.new
+        history.text = "Hello!"
+        history.organization = organization
 
-        rootmodel.add_note(note)
+        rootmodel.add_history(history)
         # when
-        result = rootmodel.find_note{|n| n.text == "Goodbye!"}
+        result = rootmodel.find_history{|n| n.text == "Goodbye!"}
 
         # then
         result.should eq nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: go_import
 version: !ruby/object:Gem::Version
-  version: 3.0.42
+  version: 4.0.0
 platform: ruby
 authors:
 - Petter Sandholdt
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-03 00:00:00.000000000 Z
+date: 2016-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes
@@ -198,9 +198,9 @@ files:
 - lib/go_import/model/deal_status_setting.rb
 - lib/go_import/model/documents.rb
 - lib/go_import/model/file.rb
+- lib/go_import/model/history.rb
+- lib/go_import/model/history_classification.rb
 - lib/go_import/model/link.rb
-- lib/go_import/model/note.rb
-- lib/go_import/model/note_classification.rb
 - lib/go_import/model/organization.rb
 - lib/go_import/model/person.rb
 - lib/go_import/model/referencetosource.rb
@@ -229,8 +229,8 @@ files:
 - sources/base-crm/data/contacts.csv
 - sources/base-crm/data/coworkers.csv
 - sources/base-crm/data/deals.csv
+- sources/base-crm/data/histories.csv
 - sources/base-crm/data/leads.csv
-- sources/base-crm/data/notes.csv
 - sources/base-crm/data/tasks.csv
 - sources/csv/.gitignore
 - sources/csv/.go_import/readme.txt
@@ -302,8 +302,8 @@ files:
 - spec/helpers/serialize_helper_spec.rb
 - spec/helpers/shard_helper_spec.rb
 - spec/helpers/xsd_validate_spec.rb
+- spec/history_spec.rb
 - spec/link_spec.rb
-- spec/note_spec.rb
 - spec/organization_spec.rb
 - spec/person_spec.rb
 - spec/rootmodel_spec.rb
@@ -348,8 +348,8 @@ test_files:
 - spec/helpers/serialize_helper_spec.rb
 - spec/helpers/shard_helper_spec.rb
 - spec/helpers/xsd_validate_spec.rb
+- spec/history_spec.rb
 - spec/link_spec.rb
-- spec/note_spec.rb
 - spec/organization_spec.rb
 - spec/person_spec.rb
 - spec/rootmodel_spec.rb

data/spec/note_spec.rb

@@ -1,150 +0,0 @@
-require "spec_helper"
-require 'go_import'
-
-describe "Note" do
-    let("note") {
-        GoImport::Note.new
-    }
-
-    it "must have a text" do
-        note.validate.length.should be > 0
-    end
-
-    it "is valid when it has text, created_by and organization" do
-        # given
-        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
-        note.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
-        note.organization = GoImport::Organization.new({ :integration_id => "456", :heading => "Lundalogik" })
-
-        # when, then
-        note.validate.should eq ""
-    end
-
-    it "is valid when it has text, created_by and person" do
-        # given
-        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
-        note.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
-        note.person = GoImport::Person.new({ :integration_id => "456", :heading => "Billy Bob" })
-
-        # when, then
-        note.validate.should eq ""
-    end
-
-    it "is valid when it has text, created_by and deal" do
-        # given
-        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
-        note.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
-        note.deal = GoImport::Deal.new({ :integration_id => "456", :heading => "The new deal" })
-
-        # when, then
-        note.validate.should eq ""
-    end
-
-    it "is invalid if no note has no attached objects" do
-        # given
-        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
-        note.created_by = GoImport::Coworker.new( { :integration_id => "123", :heading => "kalle anka" } )
-
-        # when, then
-        note.validate.length.should be > 0
-    end
-
-    it "will set organization ref when organization is assigned" do
-        # given
-        org = GoImport::Organization.new({:integration_id => "123", :name => "Beagle Boys!"})
-
-        # when
-        note.organization = org
-
-        # then
-        note.organization.is_a?(GoImport::Organization).should eq true
-        note.instance_variable_get(:@organization_reference).is_a?(GoImport::OrganizationReference).should eq true
-    end
-
-    it "will set person ref when person is assigned" do
-        # given
-        person = GoImport::Person.new({:integration_id => "123" })
-        person.parse_name_to_firstname_lastname_se "Billy Bob"
-
-        # when
-        note.person = person
-
-        # then
-        note.person.is_a?(GoImport::Person).should eq true
-        note.instance_variable_get(:@person_reference).is_a?(GoImport::PersonReference).should eq true
-    end
-
-    it "will set coworker ref when coworker is assigned" do
-        # given
-        coworker = GoImport::Coworker.new({:integration_id => "123" })
-        coworker.parse_name_to_firstname_lastname_se "Billy Bob"
-
-        # when
-        note.created_by = coworker
-
-        # then
-        note.created_by.is_a?(GoImport::Coworker).should eq true
-        note.instance_variable_get(:@created_by_reference).is_a?(GoImport::CoworkerReference).should eq true
-    end
-
-    it "will set deal ref when deal is assigned" do
-        # given
-        deal = GoImport::Deal.new({:integration_id => "123" })
-        deal.name = "The new deal"
-
-        # when
-        note.deal = deal
-
-        # then
-        note.deal.is_a?(GoImport::Deal).should eq true
-        note.instance_variable_get(:@deal_reference).is_a?(GoImport::DealReference).should eq true
-    end
-
-    it "should have Comment as default classification" do
-        # then
-        note.classification.should eq GoImport::NoteClassification::Comment
-    end
-
-    it "should not accept invalid classifications" do
-        # when, then
-        expect {
-            note.classification = "hubbabubba"
-        }.to raise_error(GoImport::InvalidNoteClassificationError)
-    end
-
-    it "should remove form feed from text" do
-        # given
-        textWithFormFeed = "Text with form feed"
-        textWithoutFormFeed = "Text with form feed"
-
-        # when
-        note.text = textWithFormFeed
-
-        # then
-        note.text.should eq textWithoutFormFeed
-    end
-
-    it "should remove vertical tab from text" do
-        # given
-        textWithVerticalTab = "Text with \vvertical tab"
-        textWithoutVerticalTab = "Text with vertical tab"
-
-        # when
-        note.text = textWithVerticalTab
-
-        # then
-        note.text.should eq textWithoutVerticalTab
-    end
-
-    it "should remove backspace from text" do
-        # given
-        textWithBackSpace = "Text with \bbackspace"
-        textWithoutBackSpace = "Text with backspace"
-
-        # when
-        note.text = textWithBackSpace
-
-        # then
-        note.text.should eq textWithoutBackSpace
-    end    
-end