go_import 3.0.25 → 3.0.26

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YmI2ODQ1ZjgzODEyYzNiMjI3NjQ3OWFhNGQ4MmVjNjYzYjgyYjhiOQ==
+    ZjBiMjk3NmIxNjgwZDNhYjI2M2M2MWEwYjUxMzgyODQ2MmNmNmE4NQ==
   data.tar.gz: !binary |-
-    NDgwNjJkOTFlODBjMWRiYmJiNGViZGUxZDJkODBjZjVlMWFmZmNhZg==
+    NTRkOGI4YTZiYjY5YzI5OTk0ZThlOWY4ZWY3NzM3YTBlNzMwMDk1MQ==
 SHA512:
   metadata.gz: !binary |-
-    NmI0N2U5N2MwYWZiMDlkNTExMmJmM2VjZjIyY2M2NzQ4NjNhMzgxNTUxNWI4
-    ZjJhZmU0MmMxOTBkNzkyNmY3ZjNiZTMyMzNiYTE5ZWMxMTE4MjY2Yzc0MzNl
-    NzE5YWVmNGQ0YmI3MzcxZmY4NDA5NjlhNGUwYTM5NzVkZWM2MDU=
+    M2JjMjNhNTc4ZTI0ODc2YTRjODU5YzFmODA2NDEzM2ZjZDI2YjE2ZTgwNGM5
+    Yjk3NjBhN2IxN2NhMzFhNzEzOGY0NTUxZWUzNjMxMmIxMzc3YWZiMDAwOTI3
+    M2E0Y2U3MzI0OGUxMWExNGI0ZTg2YTRkNDdiOGQzMzUwNjRkNGE=
   data.tar.gz: !binary |-
-    NjYwMmMyZTdkMDQzOTUyZDU0ZWIyOTU0NGY0ZTRjMGVjOTMyYmM3Yjg1YTIx
-    OGUyNjg5MDU0Y2ZiNWI3ZWUyOTQxMmY4M2ZiYjcwOTgwMTdlOTc2OTkwNjYw
-    MzU1MTM1NWU5ZDU4OWVjOWRjMmQwYjdkNWVlNjc2MTUxMDJiZjA=
+    MDE0MmJmNjliY2Y4MjBkNDk3MTNhNGNjMjljZTMyNmE5YTNiOGNjMzEyMjNk
+    NzdiZWFkZjhiZjQ0ZTYzODRhNmIzM2YwZTYwOWRhM2ZhNzA3NGMxMmI0OTgw
+    MDViZGJhODNiYjJkYTdmMmRmOTVkY2YyYzE0OWYyNzQzZGZiZDQ=

data/bin/go-import

@@ -50,8 +50,8 @@ class GoImportCommandLine < Thor
            :desc => "Name of the file where the converted source will be saved. This file should be sent to LIME Go. If the file already exist it will be replaced.",
            :type => :string,
            :required => false)
-    option(:ignore_missing_files,
-           :desc => "Output will be created even if the import contains missing files",
+    option(:ignore_invalid_files,
+           :desc => "Output will be created even if the import contains missing or invalid files",
            :type => :boolean,
            :required => false)
     option(:log_to_file,
@@ -82,36 +82,43 @@ class GoImportCommandLine < Thor
             puts "WARNING: This means that files with an absolute path will be imported with their original path. Set this constant if you want to get files from the FILES_FOLDER directory."
         end
 
-        is_ok, error_msg = can_be_serialized?(model, options.ignore_missing_files)
+        is_ok, error_msg, warnings_msg = can_be_serialized?(model, options.ignore_invalid_files)
         if is_ok
-            if options.ignore_missing_files && model.documents.files.length > 0
-                log_and_remove_missing_files model
+            if options.ignore_invalid_files && model.documents.files.length > 0
+                log_and_remove_invalid_files model
             end
 
             go_data_zip = options.output.nil? == true ? "go.zip" : options.output
             model.save_to_zip(go_data_zip)
             puts "Source has been been converted into '#{go_data_zip}'."
+            if !warnings_msg.empty? 
+                puts "WARNINGS: "
+                puts warnings_msg
+            end
         else
             puts "ERROR: Source could not be converted due to:"
             puts error_msg
 
-            if !options.ignore_missing_files &&
-                    model.documents.files.any? {|file| !::File.exists?(file.path_for_project)}
-                puts "go-import detected missing files (see above), you can ignore these with the option --ignore-missing-files."
+            if !options.ignore_invalid_files &&
+                    model.documents.files.any? {|file| file.validate.empty?}
+                puts "go-import detected invalid files (see above), you can ignore these with the option --ignore-invalid-files."
             end
         end
     end
 
     private
-    def log_and_remove_missing_files(model)
+    def log_and_remove_invalid_files(model)
         if model.documents.files.length > 0
             puts "Trying to log files that can't be found..."
-            file_log_header = "name;integration_id;path;organization.integrationid;organization.name;deal.integrationid;deal.name"
+            file_log_header = "name;integration_id;path;organization.integrationid;organization.name;deal.integrationid;deal.name;file.size"
             file_log = ""
             files_to_remove = []
             model.documents.files.each do |file|
                 if !::File.exists?(file.path_for_project)
-                    file_log = "#{file_log}#{file.name};#{file.integration_id};#{file.path};#{file.organization.nil? ? '' : file.organization.integration_id};#{file.organization.nil? ? '' : file.organization.name};#{file.deal.nil? ? '' : file.deal.integration_id};#{file.deal.nil? ? '' : file.deal.name}\n"
+                    file_log = "#{file_log}#{file.name};#{file.integration_id};#{file.path};#{file.organization.nil? ? '' : file.organization.integration_id};#{file.organization.nil? ? '' : file.organization.name};#{file.deal.nil? ? '' : file.deal.integration_id};#{file.deal.nil? ? '' : file.deal.name};0\n"
+                    files_to_remove.push file
+                elsif ::File.size(file.path_for_project) > GoImport::File::MAX_FILE_SIZE
+                    file_log = "#{file_log}#{file.name};#{file.integration_id};#{file.path};#{file.organization.nil? ? '' : file.organization.integration_id};#{file.organization.nil? ? '' : file.organization.name};#{file.deal.nil? ? '' : file.deal.integration_id};#{file.deal.nil? ? '' : file.deal.name};#{::File.size(file.path_for_project)}\n"
                     files_to_remove.push file
                 end
             end
@@ -121,12 +128,12 @@ class GoImportCommandLine < Thor
             end
 
             if file_log.length > 0
-                log_filename = 'go-import-missing-files.csv'
+                log_filename = 'go-import-invalid-files.csv'
                 ::File.open(log_filename, 'w') { |f|
                     f.puts file_log_header
                     f.puts file_log
                 }
-                puts "WARNING: go-import has ignored files. Filenames of all ignored files has been written to '#{log_filename}'."
+                puts "WARNING: go-import has invalid files. Filenames of all ignored files has been written to '#{log_filename}'."
             else
                 puts "All files are OK."
             end
@@ -134,18 +141,18 @@ class GoImportCommandLine < Thor
     end
 
     private
-    def can_be_serialized?(rootmodel, ignore_missing_files)
+    def can_be_serialized?(rootmodel, ignore_invalid_files)
         is_ok = false
         error = rootmodel.sanity_check
         if error.empty?
-            error = rootmodel.validate(ignore_missing_files)
+            error, warnings = rootmodel.validate(ignore_invalid_files)
 
             if error.empty?
                 is_ok = true
             end
         end
 
-        return [is_ok, error]
+        return [is_ok, error, warnings]
     end
 
     private

data/lib/go_import/model/address.rb

@@ -33,7 +33,11 @@ module GoImport
             when 'Sverige'
                 'SE'
             else
-                 IsoCountryCodes.search_by_name(name).first.alpha2
+                begin
+                    IsoCountryCodes.search_by_name(name).first.alpha2
+                rescue
+                    nil
+                end
             end
         end
         # parses a line like "226 48 LUND" into its corresponding
@@ -55,7 +59,5 @@ module GoImport
             end
             return nil
         end
-
-
     end
-end
+end

data/lib/go_import/model/deal.rb

@@ -91,8 +91,9 @@ module GoImport
             return reference
         end
 
-        def validate
+        def validate(labels = nil)
             error = String.new
+            warnings = String.new
 
             if @name.nil? || @name.empty?
                 error = "A name is required for deal.\n}"
@@ -106,11 +107,15 @@ module GoImport
                 error = "#{error}\n#{@status.status_reference.validate}"
             end
 
+            if !@status.nil? && !@status.status_reference.nil? && (labels.nil? || (!labels.nil? && !labels.include?(@status.status_reference.label)))
+                warnings = "Deal status '#{@status.status_reference.label}' missing, add to settings"
+            end
+
             if error.length > 0
                 error = "#{error}\n#{serialize()}"
             end
 
-            return error
+            return [error, warnings]
         end
 
 
@@ -168,13 +173,13 @@ module GoImport
         def value=(value)
             if value.nil?
                 @value = "0"
-            elsif value.empty?
+            elsif value.respond_to?(:empty?) && value.empty?
                 @value = "0"
             else
                 # we have had some issues with LIME Easy imports where
                 # the value was in the format "357 000". We need to
                 # remove those spaces.
-                fixed_value = value.gsub(" ", "")
+                fixed_value = value.to_s.gsub(" ", "")
 
                 # we assume that both , and . are thousand separators
                 # and remove them from the value string. We dont care

data/lib/go_import/model/file.rb

@@ -6,6 +6,8 @@ require_relative '../serialize_helper'
 
 module GoImport
     class File
+        MAX_FILE_SIZE = 100000000 # 100 Mb
+
         include SerializeHelper
         attr_accessor :id, :integration_id, :description
 
@@ -155,7 +157,7 @@ module GoImport
             zip_file.add(@location_in_zip_file, path_for_project)
         end
 
-        def validate(ignore_missing_files = false)
+        def validate(ignore_invalid_files = false)
             error = String.new
             warning = String.new
 
@@ -165,12 +167,15 @@ module GoImport
 
             if @path.nil? || @path.empty?
                 error = "Path is required for file.\n"
-            else
-                if !ignore_missing_files && !::File.exists?(path_for_project())
+            elsif !ignore_invalid_files 
+                if !::File.exists?(path_for_project())
                     error = "#{error}Can't find file with name '#{@name}' and original path '#{@path}' at '#{path_for_project()}'."
+                elsif ::File.size(path_for_project()) > MAX_FILE_SIZE
+                    error = "#{error}File '#{@name}' is bigger than #{MAX_FILE_SIZE} bytes."
                 end
             end
 
+
             if @created_by_reference.nil?
                 error = "#{error}Created_by is required for file (#{@name}).\n"
             end

data/lib/go_import/model/note.rb

@@ -90,7 +90,6 @@ module GoImport
             else
                 raise InvalidNoteClassificationError, classification
             end
-
         end
 
         def text=(text)

data/lib/go_import/model/note_classification.rb

@@ -23,3 +23,4 @@ end
 
 
 
+ 

data/lib/go_import/model/rootmodel.rb

@@ -208,6 +208,10 @@ module GoImport
                 raise AlreadyAddedError, "Already added a note with integration_id #{note.integration_id}"
             end
 
+            if note.created_by.nil?
+                note.created_by = @import_coworker
+            end
+            
             @notes.push(note)
 
             return note
@@ -306,22 +310,26 @@ module GoImport
             return error.strip
         end
 
-        def validate(ignore_missing_files = false)
-            error = String.new
+        def validate(ignore_invalid_files = false)
+            errors = String.new
+            warnings = String.new
 
             @organizations.each do |o|
                 validation_message = o.validate()
 
                 if !validation_message.empty?
-                    error = "#{error}\n#{validation_message}"
+                    errors = "#{errors}\n#{validation_message}"
                 end
             end
 
             @deals.each do |deal|
-                validation_message = deal.validate
+                error, warning = deal.validate @settings.deal.statuses.map {|status| status.label}
 
-                if !validation_message.empty?
-                    error = "#{error}\n#{validation_message}"
+                if !error.empty?
+                    errors = "#{errors}\n#{error}"
+                end
+                if !warning.empty?
+                    warnings = "#{warnings}\n#{warning}"
                 end
             end
 
@@ -329,25 +337,25 @@ module GoImport
                 validation_message = note.validate
 
                 if !validation_message.empty?
-                    error = "#{error}\n#{validation_message}"
+                    errors = "#{errors}\n#{validation_message}"
                 end
             end
 
             @documents.links.each do |link|
                 validation_message = link.validate
                 if !validation_message.empty?
-                    error = "#{error}\n#{validation_message}"
+                    errors = "#{errors}\n#{validation_message}"
                 end
             end
 
             @documents.files.each do |file|
-                validation_message = file.validate(ignore_missing_files)
+                validation_message = file.validate(ignore_invalid_files)
                 if !validation_message.empty?
-                    error = "#{error}\n#{validation_message}"
+                    errors = "#{errors}\n#{validation_message}"
                 end
             end
 
-            return error.strip
+            return [errors.strip, warnings.strip]
         end
 
         # @!visibility private

data/sources/lime-pro-basic/.gitignore

@@ -0,0 +1,14 @@
+# See http://help.github.com/ignore-files/ for more about ignoring files.
+#
+# If you find yourself ignoring temporary files generated by your text editor
+# or operating system, you probably want to add a global ignore instead:
+#   git config --global core.excludesfile ~/.gitignore_global
+
+# Ignore bundler config
+/.bundle
+# Ignore built gems
+/*.gem
+# Ignore all logfiles and tempfiles.
+/tmp
+/spec/tmp
+pkg

data/sources/lime-pro-basic/.go_import/readme.txt

@@ -0,0 +1 @@
+This source converts a LIME Pro "Core" database to LIME Go.