go_import 3.0.23 → 3.0.24

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NzczNzgyNTkzYzM5MjhkZjk1YjExNDFhMDc4M2U3NzRlMGU2YTI2Nw==
+    MjljMjUyMzQwNGM4OTg4ZDQxMmExN2VhYmNlYTYwNTEyMzI2MDhkOQ==
   data.tar.gz: !binary |-
-    ZmQwZjAyMGJkMzNmZWZjOTE3MDM2ZWRmMDgyNTQ4MGExMTFlYzcxYQ==
+    OWQ5Njk2Mjk1MjY3MTUxN2JkMjdlMGM1ZmM1YTc5OGVlYTNkMjIxMw==
 SHA512:
   metadata.gz: !binary |-
-    Y2I4Zjk5MmExODRlY2ExMWQ3YmM0ZDNkM2RhYzg5YTFhMjEyNzZjYjg2M2Mx
-    ODExMjdhNjU3OWFmMTQwYjA2OGJkOWRhNjY4YTlkMDRhZmI3N2I5ZGFiYWMy
-    OGQ5N2Y3M2ZiODc3OTFjZjNmMGMyZjkyZGYzYzJmY2ZiNGUyZjI=
+    OWU0MWU0MjQwN2QyOGZiN2U5MTI3NjhlMmIxOWFlYWFjZDUzZTkyNjZhZDE2
+    MGZjYzYwNDRhZDAyNGMzNWFmY2NiOTI5ODg1YzgwODdkZTQ0Y2MzZDllMjAx
+    NmE1YTI1ZWFiNmIxNjRiY2M2YzYzZTBiYjEwMjRjYTI5NzViNjY=
   data.tar.gz: !binary |-
-    ZmZlODEzYWQxZmU1NjAxYWQ5OTdjYmRmMTQ1MTAzOGQxYWI3OGIyNWVlMDEx
-    ZmRhZjYwODMzZDYzMmM1NzM5Zjc3Nzk3ZjQyYWI3OTUyYTRiOTk4NWE5YjMz
-    ZDcxNWMzZDcwZTNlYmM2NmY2ZmMzODdmYzUxZGIzMDE4NjhmYzk=
+    OTJjYjk5NmVhMDllZDZhNTFjN2EyM2FhYTk4NjUxMTdmZGRkZjQwMTVkNGEz
+    YmQ2Mjk2ZWUyNjMzZDM0N2UxNDA0MGExMWVlZjJkMGUzMmUwNjA5ZGY4NDdl
+    NWNhYWFjNDllYWRkYThjNmJjNGQwMGNjZDlmNzFiODlhNDk5NTQ=

data/lib/go_import/model/deal.rb

@@ -161,6 +161,10 @@ module GoImport
             end
         end
 
+        # Sets the deal's value. Both . and , are treated as thousand
+        # separators and thus cents and other fractions will be
+        # ignored. This makes it easier for us to convert a string
+        # into an integer value.
         def value=(value)
             if value.nil?
                 @value = "0"
@@ -172,10 +176,15 @@ module GoImport
                 # remove those spaces.
                 fixed_value = value.gsub(" ", "")
 
+                # we assume that both , and . are thousand separators
+                # and remove them from the value string. We dont care
+                # about decimal separators since the value is a deal's
+                # value which is much larger than cents and ores.
+                fixed_value = fixed_value.gsub(",", "")
+                fixed_value = fixed_value.gsub(".", "")
+
                 if is_integer?(fixed_value)
                     @value = fixed_value
-                elsif is_float?(fixed_value)
-                    @value = fixed_value
                 elsif fixed_value.length == 0
                     @value = "0"
                 else
@@ -187,9 +196,5 @@ module GoImport
         def is_integer?(value)
             true if Integer(value) rescue false
         end
-
-        def is_float?(value)
-            true if Float(value) rescue false
-        end
     end
 end

data/lib/go_import/model/note.rb

@@ -1,8 +1,9 @@
 module GoImport
     class Note
         include SerializeHelper
-        attr_accessor :id, :text, :integration_id, :date
+        attr_accessor :id, :integration_id, :date
 
+        attr_reader :text
         attr_reader :organization, :created_by, :person, :deal
 
         # The note's classification. It should be a value from
@@ -92,6 +93,29 @@ module GoImport
 
         end
 
+        def text=(text)
+            @text = text
+
+            if @text.nil?
+                return
+            end
+
+            if @text.length == 0
+                return
+            end
+
+            @text.strip!
+            
+            # remove form feeds
+            @text.gsub!("\f", "")
+
+            # remove vertical spaces
+            @text.gsub!("\v", "")
+
+            # remove backspace
+            @text.gsub!("\b", "")
+        end
+
         def validate
             error = String.new
 

data/lib/go_import/model_helpers.rb

@@ -2,23 +2,28 @@ module GoImport
     module ModelHasCustomFields
         # @example
         #     value = row['business_value_partner_info']
-        #     obj.set_custom_value("partner_info", value)
+        #     obj.set_custom_value("external_url", "https://www.somecompany.com")        
         def set_custom_value(integration_id, value)
-            return set_custom_field({integration_id: integration_id, value: value})
-        end
-        # @example
-        #     value = row['business_value_partner_info']
-        #     obj.set_custom_field({:integration_id=>"partner_info", :value=>value})
-        def set_custom_field(obj)
             @custom_values = [] if @custom_values == nil
-            value = obj[:value]
-            field = CustomFieldReference.new(obj)
+
+            if value.nil?
+                return
+            end
+
+            valueAsString = value.to_s
+            if valueAsString.length == 0
+                return
+            end
+            
+            field = CustomFieldReference.new({:integration_id => integration_id})
             custom_value = CustomValue.new
-            custom_value.value = value
+            custom_value.value = valueAsString
             custom_value.field = field
+
             index = @custom_values.find_index do |custom_value|
                 custom_value.field.same_as?(field)
             end
+
             if index
                 @custom_values.delete_at index
             end

data/sources/VISMA/converter.rb

@@ -79,7 +79,7 @@ class Converter
         organization.relation = GoImport::Relation::IsACustomer
 
         #Fill data to custom fields
-        organization.set_custom_field({:integration_id => "ackoms", :value => row["ACKOMS"]})
+        organization.set_custom_value("ackoms", row["ACKOMS"])
 
         return organization
     end

data/sources/easy/converter.rb

@@ -222,6 +222,8 @@ class Converter
         # the configure method.
 
         # person.set_custom_value("shoe_size", row['shoe size'])
+
+        return person
     end
 
     # Reads a row from the Easy exported Project.txt
@@ -280,16 +282,16 @@ class Converter
 
         # case activity
         # when 'SalesCall' 
-		# 	classification = GoImport::NoteClassification::SalesCall
-		# when 'Customer Visit'
-	    # classification = GoImport::NoteClassification::ClientVisit
-		# when 'No answer'
-		# 	classification = GoImport::NoteClassification::TriedToReach
+        #   classification = GoImport::NoteClassification::SalesCall
+        # when 'Customer Visit'
+        # classification = GoImport::NoteClassification::ClientVisit
+        # when 'No answer'
+        #   classification = GoImport::NoteClassification::TriedToReach
         # else
         #     classification = GoImport::NoteClassification::Comment
         # end
-		
-		# return classification
+        
+        # return classification
     end
 
     def get_note_classification_for_activity_on_project(activity)
@@ -303,14 +305,14 @@ class Converter
         
         # case activity
         # when 'Installation' 
-		# 	classification = GoImport::NoteClassification::ClientVisit
-		# when 'No answer'
-		# 	classification = GoImport::NoteClassification::TriedToReach
+        #   classification = GoImport::NoteClassification::ClientVisit
+        # when 'No answer'
+        #   classification = GoImport::NoteClassification::TriedToReach
         # else
         #     classification = GoImport::NoteClassification::Comment
         # end
-		
-		# return classification
+        
+        # return classification
     end
     
     def configure(rootmodel)

data/sources/salesforce/.go_import/runner.rb

@@ -286,16 +286,18 @@ def to_note(row, rootmodel)
     return note
 end
 
-def get_deal_statuses_from_opportunites()
-    puts "Trying to get deal statuses..."
-    statuses = []
+def add_opportunity_stages_as_deal_status_to_model(rootmodel)
+    puts "Trying to create deal statuses..."
 
+    default_status = ''
+    statuses = []
     process_rows(DEAL_FILE) do |row|
         status = {
             :label => row['StageName'],
             :integration_id => row['StageName'],
+            :sort_order => row['StageSortOrder']
         }
-
+        
         if row['IsClosed'] == '1'
             if row['IsWon'] == '1'
                 status[:assessment] = GoImport::DealState::PositiveEndState
@@ -306,10 +308,24 @@ def get_deal_statuses_from_opportunites()
 
         if !statuses.any? {|s| s[:label] == status[:label]}
             statuses.push status
+            
+            if row['StageSortOrder'] == '1'
+                default_status = status[:label]
+            end                
         end
     end
 
-    return statuses
+    statuses.sort! { |s1, s2| s1[:sort_order] <=> s2[:sort_order] }
+    rootmodel.settings.with_deal do |deal|
+        statuses.each do |status|
+            deal.add_status({ :label => status[:label],
+                              :integration_id => status[:integration_id],
+                              :assessment => status[:assessment]
+                            })
+        end
+
+        deal.default_status = default_status
+    end
 end
 
 def convert_source
@@ -345,17 +361,8 @@ def convert_source
                 end
             end
         end        
-
-        deal_statuses = get_deal_statuses_from_opportunites()
-        rootmodel.settings.with_deal do |deal|
-            deal_statuses.each do |status|
-                deal.add_status({ :label => status[:label],
-                                  :integration_id => status[:integration_id],
-                                  :assessment => status[:assessment]
-                                })
-            end
-        end
-
+        
+        add_opportunity_stages_as_deal_status_to_model(rootmodel)
         
         puts "Trying to import users..."
         process_rows(USER_FILE) do |row|

data/spec/deal_spec.rb

@@ -144,15 +144,26 @@ describe "Deal" do
         deal.value.should eq "100"
     end
 
-    it "should set value if value is a float" do
+    it "should treat . as thousand separator and remove it from the value" do
         # given
-        deal.name = "The new deal"
+        deal.name = "Deal with . as thousand separator"
 
         # when
         deal.value = "100.10"
 
         # then
-        deal.value.should eq "100.10"
+        deal.value.should eq "10010"
+    end
+
+    it "should tread , as thousand separator and remove it from the value" do
+        # given
+        deal.name = "Deal with , as thousand separator"
+
+        # when
+        deal.value = "100,10"
+
+        # then
+        deal.value = "10010"
     end
 
     it "should set value to 0 if value is nil" do

data/spec/helpers/serialize_helper_spec.rb

@@ -70,7 +70,7 @@ describe GoImport::SerializeHelper do
             p.with_source do |source|
                 source.par_se('122345')
             end
-            #p.source_ref = {:name=>'Go',:id=>"PASE122345"}
+            #p.source_ref = {:name => 'Go',:id => "PASE122345"}
             p.with_postal_address do |addr|
                 addr.city = "Ankeborg"
             end
@@ -78,9 +78,12 @@ describe GoImport::SerializeHelper do
             p.set_tag("tag:anka")
             p.set_tag("tag:Bj\u{00F6}rk")
             p.set_tag("tag:<Bj\u{00F6}rk>")
-            p.set_custom_field({:integration_id=>"2", :value=>"cf value"})
-            p.set_custom_field({:integration_id=>"3", :value=>"cf Bj\u{00F6}rk"})
-            p.set_custom_field({:integration_id=>"4", :value=>"cf <Bj\u{00F6}rk>"})
+            # p.set_custom_field({:integration_id => "2", :value => "cf value"})
+            # p.set_custom_field({:integration_id => "3", :value => "cf Bj\u{00F6}rk"})
+            # p.set_custom_field({:integration_id => "4", :value => "cf <Bj\u{00F6}rk>"})
+            p.set_custom_value("2", "cf value")
+            p.set_custom_value("3", "cf Bj\u{00F6}rk")
+            p.set_custom_value("4", "cf <Bj\u{00F6}rk>")
             GoImport::SerializeHelper::serialize(p,-1)
         }
         it "should contain first and last name" do
@@ -120,29 +123,30 @@ describe GoImport::SerializeHelper do
     end
     describe "Serialize organization" do
         let(:serialized) {
-            o = GoImport::Organization.new
-            o.name = "Ankeborgs bibliotek"
-            o.with_source do |source|
+            organization = GoImport::Organization.new
+            organization.name = "Ankeborgs bibliotek"
+            organization.with_source do |source|
                 source.par_se('122345')
             end
-            #o.source_ref = {:name=>'Go',:id=>"PASE122345"}
-            o.set_tag("tag:bibliotek")
-            o.set_tag("tag:Bj\u{00F6}rk")
-            o.set_custom_field({:integration_id=>"2", :value=>"cf value"})
-            o.set_custom_field({:integration_id=>"3", :value=>"cf Bj\u{00F6}rk"})
-            o.with_postal_address do |addr|
+            #organization.source_ref = {:name => 'Go',:id => "PASE122345"}
+            organization.set_tag("tag:bibliotek")
+            organization.set_tag("tag:Bj\u{00F6}rk")
+            organization.set_custom_value("2", "cf value")
+            organization.set_custom_value("3", "cf Bj\u{00F6}rk")
+            organization.with_postal_address do |addr|
                 addr.city = "Ankeborg"
             end
-            o.with_visit_address do |addr|
+            organization.with_visit_address do |addr|
                 addr.city = "Gaaseborg"
             end
-            o.add_employee({
+            organization.add_employee({
                 :integration_id => "1",
                 :first_name => "Kalle",
                 :last_name => "Anka"
             })
-            GoImport::SerializeHelper::serialize(o,-1)
+            GoImport::SerializeHelper::serialize(organization, -1)
         }
+
         it "should contain name" do
             serialized.should match(/Ankeborgs bibliotek/)
         end
@@ -177,11 +181,11 @@ describe GoImport::SerializeHelper do
 
     describe "Serialize goimport" do
         let(:serialized) {
-            i = GoImport::RootModel.new
-            o = GoImport::Organization.new
-            o.name = "Ankeborgs bibliotek"
-            i.organizations.push(o)
-            GoImport::SerializeHelper::serialize(i,-1)
+            rootmodel = GoImport::RootModel.new
+            organization = GoImport::Organization.new
+            organization.name = "Ankeborgs bibliotek"
+            rootmodel.add_organization organization
+            GoImport::SerializeHelper::serialize(rootmodel, -1)
         }
         it "should contain name" do
             serialized.should match(/Ankeborgs bibliotek/)
@@ -197,30 +201,30 @@ describe GoImport::SerializeHelper do
         describe "for person" do
             let(:import_rows) { GoImport::Person.new.get_import_rows }
             it "should contain integration id" do
-                import_rows.should include({:id=>'integration_id', :name=>'Integration id', :type=>:string})
-                import_rows.should include({:id=>'id', :name=>'Go id', :type=>:string})
+                import_rows.should include({:id => 'integration_id', :name => 'Integration id', :type => :string})
+                import_rows.should include({:id => 'id', :name => 'Go id', :type => :string})
             end
             it "should contain address" do
-                expected = {:id=>'postal_address', :name=>'Postal address', :type=>:address,
-                    :model=>[
-                    {:id=>'street',:name=>'Street', :type=>:string},
-                    {:id=>'zip_code',:name=>'Zip code', :type=>:string},
-                    {:id=>'city',:name=>'City', :type=>:string},
-                    {:id=>'country_code',:name=>'Country code', :type=>:string},
-                    {:id=>'location',:name=>'Location', :type=>:string},
-                    {:id=>'country_name',:name=>'Country name', :type=>:string},
+                expected = {:id => 'postal_address', :name => 'Postal address', :type => :address,
+                    :model => [
+                    {:id => 'street',:name => 'Street', :type => :string},
+                    {:id => 'zip_code',:name => 'Zip code', :type => :string},
+                    {:id => 'city',:name => 'City', :type => :string},
+                    {:id => 'country_code',:name => 'Country code', :type => :string},
+                    {:id => 'location',:name => 'Location', :type => :string},
+                    {:id => 'country_name',:name => 'Country name', :type => :string},
                 ]}
                 import_rows.should include(expected)
             end
             it "should contain organization" do
                 import_rows.should include({
-                    :id=>'organization',
-                    :name=>'Organization',
-                    :type=>:organization_reference,
-                    :model=>[
-                        {:id=>'id', :name=>'Go id', :type=>:string},
-                        {:id=>'integration_id', :name=>'Integration id', :type=>:string},
-                        {:id=>'heading', :name=>'Heading', :type=>:string}
+                    :id => 'organization',
+                    :name => 'Organization',
+                    :type => :organization_reference,
+                    :model => [
+                        {:id => 'id', :name => 'Go id', :type => :string},
+                        {:id => 'integration_id', :name => 'Integration id', :type => :string},
+                        {:id => 'heading', :name => 'Heading', :type => :string}
                         ]
                     })
             end
@@ -228,18 +232,18 @@ describe GoImport::SerializeHelper do
         describe "for organization" do
             let(:import_rows) { GoImport::Organization.new.get_import_rows }
             it "should contain integration id" do
-                import_rows.should include({:id=>'integration_id', :name=>'Integration id', :type=>:string})
-                import_rows.should include({:id=>'id', :name=>'Go id', :type=>:string})
+                import_rows.should include({:id => 'integration_id', :name => 'Integration id', :type => :string})
+                import_rows.should include({:id => 'id', :name => 'Go id', :type => :string})
             end
             it "should contain address" do
-                expected = {:id=>'postal_address', :name=>'Postal address', :type=>:address,
-                    :model=>[
-                        {:id=>'street',:name=>'Street', :type=>:string},
-                        {:id=>'zip_code',:name=>'Zip code', :type=>:string},
-                        {:id=>'city',:name=>'City', :type=>:string},
-                        {:id=>'country_code',:name=>'Country code', :type=>:string},
-                        {:id=>'location',:name=>'Location', :type=>:string},
-                        {:id=>'country_name',:name=>'Country name', :type=>:string},
+                expected = {:id => 'postal_address', :name => 'Postal address', :type => :address,
+                    :model => [
+                        {:id => 'street',:name => 'Street', :type => :string},
+                        {:id => 'zip_code',:name => 'Zip code', :type => :string},
+                        {:id => 'city',:name => 'City', :type => :string},
+                        {:id => 'country_code',:name => 'Country code', :type => :string},
+                        {:id => 'location',:name => 'Location', :type => :string},
+                        {:id => 'country_name',:name => 'Country name', :type => :string},
                     ]}
                 import_rows.should include(expected)
             end

data/spec/helpers/xsd_validate_spec.rb

@@ -4,50 +4,51 @@ require 'nokogiri'
 describe GoImport::SerializeHelper do
     describe "Validate according to xsd" do
         let(:validate_result) {
-            i = GoImport::RootModel.new
-            i.settings.with_organization do |s|
-                s.set_custom_field({:integration_id=>"2", :title=>"cf title"})
-                s.set_custom_field({:integration_id=>"3", :title=>"cf title2"})
+            rootmodel = GoImport::RootModel.new
+            rootmodel.settings.with_organization do |s|
+                s.set_custom_field({:integration_id => "2", :title => "cf title"})
+                s.set_custom_field({:integration_id => "3", :title => "cf title2"})
             end
-            i.add_coworker({
-                :integration_id=>"123",
-                :first_name=>"Kalle",
-                :last_name=>"Anka",
-                :email=>"kalle.anka@vonanka.com"
+            rootmodel.add_coworker({
+                :integration_id => "123",
+                :first_name => "Kalle",
+                :last_name => "Anka",
+                :email => "kalle.anka@vonanka.com"
             })
-            o = GoImport::Organization.new
-            o.name = "Ankeborgs bibliotek"
-            o.with_source do |source|
+            organization = GoImport::Organization.new
+            organization.name = "Ankeborgs bibliotek"
+            organization.with_source do |source|
                 source.par_se('122345')
             end
-            #o.source_ref = {:name=>'Go',:id=>"PASE122345"}
-            o.set_tag("tag:bibliotek")
-            o.set_tag("tag:Bj\u{00F6}rk")
-            o.set_custom_field({:integration_id=>"2", :value=>"cf value"})
-            o.set_custom_field({:integration_id=>"3", :value=>"cf Bj\u{00F6}rk"})
-            o.with_postal_address do |addr|
+            #organization.source_ref = {:name => 'Go',:id => "PASE122345"}
+            organization.set_tag("tag:bibliotek")
+            organization.set_tag("tag:Bj\u{00F6}rk")
+            organization.set_custom_value("2", "cf value")
+            organization.set_custom_value("3", "cf Bj\u{00F6}rk")
+            organization.with_postal_address do |addr|
                 addr.city = "Ankeborg"
             end
-            o.with_visit_address do |addr|
+            organization.with_visit_address do |addr|
                 addr.city = "Gaaseborg"
             end
             coworker = GoImport::Coworker.new({:integration_id => "1", :first_name => "Vincent", :last_name => "Vega"})
-            o.responsible_coworker = coworker
+            organization.responsible_coworker = coworker
 
-            emp = o.add_employee({
+            emp = organization.add_employee({
                 :integration_id => "1",
                 :first_name => "Kalle",
                 :last_name => "Anka"
             })
             emp.direct_phone_number = '234234234'
             emp.currently_employed = true
-            i.organizations.push(o)
+            rootmodel.add_organization organization
             xsd_file = File.join(File.dirname(__FILE__), '..', 'sample_data', 'schema0.xsd')
 
             xsd = Nokogiri::XML::Schema(File.read(xsd_file))
-            doc = Nokogiri::XML(GoImport::SerializeHelper::serialize(i,-1))
+            doc = Nokogiri::XML(GoImport::SerializeHelper::serialize(rootmodel, -1))
             xsd.validate(doc)
         }
+
         it "Should not contain validation errors" do
             expect(validate_result).to eq([])
         end

data/spec/note_spec.rb

@@ -49,7 +49,7 @@ describe "Note" do
         note.validate.length.should be > 0
     end
 
-    it "will set organization ref when organization is assinged" do
+    it "will set organization ref when organization is assigned" do
         # given
         org = GoImport::Organization.new({:integration_id => "123", :name => "Beagle Boys!"})
 
@@ -61,7 +61,7 @@ describe "Note" do
         note.instance_variable_get(:@organization_reference).is_a?(GoImport::OrganizationReference).should eq true
     end
 
-    it "will set person ref when person is assinged" do
+    it "will set person ref when person is assigned" do
         # given
         person = GoImport::Person.new({:integration_id => "123" })
         person.parse_name_to_firstname_lastname_se "Billy Bob"
@@ -74,7 +74,7 @@ describe "Note" do
         note.instance_variable_get(:@person_reference).is_a?(GoImport::PersonReference).should eq true
     end
 
-    it "will set coworker ref when coworker is assinged" do
+    it "will set coworker ref when coworker is assigned" do
         # given
         coworker = GoImport::Coworker.new({:integration_id => "123" })
         coworker.parse_name_to_firstname_lastname_se "Billy Bob"
@@ -87,7 +87,7 @@ describe "Note" do
         note.instance_variable_get(:@created_by_reference).is_a?(GoImport::CoworkerReference).should eq true
     end
 
-    it "will set deal ref when deal is assinged" do
+    it "will set deal ref when deal is assigned" do
         # given
         deal = GoImport::Deal.new({:integration_id => "123" })
         deal.name = "The new deal"
@@ -111,4 +111,40 @@ describe "Note" do
             note.classification = "hubbabubba"
         }.to raise_error(GoImport::InvalidNoteClassificationError)
     end
+
+    it "should remove form feed from text" do
+        # given
+        textWithFormFeed = "Text with form feed"
+        textWithoutFormFeed = "Text with form feed"
+
+        # when
+        note.text = textWithFormFeed
+
+        # then
+        note.text.should eq textWithoutFormFeed
+    end
+
+    it "should remove vertical tab from text" do
+        # given
+        textWithVerticalTab = "Text with \vvertical tab"
+        textWithoutVerticalTab = "Text with vertical tab"
+
+        # when
+        note.text = textWithVerticalTab
+
+        # then
+        note.text.should eq textWithoutVerticalTab
+    end
+
+    it "should remove backspace from text" do
+        # given
+        textWithBackSpace = "Text with \bbackspace"
+        textWithoutBackSpace = "Text with backspace"
+
+        # when
+        note.text = textWithBackSpace
+
+        # then
+        note.text.should eq textWithoutBackSpace
+    end    
 end

data/spec/organization_spec.rb

@@ -150,12 +150,37 @@ describe "Organization" do
     it "should only set relation last modified to valid date" do
         # given
         organization.relation = GoImport::Relation::IsACustomer
-
+        
         # when, then
         expect {
             organization.relation_last_modified = "hubbabubba"
         }.to raise_error(GoImport::InvalidValueError)
     end
+    
+    it "can have custom value" do
+        # given, when
+        organization.set_custom_value "field_integration_id", "the is a value"
+
+        # then
+        organization.custom_values.length.should eq 1
+    end
+
+    it "can have a custom numeric value" do
+        # given, when
+        organization.set_custom_value "price", 100
+
+        # then
+        organization.custom_values.length.should eq 1
+        organization.custom_values[0].value.should eq "100"
+    end
+
+    it "a custom value can not be empty" do
+        # given, when
+        organization.set_custom_value "field_integration_id", ""
+
+        # then
+        organization.custom_values.length.should eq 0
+    end
 end
 
 describe "OrganizationReference" do

data/spec/person_spec.rb

@@ -12,22 +12,20 @@ describe "Person" do
         person.tags[0].value.should eq 'Import'
     end
 
-    it "can set a customfield" do
-        person.set_custom_field({:integration_id=>'the key',
-            :value=> 'the value'})
+    it "can set a custom value" do
+        person.set_custom_value('the field', 'the value')
 
         value = person.custom_values[0]
         field = value.field
-        field.integration_id.should eq 'the key'
+        field.integration_id.should eq 'the field'
         value.value.should eq 'the value'
     end
 
-    it "will set custom field with same integration_id to the last value" do
-        person.set_custom_field({:integration_id=>'the key',
-            :value=> 'the value'})
+    it "will set custom value with same integration_id to the last value" do
+        person.set_custom_value('the key', 'the value')
 
-        person.set_custom_field({:integration_id=>'the key',
-            :value=> 'the value 2'})
+        person.set_custom_value('the key', 'the value 2')
+        
         value = person.custom_values[0]
         field = value.field
 
@@ -36,30 +34,6 @@ describe "Person" do
         value.value.should eq 'the value 2'
     end
 
-    it "will set custom field with same id to the last value" do
-        person.set_custom_field({ :integration_id => 'the id', :value=> 'the value' })
-
-        person.set_custom_field({ :integration_id => 'the id', :value=> 'the value 2'})
-        value = person.custom_values[0]
-        field = value.field
-
-        person.custom_values.length.should eq 1
-        field.integration_id.should eq 'the id'
-        value.value.should eq 'the value 2'
-    end
-
-    it "will set custom field (using set_custom_value) with same integration_id to the last value" do
-        person.set_custom_value('the id', 'the value')
-
-        person.set_custom_value('the id', 'the value 2')
-        value = person.custom_values[0]
-        field = value.field
-
-        person.custom_values.length.should eq 1
-        field.integration_id.should eq 'the id'
-        value.value.should eq 'the value 2'
-    end
-
     it "will only set tag once" do
         # we already have the default 'import' tag.
         person.tags.length.should eq 1

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: go_import
 version: !ruby/object:Gem::Version
-  version: 3.0.23
+  version: 3.0.24
 platform: ruby
 authors:
 - Oskar Gewalli
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-18 00:00:00.000000000 Z
+date: 2015-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes
@@ -154,8 +154,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: ! '  go-import is an import tool for LIME Go. It can take virtually any
-  input source and create pretty looking xml-files that LIME Go likes. go-import has
-  some predefined sources that makes will help you migrate your data.
+  input source and create zip-files that LIME Go likes. go-import has some predefined
+  sources that makes will help you migrate your data.
 
 '
 email: support@lundalogik.se
@@ -299,7 +299,7 @@ rubyforge_project:
 rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
-summary: Library to generate Lime Go xml import format
+summary: Tool to generate Lime Go zip import files
 test_files:
 - spec/address_spec.rb
 - spec/class_settings_spec.rb