go_gem 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de781c3ea978d43846ab114c957f973d1273a385b4a2cda8b4ab8bcae31e7b61
-  data.tar.gz: ff9e4ec5ee199bcc5aeabeec13426caa2db9cf2d593bb5fdca44f164daed6f2f
+  metadata.gz: 9391de7a479373991e4d34ffc16b48c12b0b939f7738d3534d35d46d0e8f031a
+  data.tar.gz: 9de4ce2876dfd5e63c2858502ab63f268c3dda3c0da535701f4cfc739b3f1cf8
 SHA512:
-  metadata.gz: 55fe501bd31919fe173a8ed9dbb7998a51da0098679e15f3d1ad2da120c62b78d80dc91139feb9056f949d08e49ed0bcd5ef1e217dd6d7e52297baa9039b9871
-  data.tar.gz: 82d8f84fb59e73fd7e555446fc02121e516fb5a376478a2484174bff7f2e3cdb60e7d5f461432783126fef30130c7b7e6e9081cbe6460957e87de0b1bf8b8cdd
+  metadata.gz: c5bbf69c9727d91331d4ac4e316a3cfa9462fcd180b965789da3f7e57c1d61e2cfad60d46e2db49be1335ddf88c83c18b931afe4cf0ce42a17ad208476f6ccc6
+  data.tar.gz: c78e49338aabb2cdd1490a8f258e5e39db8c1a75bb63397f280ecad88deacc39338bdddcb134d8c619c76a997abaa216cb4d6e5921133e5305a076f9a8e0f772

data/README.md

@@ -85,7 +85,9 @@ namespace :go do
       sh "which golangci-lint" do |ok, _|
         raise "golangci-lint isn't installed. See. https://golangci-lint.run/welcome/install/" unless ok
       end
-      sh GoGem::RakeTask.build_env_vars, "golangci-lint run"
+
+      build_tag = GoGem::Util.ruby_minor_version_build_tag
+      sh GoGem::RakeTask.build_env_vars, "golangci-lint run --build-tags #{build_tag}"
     end
   end
 end
@@ -101,12 +103,28 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
       - uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: false
+
+      # FIXME: setup-go installs cache in `vendor/` and setup-ruby installs cache in `vendor/bundle/`
+      #        If we use the cache in setup-go and setup-ruby at the same time, this doesn't work well because they use the same directory.
+      #        Therefore, the installation location needs to be changed from the setup-ruby default.
+      - name: bundle install
+        run: |
+          set -xe
+          bundle config --local path ruby-vendor/bundle
+          bundle install --jobs 4
 
       - name: export CGO_CFLAGS for golangci-lint
         run: bundle exec rake go:build_envs[CGO_CFLAGS] >> $GITHUB_ENV
 
+      - name: export BUILD_TAG for golangci-lint
+        run: echo "BUILD_TAG=$(bundle exec rake go:build_tag)" >> $GITHUB_ENV
+
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v6
+        with:
+          args: --build-tags ${{ env.BUILD_TAG }}
 ```
 
 #### Available configurations

data/lib/go_gem/mkmf.rb

@@ -9,6 +9,7 @@ module GoGem
     #
     # @param target [String]
     # @param srcprefix [String,nil]
+    # @param go_build_args [String,nil] Arguments passed to `go build`
     #
     # @example
     #   require "mkmf"
@@ -17,7 +18,10 @@ module GoGem
     #   # Use create_go_makefile instead of create_makefile
     #   # create_makefile("example/example")
     #   create_go_makefile("example/example")
-    def create_go_makefile(target, srcprefix = nil)
+    #
+    # @example Pass debug flags to `go build`
+    #   create_go_makefile("example/example", go_build_args: "-gcflags='all=-N -l'")
+    def create_go_makefile(target, srcprefix: nil, go_build_args: nil)
       find_executable("go")
 
       # rubocop:disable Style/GlobalVars
@@ -28,13 +32,7 @@ module GoGem
 
       create_makefile(target, srcprefix)
 
-      case `#{RbConfig::CONFIG["CC"]} --version` # rubocop:disable Lint/LiteralAsCondition
-      when /Free Software Foundation/
-        ldflags = "-Wl,--unresolved-symbols=ignore-all"
-      when /clang/
-        ldflags = "-undefined dynamic_lookup"
-      end
-
+      ldflags = GoGem::Util.generate_ldflags
       current_dir = File.expand_path(".")
 
       goflags = "-tags=#{GoGem::Util.ruby_minor_version_build_tag}"
@@ -44,7 +42,7 @@ module GoGem
           $(DLLIB): Makefile $(srcdir)/*.go
                   cd $(srcdir); \
                   CGO_CFLAGS='$(INCFLAGS)' CGO_LDFLAGS='#{ldflags}' GOFLAGS='#{goflags}' \
-                    go build -p 4 -buildmode=c-shared -o #{current_dir}/$(DLLIB)
+                    go build -p 4 -buildmode=c-shared -o #{current_dir}/$(DLLIB) #{go_build_args}
         MAKEFILE
       end
     end

data/lib/go_gem/rake_task.rb

@@ -38,11 +38,13 @@ module GoGem
   #         sh "which golangci-lint" do |ok, _|
   #           raise "golangci-lint isn't installed. See. https://golangci-lint.run/welcome/install/" unless ok
   #         end
-  #         sh GoGem::RakeTask.build_env_vars, "golangci-lint run"
+  #
+  #         build_tag = GoGem::Util.ruby_minor_version_build_tag
+  #         sh GoGem::RakeTask.build_env_vars, "golangci-lint run --build-tags #{build_tag}"
   #       end
   #     end
   #   end
-  class RakeTask < ::Rake::TaskLib # rubocop:disable Metrics/ClassLength
+  class RakeTask < ::Rake::TaskLib
     DEFAULT_TASK_NAMESPACE = :go
 
     DEFAULT_GO_BIN_PATH = "go"
@@ -97,61 +99,19 @@ module GoGem
     #
     # @return [Hash<String, String>]
     def self.build_env_vars
-      ldflags = generate_ldflags
-      cflags = generate_cflags
-
-      # FIXME: Workaround for Ubuntu (GitHub Actions)
-      if RUBY_PLATFORM =~ /linux/i
-        cflags.gsub!("-Wno-self-assign", "")
-        cflags.gsub!("-Wno-parentheses-equality", "")
-        cflags.gsub!("-Wno-constant-logical-operand", "")
-        cflags.gsub!("-Wsuggest-attribute=format", "")
-        cflags.gsub!("-Wold-style-definition", "")
-        cflags.gsub!("-Wsuggest-attribute=noreturn", "")
-        ldflags.gsub!("-Wl,--unresolved-symbols=ignore-all", "")
-      end
+      ldflags = GoGem::Util.generate_ldflags
+      cflags = GoGem::Util.generate_cflags
 
       ld_library_path = RbConfig::CONFIG["libdir"].to_s
 
       {
-        "GOFLAGS"         => generate_goflags,
+        "GOFLAGS"         => GoGem::Util.generate_goflags,
         "CGO_CFLAGS"      => cflags,
         "CGO_LDFLAGS"     => ldflags,
         "LD_LIBRARY_PATH" => ld_library_path,
       }
     end
 
-    # @return [String]
-    def self.generate_goflags
-      "-tags=#{GoGem::Util.ruby_minor_version_build_tag}"
-    end
-    private_class_method :generate_goflags
-
-    # @return [String]
-    def self.generate_ldflags
-      ldflags = "-L#{RbConfig::CONFIG["libdir"]} -l#{RbConfig::CONFIG["RUBY_SO_NAME"]}"
-
-      case `#{RbConfig::CONFIG["CC"]} --version` # rubocop:disable Lint/LiteralAsCondition
-      when /Free Software Foundation/
-        ldflags << " -Wl,--unresolved-symbols=ignore-all"
-      when /clang/
-        ldflags << " -undefined dynamic_lookup"
-      end
-
-      ldflags
-    end
-    private_class_method :generate_ldflags
-
-    # @return [String]
-    def self.generate_cflags
-      [
-        RbConfig::CONFIG["CFLAGS"],
-        "-I#{RbConfig::CONFIG["rubyarchhdrdir"]}",
-        "-I#{RbConfig::CONFIG["rubyhdrdir"]}",
-      ].join(" ")
-    end
-    private_class_method :generate_cflags
-
     # @yield
     def within_target_dir
       Dir.chdir(target_dir) do # rubocop:disable Style/ExplicitBlockArgument

data/lib/go_gem/util.rb

@@ -14,5 +14,52 @@ module GoGem
     def self.ruby_minor_version_build_tag(ruby_version = RUBY_VERSION)
       "ruby_#{ruby_version.to_f.to_s.gsub(".", "_")}"
     end
+
+    # @return [String]
+    def self.generate_ldflags
+      ldflags = "-L#{RbConfig::CONFIG["libdir"]} -l#{RbConfig::CONFIG["RUBY_SO_NAME"]}"
+
+      case `#{RbConfig::CONFIG["CC"]} --version` # rubocop:disable Lint/LiteralAsCondition
+      when /Free Software Foundation/
+        ldflags << " -Wl,--unresolved-symbols=ignore-all"
+      when /clang/
+        ldflags << " -undefined dynamic_lookup"
+      end
+
+      # FIXME: Workaround for Ubuntu (GitHub Actions)
+      ldflags.gsub!("-Wl,--unresolved-symbols=ignore-all", "") if RUBY_PLATFORM =~ /linux/i
+
+      ldflags.strip
+    end
+
+    # @return [String]
+    def self.generate_cflags
+      cflags =
+        [
+          RbConfig::CONFIG["CFLAGS"],
+          "-I#{RbConfig::CONFIG["rubyarchhdrdir"]}",
+          "-I#{RbConfig::CONFIG["rubyhdrdir"]}",
+        ].join(" ")
+
+      # FIXME: Workaround for Ubuntu (GitHub Actions)
+      if RUBY_PLATFORM =~ /linux/i
+        cflags.gsub!("-Wno-self-assign", "")
+        cflags.gsub!("-Wno-parentheses-equality", "")
+        cflags.gsub!("-Wno-constant-logical-operand", "")
+        cflags.gsub!("-Wsuggest-attribute=format", "")
+        cflags.gsub!("-Wold-style-definition", "")
+        cflags.gsub!("-Wsuggest-attribute=noreturn", "")
+      end
+
+      # FIXME: Workaround for Alpine
+      cflags.gsub!("-Wpointer-arith", "") if RUBY_PLATFORM =~ /linux-musl/i
+
+      cflags.strip
+    end
+
+    # @return [String]
+    def self.generate_goflags
+      "-tags=#{ruby_minor_version_build_tag}"
+    end
   end
 end

data/lib/go_gem/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GoGem
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/sig/go_gem/mkmf.rbs

@@ -2,6 +2,6 @@ module GoGem
   module Mkmf
     $objs: Array[untyped]
 
-    def create_go_makefile: (String target, String? srcprefix) -> void
+    def create_go_makefile: (String target, ?srcprefix: String?, ?go_build_args: String?) -> void
   end
 end

data/sig/go_gem/rake_task.rbs

@@ -30,12 +30,6 @@ module GoGem
 
     def self.build_env_vars: () -> { "GOFLAGS" => String, "CGO_CFLAGS" => String, "CGO_LDFLAGS" => String, "LD_LIBRARY_PATH" => String }
 
-    def self.generate_goflags: () -> String
-
-    def self.generate_ldflags: () -> String
-
-    def self.generate_cflags: () -> String
-
     private
 
     def define_go_test_task: () -> void

data/sig/go_gem/util.rbs

@@ -1,5 +1,11 @@
 module GoGem
   module Util
     def self.ruby_minor_version_build_tag: (?String ruby_version) -> String
+
+    def self.generate_ldflags: () -> String
+
+    def self.generate_cflags: () -> String
+
+    def self.generate_goflags: () -> String
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: go_gem
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - sue445
 bindir: exe
 cert_chain: []
-date: 2025-01-06 00:00:00.000000000 Z
+date: 2025-01-24 00:00:00.000000000 Z
 dependencies: []
 description: Helpers for compiling Go extensions for ruby
 email: