go_cd_feed 1.1.1 → 1.1.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    go_cd_feed (1.1.0)
+    go_cd_feed (1.1.1)
       nokogiri
 
 GEM

data/go_cd_feed.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "go_cd_feed"
-  s.version     = '1.1.1'
+  s.version     = '1.1.2'
   s.authors     = ["Nikhil Mungel", "Ketan Padegaonkar", "Shishir Das", "Bill DePhillips"]
   s.email       = ["hyfather@gmail.com", "KetanPadegaonkar@gmail.com", "shishir.das@gmail.com", "bill.dephillips@gmail.com"]
   s.homepage    = "http://github.com/rearadmiral/go-api-client.git"

data/lib/go_api_client/http_fetcher.rb

@@ -4,16 +4,34 @@ require 'net/https'
 module GoApiClient
   class HttpFetcher
 
+    attr_reader :status_reporter
+
+    class StatusReporter
+      def on_request_start(url, options)
+        @start_time = Time.now
+        puts "[GoApiClient] fetching #{url}"
+      end
+
+      def on_request_success(response, url, options)
+        seconds = Time.now - @start_time
+        puts "[GoApiClient] fetched #{url} in #{seconds}sec"
+      end
+    end
+
+    class QuietStatusReporter
+      def on_request_start(*args); end
+      def on_request_success(*args); end
+    end
+
     def initialize(options={})
       @username = options[:username]
       @password = options[:password]
+      @status_reporter = options[:status_reporter] || ENV['QUIET'] ? QuietStatusReporter.new : StatusReporter.new
     end
 
     def get(url, options={})
       uri = URI.parse(url)
 
-      puts "[DEBUG] fetching #{url}" unless ENV['QUIET']
-
       password = options[:password] || uri.password || @password
       username = options[:username] || uri.user     || @username
       params   = options[:params]   || {}
@@ -23,6 +41,8 @@ module GoApiClient
       http = Net::HTTP.new(uri.host, uri.port)
       http.use_ssl = uri.scheme == 'https'
 
+      status_reporter.on_request_start(uri, options)
+
       res = http.start do |http|
         req = Net::HTTP::Get.new(uri.request_uri)
         req.basic_auth(username, password) if username || password
@@ -31,6 +51,7 @@ module GoApiClient
 
       case res
       when Net::HTTPSuccess
+        status_reporter.on_request_success(res, uri, options.merge(:url => uri))
         return res
       end
       res.error!

data/test/go_api_client/atom/feed_test.rb

@@ -13,7 +13,12 @@ module GoApiClient
         assert_equal (25+4), feed.entries.count
       end
 
-      test "should stop at first page if entry id not specified" do
+      test "should stop after page limit if specified" do
+        feed = GoApiClient::Atom::Feed.new('https://go-server.example.com/go/api/pipelines/tlb/stages.xml', nil, 1).fetch!
+        assert_equal 25, feed.entries.count
+      end
+
+      test "should not stop until first page if entry id not specified" do
         stub_request(:get, "https://go-server.example.com/go/api/pipelines/tlb/stages.xml?before=7916973").to_return(:body => file_contents("pagination/stages_before_7916973.xml"))
 
         feed = GoApiClient::Atom::Feed.new('https://go-server.example.com/go/api/pipelines/tlb/stages.xml').fetch!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: go_cd_feed
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-13 00:00:00.000000000 Z
+date: 2014-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock