gnip_api 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fa62208071b71ee1b39f62ea2e2a1f828a1988d9
-  data.tar.gz: aba53bd23b19aab7e0d8093cd0d17032173956f8
+  metadata.gz: 8a2752b22cd623729d2f859893f4b301eb576aef
+  data.tar.gz: cdbeef52238ba6c0bd037f06e68710b11337a8d4
 SHA512:
-  metadata.gz: c9b59171474daf4d71ba16aea659c2c5c86d502fd9c0c63d79489f4601e1d300ea4120f66f3aea7e6755d2c1649e584259624eec22d87fb4be90cbbf8aa3206a
-  data.tar.gz: 55d5b7fe81df412c02fd6f4386a692df3b381ee62ed40ecdad611efe2bf7019f26b3940208f601ff09c10299dcaa1ffd4b712fc5a37ca25565cc7e0b031f08b5
+  metadata.gz: f1f568484d56dc95e14831a248200221c85d33fbb0e40c03f798c3de58d65f2f4e078dd11000aae87c8d3e419d79d48297fd1e6c410367bfbe63d8846a43f249
+  data.tar.gz: eda1592b79c965360154a25986cd149ad5fc2fe080153199a91996969ca67191aa373b1f49e9c1d4adc5887c3fe2891c2e7cdf08629eae1c5181274297b9b7d2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gnip_api (1.1.1)
+    gnip_api (1.1.2)
       addressable
       httparty
       yajl-ruby

data/lib/gnip_api/adapter.rb

@@ -52,7 +52,7 @@ module GnipApi
         error_message = response.error_message
         @logger.error "#{response.request_method} request to #{response.request_uri} returned with status #{response.status} FAIL: #{error_message}"
         raise GnipApi::Errors::Adapter::GnipSoftwareError.new error_message if response.status == 503 || response.status == '503'
-        # raise GnipApi::Errors::Adapter::RateLimitedError.new error_message if response.status == 429
+        raise GnipApi::Errors::Adapter::RateLimitError.new error_message if response.status == 429 || response.status == '429'
         raise GnipApi::Errors::Adapter::RequestError.new error_message
       end
     end

data/lib/gnip_api/errors.rb

@@ -20,6 +20,12 @@ module GnipApi
         end
       end
 
+      class RateLimitError < StandardError
+        def initialize msg='Exceded rate limits'
+          @message = msg
+        end
+      end
+
       class GnipSoftwareError < StandardError
         def initialize msg='Gnip Software Error'
           @message = msg

data/lib/gnip_api/version.rb

@@ -1,3 +1,3 @@
 module GnipApi
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/spec/gnip_api/adapter_spec.rb

@@ -75,4 +75,34 @@ describe GnipApi::Adapter do
     end
   end
 
+  describe '#check_response_for_errors' do
+    before{ configure_gem }
+    let(:adapter) { GnipApi::Adapter.new }
+    let(:request) { GnipApi::Request.new_get(@uri) }
+    
+    context 'when is ok' do
+      let(:response) { GnipApi::Response.new(request, 200, 'good body', {}) }
+      it('does not throw exception') { expect(Proc.new{adapter.check_response_for_errors(response)}).not_to raise_error }
+    end
+
+    context 'when rate limited' do
+      let(:error_message){ {"error"=>{"message"=>"Exceeded rate limit", "sent"=>"2017-06-05T16:20:43+00:00", "transactionId"=>"00629e29000a91c1"}}.to_json }
+      let(:response) { GnipApi::Response.new(request, 429, error_message, {}) }
+      it('raises RateLimitError') { expect(Proc.new{adapter.check_response_for_errors(response)}).to raise_error(GnipApi::Errors::Adapter::RateLimitError) }
+    end
+
+    context 'when software error' do
+      let(:error_message){ {"error"=>{"message"=>"some server error", "sent"=>"2017-06-05T16:20:43+00:00", "transactionId"=>"00629e29000a91c1"}}.to_json }
+      let(:response) { GnipApi::Response.new(request, 503, error_message, {}) }
+      it('raises GnipSoftwareError') { expect(Proc.new{adapter.check_response_for_errors(response)}).to raise_error(GnipApi::Errors::Adapter::GnipSoftwareError) }
+    end
+
+    context 'when other error' do
+      let(:error_message){ {"error"=>{"message"=>"Exceeded rate limit", "sent"=>"2017-06-05T16:20:43+00:00", "transactionId"=>"00629e29000a91c1"}}.to_json }
+      let(:response) { GnipApi::Response.new(request, 400, error_message, {}) }
+      it('raises generic error') { expect(Proc.new{adapter.check_response_for_errors(response)}).to raise_error(GnipApi::Errors::Adapter::RequestError) }
+    end
+
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gnip_api
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Rayko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-21 00:00:00.000000000 Z
+date: 2017-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler