gnawrnip 0.2.0 → 0.2.1

data/lib/gnawrnip/screenshot.rb

@@ -1,6 +1,7 @@
 require 'tempfile'
 require 'time'
 require 'capybara'
+require 'oily_png'
 
 module Gnawrnip
   class Screenshot
@@ -51,8 +52,6 @@ module Gnawrnip
         end
 
         def resize(path)
-          require 'oily_png'
-
           image = OilyPNG::Canvas.from_file(path)
           new_width, new_height = calculate_new_size(image.width, image.height)
 
@@ -67,12 +66,12 @@ module Gnawrnip
         # @return  [Array]  New width and height size. [width, height]
         #
         def calculate_new_size(width, height)
-          ratio  = width / height
+          ratio  = width.to_f / height.to_f
           target = Gnawrnip.max_frame_size
 
           return [width, height] if target > [width, height].max
 
-          if ratio < 0
+          if ratio < 1
             new_width  = target * ratio
             new_height = target
           else

data/lib/gnawrnip/version.rb

@@ -1,3 +1,3 @@
 module Gnawrnip
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/gnawrnip/screenshot_spec.rb

@@ -3,29 +3,8 @@ require 'gnawrnip/screenshot'
 
 module Gnawrnip
   describe Screenshot do
-    describe '.take' do
-      subject { Screenshot.take.read }
-
-      context 'No given max frame size' do
-        before do
-          Screenshot.stub(:need_resize?) { false }
-          Screenshot.should_not_receive(:resize)
-        end
-
-        # see GnawrnipTestSession::save_screenshot
-        it { should == "screenshot" }
-      end
-
-      context 'No given max frame size' do
-        before do
-          Screenshot.stub(:need_resize?) { true }
-          Screenshot.should_receive(:resize)
-        end
-
-        it { should == "screenshot" }
-      end
-
-      context 'not support save_screenshot' do
+    context 'Not support save_screenshot' do
+      describe '.tale' do
         before do
           GnawrnipTest::Session.any_instance.stub(:save_screenshot) do
             raise Capybara::NotSupportedByDriverError
@@ -35,8 +14,10 @@ module Gnawrnip
         subject { lambda { Screenshot.take } }
         it { should raise_error Capybara::NotSupportedByDriverError }
       end
+    end
 
-      context 'raise unknown error' do
+    context 'raise unknown error' do
+      describe '.take' do
         before do
           GnawrnipTest::Session.any_instance.stub(:save_screenshot) do
             raise Timeout::Error
@@ -61,5 +42,70 @@ module Gnawrnip
         end
       end
     end
+
+    context 'No given Gnawrnip.max_frame_size' do
+      describe '.take' do
+        subject { Screenshot.take.read }
+
+        context 'No given max frame size' do
+          before do
+            Gnawrnip.max_frame_size = nil
+            Screenshot.should_not_receive(:resize)
+          end
+
+          it { should == "screenshot" }
+        end
+      end
+    end
+
+    context 'Given Gnawrnip.max_frame_size' do
+      before do
+        OilyPNG::Canvas.stub(:from_file) { oily_png }
+      end
+
+      subject { Screenshot.take.read }
+
+      context 'width larger than height.' do
+        let(:oily_png) do
+          oily_png = double('oily_png', width: 640, height: 480, save: nil)
+          oily_png.should_receive(:resample_bilinear!).with(300, 225)
+          oily_png
+        end
+
+        before do
+          Gnawrnip.max_frame_size = 300
+        end
+
+        it { should == "screenshot" }
+      end
+
+      context 'height larger than width.' do
+        let(:oily_png) do
+          oily_png = double('oily_png', width: 480, height: 640, save: nil)
+          oily_png.should_receive(:resample_bilinear!).with(300, 400)
+          oily_png
+        end
+
+        before do
+          Gnawrnip.max_frame_size = 400
+        end
+
+        it { should == "screenshot" }
+      end
+
+      context 'Given max_frame_size larger than original.' do
+        let(:oily_png) do
+          oily_png = double('oily_png', width: 640, height: 480, save: nil)
+          oily_png.should_receive(:resample_bilinear!).with(640, 480)
+          oily_png
+        end
+
+        before do
+          Gnawrnip.max_frame_size = 1024
+        end
+
+        it { should == "screenshot" }
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gnawrnip
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-15 00:00:00.000000000 Z
+date: 2013-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -173,7 +173,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 270195121
+      hash: 3462601225133787516
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -182,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 270195121
+      hash: 3462601225133787516
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23