gmo 0.0.2 → 0.1.0

data/fixtures/vcr_cassettes/GMO_Payment_SiteAPI/_update_member_gets_data_about_a_transaction.yml

@@ -2,10 +2,10 @@
 http_interactions:
 - request:
     method: post
-    uri: https://pt01.mul-pay.jp/payment/UpdateMember.idPass
+    uri: https://<HOST>/payment/UpdateMember.idPass
     body:
       encoding: UTF-8
-      string: MemberID=100&MemberName=John+Smith2&SiteID=<SITE_ID>&SitePass=<SITE_PASS>
+      string: MemberID=1362106780&MemberName=John+Smith2&SiteID=<SITE_ID>&SitePass=<SITE_PASS>
     headers:
       Accept:
       - ! '*/*'
@@ -17,7 +17,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sat, 16 Feb 2013 05:29:21 GMT
+      - Fri, 01 Mar 2013 02:59:41 GMT
       Connection:
       - close
       Content-Type:
@@ -26,7 +26,7 @@ http_interactions:
       - chunked
     body:
       encoding: US-ASCII
-      string: MemberID=100
+      string: MemberID=1362106780
     http_version: 
-  recorded_at: Sat, 16 Feb 2013 05:29:21 GMT
+  recorded_at: Fri, 01 Mar 2013 02:59:41 GMT
 recorded_with: VCR 2.4.0

data/gmo.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |gem|
   gem.name        = "gmo"
   gem.description   = %q{Ruby client library for the GMO Payment Platform.}
   gem.summary       = %q{GMO Payment API client: Ruby client library for the GMO Payment Platform.}
-  gem.homepage      = ""
+  gem.homepage      = "https://github.com/t-k/gmo-payment-ruby"
   gem.version     = GMO::VERSION
 
   gem.authors       = ["Tatsuo Kaniwa"]

data/lib/gmo.rb

@@ -17,21 +17,17 @@ module GMO
 
   module Payment
 
-    DEV_SERVER = "pt01.mul-pay.jp"
-    # TODO: Set production server
-    PRO_SERVER = "pt01.mul-pay.jp"
-
     class API
 
       def initialize(options = {})
-        @development = options[:development] || true
+        @host = options[:host]
       end
-      attr_reader :development
+      attr_reader :host
 
       def api(path, args = {}, verb = "post", options = {}, &error_checking_block)
         # Setup args for make_request
         path = "/payment/#{path}" unless path =~ /^\//
-        options.merge!({ "development" => @development })
+        options.merge!({ :host => @host })
         # Make request via the provided service
         result = GMO.make_request path, args, verb, options
         # Check for any 500 server errors before parsing the body

data/lib/gmo/http_services.rb

@@ -15,7 +15,7 @@ module GMO
     def self.included(base)
       base.class_eval do
         def self.server(options = {})
-          options[:development] ? Payment::DEV_SERVER : Payment::PRO_SERVER
+          options[:host]
         end
       end# end class_eval
     end

data/lib/gmo/shop_and_site_api.rb

@@ -4,16 +4,16 @@ module GMO
 
     module ShopAndSiteAPIMethods
       def initialize(options = {})
-        @shop_id     = options[:shop_id]
-        @shop_pass   = options[:shop_pass]
-        @site_id     = options[:site_id]
-        @site_pass   = options[:site_pass]
-        @development = options[:development] || true
-        unless @site_id && @site_pass && @shop_id && @shop_pass
-          raise ArgumentError, "Initialize must receive a hash with :site_id, :site_pass, :shop_id and either :shop_pass! (received #{options.inspect})"
+        @shop_id   = options[:shop_id]
+        @shop_pass = options[:shop_pass]
+        @site_id   = options[:site_id]
+        @site_pass = options[:site_pass]
+        @host      = options[:host]
+        unless @site_id && @site_pass && @shop_id && @shop_pass && @host
+          raise ArgumentError, "Initialize must receive a hash with :site_id, :site_pass, :shop_id, :shop_pass and either :host! (received #{options.inspect})"
         end
       end
-      attr_reader :shop_id, :shop_pass, :site_id, :site_pass, :development
+      attr_reader :shop_id, :shop_pass, :site_id, :site_pass, :host
 
       # 2.17.2.1.決済後カード登録
       # 指定されたオーダーID の取引に使用したカードを登録します。

data/lib/gmo/shop_api.rb

@@ -6,7 +6,7 @@
 # gmo = GMO::Payment::ShopAPI.new({
 #   shop_id:     "foo",
 #   shop_pass:   "bar",
-#   development:  true
+#   host:  "mul-pay.com"
 # })
 # result = gmo.post_request("EntryTran.idPass", options)
 module GMO
@@ -15,14 +15,14 @@ module GMO
     module ShopAPIMethods
 
       def initialize(options = {})
-        @shop_id     = options[:shop_id]
-        @shop_pass   = options[:shop_pass]
-        @development = options[:development] || true
-        unless @shop_id && @shop_pass
-          raise ArgumentError, "Initialize must receive a hash with :shop_id and either :shop_pass! (received #{options.inspect})"
+        @shop_id   = options[:shop_id]
+        @shop_pass = options[:shop_pass]
+        @host      = options[:host]
+        unless @shop_id && @shop_pass && @host
+          raise ArgumentError, "Initialize must receive a hash with :shop_id, :shop_pass and either :host! (received #{options.inspect})"
         end
       end
-      attr_reader :shop_id, :shop_pass, :development
+      attr_reader :shop_id, :shop_pass, :host
 
       ## 2.1.2.1.取引登録
       # これ以降の決済取引で必要となる取引 ID と取引パスワードの発行を行い、取引を開始します。

data/lib/gmo/site_api.rb

@@ -6,7 +6,7 @@
 # gmo = GMO::Payment::SiteAPI.new({
 #   site_id:     "foo",
 #   site_pass:   "bar",
-#   development:  true
+#   host:  "mul-pay.com"
 # })
 # result = gmo.post_request("EntryTran.idPass", options)
 module GMO
@@ -15,14 +15,14 @@ module GMO
     module SiteAPIMethods
 
       def initialize(options = {})
-        @site_id     = options[:site_id]
-        @site_pass   = options[:site_pass]
-        @development = options[:development] || true
-        unless @site_id && @site_pass
-          raise ArgumentError, "Initialize must receive a hash with :site_id and either :site_pass! (received #{options.inspect})"
+        @site_id   = options[:site_id]
+        @site_pass = options[:site_pass]
+        @host      = options[:host]
+        unless @site_id && @site_pass && @host
+          raise ArgumentError, "Initialize must receive a hash with :site_id, :site_pass and either :host! (received #{options.inspect})"
         end
       end
-      attr_reader :site_id, :site_pass, :development
+      attr_reader :site_id, :site_pass, :host
 
       ## 2.3.2.1.会員登録
       # 指定されたサイトに会員を登録します。

data/lib/gmo/version.rb

@@ -1,3 +1,3 @@
 module GMO
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/spec/gmo/http_service_spec.rb

@@ -8,14 +8,9 @@ describe "GMO::HTTPService" do
 
   describe "common methods" do
     describe "server" do
-      it "should return the dev server if options[:development]" do
-        FakeHTTPService.server(:development => true).should == GMO::Payment::DEV_SERVER
+      it "should return the host" do
+        FakeHTTPService.server(:host => SPEC_CONF["host"]).should == SPEC_CONF["host"]
       end
-
-      it "should return the pro server if !options[:development]" do
-        FakeHTTPService.server(:development => false).should == GMO::Payment::PRO_SERVER
-      end
-
     end
 
   end

data/spec/gmo/shop_and_site_api_spec.rb

@@ -7,7 +7,8 @@ describe "GMO::Payment::ShopAndSiteAPI" do
       :shop_id   => SPEC_CONF["shop_id"],
       :shop_pass => SPEC_CONF["shop_pass"],
       :site_id   => SPEC_CONF["site_id"],
-      :site_pass => SPEC_CONF["site_pass"]
+      :site_pass => SPEC_CONF["site_pass"],
+      :host      => SPEC_CONF["host"]
     })
   end
 
@@ -33,6 +34,10 @@ describe "GMO::Payment::ShopAndSiteAPI" do
     @service.site_pass.should == SPEC_CONF["site_pass"]
   end
 
+  it "has an attr_reader for host" do
+    @service.host.should == SPEC_CONF["host"]
+  end
+
   describe "#trade_card" do
 
     it "got error if missing options", :vcr do

data/spec/gmo/shop_api_spec.rb

@@ -2,10 +2,15 @@ require "spec_helper"
 
 describe "GMO::Payment::ShopAPI" do
 
+  before(:all) do
+    @order_id = generate_id
+  end
+
   before(:each) do
     @service ||= GMO::Payment::ShopAPI.new({
       :shop_id   => SPEC_CONF["shop_id"],
-      :shop_pass => SPEC_CONF["shop_pass"]
+      :shop_pass => SPEC_CONF["shop_pass"],
+      :host      => SPEC_CONF["host"]
     })
   end
 
@@ -23,10 +28,15 @@ describe "GMO::Payment::ShopAPI" do
     @service.shop_pass.should == SPEC_CONF["shop_pass"]
   end
 
+  it "has an attr_reader for host" do
+    @service.host.should == SPEC_CONF["host"]
+  end
+
   describe "#entry_tran" do
     it "gets data about a transaction", :vcr do
+      order_id = @order_id
       result = @service.entry_tran({
-        :order_id => 100,
+        :order_id => order_id,
         :job_cd => "AUTH",
         :amount => 100
       })
@@ -43,11 +53,19 @@ describe "GMO::Payment::ShopAPI" do
 
   describe "#exec_tran" do
     it "gets data about a transaction", :vcr do
+      order_id = generate_id
       client_field1 = "client_field1"
+      result = @service.entry_tran({
+        :order_id => order_id,
+        :job_cd => "AUTH",
+        :amount => 100
+      })
+      access_id = result["AccessID"]
+      access_pass = result["AccessPass"]
       result = @service.exec_tran({
-        :order_id      => 100,
-        :access_id     => ACCESS_ID,
-        :access_pass   => ACCESS_PASS,
+        :order_id      => order_id,
+        :access_id     => access_id,
+        :access_pass   => access_pass,
         :method        => 1,
         :pay_times     => 1,
         :card_no       => "4111111111111111",
@@ -77,7 +95,7 @@ describe "GMO::Payment::ShopAPI" do
 
   describe "#alter_tran" do
     it "gets data about order", :vcr do
-      order_id = 1001
+      order_id = generate_id
       result = @service.entry_tran({
         :order_id => order_id,
         :job_cd => "AUTH",
@@ -110,7 +128,7 @@ describe "GMO::Payment::ShopAPI" do
     end
 
     it "change order auth to sale", :vcr do
-      order_id = 1002
+      order_id = generate_id
       result = @service.entry_tran({
         :order_id => order_id,
         :job_cd => "AUTH",
@@ -151,7 +169,7 @@ describe "GMO::Payment::ShopAPI" do
 
   describe "#change_tran" do
     it "gets data about order", :vcr do
-      order_id = 1003
+      order_id = generate_id
       result = @service.entry_tran({
         :order_id => order_id,
         :job_cd => "AUTH",
@@ -192,7 +210,7 @@ describe "GMO::Payment::ShopAPI" do
 
   describe "#search_trade" do
     it "gets data about order", :vcr do
-      order_id = 1003
+      order_id = @order_id
       result = @service.search_trade({
         :order_id => order_id
       })
@@ -227,7 +245,7 @@ describe "GMO::Payment::ShopAPI" do
     it "gets data about order", :vcr do
       client_field1 = "client_field1"
       result = @service.search_trade_multi({
-        :order_id      => 100,
+        :order_id      => @order_id,
         :pay_type      => "0"
       })
       result["Status"].nil?.should_not be_true

data/spec/gmo/site_api_spec.rb

@@ -2,10 +2,15 @@ require "spec_helper"
 
 describe "GMO::Payment::SiteAPI" do
 
+  before(:all) do
+    @member_id = generate_id
+  end
+
   before(:each) do
     @service ||= GMO::Payment::SiteAPI.new({
       :site_id   => SPEC_CONF["site_id"],
-      :site_pass => SPEC_CONF["site_pass"]
+      :site_pass => SPEC_CONF["site_pass"],
+      :host      => SPEC_CONF["host"]
     })
   end
 
@@ -23,11 +28,15 @@ describe "GMO::Payment::SiteAPI" do
     @service.site_pass.should == SPEC_CONF["site_pass"]
   end
 
+  it "has an attr_reader for host" do
+    @service.host.should == SPEC_CONF["host"]
+  end
+
   describe "#save_member" do
     it "gets data about a transaction", :vcr do
       member_name = "John Smith"
       result = @service.save_member({
-        :member_id => 100,
+        :member_id => @member_id,
         :member_name => member_name
       })
       result["MemberID"].nil?.should_not be_true
@@ -36,34 +45,37 @@ describe "GMO::Payment::SiteAPI" do
 
   describe "#update_member" do
     it "gets data about a transaction", :vcr do
-      member_id = 100
+      member_id = @member_id
       member_name = "John Smith2"
       result = @service.update_member({
         :member_id => member_id,
         :member_name => member_name
       })
       result["MemberID"].nil?.should_not be_true
-      (result["MemberID"].to_i == member_id).should be_true
     end
   end
 
   describe "#delete_member" do
     it "gets data about a member", :vcr do
-      member_id = 100
+      member_id = generate_id
+      member_name = "John Smith"
+      result = @service.save_member({
+        :member_id => member_id,
+        :member_name => member_name
+      })
       result = @service.delete_member({
         :member_id => member_id
       })
       result["MemberID"].nil?.should_not be_true
-      (result["MemberID"].to_i == member_id).should be_true
     end
   end
 
   describe "#search_member" do
     it "gets data about a member", :vcr do
       member_name = "John Smith"
-      member_id = 101
+      member_id = generate_id
       result = @service.save_member({
-        :member_id => 101,
+        :member_id => member_id,
         :member_name => member_name
       })
       result["MemberID"].nil?.should_not be_true
@@ -72,7 +84,6 @@ describe "GMO::Payment::SiteAPI" do
         :member_id => member_id
       })
       result["MemberID"].nil?.should_not be_true
-      (result["MemberID"].to_i == member_id).should be_true
       result["MemberName"].nil?.should_not be_true
       (result["MemberName"].to_s == member_name).should be_true
       result["DeleteFlag"].nil?.should_not be_true
@@ -82,7 +93,7 @@ describe "GMO::Payment::SiteAPI" do
 
   describe "#save_card" do
     it "gets data about a card", :vcr do
-      member_id = 101
+      member_id = @member_id
       card_no = "4111111111111111"
       expire = "1405"
       result = @service.save_card({
@@ -96,7 +107,7 @@ describe "GMO::Payment::SiteAPI" do
 
   describe "#delete_card" do
     it "gets data about a card", :vcr do
-      member_id = 101
+      member_id = @member_id
       card_seq = 0
       result = @service.delete_card({
         :member_id => member_id,
@@ -109,8 +120,8 @@ describe "GMO::Payment::SiteAPI" do
 
   describe "#search_card" do
     it "gets data about a card", :vcr do
-      member_id = 101
-      card_no = "4111111111111111"
+      member_id = generate_id
+      card_no = "4111111111111112"
       expire = "1405"
       result = @service.save_card({
         :member_id => member_id,

data/spec/support/config.example.yml

@@ -1,4 +1,5 @@
 shop_id: tshophoge
 shop_pass: hoge
 site_id: tsitehoge
-site_pass: hoge
+site_pass: hoge
+host: pt01.mul-pay.jp

data/spec/support/config.yml

@@ -1,4 +1,5 @@
 shop_id: tshop0001
 shop_pass: 1
 site_id: tsite0001
-site_pass: 1
+site_pass: 1
+host: pt01.mul-pay.jp

data/spec/support/factory.rb

@@ -4,5 +4,9 @@ def generate_token
   Digest::MD5.new.update(rand(10).to_s).to_s
 end
 
+def generate_id
+  Time.now.to_i
+end
+
 ACCESS_ID = generate_token
 ACCESS_PASS = generate_token

data/spec/support/vcr.rb

@@ -8,6 +8,7 @@ VCR.configure do |c|
   c.filter_sensitive_data('<SITE_ID>') { SPEC_CONF["site_id"] }
   c.filter_sensitive_data('<SITE_PASS>') { SPEC_CONF["site_pass"] }
   c.filter_sensitive_data('<SITE_PASS>') { SPEC_CONF["site_pass"] }
+  c.filter_sensitive_data('<HOST>') { SPEC_CONF["host"] }
   c.filter_sensitive_data('<ACCESS_ID>') { ACCESS_ID }
   c.filter_sensitive_data('<ACCESS_PASS>') { ACCESS_PASS }
 end