gmaps_tz 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4c398c099a44c91d5f33955f3a21b0030f1a7fca
-  data.tar.gz: 82895c6d72cd11bce737f9b966145c056a1eb9ea
+  metadata.gz: bad89fe2a86197be5e794a2e2ce3385255beeffa
+  data.tar.gz: 975f16e7effb3b3459c530e3dec858e59661546a
 SHA512:
-  metadata.gz: c5ba752eee35398941adfaa8f15ad240ba860116b232c5148d583c4ce420d0c128a72e00bc61d63e0e185e38b003e7bf430dfc9ca7154243000ca8aaffd46d05
-  data.tar.gz: cdb5977af5c59a5f87c39808d0d441db79f2f916d470b756105aba5f68c0832e50f422788ccad52ea2346a9852c738dbcbd6b91e0630bafe50dce3f27efed6a4
+  metadata.gz: c14993d5e5b240e465180640f4e8aa99f26e5b837073ed358d99dd5f6bffa1d3bece6fbd9d7517b25fc18bcd3665700350d90b430450dc607f7eda32638466cc
+  data.tar.gz: 110e3579ce6a4a0d52ed36feee400e37cc812c4c38a02fe1c3d2ad4fef020d82b74e46ee301e44a14f249d1e8ea1e7676fd9833b1ce02acec4957336b5678aba

data/.gitignore

@@ -0,0 +1 @@
+coverage/

data/lib/gmaps_tz/client.rb

@@ -19,13 +19,8 @@ module GmapsTz
 
     def get(path, query_params)
       uri = generate_uri(path, query_params)
-
       response = Net::HTTP.get_response(uri)
-      if JSON.parse(response.body)["status"] == "OK"
-       response
-      else
-        raise Error.from_response(uri, response)
-      end
+      ResponseParser.new(uri, response).execute
     end
 
     private

data/lib/gmaps_tz/error.rb

@@ -1,8 +1,6 @@
 module GmapsTz
   class Error < StandardError
-    def self.from_response(uri, response)
-      json = JSON.parse(response.body)
-
+    def self.from_json(uri, json)
       klass = case json["status"]
               when "INVALID_REQUEST"
                 InvalidRequestError
@@ -17,14 +15,14 @@ module GmapsTz
               else
                 UnexpectedResponseError
               end
-      klass.new(uri, response)
+      klass.new(uri, json)
     end
 
-    attr_accessor :uri, :result
+    attr_accessor :uri, :body
 
-    def initialize(uri, result)
+    def initialize(uri, body)
       @uri = uri
-      @result = result
+      @body = body
     end
   end
 
@@ -38,5 +36,7 @@ module GmapsTz
 
   class ZeroResultsError < Error; end
 
+  class InvalidResponseBodyError < Error; end
+
   class UnexpectedResponseError < Error; end
 end

data/lib/gmaps_tz/response_parser.rb

@@ -0,0 +1,29 @@
+module GmapsTz
+  class ResponseParser
+    def initialize(uri, response)
+      @uri
+      @response = response
+    end
+
+    def execute
+      json = parse_json
+
+      if json["status"] == "OK"
+        json
+      else
+        raise Error.from_json(@uri, json)
+      end
+    end
+
+    private
+
+    def parse_json
+      begin
+        JSON.parse(@response.body)
+      rescue JSON::ParserError
+        raise InvalidResponseBodyError.new(@uri, @response)
+      end
+    end
+
+  end
+end

data/lib/gmaps_tz/version.rb

@@ -1,3 +1,3 @@
 module GmapsTz
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/gmaps_tz.rb

@@ -1,5 +1,6 @@
 require "gmaps_tz/version"
 require "gmaps_tz/error"
+require "gmaps_tz/response_parser"
 require "gmaps_tz/client/time_zone"
 require "gmaps_tz/client"
 

data/spec/client_spec.rb

@@ -46,7 +46,14 @@ describe "Client" do
     it "returns a hash with the result when success" do
       Net::HTTP.stub(:get_response).and_return(mocked_response_ok)
       response = client.time_zone_in("1.0", "2.0", time)
-      response.should == mocked_response_ok
+      response.should == JSON.parse(mocked_response_ok.body)
+    end
+
+    it "raises the corresponding exception when it errors parsing response" do
+      Net::HTTP.stub(:get_response).and_return(FakeResponse.new(""))
+      expect {
+        client.time_zone_in("1.0", "2.0", time)
+      }.to raise_error(GmapsTz::InvalidResponseBodyError)
     end
 
     it "raises the corresponding exception when it fails" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gmaps_tz
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Pol Miro
@@ -87,24 +87,23 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .gitignore
 - .rspec
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
-- coverage/.last_run.json
-- coverage/.resultset.json
 - gmaps_tz.gemspec
 - lib/gmaps_tz.rb
 - lib/gmaps_tz/client.rb
 - lib/gmaps_tz/client/time_zone.rb
 - lib/gmaps_tz/error.rb
+- lib/gmaps_tz/response_parser.rb
 - lib/gmaps_tz/version.rb
 - spec/client_spec.rb
 - spec/error_spec.rb
 - spec/spec_helper.rb
-- version.rb
 homepage: http://github.com/polmiro/gmaps_tz
 licenses:
 - MIT

data/coverage/.last_run.json

@@ -1,5 +0,0 @@
-{
-  "result": {
-    "covered_percent": 94.19
-  }
-}

data/coverage/.resultset.json

@@ -1,190 +0,0 @@
-{
-  "RSpec": {
-    "coverage": {
-      "/Users/polmiro/Development/gmaps_tz/lib/gmaps_tz.rb": [
-        1,
-        1,
-        1,
-        1,
-        null,
-        1,
-        null,
-        null
-      ],
-      "/Users/polmiro/Development/gmaps_tz/lib/gmaps_tz/error.rb": [
-        1,
-        1,
-        1,
-        1,
-        null,
-        1,
-        null,
-        0,
-        null,
-        1,
-        null,
-        0,
-        null,
-        0,
-        null,
-        0,
-        null,
-        0,
-        null,
-        1,
-        null,
-        null,
-        1,
-        null,
-        1,
-        1,
-        1,
-        null,
-        null,
-        null,
-        1,
-        null,
-        1,
-        null,
-        1,
-        null,
-        1,
-        null,
-        1,
-        null,
-        1,
-        null
-      ],
-      "/Users/polmiro/Development/gmaps_tz/lib/gmaps_tz/client/time_zone.rb": [
-        1,
-        1,
-        1,
-        null,
-        1,
-        4,
-        null,
-        null,
-        null,
-        null,
-        null
-      ],
-      "/Users/polmiro/Development/gmaps_tz/lib/gmaps_tz/client.rb": [
-        1,
-        1,
-        null,
-        1,
-        1,
-        1,
-        null,
-        1,
-        1,
-        1,
-        null,
-        1,
-        null,
-        1,
-        4,
-        4,
-        4,
-        null,
-        null,
-        1,
-        4,
-        null,
-        4,
-        4,
-        3,
-        null,
-        1,
-        null,
-        null,
-        null,
-        1,
-        null,
-        1,
-        4,
-        null,
-        null,
-        null,
-        null,
-        null,
-        null,
-        1,
-        null,
-        15,
-        null,
-        4,
-        null,
-        null,
-        null,
-        null
-      ],
-      "/Users/polmiro/Development/gmaps_tz/spec/client_spec.rb": [
-        1,
-        4,
-        null,
-        1,
-        1,
-        null,
-        1,
-        4,
-        null,
-        null,
-        null,
-        1,
-        1,
-        3,
-        null,
-        null,
-        null,
-        null,
-        null,
-        null,
-        3,
-        null,
-        null,
-        1,
-        1,
-        1,
-        null,
-        null,
-        5,
-        null,
-        1,
-        null,
-        null,
-        1,
-        1,
-        null,
-        null,
-        1,
-        1,
-        null,
-        null,
-        1,
-        1,
-        null,
-        null,
-        1,
-        1,
-        1,
-        1,
-        null,
-        null,
-        1,
-        1,
-        1,
-        1,
-        null,
-        null,
-        null,
-        null,
-        null
-      ],
-      "/Users/polmiro/Development/gmaps_tz/spec/error_spec.rb": [
-
-      ]
-    },
-    "timestamp": 1393978034
-  }
-}

data/version.rb

@@ -1,3 +0,0 @@
-module GmapsTz
-  VERSION = "0.0.1"
-end