gmaps_geocoding 0.1.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a0762f7a1fae54e8aac3aba8e523b2ea8ab61f68
-  data.tar.gz: 210e1a48f1305392ed7b9ebb040c33cbf0cbc544
+  metadata.gz: 5f019fb274f185c52576b9ca9ec1be88841e5284
+  data.tar.gz: 9a39437c2ccd8803efef2a4e43a45339866c0be1
 SHA512:
-  metadata.gz: 1e6c4304dd3568cf5580aead51449950a21ae17043b04ba5c1449be48f4eb31909cdf4a47e972287034c59051f64f56b51bddefc1b3de4b2d8ef738573aeae4f
-  data.tar.gz: ef406b7b18d64cd055edd8baab7bb44e53613d386b9a7368c87c00c4c6ccadf1d64948a67a84387a8151552b7b5465a2e0cb31bd008637095a5851299cf1d17a
+  metadata.gz: 6eae47d13d97a317fbc51dca0844e9069a210ac67f4e9328118e12330e96f54758804c9839711ba2826ad40b7af26ca7005e2490aaa4ae302b0b3f11ca313a8e
+  data.tar.gz: 478e7fd679a880eda910d489596b88d72cd93812dc2fcc3214e2169bdc477ea259c315ccc1925b035b4ff6fc99c2eae17a4c281fca50782928ab6ef52fec56cd

data/.rubocop.yml

@@ -0,0 +1,11 @@
+# Reference here: https://github.com/bbatsov/rubocop/blob/master/config/enabled.yml
+
+Metrics/LineLength:
+  Description: 'Limit lines to 310 characters.'
+  Enabled: true
+  Max: 310
+
+Metrics/MethodLength:
+  Description: 'Try to avoid methods longer than 50 lines of code.'
+  Enabled: true
+  Max: 50

data/.travis.yml

@@ -1,5 +1,4 @@
 rvm:
-  - 1.9.3
   - 2.0.0
-  - 2.1.0
-  - 2.1.1
+  - 2.1.5
+  - 2.2.1

data/.versions.conf

@@ -1,4 +1,4 @@
-ruby=ruby-2.1.1
+ruby=ruby-2.2.1
 ruby-gemset=gmaps_geocoding
 #ruby-gem-install=bundler rake
 #ruby-bundle-install=true

data/Gemfile

@@ -1,6 +1,10 @@
 source 'https://rubygems.org'
 
+group :test do
+  gem 'simplecov', require: false
+  gem 'test-unit'
+  gem 'rubocop'
+end
+
 # Specify your gem's dependencies in gmaps_geocoding.gemspec
 gemspec
-
-gem 'simplecov', :require => false, :group => :test

data/README.md

@@ -37,15 +37,15 @@ All options could be overriden with corresponding environment variable:
 
     opts = {address: 'Tour Eiffel, Paris, IDF, France'}
     api = GmapsGeocoding::Api.new(opts)
-    data = api.get_location
-    loc = api.get_finest_latlng(data['results']) if data.include?('status') && data['status'].eql?('OK')
+    data = api.location
+    loc = api.finest_latlng(data['results']) if data.include?('status') && data['status'].eql?('OK')
 
 _Return a location array_
 
 * `loc[0] is the longitude float value`
 * `loc[1] is the latitude float value`
 
-`get_finest_latlng` retrieve the best address in this order:
+`finest_latlng` retrieve the best address in this order:
 
 * _ROOFTOP_
 * _RANGE_INTERPOLATED_
@@ -57,7 +57,16 @@ _Return a location array_
     # json output example
     opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'json'}
     api = GmapsGeocoding::Api.new(opts)
-    result = api.get_location
+    result = api.location
+
+### XML example
+
+    # xml output example
+    opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'xml'}
+    api = GmapsGeocoding::Api.new(opts)
+    result = api.location
+
+# JSON and XML output
 
 **Ruby Hash object from json output**
 
@@ -146,13 +155,6 @@ _Return a location array_
             "types"=>[]}],
          "status"=>"OK"}
 
-### XML example
-
-    # xml output example
-    opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'xml'}
-    api = GmapsGeocoding::Api.new(opts)
-    result = api.get_location
-
 **Ruby Hash object from xml output**
 
         {"status"=>"OK",

data/Rakefile

@@ -1,11 +1,9 @@
-# encoding: utf-8
 require 'bundler/gem_tasks'
 require 'rake/testtask'
+require 'rubocop/rake_task'
 require 'yard'
 
-lib = File.expand_path('../lib/', __FILE__)
-$:.unshift lib unless $:.include?(lib)
-require('gmaps_geocoding/version')
+require_relative 'lib/gmaps_geocoding/version'
 
 task gem: :build
 task :build do
@@ -20,7 +18,7 @@ task release: :build do
   system "git tag -a v#{GmapsGeocoding::VERSION} -m 'Tagging #{GmapsGeocoding::VERSION}'"
   system 'git push --tags'
   system "gem push gmaps_geocoding-#{GmapsGeocoding::VERSION}.gem"
-  # system "rm gmaps_geocoding-#{GmapsGeocoding::VERSION}.gem"
+  system "rm gmaps_geocoding-#{GmapsGeocoding::VERSION}.gem"
 end
 
 Rake::TestTask.new do |t|
@@ -28,11 +26,15 @@ Rake::TestTask.new do |t|
   t.test_files = FileList['test/**/*_test.rb']
   t.verbose = true
 end
+task default: [:test, :rubocop]
+
+RuboCop::RakeTask.new do |task|
+  task.formatters = ['simple']
+  task.fail_on_error = false
+end
 
 desc 'Generate documentation'
 YARD::Rake::YardocTask.new do |t|
-  t.files = ['lib/**/*.rb', '-', 'LICENSE.txt']
-  t.options = ['--main', 'README.md', '--no-private']
+  t.files = %w(lib/**/*.rb - LICENSE.txt)
+  t.options = %w(--main README.md --no-private)
 end
-
-task default: :test

data/gmaps_geocoding.gemspec

@@ -1,31 +1,30 @@
-# encoding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'gmaps_geocoding/version'
+require 'English'
+
+require_relative 'lib/gmaps_geocoding/version'
 
 Gem::Specification.new do |s|
   s.name = 'gmaps_geocoding'
   s.version = GmapsGeocoding::VERSION
   s.authors = ['Christian Kakesa']
   s.email = ['christian.kakesa@gmail.com']
-  s.description = %q{
+  s.description = <<-END
     A simple Ruby gem for Google Maps Geocoding API.
     This gem return a Ruby Hash object of the result.
-  }
-  s.summary = %q{Use Google Geocoding API from Ruby.}
+  END
+  s.summary = 'Use Google Geocoding API from Ruby.'
   s.homepage = 'https://github.com/fenicks/gmaps_geocoding'
   s.license = 'MIT'
 
-  s.files = `git ls-files`.split($/)
-  s.executables = s.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  s.test_files = s.files.grep(%r{^(test|spec|features)/})
+  s.files = `git ls-files`.split($RS)
+  s.executables = s.files.grep(%r{^bin\/}) { |f| File.basename(f) }
+  s.test_files = s.files.grep(%r{^(test|spec|features)\/})
   s.require_paths = ['lib']
 
-  s.add_runtime_dependency 'rest-client', '~> 1.6.7'
-  s.add_runtime_dependency 'yajl-ruby', '~> 1.2.0'
-  s.add_runtime_dependency 'nori', '~> 2.3.0'
-  s.add_runtime_dependency 'nokogiri', '~> 1.6.0'
-  s.add_development_dependency 'bundler', '>= 1.5.3'
+  s.add_runtime_dependency 'rest-client', '~> 1.8.0'
+  s.add_runtime_dependency 'yajl-ruby', '~> 1.2.1'
+  s.add_runtime_dependency 'nori', '~> 2.5.0'
+  s.add_runtime_dependency 'nokogiri', '~> 1.6.6'
+  s.add_development_dependency 'bundler', '>= 1.8.4'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'yard'
 end

data/lib/gmaps_geocoding.rb

@@ -1,5 +1,3 @@
-# encoding: utf-8
-
 require 'gmaps_geocoding/api'
 require 'gmaps_geocoding/config'
 require 'gmaps_geocoding/version'

data/lib/gmaps_geocoding/api.rb

@@ -1,6 +1,9 @@
-# encoding: utf-8
 require 'logger'
+require 'rest-client'
+require 'yajl/json_gem'
+require 'nori'
 
+# Gmaps geocoding module
 module GmapsGeocoding
   # Google Maps Geocoding Service abstraction class
   #
@@ -12,9 +15,12 @@ module GmapsGeocoding
     attr_reader :config
 
     def initialize(opts = {})
-      @logger = opts.delete(:logger)||Logger.new(STDERR) do |l|
-        l.progname = 'gmaps_geocoding'
-        l.level = $DEBUG ? Logger::DEBUG : Logger::INFO
+      @logger = opts.delete(:logger)
+      unless @logger
+        @logger = Logger.new(STDERR) do |l|
+          l.progname = 'gmaps_geocoding'.freeze
+          l.level = $DEBUG ? Logger::DEBUG : Logger::INFO
+        end
       end
       @config = GmapsGeocoding::Config.new(opts)
     end
@@ -27,26 +33,31 @@ module GmapsGeocoding
     #  # json output example
     #  opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'json'}
     #  api = GmapsGeocoding::Api.new(opts)
-    #  result = api.get_location
+    #  result = api.location
     #  # xml output example
     #  opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'xml'}
     #  api = GmapsGeocoding::Api.new(opts)
-    #  result = api.get_location
+    #  result = api.location
     #
-    def get_location
+    def location
       begin
         if @config.valid?
           rest_client = retrieve_geocoding_data
-          result = case @config.is_json_format?
+          result = case @config.json_format?
                    when true
-                     GmapsGeocoding.from_json(rest_client.to_s)
+                     Yajl::Parser.parse(rest_client)
                    else
-                     GmapsGeocoding.from_xml(rest_client.to_s)
+                     r = Nori.new.parse(rest_client)
+                     if r.include?('GeocodeResponse')
+                       r['GeocodeResponse']
+                     else
+                       { status: 'UNKNOWN_ERROR' }
+                     end
                    end
           return result
         end
       rescue => e
-        @logger.error e.to_s
+        @logger.error e
       end
       nil
     end
@@ -63,71 +74,51 @@ module GmapsGeocoding
     #  # json output example
     #  opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'json'}
     #  api = GmapsGeocoding::Api.new(opts)
-    #  data = api.get_location
+    #  data = api.location
     #  if data.include?('status') && data['status'].eql?('OK') # or more simple : if data.include?('results')
-    #    return get_finest_latlng(data['results']) # output : [2.291018, 48.857269]
+    #    return finest_latlng(data['results']) # output : [2.291018, 48.857269]
     #  end
     #
-    # @param data_result [Array] The json#results or xml#result array from {#get_location} method
+    # @param data [Array] The json#results or xml#result array from {#location} method
     # @return [Array] array contains latitude and longitude of the location
-    def get_finest_latlng(data_result)
-      tmp_result = {}
-      data = data_result
-      if data.kind_of?(Array)
-        data.each do |d|
-          tmp_result["#{d['geometry']['location_type']}"] = { lng: d['geometry']['location']['lng'].to_f,
-                                                              lat: d['geometry']['location']['lat'].to_f }
-        end
-      else
-        tmp_result["#{data['geometry']['location_type']}"] = { lng: data['geometry']['location']['lng'].to_f,
-                                                               lat: data['geometry']['location']['lat'].to_f }
-      end
-      if tmp_result.include?('ROOFTOP')
-        [tmp_result['ROOFTOP'][:lng], tmp_result['ROOFTOP'][:lat]]
-      elsif tmp_result.include?('RANGE_INTERPOLATED')
-        [tmp_result['RANGE_INTERPOLATED'][:lng], tmp_result['RANGE_INTERPOLATED'][:lat]]
-      elsif tmp_result.include?('GEOMETRIC_CENTER')
-        [tmp_result['GEOMETRIC_CENTER'][:lng], tmp_result['GEOMETRIC_CENTER'][:lat]]
-      else
-        [tmp_result['APPROXIMATE'][:lng], tmp_result['APPROXIMATE'][:lat]]
-      end
+    # rubocop:disable Metrics/AbcSize
+    def finest_latlng(data)
+      result = retrieve_finest_location(data)
+      return [result['ROOFTOP'][:lng], result['ROOFTOP'][:lat]] if result.include?('ROOFTOP')
+      return [result['RANGE_INTERPOLATED'][:lng], result['RANGE_INTERPOLATED'][:lat]] if result.include?('RANGE_INTERPOLATED')
+      return [result['GEOMETRIC_CENTER'][:lng], result['GEOMETRIC_CENTER'][:lat]] if result.include?('GEOMETRIC_CENTER')
+      [result['APPROXIMATE'][:lng], result['APPROXIMATE'][:lat]]
+    rescue
+      [0.0, 0.0]
     end
+    # rubocop:enable Metrics/AbcSize
 
     private
+
+    def retrieve_finest_location(data)
+      result = {}
+      tmp_data = data
+      tmp_data = [tmp_data] unless tmp_data.is_a?(Array)
+      tmp_data.each do |d|
+        result["#{d['geometry']['location_type']}"] = { lng: d['geometry']['location']['lng'].to_f,
+                                                        lat: d['geometry']['location']['lat'].to_f }
+      end
+      result
+    end
+
     def build_url_query
       query = {}
-      query[:address] = @config.address if @config.address
-      query[:latlng] = @config.latlng if @config.latlng
-      query[:components] = @config.components if @config.components
-      query[:sensor] = @config.sensor if @config.sensor
-      query[:bounds] = @config.bounds if @config.bounds
-      query[:language] = @config.language if @config.language
-      query[:region] = @config.region if @config.region
+      [:address, :latlng, :components, :sensor, :bounds, :language, :region].each do |k|
+        val = @config.send(k)
+        query[k] = val if val
+      end
       url = "#{@config.url}/#{@config.output}"
-      { url: url, query: query }
+      { url: url, query: query }.freeze
     end
 
     def retrieve_geocoding_data
-      require 'rest-client'
       data = build_url_query
       RestClient.get data[:url], params: data[:query]
     end
   end
-
-  class << self
-    def from_json(json)
-      require 'yajl/json_gem'
-      Yajl::Parser.parse(json)
-    end
-
-    def from_xml(xml)
-      require 'nori'
-      result = Nori.new.parse(xml)
-      if result.include?('GeocodeResponse')
-        result['GeocodeResponse']
-      else
-        { status: 'UNKNOWN_ERROR' }
-      end
-    end
-  end
 end

data/lib/gmaps_geocoding/config.rb

@@ -1,19 +1,29 @@
-# encoding: utf-8
-
+# Gmaps geocoding module
 module GmapsGeocoding
   # Configuration class for GmapsGeocoding API.
   class Config
+    # Configuration valid keys
+    VALID_KEYS = [:url, :output, :address, :latlng, :components, :sensor, :bounds, :language, :region].freeze
+
+    # Default configuration values
+    DEFAULT_CONFIG = {
+      url: 'https://maps.googleapis.com/maps/api/geocode',
+      output: 'json',
+      sensor: 'false'
+    }.freeze
+
     def initialize(opts = {})
-      @options = { url: 'https://maps.googleapis.com/maps/api/geocode' }
-      @options[:output] = ENV['GOOGLE_MAPS_GEOCODING_OUTPUT'] || opts[:output] || 'json'
-      @options[:address] = ENV['GOOGLE_MAPS_GEOCODING_ADDRESS'] || opts[:address] || ''
-      @options[:latlng] = ENV['GOOGLE_MAPS_GEOCODING_LATLNG'] || opts[:latlng] || ''
-      @options[:components] = ENV['GOOGLE_MAPS_GEOCODING_COMPONENTS'] || opts[:components] || ''
-      @options[:sensor] = ENV['GOOGLE_MAPS_GEOCODING_SENSOR'] || opts[:sensor] || 'false'
-      @options[:bounds] = ENV['GOOGLE_MAPS_GEOCODING_BOUNDS'] || opts[:bounds] || ''
-      @options[:language] = ENV['GOOGLE_MAPS_GEOCODING_LANGUAGE'] || opts[:language] || ''
-      @options[:region] = ENV['GOOGLE_MAPS_GEOCODING_REGION'] || opts[:region] || ''
-      @options.merge!(opts).reject! { |_, v| v.to_s.length == 0 }
+      @options = {}
+      @options.merge!(DEFAULT_CONFIG)
+      opts.each do |k, _|
+        next unless VALID_KEYS.include?(k)
+        val = if k.eql?(:url)
+                opts.delete(k)
+              else
+                ENV["GOOGLE_MAPS_GEOCODING_#{k.to_s.upcase}"] || opts.delete(k)
+              end
+        @options[k] = val if val
+      end
     end
 
     # URL of the Google Maps Geocoding Service
@@ -89,37 +99,38 @@ module GmapsGeocoding
     #
     # @return [true, false] Return _true_ or _false_
     def valid?
-      is_query_valid? && is_output_param_valid?
+      query_valid? && output_param_valid?
     end
 
     # Check if the output format of the query is set to _json_
     #
     # @return [true, false] Return _true_ or _false_
-    def is_json_format?
+    def json_format?
       'json'.eql?(output)
     end
 
     # Check if the output format of the query is set to _xml_
     #
     # @return [true, false] Return _true_ or _false_
-    def is_xml_format?
+    def xml_format?
       'xml'.eql?(output)
     end
 
     private
+
     # Check if the query is valid
     #
     # According to the specifications: {https://developers.google.com/maps/documentation/geocoding/#GeocodingRequests}
-    def is_query_valid?
-      (@options[:address].to_s.length > 0 && @options[:latlng].to_s.length == 0) ||
-          (@options[:address].to_s.length == 0 && @options[:latlng].to_s.length > 0) ||
-          (@options[:components].to_s.length > 0)
+    def query_valid?
+      (@options.include?(:address) && !@options.include?(:latlng)) ||
+        (!@options.include?(:address) && @options.include?(:latlng)) ||
+        @options.include?(:components)
     end
 
     # Check if the output format is valid
     #
     # According to the specifications: {https://developers.google.com/maps/documentation/geocoding/#GeocodingResponses}
-    def is_output_param_valid?
+    def output_param_valid?
       %w(json xml).include?(output)
     end
   end

data/lib/gmaps_geocoding/version.rb

@@ -1,3 +1,5 @@
+# rubocop:disable Style/Documentation
 module GmapsGeocoding
-  VERSION = '0.1.4'
+  # GmapsGeocoding version
+  VERSION = '1.0.0'.freeze
 end

data/test/gmaps_geocoding_api_test.rb

@@ -0,0 +1,36 @@
+
+require_relative '../lib/gmaps_geocoding'
+require_relative 'test_helper'
+
+# Main test class
+class GmapsGeocodingApiTest < Test::Unit::TestCase
+  def test_api_json_set
+    opts = { address: 'Tour Eiffel, Paris, IDF, France', output: 'json' }
+    api = GmapsGeocoding::Api.new(opts)
+    assert_not_nil api
+
+    result_location = api.location
+    assert_not_nil result_location
+    assert_kind_of Hash, result_location
+    assert_include result_location, 'results'
+
+    result_latlng = api.finest_latlng(result_location['results'])
+    assert_not_nil result_latlng
+    assert_instance_of Array, result_latlng
+  end
+
+  def test_api_xml_set
+    opts = { address: 'Tour Eiffel, Paris, IDF, France', output: 'xml' }
+    api = GmapsGeocoding::Api.new(opts)
+    assert_not_nil api
+
+    result_location = api.location
+    assert_not_nil result_location
+    assert_kind_of Hash, result_location
+    assert_include result_location, 'result'
+
+    result_latlng = api.finest_latlng(result_location['result'])
+    assert_not_nil result_latlng
+    assert_instance_of Array, result_latlng
+  end
+end

data/test/gmaps_geocoding_config_test.rb

@@ -0,0 +1,57 @@
+require_relative '../lib/gmaps_geocoding'
+require_relative 'test_helper'
+
+# Main test class
+class GmapsGeocodingConfigTest < Test::Unit::TestCase
+  def test_config_default
+    config = GmapsGeocoding::Config.new
+    assert_not_nil config
+
+    assert_equal false, config.valid?
+    assert_equal true,  config.json_format?
+    assert_equal false, config.xml_format?
+  end
+
+  def test_config_default_address
+    config = GmapsGeocoding::Config.new
+    assert_not_nil config
+
+    assert_equal true, config.url.size > 0
+    assert_equal 'json', config.output
+    assert_nil config.address
+  end
+
+  def test_config_default_optional
+    config = GmapsGeocoding::Config.new
+    assert_not_nil config
+    assert_nil config.latlng
+    assert_nil config.components
+    assert_equal 'false', config.sensor
+    assert_nil config.bounds
+    assert_nil config.language
+    assert_nil config.region
+  end
+
+  def test_config_address_set
+    config = GmapsGeocoding::Config.new(address: 'Tour Eiffel, IDF, Paris, France')
+    assert_not_nil config
+    assert_equal true, config.valid?
+  end
+
+  def test_config_latlng_set
+    config = GmapsGeocoding::Config.new(latlng: '40.714224,-73.961452')
+    assert_not_nil config
+    assert_equal true, config.valid?
+  end
+
+  def test_config_address_latlng_set
+    config = GmapsGeocoding::Config.new(address: 'Tour Eiffel, IDF, Paris, France', latlng: '40.714224,-73.961452')
+    assert_not_nil config
+    assert_equal false, config.valid?
+  end
+
+  def test_config_url
+    config = GmapsGeocoding::Config.new(url: 'http://fakeurl.com')
+    assert_equal 'http://fakeurl.com', config.url
+  end
+end

data/test/test_helper.rb

@@ -1,9 +1,6 @@
+require 'test/unit'
 require 'simplecov'
 
 SimpleCov.start do
-  add_filter 'coverage'
-  add_filter 'doc'
-  add_filter 'pkg'
-  add_filter 'test'
+  add_filter '/test/'
 end
-SimpleCov.command_name 'Unit Tests'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gmaps_geocoding
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Christian Kakesa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-29 00:00:00.000000000 Z
+date: 2015-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -16,70 +16,70 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.7
+        version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.7
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: 1.2.1
 - !ruby/object:Gem::Dependency
   name: nori
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.3.0
+        version: 2.5.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.6.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.6.6
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.3
+        version: 1.8.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.3
+        version: 1.8.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -108,8 +108,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: "\n    A simple Ruby gem for Google Maps Geocoding API.\n    This gem
-  return a Ruby Hash object of the result.\n  "
+description: |2
+      A simple Ruby gem for Google Maps Geocoding API.
+      This gem return a Ruby Hash object of the result.
 email:
 - christian.kakesa@gmail.com
 executables: []
@@ -117,6 +118,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - ".versions.conf"
 - ".yardopts"
@@ -129,7 +131,8 @@ files:
 - lib/gmaps_geocoding/api.rb
 - lib/gmaps_geocoding/config.rb
 - lib/gmaps_geocoding/version.rb
-- test/gmaps_geocoding_test.rb
+- test/gmaps_geocoding_api_test.rb
+- test/gmaps_geocoding_config_test.rb
 - test/test_helper.rb
 homepage: https://github.com/fenicks/gmaps_geocoding
 licenses:
@@ -151,11 +154,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Use Google Geocoding API from Ruby.
 test_files:
-- test/gmaps_geocoding_test.rb
+- test/gmaps_geocoding_api_test.rb
+- test/gmaps_geocoding_config_test.rb
 - test/test_helper.rb
 has_rdoc: 

data/test/gmaps_geocoding_test.rb

@@ -1,66 +0,0 @@
-# encoding: utf-8
-require 'test/unit'
-require_relative 'test_helper'
-require 'gmaps_geocoding'
-
-# Main test class
-class GmapsGeocodingTest < Test::Unit::TestCase
-  def test_config_default
-    config = GmapsGeocoding::Config.new
-    assert_not_nil config
-    assert_equal false, config.valid?
-  end
-
-  def test_config_address_set
-    config = GmapsGeocoding::Config.new({ address: 'Tour Eiffel, IDF, Paris, France' })
-    assert_not_nil config
-    assert_equal true, config.valid?
-  end
-
-  def test_config_latlng_set
-    config = GmapsGeocoding::Config.new({ latlng: '40.714224,-73.961452' })
-    assert_not_nil config
-    assert_equal true, config.valid?
-  end
-
-  def test_config_address_latlng_set
-    config = GmapsGeocoding::Config.new({ address: 'Tour Eiffel, IDF, Paris, France', latlng: '40.714224,-73.961452' })
-    assert_not_nil config
-    assert_equal false, config.valid?
-  end
-
-  def test_config_url
-    config = GmapsGeocoding::Config.new({ url: 'http://fakeurl.com' })
-    assert_equal 'http://fakeurl.com', config.url
-  end
-
-  def test_api_json_set
-    opts = { address: 'Tour Eiffel, Paris, IDF, France', output: 'json' }
-    api = GmapsGeocoding::Api.new(opts)
-    assert_not_nil api
-
-    result_location = api.get_location
-    assert_not_nil result_location
-    assert_kind_of Hash, result_location
-    assert_include result_location, 'results'
-
-    result_latlng = api.get_finest_latlng(result_location['results'])
-    assert_not_nil result_latlng
-    assert_instance_of Array, result_latlng
-  end
-
-  def test_api_xml_set
-    opts = { address: 'Tour Eiffel, Paris, IDF, France', output: 'xml' }
-    api = GmapsGeocoding::Api.new(opts)
-    assert_not_nil api
-
-    result_location = api.get_location
-    assert_not_nil result_location
-    assert_kind_of Hash, result_location
-    assert_include result_location, 'result'
-
-    result_latlng = api.get_finest_latlng(result_location['result'])
-    assert_not_nil result_latlng
-    assert_instance_of Array, result_latlng
-  end
-end