gmaps_geocoding 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e4f401cb0948ca4d9487429c2797d7c99f26cf15
-  data.tar.gz: 4634b06d21d151f3090a3322f695f380954950d3
+  metadata.gz: fc76d950d8449fc15e4dbee37ec08aca9df79d8a
+  data.tar.gz: 1fc6d1a2d2d6d87f768e39d230b0706491e02c96
 SHA512:
-  metadata.gz: 576577ecb16e216c6fb744c510b1cc10c933ef3b1132ed396984e0b3d5ac825158e959f55305edab091d880162345f22dfb540cb2fdfff97056bfb403d9b1dcf
-  data.tar.gz: a0965ae57458ed9671336d737f626ebd53225e8465426b1ceec713a56e3809dc8d930c12c4b6b01b42260d9d378d491854d57c8a5b8f07bb28fa878ba8cee9a0
+  metadata.gz: a13cb26c3f40aace1d82aadd52e0ea2452be7f67033c5abd6ed347cd9b40b44e532c3a31c7f70154a04a74712a05e67130639c4574fba1b4cd897ced58cf0477
+  data.tar.gz: 1edb3ae0bae8162bf38b3197e9dacb3eba49c160006f40e79e61852ccda6a8cd1adfb2fe8398d0c1d19cf1cd1cd88af3e05428690ec8c1b2b8164d0225cb70e4

data/gmaps_geocoding.gemspec

@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'yajl-ruby', '~> 1.2.0'
   s.add_runtime_dependency 'nori', '~> 2.3.0'
   s.add_runtime_dependency 'nokogiri', '~> 1.6.0'
-  s.add_development_dependency 'bundler', '~> 1.5.3'
+  s.add_development_dependency 'bundler', '>= 1.5.3'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'yard'
 end

data/lib/gmaps_geocoding/api.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+require 'logger'
 
 module GmapsGeocoding
   # Google Maps Geocoding Service abstraction class
@@ -11,6 +12,10 @@ module GmapsGeocoding
     attr_reader :config
 
     def initialize(opts = {})
+      @logger = opts.delete(:logger)||Logger.new(STDERR) do |l|
+        l.progname = 'gmaps_geocoding'
+        l.level = $DEBUG ? Logger::DEBUG : Logger::INFO
+      end
       @config = GmapsGeocoding::Config.new(opts)
     end
 
@@ -33,15 +38,15 @@ module GmapsGeocoding
         if @config.valid?
           rest_client = retrieve_geocoding_data
           result = case @config.is_json_format?
-                     when true
-                       GmapsGeocoding.from_json(rest_client.to_s)
-                     else
-                       GmapsGeocoding.from_xml(rest_client.to_s)
+                   when true
+                     GmapsGeocoding.from_json(rest_client.to_s)
+                   else
+                     GmapsGeocoding.from_xml(rest_client.to_s)
                    end
           return result
         end
       rescue => e
-        puts "[error: gmaps_geocoding]: #{e}"
+        @logger.debug "[error: gmaps_geocoding]: #{e}"
       end
       nil
     end
@@ -70,12 +75,12 @@ module GmapsGeocoding
       data = data_result
       if data.kind_of?(Array)
         data.each do |d|
-          tmp_result["#{d['geometry']['location_type']}"] = {lng: d['geometry']['location']['lng'].to_f,
-                                                             lat: d['geometry']['location']['lat'].to_f}
+          tmp_result["#{d['geometry']['location_type']}"] = { lng: d['geometry']['location']['lng'].to_f,
+                                                              lat: d['geometry']['location']['lat'].to_f }
         end
       else
-        tmp_result["#{data['geometry']['location_type']}"] = {lng: data['geometry']['location']['lng'].to_f,
-                                                              lat: data['geometry']['location']['lat'].to_f}
+        tmp_result["#{data['geometry']['location_type']}"] = { lng: data['geometry']['location']['lng'].to_f,
+                                                               lat: data['geometry']['location']['lat'].to_f }
       end
       if tmp_result.include?('ROOFTOP')
         [tmp_result['ROOFTOP'][:lng], tmp_result['ROOFTOP'][:lat]]
@@ -99,7 +104,7 @@ module GmapsGeocoding
       query[:language] = @config.language if @config.language
       query[:region] = @config.region if @config.region
       url = "#{@config.url}/#{@config.output}"
-      {url: url, query: query}
+      { url: url, query: query }
     end
 
     def retrieve_geocoding_data
@@ -121,7 +126,7 @@ module GmapsGeocoding
       if result.include?('GeocodeResponse')
         result['GeocodeResponse']
       else
-        {status: 'UNKNOWN_ERROR'}
+        { status: 'UNKNOWN_ERROR' }
       end
     end
   end

data/lib/gmaps_geocoding/config.rb

@@ -4,7 +4,7 @@ module GmapsGeocoding
   # Configuration class for GmapsGeocoding API.
   class Config
     def initialize(opts = {})
-      @options = {url: 'https://maps.googleapis.com/maps/api/geocode'}
+      @options = { url: 'https://maps.googleapis.com/maps/api/geocode' }
       @options[:output] = ENV['GOOGLE_MAPS_GEOCODING_OUTPUT'] || opts[:output] || 'json'
       @options[:address] = ENV['GOOGLE_MAPS_GEOCODING_ADDRESS'] || opts[:address] || ''
       @options[:latlng] = ENV['GOOGLE_MAPS_GEOCODING_LATLNG'] || opts[:latlng] || ''

data/lib/gmaps_geocoding/version.rb

@@ -1,3 +1,3 @@
 module GmapsGeocoding
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

data/test/gmaps_geocoding_test.rb

@@ -3,6 +3,7 @@ require 'test/unit'
 require_relative 'test_helper'
 require 'gmaps_geocoding'
 
+# Main test class
 class GmapsGeocodingTest < Test::Unit::TestCase
   def test_config_default
     config = GmapsGeocoding::Config.new
@@ -11,30 +12,30 @@ class GmapsGeocodingTest < Test::Unit::TestCase
   end
 
   def test_config_address_set
-    config = GmapsGeocoding::Config.new({address: 'Tour Eiffel, IDF, Paris, France'})
+    config = GmapsGeocoding::Config.new({ address: 'Tour Eiffel, IDF, Paris, France' })
     assert_not_nil config
     assert_equal true, config.valid?
   end
 
   def test_config_latlng_set
-    config = GmapsGeocoding::Config.new({latlng: '40.714224,-73.961452'})
+    config = GmapsGeocoding::Config.new({ latlng: '40.714224,-73.961452' })
     assert_not_nil config
     assert_equal true, config.valid?
   end
 
   def test_config_address_latlng_set
-    config = GmapsGeocoding::Config.new({address: 'Tour Eiffel, IDF, Paris, France', latlng: '40.714224,-73.961452'})
+    config = GmapsGeocoding::Config.new({ address: 'Tour Eiffel, IDF, Paris, France', latlng: '40.714224,-73.961452' })
     assert_not_nil config
     assert_equal false, config.valid?
   end
 
   def test_config_url
-    config = GmapsGeocoding::Config.new({url: 'http://fakeurl.com'})
+    config = GmapsGeocoding::Config.new({ url: 'http://fakeurl.com' })
     assert_equal 'http://fakeurl.com', config.url
   end
 
   def test_api_json_set
-    opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'json'}
+    opts = { address: 'Tour Eiffel, Paris, IDF, France', output: 'json' }
     api = GmapsGeocoding::Api.new(opts)
     assert_not_nil api
 
@@ -49,7 +50,7 @@ class GmapsGeocodingTest < Test::Unit::TestCase
   end
 
   def test_api_xml_set
-    opts = {address: 'Tour Eiffel, Paris, IDF, France', output: 'xml'}
+    opts = { address: 'Tour Eiffel, Paris, IDF, France', output: 'xml' }
     api = GmapsGeocoding::Api.new(opts)
     assert_not_nil api
 

data/test/test_helper.rb

@@ -1,6 +1,9 @@
 require 'simplecov'
 
 SimpleCov.start do
+  add_filter 'coverage'
+  add_filter 'doc'
+  add_filter 'pkg'
   add_filter 'test'
 end
 SimpleCov.command_name 'Unit Tests'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gmaps_geocoding
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Christian Kakesa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-10 00:00:00.000000000 Z
+date: 2014-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -70,14 +70,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.3
 - !ruby/object:Gem::Dependency