gmail_contacts 1.4.1 → 1.5

data/.autotest

@@ -0,0 +1,3 @@
+Autotest.add_hook :initialize do |at|
+  at.testlib = 'minitest/unit'
+end

data/History.txt

@@ -1,3 +1,8 @@
+=== 1.5 / 2009-08-20
+
+* 1 minor enhancement
+  * #fetch_photo now accepts a photo URL as well
+
 === 1.4.1 / 2009-05-20
 
 * 1 bug fix

data/Manifest.txt

@@ -1,3 +1,4 @@
+.autotest
 .document
 History.txt
 Manifest.txt

data/Rakefile

@@ -2,17 +2,18 @@
 
 require 'rubygems'
 require 'hoe'
-require './lib/gmail_contacts.rb'
 
-Hoe.new('gmail_contacts', GmailContacts::VERSION) do |p|
-  p.rubyforge_name = 'seattlerb' # if different than lowercase project name
-  p.developer 'Eric Hodel', 'drbrain@segment7.net'
+Hoe.plugin :seattlerb
 
-  p.testlib = :minitest
+Hoe.spec 'gmail_contacts' do
+  developer 'Eric Hodel', 'drbrain@segment7.net'
 
-  p.extra_deps << ['gdata', '~> 1.1']
-  p.extra_deps << ['nokogiri', '~> 1.2']
-  p.extra_dev_deps << ['minitest', '~> 1.3']
+  self.rubyforge_name = 'seattlerb'
+  self.testlib = :minitest
+
+  extra_deps << ['gdata', '~> 1.1']
+  extra_deps << ['nokogiri', '~> 1.2']
+  extra_dev_deps << ['minitest', '~> 1.3']
 end
 
 # vim: syntax=Ruby

data/lib/gmail_contacts.rb

@@ -10,7 +10,7 @@ require 'nokogiri'
 
 class GmailContacts
 
-  VERSION = '1.4.1'
+  VERSION = '1.5'
 
   Contact = Struct.new :title, :emails, :ims, :phone_numbers, :addresses,
                        :photo_url
@@ -110,10 +110,15 @@ class GmailContacts
   end
 
   ##
-  # Fetches the photo data for +contact+
+  # Fetches the photo data for +contact+ which may be a photo URL
 
   def fetch_photo(contact)
-    res = @contact_api.get contact.photo_url
+    photo_url = if String === contact then
+                  contact
+                else
+                  contact.photo_url
+                end
+    res = @contact_api.get photo_url
 
     res.body
   end

data/test/test_gmail_contacts.rb

@@ -84,6 +84,14 @@ class TestGmailContacts < MiniTest::Unit::TestCase
     assert_equal 'THIS IS A PHOTO!', photo
   end
 
+  def test_fetch_photo_url
+    @api.stub_data << 'THIS IS A PHOTO!'
+
+    photo = @gc.fetch_photo @eric.photo_url
+
+    assert_equal 'THIS IS A PHOTO!', photo
+  end
+
   def test_parse
     @gc.parse Nokogiri::XML(GmailContacts::TestStub::CONTACTS)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: gmail_contacts
 version: !ruby/object:Gem::Version 
-  version: 1.4.1
+  version: "1.5"
 platform: ruby
 authors: 
 - Eric Hodel
@@ -30,7 +30,7 @@ cert_chain:
   x52qPcexcYZR7w==
   -----END CERTIFICATE-----
 
-date: 2009-05-20 00:00:00 -07:00
+date: 2009-08-20 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -71,7 +71,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.12.1
+        version: 2.3.3
     version: 
 description: |-
   Simple Gmail contacts extraction using GData.
@@ -88,6 +88,7 @@ extra_rdoc_files:
 - Manifest.txt
 - README.txt
 files: 
+- .autotest
 - .document
 - History.txt
 - Manifest.txt
@@ -122,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: seattlerb
-rubygems_version: 1.3.3
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Simple Gmail contacts extraction using GData