glogin 0.2 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a6930e668b924c169ed5c02ac91b366edfa64cb
-  data.tar.gz: ad7c1628b4e3508c39b5c6c14c36a4deb79d04fd
+  metadata.gz: 39525c79b9353af1f2baa96306fd38ee13d73796
+  data.tar.gz: 3ae939f552d4ab34bb6b26de01b23b9944ac773d
 SHA512:
-  metadata.gz: 2504f72c9222bcd65676148017cd18d4e0ff985f42fc2f3967544eced7e8928b67ec5e3abec0c2b481c20799d8274b82e3d6a9cd1b08de6bf130472a297e3617
-  data.tar.gz: 815f03f93317871b300a72432edb448a77a223a1912ca1ad4f0c9ad7451e18702673d4fde83b6da0f3c573ad76e7e96805f1126e42458d08f5123cf2e852f5ed
+  metadata.gz: ecbacab1006d2c2cab12dce480cc7a6e2948c0d3977b7ab8570c5deafc939f822885a17c584bcbb65341e1d45e5bb1f623c69a4f62ebabc78e39b1d4badb7506
+  data.tar.gz: b9a115d1c87718cece3763ededbe430ac7b6dcf5f52ec8b12242ae40cf0e6081a2a8fa474678e4685f615c08bbbd9b89b67404ebed1048c7c3093b061d8f75eb

data/README.md

@@ -23,11 +23,11 @@ First, somewhere in the global space, before the app starts:
 require 'glogin'
 configure do
   set :glogin, GLogin::Auth.new(
-    // Make sure their values are coming from a secure
-    // place and are not visible in the source code:
+    # Make sure their values are coming from a secure
+    # place and are not visible in the source code:
     client_id, client_secret,
-    // This is what you will register in GitHub as an
-    // authorization callback URL:
+    # This is what you will register in GitHub as an
+    # authorization callback URL:
     'http://www.example.com/github-callback'
   )
 end
@@ -43,8 +43,8 @@ before '/*' do
     begin
       @user = Cookie::Closed.new(
         cookies[:glogin],
-        // This must be some long text to be used to
-        // encrypt the value in the cookie.
+        # This must be some long text to be used to
+        # encrypt the value in the cookie.
         secret
       ).to_user
     rescue OpenSSL::Cipher::CipherError => _
@@ -67,7 +67,7 @@ Next, we need a URL for GitHub OAuth callback:
 get '/github-callback' do
   cookies[:glogin] = Cookie::Open.new(
     settings.glogin.user(params[:code]),
-    // The same encryption secret that we were using above:
+    # The same encryption secret that we were using above:
     secret
   ).to_s
   redirect to('/')

data/lib/glogin/cookie.rb

@@ -41,17 +41,19 @@ module GLogin
       end
 
       def to_user
-        if @secret.empty?
-          @text
-        else
-          cpr = Cookie.cipher
-          cpr.decrypt
-          cpr.key = Digest::SHA1.hexdigest(@secret)
-          decrypted = cpr.update(Base64.decode64(@text))
-          decrypted << cpr.final
-          parts = decrypted.to_s.split('|')
-          { login: parts[0], avatar: parts[1] }
-        end
+        plain =
+          if @secret.empty?
+            @text
+          else
+            cpr = Cookie.cipher
+            cpr.decrypt
+            cpr.key = Digest::SHA1.hexdigest(@secret)
+            decrypted = cpr.update(Base64.decode64(@text))
+            decrypted << cpr.final
+            decrypted.to_s
+          end
+        parts = plain.split('|')
+        { login: parts[0], avatar: parts[1] }
       end
     end
 

data/lib/glogin/version.rb

@@ -25,5 +25,5 @@
 # Copyright:: Copyright (c) 2017 Yegor Bugayenko
 # License:: MIT
 module GLogin
-  VERSION = '0.2'.freeze
+  VERSION = '0.2.1'.freeze
 end

data/test/glogin/test_cookie.rb

@@ -40,6 +40,14 @@ class TestCookie < Minitest::Test
     assert_equal(user[:avatar], 'https://avatars1.githubusercontent.com/u/526301')
   end
 
+  def test_decrypts_in_test_mode
+    user = GLogin::Cookie::Closed.new(
+      'test|http://example.com', ''
+    ).to_user
+    assert_equal(user[:login], 'test')
+    assert_equal(user[:avatar], 'http://example.com')
+  end
+
   def test_fails_on_broken_text
     assert_raises OpenSSL::Cipher::CipherError do
       GLogin::Cookie::Closed.new(

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: glogin
 version: !ruby/object:Gem::Version
-  version: '0.2'
+  version: 0.2.1
 platform: ruby
 authors:
 - Yegor Bugayenko