globus_client 0.16.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e2a9f5ea8b86fba80105171529f3c22b751e00703905d0ba3b20d08ea61111c
-  data.tar.gz: 1376671b1dbd3dd2adba6bf2e076097f8c96d13f9773a0a976270dfd4592cf4b
+  metadata.gz: e7af86d10638224774c4bef0d85c4cbbe4e80c67edf432e6194ba097c8cb1cbe
+  data.tar.gz: 7d2cb00fa8d76638fd8f6c0581766b5d9aaf5c3ed6a0322c69c12a64b1ebbf0d
 SHA512:
-  metadata.gz: bde893f245af7928af36da0676452bd503cfd3c9d847b1d66efb9be18591563ab1d09ef12b8341223968fa1c0534c31a90263689b392f739539a4fadbf1b091c
-  data.tar.gz: b37a773e0005668970a04895e47d4f188cc53d38991283c717eb5d9a52a756218b666538c5ce9da1ee6559b71facaace57ca9eae3d0fc2094e47b373d047ba2f
+  metadata.gz: 82be27face7403bf3e05f0c7356cd49fbae59afe06a37aabde60ba9a713237d144d116a57a3aff81c19cfeae046c418d8d828e6864053e8d56a72213213331f5
+  data.tar.gz: dc6fff3543f1d5b5a0d56ac83c49a1285fc0e28a1949a25234aa4aecfa65d65850444ac3418d69f0c4c9c772ddc4b86d3b225bff14e813d306bb20d10ca64ef6

data/.rubocop.yml

@@ -1,6 +1,6 @@
 inherit_from: .rubocop_todo.yml
 
-require:
+plugins:
   - rubocop-performance
   - rubocop-rspec
 
@@ -22,7 +22,7 @@ Layout/LineLength:
   Max: 150
 
 # Naming
-Naming/PredicateName:
+Naming/PredicatePrefix:
   ForbiddenPrefixes:
     - is_
     - have_

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    globus_client (0.16.0)
+    globus_client (0.18.0)
       activesupport (>= 4.2)
       faraday
       faraday-retry
@@ -26,9 +26,9 @@ GEM
     addressable (2.8.7)
       public_suffix (>= 2.0.2, < 7.0)
     ast (2.4.3)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.2)
     byebug (12.0.0)
     concurrent-ruby (1.3.5)
     connection_pool (2.5.3)
@@ -38,13 +38,13 @@ GEM
     diff-lcs (1.6.2)
     docile (1.4.1)
     drb (2.2.3)
-    faraday (2.13.1)
+    faraday (2.13.2)
       faraday-net_http (>= 2.0, < 3.5)
       json
       logger
-    faraday-net_http (3.4.0)
+    faraday-net_http (3.4.1)
       net-http (>= 0.5.0)
-    faraday-retry (2.3.1)
+    faraday-retry (2.3.2)
       faraday (~> 2.0)
     hashdiff (1.2.0)
     i18n (1.14.7)
@@ -64,23 +64,23 @@ GEM
     public_suffix (6.0.2)
     racc (1.8.1)
     rainbow (3.1.1)
-    rake (13.2.1)
+    rake (13.3.0)
     regexp_parser (2.10.0)
     rexml (3.4.1)
-    rspec (3.13.0)
+    rspec (3.13.1)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.3)
+    rspec-core (3.13.5)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.4)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-mocks (3.13.4)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.3)
-    rubocop (1.75.7)
+    rspec-support (3.13.4)
+    rubocop (1.78.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -88,10 +88,10 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.45.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.44.1)
+    rubocop-ast (1.45.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-performance (1.25.0)

data/lib/globus_client/endpoint.rb

@@ -53,7 +53,7 @@ class GlobusClient
 
     # Delete the access rule https://docs.globus.org/api/transfer/acl/#delete_access_rule
     def delete_access_rule
-      raise(StandardError, "Access rule not found for #{path}") unless access_rule_id
+      raise GlobusClient::AccessRuleNotFound, "Access rule not found for #{path}" unless access_rule_id
 
       GlobusClient.instance.delete(
         base_url: GlobusClient.config.transfer_url,
@@ -79,7 +79,7 @@ class GlobusClient
         params: { path: }
       )
       true
-    rescue GlobusClient::UnexpectedResponse::ResourceNotFound
+    rescue GlobusClient::ResourceNotFound
       false
     end
 
@@ -88,7 +88,7 @@ class GlobusClient
     attr_reader :path, :user_id, :notify_email
 
     def globus_identity_id
-      Identity.new.get_identity_id(user_id)
+      @globus_identity_id ||= Identity.new.get_identity_id(user_id)
     end
 
     # Builds up a path from a list of path elements. E.g., input would look like:
@@ -168,7 +168,7 @@ class GlobusClient
     end
 
     def update_access_request(permissions:)
-      raise(StandardError, "Access rule not found for #{path}") unless access_rule_id
+      raise GlobusClient::AccessRuleNotFound, "Access rule not found for #{path}" unless access_rule_id
 
       GlobusClient.instance.put(
         base_url: GlobusClient.config.transfer_url,
@@ -187,7 +187,7 @@ class GlobusClient
         content_type: 'application/json'
       )
 
-      response.fetch('DATA').find { |acl| acl['path'] == full_path }
+      response.fetch('DATA').find { |acl| acl['path'] == full_path && acl['principal'] == globus_identity_id }
     end
 
     def access_rule_id

data/lib/globus_client/errors.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+class GlobusClient
+  # Holds all of the client's custom exception classes
+  module Errors
+    # Error raised when the Globus Auth or Transfer API returns a 400 error
+    class BadRequestError < StandardError; end
+
+    # Error raised by the Globus Auth API returns a 401 Unauthorized
+    class UnauthorizedError < StandardError; end
+
+    # Error raised when the Globus Auth or Transfer API returns a 403 Forbidden
+    class ForbiddenError < StandardError; end
+
+    # Error raised when the Globus Auth or Transfer API returns a 404 NotFound
+    class ResourceNotFound < StandardError; end
+
+    # Error raised when a consumer acts upon an access rule that was not found
+    class AccessRuleNotFound < StandardError; end
+
+    # Error raised when response has an unexpected error (e.g., an HTTP 500)
+    class InternalServerError < StandardError; end
+
+    # Error raised when the Globus Transfer API returns a 502 Bad Gateway
+    class EndpointError < StandardError; end
+
+    # Error raised when the remote server returns a 503 Bad Gateway
+    class ServiceUnavailable < StandardError; end
+  end
+end

data/lib/globus_client/unexpected_response.rb

@@ -3,24 +3,6 @@
 class GlobusClient
   # Handles unexpected responses when communicating with Globus
   class UnexpectedResponse
-    # Error raised when the Globus Auth or Transfer API returns a 400 error
-    class BadRequestError < StandardError; end
-
-    # Error raised by the Globus Auth API returns a 401 Unauthorized
-    class UnauthorizedError < StandardError; end
-
-    # Error raised when the Globus Auth or Transfer API returns a 403 Forbidden
-    class ForbiddenError < StandardError; end
-
-    # Error raised when the Globus Auth or Transfer API returns a 404 NotFound
-    class ResourceNotFound < StandardError; end
-
-    # Error raised when the Globus Transfer API returns a 502 Bad Gateway
-    class EndpointError < StandardError; end
-
-    # Error raised when the remote server returns a 503 Bad Gateway
-    class ServiceUnavailable < StandardError; end
-
     # @param [Faraday::Response] response
     # https://docs.globus.org/api/transfer/file_operations/#common_errors
     # https://docs.globus.org/api/transfer/file_operations/#errors
@@ -29,19 +11,19 @@ class GlobusClient
     def self.call(response)
       case response.status
       when 400
-        raise BadRequestError, "Invalid path or another error with the request: #{response.body}"
+        raise GlobusClient::BadRequestError, "Invalid path or another error with the request: #{response.body}"
       when 401
-        raise UnauthorizedError, "There was a problem with the access token: #{response.body} "
+        raise GlobusClient::UnauthorizedError, "There was a problem with the access token: #{response.body} "
       when 403
-        raise ForbiddenError, "The operation requires privileges which the client does not have: #{response.body}"
+        raise GlobusClient::ForbiddenError, "The operation requires privileges which the client does not have: #{response.body}"
       when 404
-        raise ResourceNotFound, "Endpoint ID not found or resource does not exist: #{response.body}"
+        raise GlobusClient::ResourceNotFound, "Endpoint ID not found or resource does not exist: #{response.body}"
       when 502
-        raise EndpointError, "Other error with endpoint: #{response.status} #{response.body}."
+        raise GlobusClient::EndpointError, "Other error with endpoint: #{response.status} #{response.body}."
       when 503
-        raise ServiceUnavailable, 'The service is down for maintenance.'
+        raise GlobusClient::ServiceUnavailable, 'The service is down for maintenance.'
       else
-        raise StandardError, "Unexpected response: #{response.status} #{response.body}."
+        raise GlobusClient::InternalServerError, "Unexpected response: #{response.status} #{response.body}."
       end
     end
   end

data/lib/globus_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class GlobusClient
-  VERSION = '0.16.0'
+  VERSION = '0.18.0'
 end

data/lib/globus_client.rb

@@ -12,6 +12,7 @@ Zeitwerk::Loader.for_gem.setup
 
 # Client for interacting with the Globus API
 class GlobusClient # rubocop:disable Metrics/ClassLength
+  include Errors
   include Singleton
 
   class << self

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: globus_client
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.18.0
 platform: ruby
 authors:
 - Aaron Collier
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-05-28 00:00:00.000000000 Z
+date: 2025-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -91,6 +91,7 @@ files:
 - lib/globus_client/authenticator.rb
 - lib/globus_client/endpoint.rb
 - lib/globus_client/endpoint_manager.rb
+- lib/globus_client/errors.rb
 - lib/globus_client/identity.rb
 - lib/globus_client/unexpected_response.rb
 - lib/globus_client/version.rb