globalize-accessors 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce6fd7599f86b6c3962521da63aba9d568360b3a
-  data.tar.gz: 27afe99b06330d8ef59bd09dfdee4b21571bac25
+  metadata.gz: 3229262ee8f633268283f5d27f9530b3ee419d8f
+  data.tar.gz: 791ffbdfa8071c57411f9e00f9366a3b242731d9
 SHA512:
-  metadata.gz: 81581d05228b6664c5e4e81e32ec1b3b249ab8bc222bcbf2cef6d795ee97e056802a26a49504de10415dc047f559691bec7e1e1a127ec20b59cf8b5fb9019c41
-  data.tar.gz: 203866ebfd2e76a4753a679f0d5ed6bc339a80cf8d7edcc08c835ceee01e7f53f28bcb9789a7f70da0bcef61ff4c75a9d2ab111519a2333eea6bc4d9acde549f
+  metadata.gz: 31cadd05e47d9c3b701527d4e70b551ad542a2594fa0f0c18c6064b9cb669bfc8c473568e286fb68a6784010d9f251f41fe93dbb4d3bd80cd80c44d1d0d9c92a
+  data.tar.gz: da7ac8bb04ae0993b630203065750694abd8b372192d6ae706b2daf46b6deec78602443daa2c6ffd0c21c7a4e7d131b07ff6b9744148fd9dfea7e305207f0ed6

data/globalize-accessors.gemspec

@@ -14,19 +14,11 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3"
   s.rubyforge_project         = "globalize-accessors"
 
-  if ENV['RAILS_3']
-    s.add_dependency "globalize", "~> 3.0.0"
-  elsif ENV['RAILS_4']
-    s.add_dependency "globalize", "~> 4.0.0.alpha.1"
-  else
-    s.add_dependency "globalize", ">= 3"
-  end
-
-  s.add_development_dependency "bundler", ">= 1.3.5"
+  s.add_dependency "globalize", "~> 5.0.0"
+  s.add_development_dependency "bundler", "~> 1.7.2"
   s.add_development_dependency "rake", "~> 0.9.2"
   s.add_development_dependency "sqlite3"
-  s.add_development_dependency "minitest", "~> 4.2"
-
+  s.add_development_dependency "minitest", "~> 5.1"
 
   s.files        = `git ls-files`.split("\n")
   s.executables  = `git ls-files`.split("\n").map{|f| f =~ /^bin\/(.*)/ ? $1 : nil}.compact

data/lib/globalize-accessors.rb

@@ -36,8 +36,9 @@ module Globalize::Accessors
     localized_attr_name = localized_attr_name_for(attr_name, locale)
 
     define_method :"#{localized_attr_name}=" do |value|
+      return if !translation_caches[locale] && value.blank?
       write_attribute(attr_name, value, :locale => locale)
-      translation_for(locale)[attr_name] = value if value.present?
+      translation_for(locale)[attr_name] = value
     end
     if respond_to?(:accessible_attributes) && accessible_attributes.include?(attr_name)
       attr_accessible :"#{localized_attr_name}"

data/lib/globalize-accessors/version.rb

@@ -1,5 +1,5 @@
 module Globalize
   module Accessors
-    VERSION = '0.1.5'
+    VERSION = '0.2.0'
   end
 end

data/test/globalize_accessors_test.rb

@@ -17,19 +17,11 @@ class GlobalizeAccessorsTest < ActiveSupport::TestCase
   end
 
   class UnitInheritedWithOptions < ActiveRecord::Base
+    self.table_name = :units
     translates :color
     globalize_accessors :locales => [:de], :attributes => [:color]
   end
 
-  if ENV['RAILS_3']
-    class UnitWithAttrAccessible < ActiveRecord::Base
-      self.table_name = :units
-      attr_accessible :name
-      translates :name, :title
-      globalize_accessors
-    end
-  end
-
   class UnitWithDashedLocales < ActiveRecord::Base
     self.table_name = :units
     translates :name
@@ -74,6 +66,29 @@ class GlobalizeAccessorsTest < ActiveSupport::TestCase
     assert_equal 0, u.translations.size
   end
 
+  test "doesn't build translations without values even after saving" do
+    u = Unit.new(:name_en => nil, :title_pl => " ")
+    u.save
+
+    # On Rails 4, Globalize will always create an empty translation for
+    # the default locale
+    # On Rails 3, Globalize will never create a translation
+    assert u.translated_locales.exclude?(:pl)
+  end
+
+  test "persisted translations can be set to empty values" do
+    u = Unit.new(:name_en => "test")
+    u.save
+    u.name_en = ""
+    assert_equal "", u.translations.first.name
+  end
+
+  test "not persisted translations can be set to empty values" do
+    u = Unit.new(:name_en => "test")
+    u.name_en = ""
+    assert_equal "", u.translations.first.name
+  end
+
   test "write on new object and read on saved" do
     u = Unit.create!(:name_en => "Name en", :title_pl => "Title pl")
 
@@ -137,18 +152,6 @@ class GlobalizeAccessorsTest < ActiveSupport::TestCase
     assert_equal "Name pl",  u.name_pl
   end
 
-  if ENV['RAILS_3']
-    test "whitelist locale accessors if the original attribute is whitelisted" do
-      u = UnitWithAttrAccessible.new()
-      u.update_attributes(:name => "Name en", :name_pl => "Name pl", :title => "Title en", :title_pl => "Title pl")
-
-      assert_equal "Name en",  u.name
-      assert_equal "Name pl",  u.name_pl
-      assert_nil  u.title
-      assert_nil  u.title_pl
-    end
-  end
-
   test "globalize locales on class without locales specified in options" do
     assert_equal [:en, :pl], Unit.globalize_locales
   end

data/test/test_helper.rb

@@ -12,6 +12,7 @@ plugin_test_dir = File.dirname(__FILE__)
 
 ActiveRecord::Base.logger = Logger.new(File.join(plugin_test_dir, "debug.log"))
 ActiveRecord::Base.configurations = YAML::load(  IO.read( File.join(plugin_test_dir, 'db', 'database.yml')  ) )
-ActiveRecord::Base.establish_connection("sqlite3mem")
+ActiveRecord::Base.establish_connection(:sqlite3mem)
 ActiveRecord::Migration.verbose = false
+ActiveSupport::TestCase.test_order = :sorted
 load(File.join(plugin_test_dir, "db", "schema.rb"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: globalize-accessors
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - Tomasz Stachewicz
@@ -12,36 +12,36 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-16 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: globalize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: 1.7.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.5
+        version: 1.7.2
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -76,14 +76,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.1'
 description: Define methods for accessing translated attributes
 email:
 - tomekrs@o2.pl
@@ -128,8 +128,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '1.3'
 requirements: []
 rubyforge_project: globalize-accessors
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Define methods for accessing translated attributes
 test_files: []
+has_rdoc: