globalize-accessors 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb81591d0892a68040b226ca603d12e538aaa430
-  data.tar.gz: 4b4e3a579c5eff87286b320b7177f86fa8313b1f
+  metadata.gz: e6b68096730b07010773411f39a6765871049ac8
+  data.tar.gz: ffe954c351fff999d909f3dd7b06f6cbb316c7b8
 SHA512:
-  metadata.gz: 89c74b3362d3fcadeb5999bd19a55ff8695cb421efa1553f08a6dedf2c8375d19956a4cba63cdaf393e4edcf6cd65cf276e9ed9096dd3533498075e74d71fa50
-  data.tar.gz: 52283201db4341df4b3bb5bef75f77be4d1247a8ccff3f29cd3e79968f9e631b9089e75634f370ef857bbd5fb6ecc442d0b4baf2d1952ad7b4c393ca37c1736e
+  metadata.gz: 9bb53008d46631cf26b48442bac3f913c41e0814f9f3659da7bf3aaffa761fb7be2d1eca0069ff27786a3f04c6c42b467210cd99cd1b1d10df22d78b8c967b3f
+  data.tar.gz: 86f3612c8aec29e123743e3db869fc243f7918074212a7d31d3f8a4cdf9951c8e00fb68497480561b6ec1886cc1b4698676c84558672af0acddd989bcb62b5b2

data/MIT-LICENSE

@@ -1,4 +1,5 @@
-Copyright (c) 2009 [name of plugin creator]
+Copyright (c) 2009, 2010, 2011, 2012, 2013 Tomek "Tomash" Stachewicz,
+Robert Pankowecki, Chris Salzberg
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/Rakefile

@@ -13,7 +13,7 @@ require 'rake'
 desc 'Default: run unit tests.'
 task :default => :test
 
-desc 'Test the easy_globalize_accessors plugin.'
+desc 'Test globalize-accessors gem.'
 Rake::TestTask.new(:test) do |t|
   t.libs << 'lib'
   t.libs << 'test'
@@ -21,7 +21,7 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = true
 end
 
-desc 'Generate documentation for the easy_globalize_accessors plugin.'
+desc 'Generate documentation for globalize-accessors gem.'
 Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = 'EasyGlobalizeAccessors'

data/globalize-accessors.gemspec

@@ -3,7 +3,7 @@ require File.expand_path("../lib/globalize-accessors/version", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "globalize-accessors"
-  s.version     = GlobalizeAccessors::VERSION
+  s.version     = Globalize::Accessors::VERSION
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Tomasz Stachewicz", "Wojciech Pietrzak", "Steve Verlinden", "Robert Pankowecki", "Chris Salzberg"]
   s.email       = ["tomekrs@o2.pl", "steve.verlinden@gmail.com", "robert.pankowecki@gmail.com", "rpa@gavdi.com", "chrissalzberg@gmail.com"]
@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.summary     = "Define methods for accessing translated attributes"
   s.description = "Define methods for accessing translated attributes"
 
-  s.required_rubygems_version = ">= 1.3.6"
+  s.required_rubygems_version = ">= 1.3"
   s.rubyforge_project         = "globalize-accessors"
 
   if ENV['RAILS_3']
@@ -22,9 +22,10 @@ Gem::Specification.new do |s|
     s.add_dependency "globalize", ">= 3"
   end
 
-  s.add_development_dependency "bundler", "~> 1.3.5"
+  s.add_development_dependency "bundler", ">= 1.3.5"
   s.add_development_dependency "rake", "~> 0.9.2"
   s.add_development_dependency "sqlite3"
+  s.add_development_dependency "minitest", "~> 4.2"
 
 
   s.files        = `git ls-files`.split("\n")

data/lib/globalize-accessors.rb

@@ -13,19 +13,16 @@ module Globalize::Accessors
     end
   end
 
-
   private
 
-
   def define_accessors(attr_name, locale)
     define_getter(attr_name, locale)
     define_setter(attr_name, locale)
   end
 
-
   def define_getter(attr_name, locale)
     define_method :"#{attr_name}_#{locale.to_s.underscore}" do
-      read_attribute(attr_name, :locale => locale)
+      globalize.stash.contains?(locale, attr_name) ? globalize.send(:fetch_stash, locale, attr_name) : globalize.send(:fetch_attribute, locale, attr_name)
     end
   end
 
@@ -34,6 +31,7 @@ module Globalize::Accessors
 
     define_method :"#{localized_attr_name}=" do |value|
       write_attribute(attr_name, value, :locale => locale)
+      translation_for(locale)[attr_name] = value if value.present?
     end
     if respond_to?(:accessible_attributes) && accessible_attributes.include?(attr_name)
       attr_accessible :"#{localized_attr_name}"

data/lib/globalize-accessors/version.rb

@@ -1,3 +1,5 @@
-module GlobalizeAccessors
-  VERSION = '0.1.3'
+module Globalize
+  module Accessors
+    VERSION = '0.1.4'
+  end
 end

data/readme.md

@@ -26,7 +26,7 @@ class Product
 end
 ````
 
-Gives you access to methods: `title_pl`, `title_en`, `title_pl=`, `title_en=` (and a similar set of description_* methods). These work seamlessly with Globalize (not even touching the "core" `title`, `title=` methods used by Globalize itself).
+Gives you access to methods: `title_pl`, `title_en`, `title_pl=`, `title_en=`. These work seamlessly with Globalize (not even touching the "core" `title`, `title=` methods used by Globalize itself).
 
 The `:locales` and `:attributes` options are optional. Their default values are:
 
@@ -82,4 +82,6 @@ end
 
 ## Licence
 
-Copyright (c) 2009-2013 Tomek "Tomash" Stachewicz (http://tomash.wrug.eu),  Robert Pankowecki (http://robert.pankowecki.pl) released under the MIT license
+Copyright (c) 2009-2013 Tomek "Tomash" Stachewicz (http://tomash.wrug.eu),
+Robert Pankowecki (http://robert.pankowecki.pl), Chris Salzberg (http://dejimata.com)
+released under the MIT license

data/test/globalize_accessors_test.rb

@@ -51,6 +51,17 @@ class GlobalizeAccessorsTest < ActiveSupport::TestCase
     assert_nil u.title_en
   end
 
+  test "build translations for a new object" do
+    u = Unit.new(:name_en => "Name en", :title_pl => "Title pl")
+    assert_equal 2, u.translations.size # size of the collection
+    assert_equal 0, u.translations.count # count from database
+  end
+
+  test "doesn't build translations without values" do
+    u = Unit.new(:name_en => nil, :title_pl => " ")
+    assert_equal 0, u.translations.size
+  end
+
   test "write on new object and read on saved" do
     u = Unit.create!(:name_en => "Name en", :title_pl => "Title pl")
 
@@ -62,6 +73,14 @@ class GlobalizeAccessorsTest < ActiveSupport::TestCase
     assert_nil u.title_en
   end
 
+   test "updates translations for existing object" do
+    u = Unit.create!(:name_en => "Name en", :title_pl => "Title pl")
+    u.name_en = "New name en"
+    assert_equal "New name en", u.translations.find {|t| t.locale == :en }.name
+    assert_equal "Title pl", u.translations.find {|t| t.locale == :pl }.title
+    assert_equal 2, u.translations.count
+  end
+
   test "read on existing object" do
     u = Unit.create!(:name_en => "Name en", :title_pl => "Title pl")
     u = Unit.find(u.id)
@@ -144,6 +163,17 @@ class GlobalizeAccessorsTest < ActiveSupport::TestCase
     assert_equal "Name en-AU",  u.name_en_au
   end
 
+  test "read when fallbacks present" do
+    u = Unit.create!(:name_en => "Name en", :title_pl => "Title pl")
+    u = Unit.find(u.id)
+    def u.globalize_fallbacks(locale)
+      locale == :pl ? [:pl, :en] : [:en, :pl]
+    end
+
+    assert_equal "Name en",  u.name
+    assert_nil u.title_en
+  end
+
   test "globalize attribute names on class without attributes specified in options" do
     assert_equal [:name_en, :name_pl, :title_en, :title_pl], Unit.globalize_attribute_names
   end

data/test/test_helper.rb

@@ -1,7 +1,7 @@
 require 'i18n'
 I18n.available_locales = [:en, :pl]
 
-require 'test/unit'
+require 'minitest/autorun'
 require 'active_support'
 require 'active_support/test_case'
 require 'logger'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: globalize-accessors
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Tomasz Stachewicz
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-25 00:00:00.000000000 Z
+date: 2014-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: globalize
@@ -32,14 +32,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
 - !ruby/object:Gem::Dependency
@@ -70,6 +70,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '4.2'
 description: Define methods for accessing translated attributes
 email:
 - tomekrs@o2.pl
@@ -111,11 +125,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.6
+      version: '1.3'
 requirements: []
 rubyforge_project: globalize-accessors
-rubygems_version: 2.0.3
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Define methods for accessing translated attributes
 test_files: []
+has_rdoc: