globalid 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f2528856199c7987932762dc50ef3c32e648bed3
-  data.tar.gz: 5173c699b2cc2259f69020ad8ab612cd743c6dcc
+  metadata.gz: 0900d9c61b92f834447117f95eb42e288bc4c295
+  data.tar.gz: a16f774ad3ff54c240b65575316d88186f7de201
 SHA512:
-  metadata.gz: bfe22b6446db4558d072e4879ab105aecc08d3f5e4ad11c10242165391b3aab1aea0c913f03af1a17f3fa1358edd11988436c39f47088d00317908ca39ef34d2
-  data.tar.gz: 56ee044ed7cec2396866bc83be18c0045784c5e36072a20545c92b30305704d49169291a6e8b4dd2d6b89f4aecf0495cfa140c3d80b62a1786876d2adb2f1ea2
+  metadata.gz: c011c4f6d933622e912095363f7443291fff84e51cedd885cf75d3d30c64bd11ddc9a23d9be58428f24fe2672793aff9252ad8ddfce7999ff47d6083b779e04b
+  data.tar.gz: 939192c118d11e7e2975e4d20042b4fec032a5bb8970917b608b079062da32ae2f0b7188d0cd029f6012b5a22fb6d1010e92d62e7109d7deaea8521a43411dcb

data/lib/global_id/locator.rb

@@ -22,8 +22,8 @@ class GlobalID
       # The GlobalIDs are located using Model.find(array_of_ids), so the models must respond to
       # that finder signature.
       #
-      # This approach will efficiently call only one #find per model class, but still interpolate
-      # the results to match the order in which the gids were passed.
+      # This approach will efficiently call only one #find (or #where(id: id), when using ignore_missing)
+      # per model class, but still interpolate the results to match the order in which the gids were passed.
       #
       # Options:
       # * <tt>:only</tt> - A class, module or Array of classes and/or modules that are
@@ -31,11 +31,17 @@ class GlobalID
       #   classes to those classes or their subclasses.  Passing one or more modules in limits
       #   instances of returned classes to those including that module.  If no classes or
       #   modules match, +nil+ is returned.
+      # * <tt>:ignore_missing</tt> - By default, locate_many will call #find on the model to locate the
+      #   ids extracted from the GIDs. In Active Record (and other data stores following the same pattern),
+      #   #find will raise an exception if a named ID can't be found. When you set this option to true,
+      #   we will use #where(id: ids) instead, which does not raise on missing records.
       def locate_many(gids, options = {})
         if (allowed_gids = parse_allowed(gids, options[:only])).any?
           models_and_ids  = allowed_gids.collect { |gid| [ gid.model_name.constantize, gid.model_id ] }
           ids_by_model    = models_and_ids.group_by(&:first)
-          loaded_by_model = Hash[ids_by_model.map { |model, ids| [ model, model.find(ids.map(&:last)).index_by { |record| record.id.to_s } ] }]
+          loaded_by_model = Hash[ids_by_model.map { |model, ids|
+            [ model, find_records(model, ids.map(&:last), ignore_missing: options[:ignore_missing]).index_by { |record| record.id.to_s } ]
+          }]
 
           models_and_ids.collect { |(model, id)| loaded_by_model[model][id] }.compact
         else
@@ -116,6 +122,14 @@ class GlobalID
         def normalize_app(app)
           app.to_s.downcase
         end
+
+        def find_records(model_class, ids, ignore_missing:)
+          if ignore_missing
+            model_class.where(id: ids)
+          else
+            model_class.find(ids)
+          end
+        end
     end
 
     private

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: globalid
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-12 00:00:00.000000000 Z
+date: 2015-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport