global-registry-bindings 0.2.0 → 0.3.0

data/spec/spec_helper.rb

@@ -8,7 +8,11 @@ require 'active_record'
 ActiveRecord::Migration.verbose = false
 
 require 'combustion'
-Combustion.initialize! :active_record
+Combustion.initialize! :active_record do
+  if config.active_record.sqlite3.respond_to?(:represent_boolean_as_integer)
+    config.active_record.sqlite3.represent_boolean_as_integer = true
+  end
+end
 
 require 'rspec/rails'
 require 'webmock/rspec'

data/spec/workers/push_entity_worker_spec.rb

@@ -18,6 +18,17 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
         end
       end
 
+      context 'with valid id and fingerprint' do
+        it 'should call #push_entity_to_global_registry' do
+          expect(Namespaced::Person).to receive(:find).with(person.id).and_return(person)
+
+          worker = GlobalRegistry::Bindings::Workers::PushEntityWorker.new
+          expect(worker).to receive(:push_entity_to_global_registry)
+          worker.perform('Namespaced::Person', person.id)
+          expect(worker.model).to be person
+        end
+      end
+
       context 'with invalid id' do
         it 'should fail silently' do
           expect(Namespaced::Person).to receive(:find).with(person.id).and_raise(ActiveRecord::RecordNotFound)
@@ -116,8 +127,16 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
 
     describe Namespaced::Person do
       let(:worker) { GlobalRegistry::Bindings::Workers::PushEntityWorker.new person }
+      let(:entity_body) do
+        { entity: { person: { first_name: 'Tony', last_name: 'Stark',
+                              client_integration_id: person.id,
+                              client_updated_at: '2001-02-03 00:00:00',
+                              authentication: {
+                                key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
+                              } } } }
+      end
       context 'as create' do
-        let(:person) { create(:person) }
+        let(:person) { create(:person, global_registry_fingerprint: 'abc123') }
 
         context '\'person\' entity_type does not exist' do
           let!(:requests) do
@@ -136,12 +155,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
                                             field_type: 'string' } })
                .to_return(status: 200),
              stub_request(:post, 'https://backend.global-registry.org/entities')
-               .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                 client_integration_id: person.id,
-                                                 client_updated_at: '2001-02-03 00:00:00',
-                                                 authentication: {
-                                                   key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                 } } } })
+               .with(body: entity_body)
                .to_return(body: file_fixture('post_entities_person.json'), status: 200)]
           end
 
@@ -149,6 +163,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
             worker.push_entity_to_global_registry
             requests.each { |r| expect(r).to have_been_requested.once }
             expect(person.global_registry_id).to eq '22527d88-3cba-11e7-b876-129bd0521531'
+            expect(person.global_registry_fingerprint).to eq '4c671c203b5dd19cdc1920ba5434cf64'
           end
         end
 
@@ -158,12 +173,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
               .with(query: { 'filters[name]' => 'person', 'filters[parent_id]' => nil })
               .to_return(body: file_fixture('get_entity_types_person.json'), status: 200),
              stub_request(:post, 'https://backend.global-registry.org/entities')
-               .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                 client_integration_id: person.id,
-                                                 client_updated_at: '2001-02-03 00:00:00',
-                                                 authentication: {
-                                                   key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                 } } } })
+               .with(body: entity_body)
                .to_return(body: file_fixture('post_entities_person.json'), status: 200)]
           end
 
@@ -171,6 +181,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
             worker.push_entity_to_global_registry
             requests.each { |r| expect(r).to have_been_requested.once }
             expect(person.global_registry_id).to eq '22527d88-3cba-11e7-b876-129bd0521531'
+            expect(person.global_registry_fingerprint).to eq '4c671c203b5dd19cdc1920ba5434cf64'
           end
         end
 
@@ -184,12 +195,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
                                             field_type: 'string' } })
                .to_return(status: 200),
              stub_request(:post, 'https://backend.global-registry.org/entities')
-               .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                 client_integration_id: person.id,
-                                                 client_updated_at: '2001-02-03 00:00:00',
-                                                 authentication: {
-                                                   key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                 } } } })
+               .with(body: entity_body)
                .to_return(body: file_fixture('post_entities_person.json'), status: 200)]
           end
 
@@ -197,6 +203,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
             worker.push_entity_to_global_registry
             requests.each { |r| expect(r).to have_been_requested.once }
             expect(person.global_registry_id).to eq '22527d88-3cba-11e7-b876-129bd0521531'
+            expect(person.global_registry_fingerprint).to eq '4c671c203b5dd19cdc1920ba5434cf64'
           end
         end
 
@@ -208,22 +215,21 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
 
           it 'should skip creating entity_type and push the entity' do
             request = stub_request(:post, 'https://backend.global-registry.org/entities')
-                      .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                        client_integration_id: person.id,
-                                                        client_updated_at: '2001-02-03 00:00:00',
-                                                        authentication: {
-                                                          key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                        } } } })
+                      .with(body: entity_body)
                       .to_return(body: file_fixture('post_entities_person.json'), status: 200)
             worker.push_entity_to_global_registry
             expect(request).to have_been_requested.once
             expect(person.global_registry_id).to eq '22527d88-3cba-11e7-b876-129bd0521531'
+            expect(person.global_registry_fingerprint).to eq '4c671c203b5dd19cdc1920ba5434cf64'
           end
         end
       end
 
       context 'as an update' do
-        let(:person) { create(:person, global_registry_id: 'f8d20318-2ff2-4a98-a5eb-e9d840508bf1') }
+        let(:person) do
+          create(:person, global_registry_id: 'f8d20318-2ff2-4a98-a5eb-e9d840508bf1',
+                          global_registry_fingerprint: 'abc123')
+        end
         context '\'person\' entity_type is cached' do
           before :each do
             person_entity_types = JSON.parse(file_fixture('get_entity_types_person.json').read)
@@ -233,12 +239,7 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
           it 'should skip creating entity_type and update the entity' do
             request = stub_request(:put,
                                    'https://backend.global-registry.org/entities/f8d20318-2ff2-4a98-a5eb-e9d840508bf1')
-                      .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                        client_integration_id: person.id,
-                                                        client_updated_at: '2001-02-03 00:00:00',
-                                                        authentication: {
-                                                          key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                        } } } })
+                      .with(body: entity_body)
                       .to_return(body: file_fixture('post_entities_person.json'), status: 200)
             worker.push_entity_to_global_registry
             expect(request).to have_been_requested.once
@@ -248,20 +249,10 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
             let!(:requests) do
               [stub_request(:put,
                             'https://backend.global-registry.org/entities/f8d20318-2ff2-4a98-a5eb-e9d840508bf1')
-                .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                  client_integration_id: person.id,
-                                                  client_updated_at: '2001-02-03 00:00:00',
-                                                  authentication: {
-                                                    key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                  } } } })
+                .with(body: entity_body)
                 .to_return(status: 404),
                stub_request(:post, 'https://backend.global-registry.org/entities')
-                 .with(body: { entity: { person: { first_name: 'Tony', last_name: 'Stark',
-                                                   client_integration_id: person.id,
-                                                   client_updated_at: '2001-02-03 00:00:00',
-                                                   authentication: {
-                                                     key_guid: '98711710-acb5-4a41-ba51-e0fc56644b53'
-                                                   } } } })
+                 .with(body: entity_body)
                  .to_return(body: file_fixture('post_entities_person.json'), status: 200)]
             end
 
@@ -269,6 +260,19 @@ RSpec.describe GlobalRegistry::Bindings::Workers::PushEntityWorker do
               worker.push_entity_to_global_registry
               requests.each { |r| expect(r).to have_been_requested.once }
               expect(person.global_registry_id).to eq '22527d88-3cba-11e7-b876-129bd0521531'
+              expect(person.global_registry_fingerprint).to eq '4c671c203b5dd19cdc1920ba5434cf64'
+            end
+          end
+
+          context 'fingerprints match' do
+            it 'should do nothing' do
+              request = stub_request(:put,
+                                     'https://backend.global-registry.org/entities/f8d20318-2ff2-4a98-a5eb-e9d840508bf1')
+                        .with(body: entity_body)
+                        .to_return(body: file_fixture('post_entities_person.json'), status: 200)
+              person.global_registry_fingerprint = '4c671c203b5dd19cdc1920ba5434cf64'
+              worker.push_entity_to_global_registry
+              expect(request).not_to have_been_requested
             end
           end
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: global-registry-bindings
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Brian Zoetewey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-09 00:00:00.000000000 Z
+date: 2019-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -90,6 +90,26 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '6'
+- !ruby/object:Gem::Dependency
+  name: deepsort
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.4.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.4.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -110,14 +130,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -216,20 +236,6 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.48.1
-- !ruby/object:Gem::Dependency
-  name: database_cleaner
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -395,6 +401,7 @@ files:
 - spec/internal/config/initializers/global_registry.rb
 - spec/internal/config/routes.rb
 - spec/internal/db/schema.rb
+- spec/internal/db/test.sqlite
 - spec/internal/log/test.log
 - spec/models/address_spec.rb
 - spec/models/assignment_spec.rb
@@ -449,6 +456,7 @@ test_files:
 - spec/internal/config/database.yml
 - spec/internal/config/initializers/global_registry.rb
 - spec/internal/db/schema.rb
+- spec/internal/db/test.sqlite
 - spec/internal/log/test.log
 - spec/models/person_spec.rb
 - spec/models/testing_spec.rb