glimr-api-client 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d090c08e733fa1980327591baf348705a15ef1a
-  data.tar.gz: 7f0fc6d4e7940a860a92e7b551520a29c7692b35
+  metadata.gz: a95379c7f68eb8bfdfa5a18fe3d28d1f540bdfd0
+  data.tar.gz: da42193aea4ccd8b6488f4170890a7ae63a4e273
 SHA512:
-  metadata.gz: 3f3bd5682bec9f2c78a9c299b22847532d93f0dd35c2a43891d9e9b3a4811fb99b117f232f4dde2a0cf93c274e229ab091a3c90c87a7b5b5aab05998c272ca9c
-  data.tar.gz: 489f72535fda5e5e17f8ea2a8040690df0c0bc23091bdb1e31625ba8fcb02d0346865f0f25ba67a245b8afa65f0ba0877befa9c7db026a98b70ebe7957c0999d
+  metadata.gz: 4b883fe2a22fa59cde745fa11c8b18131b45d73fe4e2bcabf2bbcc1ffa729a3985f8115c8d36558803328093e6ba99a34b230da1c15021959c1c1160921f5708
+  data.tar.gz: 25564435a7cfe5f88e7dfef8e2a5e61912b2749282d66a7ab15479407ef4b17deb0752a5094d6e194c89c6c1426449e6f8943843df8b158ed4de220265fc8574

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    glimr-api-client (0.1.3)
+    glimr-api-client (0.1.4)
+      activesupport (~> 5.0)
       excon (~> 0.51)
 
 GEM
@@ -75,7 +76,7 @@ GEM
     docile (1.1.5)
     equalizer (0.0.11)
     erubis (2.7.0)
-    excon (0.52.0)
+    excon (0.54.0)
     fuubar (2.0.0)
       rspec (~> 3.0)
       ruby-progressbar (~> 1.4)
@@ -249,4 +250,4 @@ DEPENDENCIES
   sqlite3 (~> 1.3)
 
 BUNDLED WITH
-   1.12.5
+   1.13.3

data/README.md

@@ -7,6 +7,12 @@ use in various UK tribunals.
 
 ## Usage
 
+### Configuration
+
+The gem expects a `GLIMR_API_URL` environment variable, providing the endpoint at which the API can be found. This will be something like; `https://glimr-api.taxtribunals.dsd.io`
+
+This URL must be accessible from wherever your code is running.
+
 ### Check Availablity
 
 ```ruby

data/glimr_api_client.gemspec

@@ -27,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'sqlite3', '~> 1.3'
 
   spec.add_dependency 'excon', '~> 0.51'
+  spec.add_dependency 'activesupport', '~> 5.0'
 end

data/lib/glimr_api_client/api.rb

@@ -1,3 +1,7 @@
+require 'excon'
+require 'active_support'
+require 'active_support/core_ext/object/to_query'
+
 module GlimrApiClient
   module Api
 
@@ -7,13 +11,12 @@ module GlimrApiClient
           # Only timeouts and network issues raise errors.
           handle_response_errors(resp)
           @body = resp.body
-          @status = resp.status
         }
     rescue Excon::Error => e
-      if endpoint == '/paymenttaken'
-        raise GlimrApiClient::PaymentNotificationFailure, e
+      if endpoint.eql?('/paymenttaken')
+        raise PaymentNotificationFailure, e
       else
-        raise GlimrApiClient::Unavailable, e
+        raise Unavailable, e
       end
     end
 
@@ -24,12 +27,14 @@ module GlimrApiClient
     private
 
     def handle_response_errors(resp)
-      if resp.status == 404
-        raise GlimrApiClient::CaseNotFound
-      elsif (400..599).cover?(resp.status) && endpoint == '/paymenttaken'
-        raise GlimrApiClient::PaymentNotificationFailure, resp.status
+      if (!endpoint.eql?('/paymenttaken') && resp.status.equal?(404))
+        raise CaseNotFound, resp.status
       elsif (400..599).cover?(resp.status)
-        raise GlimrApiClient::Unavailable, resp.status
+        if endpoint.eql?('/paymenttaken')
+          raise PaymentNotificationFailure, resp.status
+        else
+          raise Unavailable, resp.status
+        end
       end
     end
 
@@ -40,7 +45,8 @@ module GlimrApiClient
           'Content-Type' => 'application/json',
           'Accept' => 'application/json'
         },
-        persistent: true
+        persistent: true,
+        connect_timeout: 15
       )
     end
   end

data/lib/glimr_api_client/available.rb

@@ -1,10 +1,9 @@
 module GlimrApiClient
   class Available
     include GlimrApiClient::Api
+    extend SingleForwardable
 
-    class << self
-      delegate :call, to: :new
-    end
+    def_delegator :new, :call
 
     def call
       post

data/lib/glimr_api_client/version.rb

@@ -1,3 +1,3 @@
 module GlimrApiClient
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 end

data/lib/tasks/mutant.rake

@@ -1,49 +1,9 @@
 task :mutant do
-  classes_to_mutate.each do |klass|
-    vars = 'NOCOVERAGE=true'
-    flags = '--include lib --use rspec'
-    unless system("#{vars} mutant #{flags} #{klass}")
-      raise 'Mutation testing failed'
-    end
+  vars = 'NOCOVERAGE=true'
+  flags = '--include lib --use rspec --fail-fast'
+  unless system("#{vars} mutant #{flags} GlimrApiClient*")
+    raise 'Mutation testing failed'
   end
 end
 
 task(:default).prerequisites << task(:mutant)
-
-private
-
-def classes_to_mutate
-  files = grep_files_for_classes
-  klasses = extract_classes_for_mutation(files)
-  klasses.map { |k|
-    setup_class_for_run(k)
-  }
-end
-
-# This is a nasty hack because we’re using POROs; otherwise, we could just use
-# ApplicationRecord.descendants...
-#
-# Grepping through the source code seemed to be the most pragmatic solution
-# so that developers don’t need to remember to add new classes to a list for
-# mutation testing, but it’s not ideal
-def grep_files_for_classes
-  Dir.glob('lib/**/*.rb').
-    map { |f|
-    # There are some examples of `class << self` in codebase.
-    File.readlines(f).grep(/\bclass(?!\s<<)/)
-  }.flatten
-end
-
-def extract_classes_for_mutation(files)
-  re = /class (?<klass>\w+)/
-
-  files.map { |s|
-    re.match(s)[:klass]
-  }.compact
-end
-
-def setup_class_for_run(klass)
-  Object.const_get(klass)
-rescue NameError
-  Object.const_get("GlimrApiClient::#{klass}")
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glimr-api-client
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Todd Tyree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-12 00:00:00.000000000 Z
+date: 2016-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -178,6 +178,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.51'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
 description: 
 email:
 - todd.tyree@digital.justice.gov.uk
@@ -225,7 +239,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Easy integration with the glimr case management system