glimmer 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c305f675b946595a08012449c49518559acb8238f486c154b3720c0428b5c88
-  data.tar.gz: 3f5d4ece86f4c737f7d0ae9cb1f6f235fca33694653c6a760afe33fcc6117692
+  metadata.gz: 7e54e98c5ffbe3d68414f3d50103d1d4871ba6a7d9a620b78c57850df8cd7247
+  data.tar.gz: 445cccf31afff2be026317731bd08d3cf51fe79fc3ae166ffd75ed7d93291f5e
 SHA512:
-  metadata.gz: 42ea536ecec59e08a94f1dd561b614d6eb64f4d44c8c2ac9de8ef4170a3f6399659de613cd08acb52b2fea68524f65e28e578ecdfa64842f6faf8711efc3b076
-  data.tar.gz: 245ace0d9f7f92efc9071c86b96de8a64b2b624c8194ae5af85c9f74ea77db924028f5cc57505807c7f309d5d8688a0d072e5a50ad40e9e4d0c01ae62dc6b32c
+  metadata.gz: 712e885e76e573b302a961e00a21b680d236aa4d63567e57c6d4dd014f3f57cddb82f72259769695bea4f4a7eb3da768153827f0554fe73002605944f6e60701
+  data.tar.gz: 93152749050dd124163b074260dc1c587fff26726d157808436922cb99aca5acd2156377b8e32344ee9a53cc686bac5ada5127ee96161e81622e159b2bd999cc

data/README.markdown

@@ -1,4 +1,4 @@
-# Glimmer 0.5.2 Beta (JRuby Desktop UI DSL + Data-Binding)
+# Glimmer 0.5.3 Beta (JRuby Desktop UI DSL + Data-Binding)
 [![Coverage Status](https://coveralls.io/repos/github/AndyObtiva/glimmer/badge.svg?branch=master)](https://coveralls.io/github/AndyObtiva/glimmer?branch=master)
 
 Glimmer is a native-UI cross-platform desktop development library written in Ruby. Glimmer's main innovation is a JRuby DSL that enables productive and efficient authoring of desktop application user-interfaces while relying on the robust platform-native Eclipse SWT library. Glimmer additionally innovates by having built-in data-binding support to greatly facilitate synchronizing the UI with domain models. As a result, that achieves true decoupling of object oriented components, enabling developers to solve business problems without worrying about UI concerns, or alternatively drive development UI-first, and then write clean business components test-first afterwards.
@@ -111,14 +111,14 @@ Please follow these instructions to make the `glimmer` command available on your
 
 Run this command to install directly:
 ```
-jgem install glimmer -v 0.5.2
+jgem install glimmer -v 0.5.3
 ```
 
 ### Option 2: Bundler
 
 Add the following to `Gemfile`:
 ```
-gem 'glimmer', '~> 0.5.2'
+gem 'glimmer', '~> 0.5.3'
 ```
 
 And, then run:
@@ -587,6 +587,8 @@ composite {
 # ...
 ```
 
+If you data-bind any layout properties, when they change, the shell containing their widget re-packs its children (calls `#pack` method automatically) to ensure proper relayout of all widgets.
+
 Alternatively, a layout may be constructed by following the SWT API for the layout object. For example, a `RowLayout` can be constructed by passing it an SWT style constant (Glimmer automatically accepts symbols (e.g. `:horizontal`) for SWT style arguments like `SWT::HORIZONTAL`.)
 
 ```ruby
@@ -643,7 +645,7 @@ shell {
     }
     label {text "Age: "}
     label {
-      text bind(@contact, :age, :fixnum, computed_by: [:year_of_birth])
+      text bind(@contact, :age, on_write: :to_i, computed_by: [:year_of_birth])
       layout_data {
         horizontalAlignment :fill
         grabExcessHorizontalSpace true
@@ -657,9 +659,9 @@ Check out the samples directory for more advanced examples of layouts in Glimmer
 
 **Defaults**:
 
-Glimmer composites always come with grid_layout by default, but you can still specify explicitly if you'd like to set specific properties on it.
+Glimmer composites always come with `grid_layout` by default, but you can still specify explicitly if you'd like to set specific properties on it.
 
-Glimmer shell always comes with fill_layout having :horizontal type.
+Glimmer shell always comes with `fill_layout` having `:horizontal` type.
 
 This is a great guide for learning more about SWT layouts:
 
@@ -726,6 +728,8 @@ composite {
 # ...
 ```
 
+If you data-bind any layout data properties, when they change, the shell containing their widget re-packs its children (calls `#pack` method automatically) to ensure proper relayout of all widgets.
+
 **NOTE**: Layout data must never be reused between widgets. Always specify or clone again for every widget.
 
 This is a great guide for learning more about SWT layouts:
@@ -741,25 +745,43 @@ https://help.eclipse.org/2019-12/nftopic/org.eclipse.platform.doc.isv/reference/
 Data-binding is done with `bind` command following widget property to bind and taking model and bindable attribute as arguments.
 
 Data-binding examples:
-- `text bind(contact, :first_name)`
-- `text bind(contact, 'address.street')`
-- `text bind(contact, 'addresses[1].street')`
-- `text bind(contact, :age, computed_by: :date_of_birth)`
-- `text bind(contact, :name, computed_by: [:first_name, :last_name])`
-- `text bind(contact, 'profiles[0].name', computed_by: ['profiles[0].first_name', 'profiles[0].last_name'])`
 
-The 1st example binds the text property of a widget like `label` to the first name of a contact model.
+`text bind(contact, :first_name)`
+
+This example binds the text property of a widget like `label` to the first name of a contact model.
 
-The 2nd example binds the text property of a widget like `label` to the nested street of
+`text bind(contact, 'address.street')`
+
+This example binds the text property of a widget like `label` to the nested street of
 the address of a contact. This is called nested property data binding.
 
-The 3rd example binds the text property of a widget like `label` to the nested indexed address street of a contact. This is called nested indexed property data binding.
+`text bind(contact, 'address.street', on_read: :upcase, on_write: :downcase)`
+
+This example adds on the one above it by specifying converters on read and write of the model property, like in the case of a `text` widget. The text widget will then displays the street upper case and the model will store it lower case. When specifying converters, read and write operations must be symmetric (to avoid an infinite update loop between the widget and the model since the widget checks first if value changed before updating)
+
+`text bind(contact, 'address.street', on_read: lambda { |s| s[0..10] })`
+
+This example also specifies a converter on read of the model property, but via a lambda, which truncates the street to 10 characters only. Note that the read and write operations are assymetric. This is fine in the case of formatting data for a read-only widget like `label`
+
+`text bind(contact, 'address.street') { |s| s[0..10] }`
+
+This is a block shortcut version of the syntax above it. It facilitates formatting model data for read-only widgets since it's a very common view concern. It also saves the developer from having to create a separate formatter/presenter for the model when the view can be an active view that handles common simple formatting operations directly.
+
+`text bind(contact, 'addresses[1].street')`
+
+This example binds the text property of a widget like `label` to the nested indexed address street of a contact. This is called nested indexed property data binding.
 
-The 4th example demonstrates computed value data binding whereby the value of `age` depends on changes to `date_of_birth`.
+`text bind(contact, :age, computed_by: :date_of_birth)`
 
-The 5th example demonstrates computed value data binding whereby the value of `name` depends on changes to both `first_name` and `last_name`.
+This example demonstrates computed value data binding whereby the value of `age` depends on changes to `date_of_birth`.
 
-The 6th example demonstrates nested indexed computed value data binding whereby the value of `profiles[0].name` depends on changes to both nested `profiles[0].first_name` and `profiles[0].last_name`.
+`text bind(contact, :name, computed_by: [:first_name, :last_name])`
+
+This example demonstrates computed value data binding whereby the value of `name` depends on changes to both `first_name` and `last_name`.
+
+`text bind(contact, 'profiles[0].name', computed_by: ['profiles[0].first_name', 'profiles[0].last_name'])`
+
+This example demonstrates nested indexed computed value data binding whereby the value of `profiles[0].name` depends on changes to both nested `profiles[0].first_name` and `profiles[0].last_name`.
 
 Example from [samples/hello_combo.rb](samples/hello_combo.rb) sample (you may copy/paste in [`girb`](#girb-glimmer-irb-command)):
 
@@ -1283,71 +1305,6 @@ shell { |app_shell|
 }.open
 ```
 
-### Custom Shells
-
-Custom shells are a kind of custom widgets that have shells only as the body root. They can be self-contained applications that may be opened and hidden/closed independently of the main app.
-
-They may also be chained in a wizard fashion.
-
-Example (you may copy/paste in [`girb`](#girb-glimmer-irb-command)):
-
-```ruby
-class WizardStep
-  include Glimmer::UI::CustomShell
-
-  options :number, :step_count
-
-  before_body {
-    @title = "Step #{number}"
-  }
-
-  body {
-    shell {
-      text "Wizard - #{@title}"
-      minimum_size 200, 100
-      fill_layout :vertical
-      label(:center) {
-        text @title
-        font height: 30
-      }
-      if number < step_count
-        button {
-          text "Go To Next Step"
-          on_widget_selected {
-            body_root.hide
-          }
-        }
-      end
-    }
-  }
-end
-
-shell { |app_shell|
-  text "Wizard"
-  minimum_size 200, 100
-  @current_step_number = 1
-  @wizard_steps = 5.times.map { |n|
-    wizard_step(number: n+1, step_count: 5) {
-      on_event_hide {
-        if @current_step_number < 5
-          @current_step_number += 1
-          app_shell.hide
-          @wizard_steps[@current_step_number - 1].open
-        end
-      }      
-    }
-  }
-  button {
-    text "Start"
-    font height: 40
-    on_widget_selected {
-      app_shell.hide
-      @wizard_steps[@current_step_number - 1].open
-    }
-  }
-}.open
-```
-
 ### Miscellaneous
 
 #### Video Widget
@@ -1527,7 +1484,7 @@ Glimmer comes with a Ruby Logger accessible via `Glimmer.logger`
 Its level of logging defaults to `Logger::WARN`
 It may be configured to show a different level of logging as follows:
 ```ruby
-Glimmer.logger.level = Logger::DEBUG
+Glimmer.logger&.level = Logger::DEBUG
 ```
 This results in more verbose debugging log to `STDOUT`, which is helpful in troubleshooting Glimmer DSL syntax when needed.
 
@@ -1582,6 +1539,12 @@ Glimmer simplifies the process for general packaging on the Mac by providing a r
 
 - Create `Rakefile` in your app root directory
 - Add the following line to it: `require 'glimmer/rake_task'`
+- Create a Ruby script under bin to launch your application (e.g. `bin/math_bowling`) with the following content (replacing `'../app/my_application.rb'` with your application path):
+```ruby
+require 'glimmer/launcher'
+require Glimmer::Launcher.swt_jar_file
+require_relative '../app/my_application.rb'
+```
 
 Now, you can run the following command to package your app into a Mac DMG file (using both Warbler and javapackager):
 ```

data/lib/glimmer.rb

@@ -42,10 +42,14 @@ module Glimmer
 
     # Returns Glimmer logger (standard Ruby logger)
     def logger
-      unless defined? @@logger
-        @@logger = Logger.new(STDOUT).tap {|logger| logger.level = Logger::WARN}
-      end
-      @@logger
+      # unless defined? @@logger
+      #   @@logger = Logger.new(STDOUT).tap {|logger| logger.level = Logger::WARN}
+      # end
+      @@logger if defined? @@logger
+    end
+
+    def enable_logging
+      @@logger = Logger.new(STDOUT).tap {|logger| logger.level = Logger::WARN}
     end
   end
 
@@ -54,13 +58,13 @@ module Glimmer
     if method_symbol.to_s.match(REGEX_METHODS_EXCLUDED)
       raise InvalidKeywordError, "Glimmer excluded keyword: #{method_symbol}"
     end
-    Glimmer.logger.debug "keyword: " + method_symbol.to_s + " and args: " + args.to_s
+    Glimmer.logger&.debug "keyword: " + method_symbol.to_s + " and args: " + args.to_s
     Glimmer::DSL::Engine.interpret(method_symbol, *args, &block)
   rescue InvalidKeywordError => e
     if !method_symbol.to_s.match(REGEX_METHODS_EXCLUDED)
-      Glimmer.logger.error e.message
+      Glimmer.logger&.error e.message
     end
-    Glimmer.logger.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+    Glimmer.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
     super(method_symbol, *args, &block)
   end
 end

data/lib/glimmer/data_binding/model_binding.rb

@@ -7,23 +7,15 @@ module Glimmer
       include Observable
       include Observer
 
-      attr_reader :property_type, :binding_options
+      attr_reader :binding_options
 
-      PROPERTY_TYPE_CONVERTERS = {
-        :undefined => lambda { |value| value },
-        :fixnum => lambda { |value| value.to_i },
-        :array => lambda { |value| value.to_a }
-      }
-
-      def initialize(base_model, property_name_expression, property_type = :undefined, binding_options = nil)
-        property_type = :undefined if property_type.nil?
+      def initialize(base_model, property_name_expression, binding_options = nil)
         @base_model = base_model
         @property_name_expression = property_name_expression
-        @property_type = property_type
         @binding_options = binding_options || {}
         if computed?
           @computed_model_bindings = computed_by.map do |computed_by_property_expression|
-            self.class.new(base_model, computed_by_property_expression, :undefined, computed_binding_options)
+            self.class.new(base_model, computed_by_property_expression)
           end
         end
       end
@@ -59,6 +51,30 @@ module Glimmer
         nested_property? ? nested_property_name : property_name_expression
       end
 
+      def convert_on_read(value)
+        apply_converter(@binding_options[:on_read], value)
+      end
+
+      def convert_on_write(value)
+        apply_converter(@binding_options[:on_write], value)
+      end
+
+      def apply_converter(converter, value)
+        if converter.nil?
+          value
+        elsif converter.is_a?(String) || converter.is_a?(Symbol)
+          if value.respond_to?(converter)
+            value.send(converter)
+          else
+            raise Glimmer::Error, "Unsupported bind converter: #{converter.inspect}"
+          end
+        elsif converter.respond_to?(:call, value)
+          converter.call(value)
+        else
+          raise Glimmer::Error, "Unsupported bind converter: #{converter.inspect}"
+        end
+      end
+
       # All nested property names
       # e.g. property name expression "address.state" gives ['address', 'state']
       # If there are any indexed property names, this returns indexes as properties.
@@ -95,10 +111,6 @@ module Glimmer
         [@binding_options[:computed_by]].flatten.compact
       end
 
-      def computed_binding_options
-        @binding_options.reject {|k,v| k == :computed_by}
-      end
-
       def nested_property_observers_for(observer)
         @nested_property_observers_collection ||= {}
         unless @nested_property_observers_collection.has_key?(observer)
@@ -121,7 +133,10 @@ module Glimmer
         elsif nested_property?
           add_nested_observers(observer)
         else
-          observer_registration = observer.observe(model, property_name)
+          model_binding_observer = Observer.proc do |new_value|
+            observer.call(evaluate_property)
+          end
+          observer_registration = model_binding_observer.observe(model, property_name)
           my_registration = observer.registration_for(self)
           observer.add_dependent(my_registration => observer_registration)
         end
@@ -183,7 +198,7 @@ module Glimmer
 
       def call(value)
         return if model.nil?
-        converted_value = PROPERTY_TYPE_CONVERTERS[@property_type].call(value)
+        converted_value = value
         invoke_property_writer(model, "#{property_name}=", converted_value) unless evaluate_property == converted_value
       end
 
@@ -200,21 +215,24 @@ module Glimmer
       end
 
       def property_indexed?(property_expression)
-        property_expression.start_with?('[')
+        property_expression.to_s.start_with?('[')
       end
 
       def invoke_property_reader(object, property_expression)
+        value = nil
         if property_indexed?(property_expression)
           property_method = '[]'
           property_argument = property_expression[1...-1]
           property_argument = property_argument.to_i if property_argument.match(/\d+/)
-          object.send(property_method, property_argument)
+          value = object.send(property_method, property_argument)
         else
-          object.send(property_expression)
+          value = object.send(property_expression)
         end
+        convert_on_read(value)
       end
 
       def invoke_property_writer(object, property_expression, value)
+        value = convert_on_write(value)
         if property_indexed?(property_expression)
           property_method = '[]='
           property_argument = property_expression[1...-2]

data/lib/glimmer/data_binding/observable_model.rb

@@ -76,7 +76,7 @@ module Glimmer
         end
       rescue => e
         # ignore writing if no property writer exists
-        Glimmer.logger.debug "No need to observe property writer: #{property_writer_name}\n#{e.message}\n#{e.backtrace.join("\n")}"
+        Glimmer.logger&.debug "No need to observe property writer: #{property_writer_name}\n#{e.message}\n#{e.backtrace.join("\n")}"
       end
 
       def unregister_dependent_observers(property_name, old_value)

data/lib/glimmer/data_binding/widget_binding.rb

@@ -15,8 +15,13 @@ module Glimmer
         @property = property
         @translator = translator || proc {|value| value}
 
-        @widget.on_widget_disposed do |dispose_event|
-          unregister_all_observables
+        begin
+          @widget.on_widget_disposed do |dispose_event|
+            unregister_all_observables
+          end
+        rescue => e
+          # No Op
+          Glimmer.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
         end
       end
       def call(value)

data/lib/glimmer/dsl/bind_expression.rb

@@ -11,8 +11,6 @@ module Glimmer
       def can_interpret?(parent, keyword, *args, &block)
         (
           keyword == 'bind' and
-            block.nil? and
-            widget?(parent) and
             (
               (
                 (args.size == 2) and
@@ -21,23 +19,16 @@ module Glimmer
                 (
                   (args.size == 3) and
                     textual?(args[1]) and
-                    (textual?(args[2]) or args[2].is_a?(Hash))
-                ) ||
-                (
-                  (args.size == 4) and
-                    textual?(args[1]) and
-                    textual?(args[2]) and
-                    (args[3].is_a?(Hash))
+                    (args[2].is_a?(Hash))
                 )
             )
         )
       end
 
       def interpret(parent, keyword, *args, &block)
-        property_type = args[2] if (args.size == 3) and !args[2].is_a?(Hash)
-        binding_options = args[2] if args[2].is_a?(Hash)
-        binding_options = args[3] if args[3].is_a?(Hash)
-        DataBinding::ModelBinding.new(args[0], args[1].to_s, property_type, binding_options)
+        binding_options = args[2] || {}
+        binding_options[:on_read] = binding_options.delete(:on_read) || binding_options.delete('on_read') || block
+        DataBinding::ModelBinding.new(args[0], args[1].to_s, binding_options)
       end
     end
   end

data/lib/glimmer/dsl/custom_widget_expression.rb

@@ -18,7 +18,7 @@ module Glimmer
 
       def interpret(parent, keyword, *args, &block)
         options = args.last.is_a?(Hash) ? args.pop : {}
-        Glimmer.logger.debug "Custom widget #{keyword} styles are: [" + args.inspect + "] and options are: #{options}"
+        Glimmer.logger&.debug "Custom widget #{keyword} styles are: [" + args.inspect + "] and options are: #{options}"
         UI::CustomWidget.for(keyword).new(parent, *args, options, &block)
       end
 

data/lib/glimmer/dsl/data_binding_expression.rb

@@ -14,8 +14,7 @@ module Glimmer
     class DataBindingExpression < Expression
       def can_interpret?(parent, keyword, *args, &block)
         args.size == 1 and
-        args[0].is_a?(DataBinding::ModelBinding) and
-        widget?(parent)
+        args[0].is_a?(DataBinding::ModelBinding)
       end
 
       def interpret(parent, keyword, *args, &block)
@@ -26,7 +25,7 @@ module Glimmer
         #TODO make this options observer dependent and all similar observers in widget specific data binding handlers
         widget_binding.observe(model_binding)
         # TODO simplify this logic and put it where it belongs
-        parent.add_observer(model_binding, keyword)
+        parent.add_observer(model_binding, keyword) if parent.respond_to?(:add_observer, [model_binding, keyword])
       end
     end
   end

data/lib/glimmer/dsl/engine.rb

@@ -27,7 +27,7 @@ module Glimmer
         # TODO rename to dynamic_expressions in the future when supporting static expressions
         def dynamic_expressions=(expression_names)
           @dynamic_expression_chain_of_responsibility = expression_names.reverse.reduce(nil) do |last_expresion_handler, expression_name|
-            Glimmer.logger.debug "Loading #{expression_class_name(expression_name)}..."
+            Glimmer.logger&.debug "Loading #{expression_class_name(expression_name)}..."
             expression = expression_class(expression_name).new
             expression_handler = ExpressionHandler.new(expression)
             expression_handler.next = last_expresion_handler if last_expresion_handler

data/lib/glimmer/dsl/expression_handler.rb

@@ -23,9 +23,9 @@ module Glimmer
       # Otherwise, it forwards to the next handler configured via `#next=` method
       # If there is no handler next, then it raises an error
       def handle(parent, keyword, *args, &block)
-        Glimmer.logger.debug "Attempting to handle #{keyword}(#{args}) with #{@expression.class.name.split(":").last}"
+        Glimmer.logger&.debug "Attempting to handle #{keyword}(#{args}) with #{@expression.class.name.split(":").last}"
         if @expression.can_interpret?(parent, keyword, *args, &block)
-          Glimmer.logger.debug "#{@expression.class.name} will handle expression keyword #{keyword} with arguments #{args}"
+          Glimmer.logger&.debug "#{@expression.class.name} will handle expression keyword #{keyword} with arguments #{args}"
           return @expression
         elsif @next_expression_handler
           return @next_expression_handler.handle(parent, keyword, *args, &block)
@@ -34,7 +34,7 @@ module Glimmer
           message = "Glimmer keyword #{keyword} with args #{args} cannot be handled"
           message += " inside parent #{parent.inspect}" if parent
           message += "! Check the validity of the code."
-          # Glimmer.logger.error message
+          # Glimmer.logger&.error message
           raise InvalidKeywordError, message
         end
       end

data/lib/glimmer/dsl/layout_data_expression.rb

@@ -16,7 +16,7 @@ module Glimmer
       end
 
       def interpret(parent, keyword, *args, &block)
-        Glimmer.logger.debug "Layout Data args are: #{args.inspect}"
+        Glimmer.logger&.debug "Layout Data args are: #{args.inspect}"
         SWT::LayoutDataProxy.new(parent, args)
       end
     end

data/lib/glimmer/dsl/layout_expression.rb

@@ -18,7 +18,7 @@ module Glimmer
       end
 
       def interpret(parent, keyword, *args, &block)
-        Glimmer.logger.debug "Layout #{keyword} args are: #{args.inspect}"
+        Glimmer.logger&.debug "Layout #{keyword} args are: #{args.inspect}"
         SWT::LayoutProxy.new(keyword, parent, args)
       end
     end

data/lib/glimmer/dsl/static_expression.rb

@@ -21,7 +21,7 @@ module Glimmer
           if !static_expression.can_interpret?(parent, keyword, *args, &block)
             raise Error, "Invalid use of Glimmer keyword #{keyword} with args #{args.inspect} under parent #{parent.inspect}"
           else
-            Glimmer.logger.debug "#{base.name} will handle expression keyword #{keyword} with arguments #{args}"
+            Glimmer.logger&.debug "#{base.name} will handle expression keyword #{keyword} with arguments #{args}"
             static_expression.interpret(parent, keyword, *args, &block).tap do |ui_object|
               Glimmer::DSL::Engine.add_content(ui_object, static_expression, &block) unless block.nil?
             end

data/lib/glimmer/dsl/tab_item_expression.rb

@@ -17,7 +17,7 @@ module Glimmer
           if parent.swt_widget.is_a?(TabFolder)
             return true
           else
-            Glimmer.logger.error "tab_item widget may only be used directly under a tab_folder widget!"
+            Glimmer.logger&.error "tab_item widget may only be used directly under a tab_folder widget!"
           end
         end
         false

data/lib/glimmer/dsl/widget_expression.rb

@@ -16,7 +16,7 @@ module Glimmer
       end
 
       def interpret(parent, keyword, *args, &block)
-        Glimmer.logger.debug "widget styles are: " + args.inspect
+        Glimmer.logger&.debug "widget styles are: " + args.inspect
         SWT::WidgetProxy.new(keyword, parent, args)
       end
     end

data/lib/glimmer/dsl/widget_listener_expression.rb

@@ -6,17 +6,19 @@ module Glimmer
       include_package 'org.eclipse.swt.widgets'
 
       def can_interpret?(parent, keyword, *args, &block)
-        Glimmer.logger.debug "keyword starts with on_: #{keyword.start_with?('on_')}"
-        return unless keyword.start_with?('on_')
-        Glimmer.logger.debug "block exists?: #{!block.nil?}"
-        return unless !block.nil?
+        Glimmer.logger&.debug "keyword starts with on_: #{keyword.start_with?('on_')}"
+        return false unless keyword.start_with?('on_')
         widget_parentage = widget?(parent)
-        Glimmer.logger.debug "parent is a widget: #{widget_parentage}"
-        return unless widget_parentage
-        Glimmer.logger.debug "args are empty?: #{args.empty?}"
-        return unless args.empty?
+        Glimmer.logger&.debug "parent is a widget: #{widget_parentage}"
+        return false unless widget_parentage
+        Glimmer.logger&.debug "block exists?: #{!block.nil?}"
+        raise Glimmer::Error, "Listener is missing block for keyword: #{keyword}" unless block_given?
+        Glimmer.logger&.debug "args are empty?: #{args.empty?}"
+        raise Glimmer::Error, "Invalid listener arguments for keyword: #{keyword}(#{args.inspect})" unless args.empty?
         result = parent.can_handle_observation_request?(keyword)
-        Glimmer.logger.debug "can add listener? #{result}"
+        Glimmer.logger&.debug "can add listener? #{result}"
+        raise Glimmer::Error, "Invalid listener keyword: #{keyword}" unless result
+        true
       end
 
       def interpret(parent, keyword, *args, &block)

data/lib/glimmer/swt/layout_data_proxy.rb

@@ -31,7 +31,7 @@ module Glimmer
         begin
           @swt_layout_data = swt_layout_data_class.new(*args)
         rescue => e
-          Glimmer.logger.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+          Glimmer.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
           @swt_layout_data = args.first if args.count == 1
         end
         @widget_proxy.swt_widget.setLayoutData(@swt_layout_data)
@@ -62,12 +62,23 @@ module Glimmer
 
       def set_attribute(attribute_name, *args)
         args = SWTProxy.constantify_args(args)
-        @swt_layout_data.send(attribute_setter(attribute_name), *args)
+        if args.first != @swt_layout_data.send(attribute_getter(attribute_name))
+          @swt_layout_data.send(attribute_setter(attribute_name), *args)
+          @widget_proxy.swt_widget.getShell.pack
+        end
+      end
+
+      def get_attribute(attribute_name)
+        @swt_layout_data.send(attribute_getter(attribute_name))
       end
 
       def attribute_setter(attribute_name)
         "#{attribute_name.to_s.camelcase(:lower)}="
       end
+
+      def attribute_getter(attribute_name)
+        "#{attribute_name.to_s.camelcase(:lower)}"
+      end
     end
   end
 end

data/lib/glimmer/swt/layout_proxy.rb

@@ -34,8 +34,8 @@ module Glimmer
           end
           swt_layout_class
         rescue => e
-          Glimmer.logger.debug e.message
-          # Glimmer.logger.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+          Glimmer.logger&.debug e.message
+          # Glimmer.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
           raise e
         end
       end
@@ -54,7 +54,15 @@ module Glimmer
 
       def set_attribute(attribute_name, *args)
         apply_property_type_converters(attribute_name, args)
-        @swt_layout.send(attribute_setter(attribute_name), *args)
+        if args.first != @swt_layout.send(attribute_getter(attribute_name))
+          @swt_layout.send(attribute_setter(attribute_name), *args)
+          @widget_proxy.swt_widget.getShell.pack
+          # TODO see if pack(true) is needed
+        end
+      end
+
+      def get_attribute(attribute_name)
+        @swt_layout.send(attribute_getter(attribute_name))
       end
 
       def apply_property_type_converters(attribute_name, args)
@@ -66,6 +74,10 @@ module Glimmer
       def attribute_setter(attribute_name)
         "#{attribute_name.to_s.camelcase(:lower)}="
       end
+
+      def attribute_getter(attribute_name)
+        "#{attribute_name.to_s.camelcase(:lower)}"
+      end
     end
   end
 end

data/lib/glimmer/swt/shell_proxy.rb

@@ -52,7 +52,6 @@ module Glimmer
           center
           @swt_widget.open
           start_event_loop
-          @display.dispose # TODO consider if it's more performant to reuse instead of disposing
         end
       end
       alias show open

data/lib/glimmer/swt/widget_proxy.rb

@@ -71,7 +71,7 @@ module Glimmer
           widget_custom_attribute[:setter][:invoker].call(@swt_widget, args)
         else
           apply_property_type_converters(attribute_name, args)
-          @swt_widget.send(attribute_setter(attribute_name), *args)
+          @swt_widget.send(attribute_setter(attribute_name), *args) unless @swt_widget.send(attribute_getter(attribute_name)) == args.first
         end
       end
 
@@ -129,17 +129,17 @@ module Glimmer
         swt_widget_name = underscored_widget_name.camelcase(:upper)
         swt_widget_class = eval(swt_widget_name)
         unless swt_widget_class.ancestors.include?(org.eclipse.swt.widgets.Widget)
-          Glimmer.logger.debug("Class #{swt_widget_class} matching #{underscored_widget_name} is not a subclass of org.eclipse.swt.widgets.Widget")
+          Glimmer.logger&.debug("Class #{swt_widget_class} matching #{underscored_widget_name} is not a subclass of org.eclipse.swt.widgets.Widget")
           return nil
         end
         swt_widget_class
       rescue NameError => e
-        Glimmer.logger.debug e.message
-        # Glimmer.logger.debug("#{e.message}\n#{e.backtrace.join("\n")}")
+        Glimmer.logger&.debug e.message
+        # Glimmer.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
         nil
       rescue => e
-        Glimmer.logger.debug e.message
-        # Glimmer.logger.debug("#{e.message}\n#{e.backtrace.join("\n")}")
+        Glimmer.logger&.debug e.message
+        # Glimmer.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
         nil
       end
 
@@ -325,6 +325,7 @@ module Glimmer
             value
           end
         end
+        # TODO consider detecting type on widget method and automatically invoking right converter (e.g. :to_s for String, :to_i for Integer)
         @property_type_converters ||= {
           :background => color_converter,
           :background_image => proc do |value|

data/lib/glimmer/ui/custom_widget.rb

@@ -35,7 +35,7 @@ module Glimmer
                 begin
                   result.const_get(namespace)
                 rescue => e
-                  # Glimmer.logger.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+                  # Glimmer.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
                   result
                 end
               end
@@ -45,8 +45,8 @@ module Glimmer
           raise "#{underscored_custom_widget_name} has no custom widget class!" if custom_widget_class.nil?
           custom_widget_class if custom_widget_class.ancestors.include?(Glimmer::UI::CustomWidget)
         rescue => e
-          Glimmer.logger.debug e.message
-          Glimmer.logger.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+          Glimmer.logger&.debug e.message
+          Glimmer.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
           nil
         end
 
@@ -127,7 +127,7 @@ module Glimmer
 
       def handle_observation_request(observation_request, &block)
         if observation_request.start_with?('on_updated_')
-          property = observation_request.sub(/^on_updated_/, '')
+          property = observation_request.sub(/^on_updated_/, '') # TODO look into eliminating duplication from above
           add_observer(DataBinding::Observer.proc(&block), property) if can_add_observer?(property)
         else
           body_root.handle_observation_request(observation_request, &block)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glimmer
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - AndyMaleh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-12 00:00:00.000000000 Z
+date: 2020-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -85,7 +85,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.0.0
+        version: 10.1.0
   name: rake
   type: :runtime
   prerelease: false
@@ -93,7 +93,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 10.0.0
+        version: 10.1.0
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements: