glimmer-dsl-swt 4.24.4.0 → 4.24.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81eb61402ae45b2e3782b9c10dc6b0374e39fb7f74351d2ed940719fbd6e4ec3
-  data.tar.gz: dfa93b670ddc363dd2dc602920d5e24510202b179f7e7740ee8abc50fc91eee4
+  metadata.gz: c0501a99ee5c020f5af90de5bef4b2de5649b71ecc72ef18c07cf7624e202cd2
+  data.tar.gz: 17f1582e1692df7535ff337c9994f4db60ebf85c1ebc2a1e34057f29218e6dfd
 SHA512:
-  metadata.gz: 46bee26330ce88284c85f263b0db58dda6dfb76cd2d2f37938c881f6567d74cd0a514565625a6c21da53b91e119fd31185dda8b22626e357fb79612e9013f6fe
-  data.tar.gz: '049762158e8e4015ec1a157edd148212078a106b753b9ad4f6111ab49746fe2934471382b4c5c20d9ee00a9abca8d8c22866c1c3ecd7aa733ccc5aeb28eb6c7b'
+  metadata.gz: c6653469f0356e6f8b26176cf1ed780b77a04288855c532c7f33cc0a6363e2674b79fb836cf9482cb7668d06002d8cfc097f73df7b9c1777b835ec231db37d76
+  data.tar.gz: 87f7266996c85bb845495032c41f84132a86c935a516f6a38a96a3b57904855096c00e522c6065124b881f6fbaff865066f7978fe64e392a168d91e4a4aa7abc

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 4.24.4.1
+
+- Optimize `table` data-binding performance (improving paging performance in `refined_table`) by making observer registrations run asynchronously in a separate thread
+- Fix cleaning of old `table` data-binding observers (it was retaining some old observers after table updates)
+- Fix issue with ActiveSupport overriding Facets String `underscore`/`snakecase`/`titlecase`/`camelcase` methods with different incompatible implementations when loaded by a project (now, that is repaired automatically)
+
 ## 4.24.4.0
 
 - Save `WidgetBinding` instances on `WidgetProxy` objects via `widget_bindings` attribute

data/README.md

@@ -1,4 +1,4 @@
-# [<img src="https://raw.githubusercontent.com/AndyObtiva/glimmer/master/images/glimmer-logo-hi-res.png" height=85 />](https://github.com/AndyObtiva/glimmer) Glimmer DSL for SWT 4.24.4.0
+# [<img src="https://raw.githubusercontent.com/AndyObtiva/glimmer/master/images/glimmer-logo-hi-res.png" height=85 />](https://github.com/AndyObtiva/glimmer) Glimmer DSL for SWT 4.24.4.1
 ## JRuby Desktop Development GUI Framework
 [![Gem Version](https://badge.fury.io/rb/glimmer-dsl-swt.svg)](http://badge.fury.io/rb/glimmer-dsl-swt)
 [![Travis CI](https://travis-ci.com/AndyObtiva/glimmer-dsl-swt.svg?branch=master)](https://travis-ci.com/github/AndyObtiva/glimmer-dsl-swt)
@@ -21,7 +21,7 @@ Featured in JRuby Cookbook](http://shop.oreilly.com/product/9780596519650.do) an
 
 ![Eclipse SWT RCP NASA Mars Rover](/images/glimmer-eclipse-swt-rcp-nasa-mars-rover.png)
 
-[Glimmer DSL for SWT](https://rubygems.org/gems/glimmer-dsl-swt) 4.24.4.0 includes [SWT 4.24](https://download.eclipse.org/eclipse/downloads/drops4/R-4.24-202206070700/), which was released on June 7, 2022. Gem version numbers are in sync with the SWT library versions. The first two digits represent the SWT version number. The last two digits represent the minor and patch versions of Glimmer DSL for SWT.
+[Glimmer DSL for SWT](https://rubygems.org/gems/glimmer-dsl-swt) 4.24.4.1 includes [SWT 4.24](https://download.eclipse.org/eclipse/downloads/drops4/R-4.24-202206070700/), which was released on June 7, 2022. Gem version numbers are in sync with the SWT library versions. The first two digits represent the SWT version number. The last two digits represent the minor and patch versions of Glimmer DSL for SWT.
 
 **Starting in version 4.20.0.0, [Glimmer DSL for SWT](https://rubygems.org/gems/glimmer-dsl-swt) comes with the new [***Shine***](/docs/reference/GLIMMER_GUI_DSL_SYNTAX.md#shine) syntax** for highly intuitive and visually expressive View/Model Attribute Mapping, relying on `<=>` for bidirectional (two-way) data-binding and `<=` for unidirectional (one-way) data-binding, providing an alternative to the `bind` keyword. That was [originally conceived back in 2007](https://andymaleh.blogspot.com/2007/12/data-shining-in-glimmer.html).
 
@@ -338,7 +338,7 @@ jgem install glimmer-dsl-swt
 
 Or this command if you want a specific version:
 ```
-jgem install glimmer-dsl-swt -v 4.24.4.0
+jgem install glimmer-dsl-swt -v 4.24.4.1
 ```
 
 `jgem` is JRuby's version of `gem` command.
@@ -366,7 +366,7 @@ Note: if you're using activerecord or activesupport, keep in mind that Glimmer u
 
 Add the following to `Gemfile`:
 ```
-gem 'glimmer-dsl-swt', '~> 4.24.4.0'
+gem 'glimmer-dsl-swt', '~> 4.24.4.1'
 ```
 
 And, then run:
@@ -389,7 +389,7 @@ glimmer
 ```
 
 ```
-Glimmer (JRuby Desktop Development GUI Framework) - JRuby Gem: glimmer-dsl-swt v4.24.4.0
+Glimmer (JRuby Desktop Development GUI Framework) - JRuby Gem: glimmer-dsl-swt v4.24.4.1
       
 Usage: glimmer [--bundler] [--pd] [--quiet] [--debug] [--log-level=VALUE] [[ENV_VAR=VALUE]...] [[-jruby-option]...] (application.rb or task[task_args]) [[application2.rb]...]
 

data/VERSION

@@ -1 +1 @@
-4.24.4.0
+4.24.4.1

data/docs/reference/GLIMMER_GUI_DSL_SYNTAX.md

@@ -58,7 +58,7 @@ This guide should help you get started with Glimmer DSL for SWT. For more advanc
       - [Table Selection](#table-selection)
       - [Table Editing](#table-editing)
       - [Table Sorting](#table-sorting)
-      - [Refined Table with Pagination](#refined-table-with-pagination)
+      - [Refined Table](#refined-table)
     - [Tree](#tree)
     - [DateTime](#datetime)
   - [Observer](#observer)
@@ -4111,8 +4111,8 @@ This automatically leverages the SWT TableEditor custom class behind the scenes,
 passed table item text into something else.
 It automatically persists the change to `items` data-bound model on ENTER/FOCUS-OUT or cancels on ESC/NO-CHANGE.
 
-Note that `table` is designed to expect about 100 rows only, not more than that, or otherwise it will not offer a user-friendly experience due to requiring users to scroll through a lot of data.
-If you need to display a table with more than 100 rows, then you need to employ pagination. That is already supported in the [Refined Table (`refined_table`)](#refined-table-with-pagination) custom widget documented below.
+Note that `table` is useful with a maximum of about 100 rows only, not more than that, or otherwise it will not offer a user-friendly experience due to requiring users to scroll through a lot of data.
+If you need to display a table with more than 100 rows, then you need to employ pagination. That is already supported in the [Refined Table (`refined_table`)](#refined-table) custom widget documented below.
 
 ##### Table Item Properties
 
@@ -4241,7 +4241,7 @@ shell {
 
 Check out [Hello, Table!](/docs/reference/GLIMMER_SAMPLES.md#hello-table) for an actual example including table editors.
 
-[Are We There Yet?](#are-we-there-yet) is an actual production Glimmer application that takes full advantage of table capabilities, storing model data in a database via ActiveRecord. As such, it's an excellent demonstration of how to use Glimmer DSL for SWT with a database.
+[Are We There Yet?](#are-we-there-yet) is an actual production Glimmer application that takes full advantage of table capabilities, storing model data in a database via ActiveRecord and SQLite DB. As such, it's an excellent demonstration of how to use Glimmer DSL for SWT with a database. [Contact Manager](https://github.com/AndyObtiva/contact_manager) is an external sample application that also utilizes a table with ActiveRecord and SQLite DB. It comes with a [blog post](https://andymaleh.blogspot.com/2022/06/using-activerecord-with-sqlite-db-in.html?m=0) that provides a step by step guide on how to build such an application.
 
 ##### Table Sorting
 
@@ -4307,19 +4307,19 @@ Here is an explanation of the example above:
 
 `<= [model, :property, read_only_sort: true]` could be used with items to make sorting not propagate sorting changes to model.
 
-##### Refined Table with Pagination
+##### Refined Table
 
 **(ALPHA FEATURE)**
 
 `refined_table` is a custom widget that can handle very large amounts of data by applying pagination.
 
-Just use like a standard `table`, but data-bind models to a `model_array` property instead of `items`. `refined_table` will take care of the rest.
+Just use like a standard `table`, but data-bind models to the `model_array` property instead of `items`. `refined_table` will take care of the rest.
 
 Options:
 - `per_page` (default: `10`): specifies how many rows to display per page
 - `page` (default: `1` if table is filled and `0` otherwise): specifies initial page
 
-Note that currently `refined_table` only supports displaying a **read-only** table (meaning it can read updates from the model, but it cannot write back to the model through table editing cells).
+Note that currently `refined_table` only supports displaying a **read-only** table (meaning it can read updates from the model, but it cannot write back to the model through `TableEditor` cells).
 
 Example taken from [Hello, Refined Table!](/docs/reference/GLIMMER_SAMPLES.md#hello-refined-table):
 

data/docs/reference/GLIMMER_SAMPLES.md

@@ -783,7 +783,7 @@ Hello, Table! Game Booked Rows
 
 #### Hello, Refined Table!
 
-This sample demonstrates the use of the [`refined_table` widget](/docs/reference/GLIMMER_GUI_DSL_SYNTAX.md#refined-table-with-pagination), which provides a paginated `table` that can handle very large amounts of data.
+This sample demonstrates the use of the [`refined_table` widget](/docs/reference/GLIMMER_GUI_DSL_SYNTAX.md#refined-table), which provides a paginated `table` that can handle very large amounts of data.
 
 Code:
 

data/lib/ext/glimmer.rb

@@ -27,6 +27,11 @@ module Glimmer
       if Object.const_defined?(:ActiveSupport) && ActiveSupport.const_defined?(:Dependencies)
         begin
           ActiveSupport::Dependencies.unhook!
+          # override activesupport string method implementations if already loaded
+          gem 'facets'
+          load 'facets/string/snakecase.rb'
+          load 'facets/string/titlecase.rb'
+          load 'facets/string/camelcase.rb'
         rescue => e
           # noop TODO support logging unimportant details below debug level
         end

data/lib/glimmer/data_binding/table_items_binding.rb

@@ -37,9 +37,12 @@ module Glimmer
       include_package 'org.eclipse.swt.widgets'
       
       TABLE_ITEM_PROPERTIES = %w[background foreground font image]
+      
+      attr_reader :data_binding_done
 
       def initialize(parent, model_binding, column_properties = nil)
         @table = parent.is_a?(Glimmer::SWT::TableProxy) ? parent : parent.body_root # assume custom widget in latter case
+        @table.table_items_binding = self
         @model_binding = model_binding
         @read_only_sort = @model_binding.binding_options[:read_only_sort]
         @table.editable = false if @model_binding.binding_options[:read_only]
@@ -81,31 +84,35 @@ module Glimmer
           else
             if new_model_collection and new_model_collection.is_a?(Array)
               @model_observer_registrations ||= {}
-              new_model_collection.each do |model|
-                @model_observer_registrations[model] ||= {}
-                @column_properties.each do |column_property|
-                  old_model_observer_registration = @model_observer_registrations[model][column_property]
-                  remove_dependent(@table_observer_registration => old_model_observer_registration) if old_model_observer_registration
-                  old_model_observer_registration&.unobserve
-                  model_observer_registration = observe(model, column_property)
-                  @model_observer_registrations[model][column_property] = model_observer_registration
-                  add_dependent(@table_observer_registration => model_observer_registration)
-                end
-              end
-
-              if !same_model_collection_with_different_sort?(new_model_collection)
-                new_model_collection.each do |model|
-                  TABLE_ITEM_PROPERTIES.each do |table_item_property|
+              @table_item_property_observation_mutex ||= Mutex.new
+              
+              Thread.new do
+                @data_binding_done = false
+                @table_item_property_observation_mutex.synchronize do
+                  deregister_model_observer_registrations
+                
+                  new_model_collection.each_with_index do |model, model_index|
+                    @model_observer_registrations[model_index] ||= {}
                     @column_properties.each do |column_property|
-                      column_property = "#{column_property}_#{table_item_property}"
-                      old_model_observer_registration = @model_observer_registrations[model][column_property]
-                      remove_dependent(@table_observer_registration => old_model_observer_registration) if old_model_observer_registration
-                      old_model_observer_registration&.unobserve
                       model_observer_registration = observe(model, column_property)
-                      @model_observer_registrations[model][column_property] = model_observer_registration
+                      @model_observer_registrations[model_index][column_property] = model_observer_registration
                       add_dependent(@table_observer_registration => model_observer_registration)
                     end
                   end
+    
+                  if !same_model_collection_with_different_sort?(new_model_collection)
+                    new_model_collection.each_with_index do |model, model_index|
+                      TABLE_ITEM_PROPERTIES.each do |table_item_property|
+                        @column_properties.each do |column_property|
+                          column_property = "#{column_property}_#{table_item_property}"
+                          model_observer_registration = observe(model, column_property)
+                          @model_observer_registrations[model_index][column_property] = model_observer_registration
+                          add_dependent(@table_observer_registration => model_observer_registration)
+                        end
+                      end
+                    end
+                  end
+                  @data_binding_done = true
                 end
               end
               
@@ -211,7 +218,24 @@ module Glimmer
       end
       
       def table_item_model_collection
-        @table.swt_widget.items.map(&:get_data)
+        Glimmer::SWT::DisplayProxy.instance.auto_exec do
+          if @table.disposed?
+            []
+          else
+            @table.swt_widget.items.map(&:get_data)
+          end
+        end
+      end
+      
+      def deregister_model_observer_registrations
+        @model_observer_registrations&.dup&.each do |model_index, model_column_properties|
+          model_column_properties.dup.each do |column_property, model_observer_registration|
+            remove_dependent(@table_observer_registration => model_observer_registration) if model_observer_registration
+            model_observer_registration&.unobserve
+            model_column_properties.delete(column_property)
+          end
+          @model_observer_registrations.delete(model_index)
+        end
       end
       
       def model_collection_attribute_values(model_collection)

data/lib/glimmer/swt/table_proxy.rb

@@ -247,6 +247,7 @@ module Glimmer
       
       attr_reader :table_editor, :table_editor_widget_proxy, :sort_property, :sort_direction, :sort_block, :sort_type, :sort_by_block, :additional_sort_properties, :editor, :editable
       attr_writer :column_properties
+      attr_accessor :table_items_binding
       alias column_attributes= column_properties=
       alias editable? editable
       

data/samples/elaborate/contact_manager.rb

@@ -122,7 +122,7 @@ class ContactManager
           }
         }
 
-        table(:editable, :multi) { |table_proxy|
+        table(:editable, :border) { |table_proxy|
           layout_data {
             horizontal_alignment :fill
             vertical_alignment :fill

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glimmer-dsl-swt
 version: !ruby/object:Gem::Version
-  version: 4.24.4.0
+  version: 4.24.4.1
 platform: ruby
 authors:
 - Andy Maleh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-05 00:00:00.000000000 Z
+date: 2022-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -344,17 +344,17 @@ dependencies:
         version: 0.14.1.cr2
 description: Glimmer DSL for SWT (JRuby Desktop Development GUI Framework) is a native-GUI
   cross-platform desktop development library written in JRuby, an OS-threaded faster
-  JVM version of Ruby. It includes SWT 4.22 (released November 24, 2021). Glimmer's
-  main innovation is a declarative Ruby DSL that enables productive and efficient
-  authoring of desktop application user-interfaces by relying on the robust Eclipse
-  SWT library. Glimmer additionally innovates by having built-in data-binding support,
-  which greatly facilitates synchronizing the GUI with domain models, thus achieving
-  true decoupling of object oriented components and enabling developers to solve business
-  problems (test-first) without worrying about GUI concerns, or alternatively drive
-  development GUI-first, and then write clean business models (test-first) afterwards.
-  Not only does Glimmer provide a large set of GUI widgets, but it also supports drawing
-  Canvas Graphics like Shapes and Animations. To get started quickly, Glimmer offers
-  scaffolding options for Apps, Gems, and Custom Widgets. Glimmer also includes native-executable
+  JVM version of Ruby. It includes SWT 4.24 (released June 7, 2022). Glimmer's main
+  innovation is a declarative Ruby DSL that enables productive and efficient authoring
+  of desktop application user-interfaces by relying on the robust Eclipse SWT library.
+  Glimmer additionally innovates by having built-in data-binding support, which greatly
+  facilitates synchronizing the GUI with domain models, thus achieving true decoupling
+  of object oriented components and enabling developers to solve business problems
+  (test-first) without worrying about GUI concerns, or alternatively drive development
+  GUI-first, and then write clean business models (test-first) afterwards. Not only
+  does Glimmer provide a large set of GUI widgets, but it also supports drawing Canvas
+  Graphics like Shapes and Animations. To get started quickly, Glimmer offers scaffolding
+  options for Apps, Gems, and Custom Widgets. Glimmer also includes native-executable
   packaging support, sorely lacking in other libraries, thus enabling the delivery
   of desktop apps written in Ruby as truly native DMG/PKG/APP files on the Mac, MSI/EXE
   files on Windows, and DEB/RPM files on Linux. Glimmer was the first Ruby gem to