glimmer-dsl-swt 0.3.0 → 0.5.1

data/lib/glimmer/swt/layout_data_proxy.rb

@@ -31,7 +31,7 @@ module Glimmer
         begin
           @swt_layout_data = swt_layout_data_class.new(*args)
         rescue => e
-          Glimmer::Config.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+          Glimmer::Config.logger.debug {"#{e.message}\n#{e.backtrace.join("\n")}"}
           @swt_layout_data = args.first if args.count == 1
         end
         @widget_proxy.swt_widget.setLayoutData(@swt_layout_data)

data/lib/glimmer/swt/layout_proxy.rb

@@ -34,8 +34,8 @@ module Glimmer
           end
           swt_layout_class
         rescue => e
-          Glimmer::Config.logger&.debug e.message
-          # Glimmer::Config.logger&.debug "#{e.message}\n#{e.backtrace.join("\n")}"
+          Glimmer::Config.logger.debug {e.message}
+          # Glimmer::Config.logger.debug {"#{e.message}\n#{e.backtrace.join("\n")}"}
           raise e
         end
       end

data/lib/glimmer/swt/message_box_proxy.rb

@@ -15,11 +15,13 @@ module Glimmer
       
       def initialize(parent, style)
         parent = parent.swt_widget if parent.respond_to?(:swt_widget) && parent.swt_widget.is_a?(Shell)
+        @temporary_parent = parent = Glimmer::SWT::ShellProxy.new.swt_widget if parent.nil?
         @swt_widget = MessageBox.new(parent, style)
       end
       
       def open
         @swt_widget.open
+        @temporary_parent&.dispose
       end
       
       # TODO refactor the following methods to put in a JavaBean mixin or somethin (perhaps contribute to OSS project too)

data/lib/glimmer/swt/shell_proxy.rb

@@ -40,9 +40,10 @@ module Glimmer
           end
           args = args.compact
           @swt_widget = Shell.new(*args)
+          @swt_widget.set_data('proxy', self)
           @swt_widget.setLayout(FillLayout.new)
           @swt_widget.setMinimumSize(WIDTH_MIN, HEIGHT_MIN)
-          on_event_show do
+          on_swt_show do
             Thread.new do      
               sleep(0.25)
               async_exec do
@@ -83,10 +84,6 @@ module Glimmer
         @swt_widget.setVisible(false)
       end
 
-      def close
-        @swt_widget.close
-      end
-
       def visible?
         @swt_widget.isDisposed ? false : @swt_widget.isVisible
       end
@@ -130,7 +127,11 @@ module Glimmer
       # This method is not needed except in rare circumstances where there is a need to start the SWT Event Loop before opening the shell.
       def start_event_loop
         until @swt_widget.isDisposed
-          @display.sleep unless @display.readAndDispatch
+          begin
+            @display.sleep unless @display.readAndDispatch
+          rescue => e
+            Glimmer::Config.logger.debug {e.full_message}
+          end
         end
       end
 
@@ -140,9 +141,9 @@ module Glimmer
           visibility_notifier = proc do
             observer.call(visible?)
           end
-          on_event_show(&visibility_notifier)
-          on_event_hide(&visibility_notifier)
-          on_event_close(&visibility_notifier)
+          on_swt_show(&visibility_notifier)
+          on_swt_hide(&visibility_notifier)
+          on_swt_close(&visibility_notifier)
         else
           super
         end

data/lib/glimmer/swt/style_constantizable.rb

@@ -61,12 +61,12 @@ module Glimmer
           negative ? ~bit_value : bit_value
         rescue => e
           begin
-#             Glimmer::Config.logger&.debug(e.full_message)
+#             Glimmer::Config.logger.debug {e.full_message}
             alternative_swt_constant_symbol = constant_source_class.constants.find {|c| c.to_s.upcase == swt_constant_symbol.to_s.upcase}
             bit_value = constant_source_class.const_get(alternative_swt_constant_symbol)
             negative ? ~bit_value : bit_value
           rescue => e
-#             Glimmer::Config.logger&.debug(e.full_message)
+#             Glimmer::Config.logger.debug {e.full_message}
             bit_value = extra_styles[swt_constant_symbol]
             if bit_value
               negative ? ~bit_value : bit_value

data/lib/glimmer/swt/table_column_proxy.rb

@@ -3,7 +3,7 @@ require 'glimmer/swt/widget_proxy'
 module Glimmer
   module SWT
     class TableColumnProxy < Glimmer::SWT::WidgetProxy    
-      attr_reader :no_sort, :sort_property
+      attr_reader :no_sort, :sort_property, :editor
       alias no_sort? no_sort
       attr_accessor :sort_block, :sort_by_block
       
@@ -19,6 +19,10 @@ module Glimmer
         @sort_property = args unless args.empty?
       end
       
+      def editor=(args)
+        @editor = args
+      end
+      
     end
   end
 end

data/lib/glimmer/swt/table_proxy.rb

@@ -1,4 +1,4 @@
-  require 'glimmer/swt/widget_proxy'
+require 'glimmer/swt/widget_proxy'
 
 module Glimmer
   module SWT
@@ -23,8 +23,8 @@ module Glimmer
         def find_table_item_and_column_index
           {}.tap do |result|
             if respond_to?(:x) && respond_to?(:y)
-              result[:table_item] = widget.getItems.detect do |ti|
-                result[:column_index] = widget.getColumnCount.times.to_a.detect do |ci|
+              result[:table_item] = widget.items.detect do |ti|
+                result[:column_index] = widget.column_count.times.to_a.detect do |ci|
                   ti.getBounds(ci).contains(x, y)
                 end
               end
@@ -33,7 +33,61 @@ module Glimmer
         end   
       end
       
-      attr_reader :table_editor, :table_editor_text_proxy, :sort_property, :sort_direction, :sort_block, :sort_type, :sort_by_block, :additional_sort_properties
+      class << self
+        def editors
+          @editors ||= {
+            text: {
+              widget_value_property: :text,
+              editor_gui: lambda do |args, model, property, table_proxy|
+                table_proxy.table_editor.minimumHeight = 20
+                table_editor_widget_proxy = text(*args) {
+                  text model.send(property)
+                  focus true
+                  on_focus_lost {
+                    table_proxy.finish_edit!
+                  }
+                  on_key_pressed { |key_event|
+                    if key_event.keyCode == swt(:cr)
+                      table_proxy.finish_edit!
+                    elsif key_event.keyCode == swt(:esc)
+                      table_proxy.cancel_edit!
+                    end
+                  }              
+                }
+                table_editor_widget_proxy.swt_widget.selectAll          
+                table_editor_widget_proxy
+              end,
+            },
+            combo: {
+              widget_value_property: :text,
+              editor_gui: lambda do |args, model, property, table_proxy|
+                table_proxy.table_editor.minimumHeight = 25
+                table_editor_widget_proxy = combo(*args) {
+                  items model.send("#{property}_options")
+                  text model.send(property)
+                  focus true
+                  on_focus_lost {
+                    table_proxy.finish_edit!
+                  }
+                  on_key_pressed { |key_event|
+                    if key_event.keyCode == swt(:cr)
+                      table_proxy.finish_edit!
+                    elsif key_event.keyCode == swt(:esc)
+                      table_proxy.cancel_edit!
+                    end
+                  }
+                  on_widget_selected {
+                    table_proxy.finish_edit!
+                  }
+                }
+                table_editor_widget_proxy
+              end,
+            }
+          }      
+        end
+      end
+      
+      attr_reader :table_editor, :table_editor_widget_proxy, :sort_property, :sort_direction, :sort_block, :sort_type, :sort_by_block, :additional_sort_properties, :editor
       attr_accessor :column_properties
       
       def initialize(underscored_widget_name, parent, args)
@@ -46,7 +100,7 @@ module Glimmer
 
       def model_binding
         swt_widget.data
-      end      
+      end
       
       def sort_by_column(table_column_proxy)
         index = swt_widget.columns.to_a.index(table_column_proxy.swt_widget)
@@ -100,6 +154,10 @@ module Glimmer
         @additional_sort_properties = args unless args.empty?
       end
       
+      def editor=(args)
+        @editor = args
+      end 
+      
       def sort
         return unless sort_property && (sort_type || sort_block || sort_by_block)
         array = model_binding.evaluate_property
@@ -152,6 +210,14 @@ module Glimmer
         })
       end
       
+      def post_initialize_child(table_column_proxy)
+        table_column_proxies << table_column_proxy
+      end
+      
+      def table_column_proxies
+        @table_column_proxies ||= []
+      end
+      
       # Indicates if table is in edit mode, thus displaying a text widget for a table item cell
       def edit_mode?
         !!@edit_mode
@@ -177,58 +243,62 @@ module Glimmer
             
       def edit_table_item(table_item, column_index, before_write: nil, after_write: nil, after_cancel: nil)
         return if table_item.nil?
+        model = table_item.data
+        property = column_properties[column_index]
         @cancel_edit&.call if @edit_mode
+        action_taken = false
         @edit_mode = true
-        content {
-          @table_editor_text_proxy = text {
-            focus true
-            text table_item.getText(column_index)
-            action_taken = false
-            @cancel_edit = lambda do
-              @cancel_in_progress = true
-              @table_editor_text_proxy&.swt_widget&.dispose
-              @table_editor_text_proxy = nil
-              after_cancel&.call
+        
+        editor_config = table_column_proxies[column_index].editor || editor
+        editor_config = editor_config.to_a
+        editor_widget_options = editor_config.last.is_a?(Hash) ? editor_config.last : {}
+        editor_widget_arg_last_index = editor_config.last.is_a?(Hash) ? -2 : -1
+        editor_widget = editor_config[0] || :text
+        editor_widget_args = editor_config[1..editor_widget_arg_last_index]
+        model_editing_property = editor_widget_options[:property] || property
+        widget_value_property = TableProxy::editors[editor_widget][:widget_value_property]
+        
+        @cancel_edit = lambda do |event=nil|
+          @cancel_in_progress = true
+          @table_editor_widget_proxy&.swt_widget&.dispose
+          @table_editor_widget_proxy = nil
+          after_cancel&.call
+          @edit_in_progress = false
+          @cancel_in_progress = false
+          @cancel_edit = nil
+          @edit_mode = false
+        end
+        
+        @finish_edit = lambda do |event=nil|
+          new_value = @table_editor_widget_proxy&.swt_widget&.send(widget_value_property)
+          if table_item.isDisposed
+            @cancel_edit.call
+          elsif new_value && !action_taken && !@edit_in_progress && !@cancel_in_progress
+            action_taken = true
+            @edit_in_progress = true
+            if new_value == model.send(model_editing_property)
+              @cancel_edit.call
+            else
+              before_write&.call
+              model.send("#{model_editing_property}=", new_value) # makes table update itself, so must search for selected table item again
+              # Table refresh happens here because of model update triggering observers, so must retrieve table item again
+              edited_table_item = search { |ti| ti.getData == model }.first
+              swt_widget.showItem(edited_table_item)
+              @table_editor_widget_proxy&.swt_widget&.dispose
+              @table_editor_widget_proxy = nil
+              after_write&.call(edited_table_item)              
               @edit_in_progress = false
-              @cancel_in_progress = false
-              @cancel_edit = nil
-              @edit_mode = false
-            end
-            @finish_edit = lambda do |event=nil|
-              if table_item.isDisposed
-                @cancel_edit.call
-              elsif !action_taken && !@edit_in_progress && !@cancel_in_progress
-                action_taken = true
-                @edit_in_progress = true
-                new_text = @table_editor_text_proxy.swt_widget.getText
-                if new_text == table_item.getText(column_index)
-                  @cancel_edit.call
-                else
-                  before_write&.call
-                  table_item.setText(column_index, new_text)
-                  model = table_item.getData
-                  model.send("#{column_properties[column_index]}=", new_text) # makes table update itself, so must search for selected table item again
-                  edited_table_item = search { |ti| ti.getData == model }.first
-                  swt_widget.showItem(edited_table_item)
-                  @table_editor_text_proxy&.swt_widget&.dispose
-                  @table_editor_text_proxy = nil
-                  after_write&.call(edited_table_item)
-                  @edit_in_progress = false
-                end
-              end
             end
-            on_focus_lost(&@finish_edit)
-            on_key_pressed { |key_event|
-              if key_event.keyCode == swt(:cr)
-                @finish_edit.call(key_event)
-              elsif key_event.keyCode == swt(:esc)
-                @cancel_edit.call
-              end
-            }
-          }
-          @table_editor_text_proxy.swt_widget.selectAll
+          end
+        end
+
+        content { 
+          @table_editor_widget_proxy = TableProxy::editors[editor_widget][:editor_gui].call(editor_widget_args, model, model_editing_property, self)
         }
-        @table_editor.setEditor(@table_editor_text_proxy.swt_widget, table_item, column_index)
+        @table_editor.setEditor(@table_editor_widget_proxy.swt_widget, table_item, column_index)
+      rescue => e
+        Glimmer::Config.logger.error {e.full_message}
+        raise e
       end
       
       def add_listener(underscored_listener_name, &block)

data/lib/glimmer/swt/widget_proxy.rb

@@ -3,7 +3,6 @@ require 'glimmer/swt/color_proxy'
 require 'glimmer/swt/font_proxy'
 require 'glimmer/swt/swt_proxy'
 require 'glimmer/swt/dnd_proxy'
-require 'glimmer/data_binding/observable_widget'
 
 # TODO refactor to make file smaller and extract sub-widget-proxies out of this
 
@@ -20,11 +19,10 @@ module Glimmer
     # Follows the Proxy Design Pattern
     class WidgetProxy
       include Packages
-      include DataBinding::ObservableWidget
 
       DEFAULT_STYLES = {
         "text"        => [:border],
-        "table"       => [:border],
+        "table"       => [:virtual, :border],
         "tree"       =>  [:virtual, :border, :h_scroll, :v_scroll],
         "spinner"     => [:border],
         "styled_text" => [:border],
@@ -60,6 +58,7 @@ module Glimmer
         styles, extra_options = extract_args(underscored_widget_name, args)
         swt_widget_class = self.class.swt_widget_class_for(underscored_widget_name)
         @swt_widget = swt_widget_class.new(parent.swt_widget, style(underscored_widget_name, styles), *extra_options)
+        @swt_widget.set_data('proxy', self)
         DEFAULT_INITIALIZERS[underscored_widget_name]&.call(@swt_widget)
         parent.post_initialize_child(self)
       end
@@ -176,44 +175,44 @@ module Glimmer
               }
             end,
             :caret_position => lambda do |observer|
-              on_event_keydown { |event|
+              on_swt_keydown { |event|
                 observer.call(@swt_widget.getCaretPosition)
               }
-              on_event_keyup { |event|
+              on_swt_keyup { |event|
                 observer.call(@swt_widget.getCaretPosition)
               }
-              on_event_mousedown { |event|
+              on_swt_mousedown { |event|
                 observer.call(@swt_widget.getCaretPosition)
               }
-              on_event_mouseup { |event|
+              on_swt_mouseup { |event|
                 observer.call(@swt_widget.getCaretPosition)
               }
             end,
             :selection => lambda do |observer|
-              on_event_keydown { |event|
+              on_swt_keydown { |event|
                 observer.call(@swt_widget.getSelection)
               }
-              on_event_keyup { |event|
+              on_swt_keyup { |event|
                 observer.call(@swt_widget.getSelection)
               }
-              on_event_mousedown { |event|
+              on_swt_mousedown { |event|
                 observer.call(@swt_widget.getSelection)
               }
-              on_event_mouseup { |event|
+              on_swt_mouseup { |event|
                 observer.call(@swt_widget.getSelection)
               }
             end,
             :selection_count => lambda do |observer|
-              on_event_keydown { |event|
+              on_swt_keydown { |event|
                 observer.call(@swt_widget.getSelectionCount)
               }
-              on_event_keyup { |event|
+              on_swt_keyup { |event|
                 observer.call(@swt_widget.getSelectionCount)
               }
-              on_event_mousedown { |event|
+              on_swt_mousedown { |event|
                 observer.call(@swt_widget.getSelectionCount)
               }
-              on_event_mouseup { |event|
+              on_swt_mouseup { |event|
                 observer.call(@swt_widget.getSelectionCount)
               }
             end,
@@ -267,17 +266,17 @@ module Glimmer
         swt_widget_name = underscored_widget_name.camelcase(:upper)
         swt_widget_class = eval(swt_widget_name)
         unless swt_widget_class.ancestors.include?(org.eclipse.swt.widgets.Widget)
-          Glimmer::Config.logger&.debug("Class #{swt_widget_class} matching #{underscored_widget_name} is not a subclass of org.eclipse.swt.widgets.Widget")
+          Glimmer::Config.logger.debug {"Class #{swt_widget_class} matching #{underscored_widget_name} is not a subclass of org.eclipse.swt.widgets.Widget"}
           return nil
         end
         swt_widget_class
-      rescue NameError => e
-        Glimmer::Config.logger&.debug e.full_message
-        # Glimmer::Config.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
+      rescue SyntaxError, NameError => e
+        Glimmer::Config.logger.debug {e.full_message}
+        # Glimmer::Config.logger.debug {"#{e.message}\n#{e.backtrace.join("\n")}"}
         nil
       rescue => e
-        Glimmer::Config.logger&.debug e.full_message
-        # Glimmer::Config.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
+        Glimmer::Config.logger.debug {e.full_message}
+        # Glimmer::Config.logger.debug {"#{e.message}\n#{e.backtrace.join("\n")}"}
         nil
       end
 
@@ -336,10 +335,10 @@ module Glimmer
       
       # TODO eliminate duplication in the following methods perhaps by relying on exceptions
 
-      def can_handle_observation_request?(observation_request)
+      def can_handle_observation_request?(observation_request)        
         observation_request = observation_request.to_s
-        if observation_request.start_with?('on_event_')
-          constant_name = observation_request.sub(/^on_event_/, '')
+        if observation_request.start_with?('on_swt_')
+          constant_name = observation_request.sub(/^on_swt_/, '')
           SWTProxy.has_constant?(constant_name)
         elsif observation_request.start_with?('on_')
           event = observation_request.sub(/^on_/, '')
@@ -357,6 +356,9 @@ module Glimmer
             @drag_source_proxy = nil
           end
         end
+      rescue => e
+        Glimmer::Config.logger.debug {e.full_message}
+        false        
       end
 
       def can_handle_drop_observation_request?(observation_request)
@@ -372,8 +374,9 @@ module Glimmer
       end
 
       def handle_observation_request(observation_request, &block)
-        if observation_request.start_with?('on_event_')
-          constant_name = observation_request.sub(/^on_event_/, '')
+        observation_request = observation_request.to_s
+        if observation_request.start_with?('on_swt_')
+          constant_name = observation_request.sub(/^on_swt_/, '')
           add_swt_event_listener(constant_name, &block)
         elsif observation_request.start_with?('on_')
           event = observation_request.sub(/^on_/, '')
@@ -392,6 +395,23 @@ module Glimmer
         Glimmer::DSL::Engine.add_content(self, Glimmer::DSL::SWT::WidgetExpression.new, &block)
       end
 
+      def method_missing(method, *args, &block)
+        if can_handle_observation_request?(method)          
+          handle_observation_request(method, &block)
+        else
+          swt_widget.send(method, *args, &block)
+        end
+      rescue => e
+        Glimmer::Config.logger.debug {"Neither WidgetProxy nor #{swt_widget.class.name} can handle the method ##{method}"}
+        super
+      end
+      
+      def respond_to?(method, *args, &block)
+        super || 
+          can_handle_observation_request?(method) ||
+          swt_widget.respond_to?(method, *args, &block)
+      end
+
       private
 
       def style(underscored_widget_name, styles)
@@ -437,7 +457,7 @@ module Glimmer
       def add_listener(underscored_listener_name, &block)
         widget_add_listener_method, listener_class, listener_method = self.class.find_listener(@swt_widget.getClass, underscored_listener_name)        
         widget_listener_proxy = nil
-        safe_block = lambda { |event| block.call(event) unless @swt_widget.isDisposed }        
+        safe_block = lambda { |*args| block.call(*args) unless @swt_widget.isDisposed }        
         listener = listener_class.new(listener_method => safe_block)
         @swt_widget.send(widget_add_listener_method, listener)
         widget_listener_proxy = WidgetListenerProxy.new(swt_widget: @swt_widget, swt_listener: listener, widget_add_listener_method: widget_add_listener_method, swt_listener_class: listener_class, swt_listener_method: listener_method)
@@ -479,9 +499,9 @@ module Glimmer
             listener_class.define_method('initialize') do |event_method_block_mapping|
               @event_method_block_mapping = event_method_block_mapping
             end
-            listener_type.getMethods.each do |event_method|
-              listener_class.define_method(event_method.getName) do |event|
-                @event_method_block_mapping[event_method.getName]&.call(event)
+            listener_type.getMethods.each do |event_method|              
+              listener_class.define_method(event_method.getName) do |*args|
+                @event_method_block_mapping[event_method.getName]&.call(*args)
               end
             end
           end
@@ -492,7 +512,7 @@ module Glimmer
       def add_swt_event_listener(swt_constant, &block)
         event_type = SWTProxy[swt_constant]
         widget_listener_proxy = nil
-        safe_block = lambda { |event| block.call(event) unless @swt_widget.isDisposed }
+        safe_block = lambda { |*args| block.call(*args) unless @swt_widget.isDisposed }
         @swt_widget.addListener(event_type, &safe_block)
         widget_listener_proxy = WidgetListenerProxy.new(swt_widget: @swt_widget, swt_listener: @swt_widget.getListeners(event_type).last, event_type: event_type, swt_constant: swt_constant)
       end
@@ -579,7 +599,7 @@ module Glimmer
               end
               image_data = ImageData.new(value)
               # TODO in the future, look into unregistering this listener when no longer needed
-              on_event_Resize do |resize_event|
+              on_swt_Resize do |resize_event|
                 new_image_data = image_data.scaledTo(@swt_widget.getSize.x, @swt_widget.getSize.y)
                 @swt_widget.getBackgroundImage&.dispose
                 @swt_widget.setBackgroundImage(Image.new(@swt_widget.getDisplay, new_image_data))