glimmer-dsl-swt 0.2.1 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d324a6327e85a840d2a980ba78a47fa9c50e927b409f128c60d9b2ac38f2124
-  data.tar.gz: ace770a87429cbaca623310837618e14f12e8375221c433751e1feb13e768eff
+  metadata.gz: ce119763646f3e3ccc0211534317572ed02c5d21b9820387dec34d83b714e50f
+  data.tar.gz: 1c4486c574ab3e8d30957133b9aab200dcfbdea10ea1c4aa0279a4991f80a0dd
 SHA512:
-  metadata.gz: 0d7e8c740b9fb6a8993e906a485cdc50241ea5a12664ff4f9ec128de2b2f77ad9718ae41fb0e9bd391546127273769769a1ac259870f2327bd29bba18d40afe3
-  data.tar.gz: 56406b25d9ab52e5af2043f33860cbd8cc0a5681b4e7eeba77325122c71cf9897c7bcd6f19ea68e3b3171f1e0dfa07c8d8dc501297fce2e8c83cc37ba3ed024b
+  metadata.gz: cea6c2e7ac8920d4ae87e447f08c7a622fc8851827b76160dc07b36d8c725911bf94a772aa5f47e43465a24961f7dc38b1d974a164ec3704d159dee61deb7712
+  data.tar.gz: 8efbb95213218c052cbcc8165dc2305c41f26a42f1a374ba05fd9b5912c3a79bfbb99522a524c8cc0fa88b128c471ab22e03fb75a750b7dd31708617b4c6b4cf

data/README.md

@@ -1,4 +1,4 @@
-# <img src="https://raw.githubusercontent.com/AndyObtiva/glimmer/master/images/glimmer-logo-hi-res.png" height=85 /> Glimmer DSL for SWT 0.2.1 (Desktop GUI)
+# <img src="https://raw.githubusercontent.com/AndyObtiva/glimmer/master/images/glimmer-logo-hi-res.png" height=85 /> Glimmer DSL for SWT 0.3.1 (Desktop GUI)
 [![Gem Version](https://badge.fury.io/rb/glimmer-dsl-swt.svg)](http://badge.fury.io/rb/glimmer-dsl-swt)
 [![Travis CI](https://travis-ci.com/AndyObtiva/glimmer-dsl-swt.svg?branch=master)](https://travis-ci.com/github/AndyObtiva/glimmer-dsl-swt)
 [![Coverage Status](https://coveralls.io/repos/github/AndyObtiva/glimmer-dsl-swt/badge.svg?branch=master)](https://coveralls.io/github/AndyObtiva/glimmer-dsl-swt?branch=master)
@@ -10,7 +10,7 @@
 
 You may find full setup/usage instructions at the main [Glimmer project page](https://github.com/AndyObtiva/glimmer).
 
-Other Glimmer DSL gems:
+Other [Glimmer](https://github.com/AndyObtiva/glimmer) DSL gems:
 - [glimmer-dsl-opal](https://github.com/AndyObtiva/glimmer-dsl-opal): Glimmer DSL for Opal (Web GUI Adapter for Desktop Apps)
 - [glimmer-dsl-xml](https://github.com/AndyObtiva/glimmer-dsl-xml): Glimmer DSL for XML (& HTML)
 - [glimmer-dsl-css](https://github.com/AndyObtiva/glimmer-dsl-css): Glimmer DSL for CSS (Cascading Style Sheets)

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.3.1

data/lib/glimmer/data_binding/table_items_binding.rb

@@ -15,6 +15,7 @@ module Glimmer
       def initialize(parent, model_binding, column_properties)
         @table = parent
         @model_binding = model_binding
+        @table.swt_widget.data = @model_binding
         @column_properties = column_properties
         if @table.respond_to?(:column_properties=)
           @table.column_properties = @column_properties

data/lib/glimmer/dsl/swt/block_property_expression.rb

@@ -0,0 +1,20 @@
+require 'glimmer/dsl/expression'
+
+module Glimmer
+  module DSL
+    module SWT
+      class BlockPropertyExpression < Expression
+        def can_interpret?(parent, keyword, *args, &block)
+          block_given? and
+            args.size == 0 and
+            parent.respond_to?("#{keyword}_block=")
+        end
+  
+        def interpret(parent, keyword, *args, &block)
+          parent.send("#{keyword}_block=", block)
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/glimmer/dsl/swt/combo_selection_data_binding_expression.rb

@@ -35,6 +35,10 @@ module Glimmer
           parent.on_widget_selected do
             model_binding.call(widget_binding.evaluate_property)
           end
+          
+          parent.on_modify_text do
+            model_binding.call(widget_binding.evaluate_property)
+          end
         end
       end
     end

data/lib/glimmer/dsl/swt/dsl.rb

@@ -25,6 +25,7 @@ module Glimmer
           table_items_data_binding
           data_binding
           property
+          block_property
           widget
           custom_widget
         ]

data/lib/glimmer/dsl/swt/widget_expression.rb

@@ -31,5 +31,7 @@ module Glimmer
 end
 
 require 'glimmer/swt/widget_proxy'
+require 'glimmer/swt/scrolled_composite_proxy'
 require 'glimmer/swt/tree_proxy'
 require 'glimmer/swt/table_proxy'
+require 'glimmer/swt/table_column_proxy'

data/lib/glimmer/package.rb

@@ -7,6 +7,12 @@ module Glimmer
     class << self
       attr_accessor :javapackager_extra_args
       
+      def clean
+        require 'fileutils'
+        FileUtils.rm_rf('dist')
+        FileUtils.rm_rf('packages')
+      end
+      
       def config
         project_name = File.basename(File.expand_path('.'))
         if !File.exists?('config/warble.rb')
@@ -15,7 +21,7 @@ module Glimmer
           system('warble config')
           new_config = File.read('config/warble.rb').split("\n").inject('') do |output, line|
             if line.include?('config.dirs =')
-              line = line.sub('# ', '').sub(/=[^=\n]+$/, '= %w(app config db lib script bin docs fonts icons images sounds videos)')
+              line = line.sub('# ', '').sub(/=[^=\n]+$/, '= %w(app config db lib script bin docs fonts icons images sounds videos vendor)')
             end
             if line.include?('config.includes =')
               line = line.sub('# ', '').sub(/=[^=\n]+$/, "= FileList['LICENSE.txt', 'VERSION']")

data/lib/glimmer/rake_task.rb

@@ -4,6 +4,11 @@ require_relative 'package'
 
 namespace :glimmer do
   namespace :package do
+    desc 'Clean by removing "dist" and "packages" directories'
+    task :clean do
+      Glimmer::Package.clean
+    end
+
     desc 'Generate JAR config file'
     task :config do
       Glimmer::Package.config

data/lib/glimmer/scaffold.rb

@@ -58,7 +58,7 @@ class Scaffold
       
       # for a library or gem, you might want to ignore these files since the code is
       # intended to run in multiple environments; otherwise, check them in:
-      Gemfile.lock
+      # Gemfile.lock
       # .ruby-version
       # .ruby-gemset
       
@@ -179,6 +179,7 @@ class Scaffold
     end
 
     def custom_shell_gem(custom_shell_name, namespace)
+      return puts('Namespace is required! Usage: glimmer scaffold:custom_shell_gem[custom_shell_name,namespace]') unless `git config --get github.user`.to_s.strip == 'AndyObtiva'
       gem_name = "glimmer-cs-#{compact_name(custom_shell_name)}"
       gem_summary = "#{human_name(custom_shell_name)} - Glimmer Custom Shell"
       if namespace
@@ -218,6 +219,7 @@ class Scaffold
     end
 
     def custom_widget_gem(custom_widget_name, namespace)
+      return puts('Namespace is required! Usage: glimmer scaffold:custom_widget_gem[custom_widget_name,namespace]') unless `git config --get github.user`.to_s.strip == 'AndyObtiva'
       gem_name = "glimmer-cw-#{compact_name(custom_widget_name)}"
       gem_summary = "#{human_name(custom_widget_name)} - Glimmer Custom Widget"
       if namespace
@@ -483,12 +485,10 @@ class Scaffold
         custom_shell_file_content += <<-MULTI_LINE_STRING
 
     def display_about_dialog
-      message_box = MessageBox.new(swt_widget)
-      message_box.setText("About")
-      message = "#{human_name(namespace)} - #{human_name(custom_shell_name)} \#{VERSION}\n\n"
-      message += LICENSE
-      message_box.setMessage(message)
-      message_box.open
+      message_box(body_root) {
+        text 'About'
+        message "#{human_name(namespace)} - #{human_name(custom_shell_name)} \#{VERSION}\\n\\n\#{LICENSE}"
+      }.open
     end
     
     def display_preferences_dialog

data/lib/glimmer/swt/scrolled_composite_proxy.rb

@@ -0,0 +1,21 @@
+require 'glimmer/swt/widget_proxy'
+
+module Glimmer
+  module SWT
+    class ScrolledCompositeProxy < Glimmer::SWT::WidgetProxy
+      def initialize(underscored_widget_name, parent, args)
+        unless args.first.is_a?(Numeric)
+          args.unshift(:h_scroll)
+          args.unshift(:v_scroll)
+        end
+        super
+        swt_widget.expand_horizontal = true
+        swt_widget.expand_vertical = true
+      end
+      
+      def post_initialize_child(child)
+        swt_widget.content = child.swt_widget        
+      end
+    end
+  end
+end

data/lib/glimmer/swt/shell_proxy.rb

@@ -130,7 +130,11 @@ module Glimmer
       # This method is not needed except in rare circumstances where there is a need to start the SWT Event Loop before opening the shell.
       def start_event_loop
         until @swt_widget.isDisposed
-          @display.sleep unless @display.readAndDispatch
+          begin
+            @display.sleep unless @display.readAndDispatch
+          rescue => e
+            Glimmer::Config.logger&.debug e.full_message          
+          end
         end
       end
 

data/lib/glimmer/swt/swt_proxy.rb

@@ -31,7 +31,8 @@ module Glimmer
       end
       
       EXTRA_STYLES = {
-        NO_RESIZE: self[:shell_trim, :resize!, :max!]
+        NO_RESIZE: self[:shell_trim, :resize!, :max!],
+        NO_SORT: -7,
       }            
     end
   end

data/lib/glimmer/swt/table_column_proxy.rb

@@ -0,0 +1,28 @@
+require 'glimmer/swt/widget_proxy'
+
+module Glimmer
+  module SWT
+    class TableColumnProxy < Glimmer::SWT::WidgetProxy    
+      attr_reader :no_sort, :sort_property, :editor
+      alias no_sort? no_sort
+      attr_accessor :sort_block, :sort_by_block
+      
+      def initialize(underscored_widget_name, parent, args)
+        @no_sort = args.delete(:no_sort)
+        super
+        on_widget_selected do |event|
+          parent.sort_by_column(self)
+        end unless no_sort?
+      end
+      
+      def sort_property=(args)
+        @sort_property = args unless args.empty?
+      end
+      
+      def editor=(args)
+        @editor = args
+      end
+      
+    end
+  end
+end

data/lib/glimmer/swt/table_proxy.rb

@@ -23,8 +23,8 @@ module Glimmer
         def find_table_item_and_column_index
           {}.tap do |result|
             if respond_to?(:x) && respond_to?(:y)
-              result[:table_item] = widget.getItems.detect do |ti|
-                result[:column_index] = widget.getColumnCount.times.to_a.detect do |ci|
+              result[:table_item] = widget.items.detect do |ti|
+                result[:column_index] = widget.column_count.times.to_a.detect do |ci|
                   ti.getBounds(ci).contains(x, y)
                 end
               end
@@ -33,7 +33,61 @@ module Glimmer
         end   
       end
       
-      attr_reader :table_editor, :table_editor_text_proxy
+      class << self
+        def editors
+          @editors ||= {
+            text: {
+              widget_value_property: :text,
+              editor_gui: lambda do |args, model, property, table_proxy|
+                table_proxy.table_editor.minimumHeight = 20
+                table_editor_widget_proxy = text(*args) {
+                  text model.send(property)
+                  focus true
+                  on_focus_lost {
+                    table_proxy.finish_edit!
+                  }
+                  on_key_pressed { |key_event|
+                    if key_event.keyCode == swt(:cr)
+                      table_proxy.finish_edit!
+                    elsif key_event.keyCode == swt(:esc)
+                      table_proxy.cancel_edit!
+                    end
+                  }              
+                }
+                table_editor_widget_proxy.swt_widget.selectAll          
+                table_editor_widget_proxy
+              end,
+            },
+            combo: {
+              widget_value_property: :text,
+              editor_gui: lambda do |args, model, property, table_proxy|
+                table_proxy.table_editor.minimumHeight = 25
+                table_editor_widget_proxy = combo(*args) {
+                  items model.send("#{property}_options")
+                  text model.send(property)
+                  focus true
+                  on_focus_lost {
+                    table_proxy.finish_edit!
+                  }
+                  on_key_pressed { |key_event|
+                    if key_event.keyCode == swt(:cr)
+                      table_proxy.finish_edit!
+                    elsif key_event.keyCode == swt(:esc)
+                      table_proxy.cancel_edit!
+                    end
+                  }
+                  on_widget_selected {
+                    table_proxy.finish_edit!
+                  }
+                }
+                table_editor_widget_proxy
+              end,
+            }
+          }      
+        end
+      end
+      
+      attr_reader :table_editor, :table_editor_text_proxy, :table_editor_widget_proxy, :sort_property, :sort_direction, :sort_block, :sort_type, :sort_by_block, :additional_sort_properties, :editor
       attr_accessor :column_properties
       
       def initialize(underscored_widget_name, parent, args)
@@ -43,7 +97,95 @@ module Glimmer
         @table_editor.grabHorizontal = true
         @table_editor.minimumHeight = 20
       end
-    
+
+      def model_binding
+        swt_widget.data
+      end
+      
+      def sort_by_column(table_column_proxy)
+        index = swt_widget.columns.to_a.index(table_column_proxy.swt_widget)
+        new_sort_property = table_column_proxy.sort_property || [column_properties[index]]
+        if new_sort_property.size == 1 && !additional_sort_properties.to_a.empty?
+          selected_additional_sort_properties = additional_sort_properties.clone
+          if selected_additional_sort_properties.include?(new_sort_property.first)
+            selected_additional_sort_properties.delete(new_sort_property.first)
+            new_sort_property += selected_additional_sort_properties
+          else
+            new_sort_property += additional_sort_properties
+          end
+        end
+        
+        @sort_direction = @sort_direction.nil? || @sort_property != new_sort_property || @sort_direction == :descending ? :ascending : :descending        
+        swt_widget.sort_direction = @sort_direction == :ascending ? SWTProxy[:up] : SWTProxy[:down]
+        
+        @sort_property = new_sort_property
+        swt_widget.sort_column = table_column_proxy.swt_widget
+        
+        @sort_by_block = nil
+        @sort_block = nil
+        @sort_type = nil
+        if table_column_proxy.sort_by_block
+          @sort_by_block = table_column_proxy.sort_by_block
+        elsif table_column_proxy.sort_block
+          @sort_block = table_column_proxy.sort_block
+        else
+          detect_sort_type        
+        end
+        sort
+      end
+      
+      def detect_sort_type
+        @sort_type = sort_property.size.times.map { String }
+        array = model_binding.evaluate_property
+        sort_property.each_with_index do |a_sort_property, i|
+          values = array.map { |object| object.send(a_sort_property) }
+          value_classes = values.map(&:class).uniq
+          if value_classes.size == 1
+            @sort_type[i] = value_classes.first
+          elsif value_classes.include?(Integer)
+            @sort_type[i] = Integer
+          elsif value_classes.include?(Float)
+            @sort_type[i] = Float
+          end
+        end
+      end
+      
+      def additional_sort_properties=(args)
+        @additional_sort_properties = args unless args.empty?
+      end
+      
+      def editor=(args)
+        @editor = args
+      end 
+      
+      def sort
+        return unless sort_property && (sort_type || sort_block || sort_by_block)
+        array = model_binding.evaluate_property
+        # Converting value to_s first to handle nil cases. Should work with numeric, boolean, and date fields
+        if sort_block
+          sorted_array = array.sort(&sort_block)
+        elsif sort_by_block
+          sorted_array = array.sort_by(&sort_by_block)          
+        else
+          sorted_array = array.sort_by do |object|
+            sort_property.each_with_index.map do |a_sort_property, i|
+              value = object.send(a_sort_property)
+              # handle nil and difficult to compare types gracefully
+              if sort_type[i] == Integer
+                value = value.to_i
+              elsif sort_type[i] == Float
+                value = value.to_f
+              elsif sort_type[i] == String
+                value = value.to_s
+              end
+              value
+            end
+          end
+        end
+        sorted_array = sorted_array.reverse if sort_direction == :descending
+        model_binding.call(sorted_array)
+      end
+      
       # Performs a search for table items matching block condition
       # If no condition block is passed, returns all table items
       # Returns a Java TableItem array to easily set as selection on org.eclipse.swt.Table if needed
@@ -68,6 +210,14 @@ module Glimmer
         })
       end
       
+      def post_initialize_child(table_column_proxy)
+        table_column_proxies << table_column_proxy
+      end
+      
+      def table_column_proxies
+        @table_column_proxies ||= []
+      end
+      
       # Indicates if table is in edit mode, thus displaying a text widget for a table item cell
       def edit_mode?
         !!@edit_mode
@@ -93,58 +243,62 @@ module Glimmer
             
       def edit_table_item(table_item, column_index, before_write: nil, after_write: nil, after_cancel: nil)
         return if table_item.nil?
+        model = table_item.data
+        property = column_properties[column_index]
         @cancel_edit&.call if @edit_mode
+        action_taken = false
         @edit_mode = true
-        content {
-          @table_editor_text_proxy = text {
-            focus true
-            text table_item.getText(column_index)
-            action_taken = false
-            @cancel_edit = lambda do
-              @cancel_in_progress = true
-              @table_editor_text_proxy&.swt_widget&.dispose
-              @table_editor_text_proxy = nil
-              after_cancel&.call
+        
+        editor_config = table_column_proxies[column_index].editor || editor
+        editor_config = editor_config.to_a
+        editor_widget_options = editor_config.last.is_a?(Hash) ? editor_config.last : {}
+        editor_widget_arg_last_index = editor_config.last.is_a?(Hash) ? -2 : -1
+        editor_widget = editor_config[0] || :text
+        editor_widget_args = editor_config[1..editor_widget_arg_last_index]
+        model_editing_property = editor_widget_options[:property] || property
+        widget_value_property = TableProxy::editors[editor_widget][:widget_value_property]
+        
+        @cancel_edit = lambda do |event=nil|
+          @cancel_in_progress = true
+          @table_editor_widget_proxy&.swt_widget&.dispose
+          @table_editor_widget_proxy = nil
+          after_cancel&.call
+          @edit_in_progress = false
+          @cancel_in_progress = false
+          @cancel_edit = nil
+          @edit_mode = false
+        end
+        
+        @finish_edit = lambda do |event=nil|
+          new_value = @table_editor_widget_proxy&.swt_widget&.send(widget_value_property)
+          if table_item.isDisposed
+            @cancel_edit.call
+          elsif new_value && !action_taken && !@edit_in_progress && !@cancel_in_progress
+            action_taken = true
+            @edit_in_progress = true
+            if new_value == model.send(model_editing_property)
+              @cancel_edit.call
+            else
+              before_write&.call
+              model.send("#{model_editing_property}=", new_value) # makes table update itself, so must search for selected table item again
+              # Table refresh happens here because of model update triggering observers, so must retrieve table item again
+              edited_table_item = search { |ti| ti.getData == model }.first
+              swt_widget.showItem(edited_table_item)
+              @table_editor_widget_proxy&.swt_widget&.dispose
+              @table_editor_widget_proxy = nil
+              after_write&.call(edited_table_item)              
               @edit_in_progress = false
-              @cancel_in_progress = false
-              @cancel_edit = nil
-              @edit_mode = false
-            end
-            @finish_edit = lambda do |event=nil|
-              if table_item.isDisposed
-                @cancel_edit.call
-              elsif !action_taken && !@edit_in_progress && !@cancel_in_progress
-                action_taken = true
-                @edit_in_progress = true
-                new_text = @table_editor_text_proxy.swt_widget.getText
-                if new_text == table_item.getText(column_index)
-                  @cancel_edit.call
-                else
-                  before_write&.call
-                  table_item.setText(column_index, new_text)
-                  model = table_item.getData
-                  model.send("#{column_properties[column_index]}=", new_text) # makes table update itself, so must search for selected table item again
-                  edited_table_item = search { |ti| ti.getData == model }.first
-                  swt_widget.showItem(edited_table_item)
-                  @table_editor_text_proxy&.swt_widget&.dispose
-                  @table_editor_text_proxy = nil
-                  after_write&.call(edited_table_item)
-                  @edit_in_progress = false
-                end
-              end
             end
-            on_focus_lost(&@finish_edit)
-            on_key_pressed { |key_event|
-              if key_event.keyCode == swt(:cr)
-                @finish_edit.call(key_event)
-              elsif key_event.keyCode == swt(:esc)
-                @cancel_edit.call
-              end
-            }
-          }
-          @table_editor_text_proxy.swt_widget.selectAll
+          end
+        end
+
+        content { 
+          @table_editor_widget_proxy = @table_editor_text_proxy = TableProxy::editors[editor_widget][:editor_gui].call(editor_widget_args, model, model_editing_property, self)
         }
-        @table_editor.setEditor(@table_editor_text_proxy.swt_widget, table_item, column_index)
+        @table_editor.setEditor(@table_editor_widget_proxy.swt_widget, table_item, column_index)
+      rescue => e
+        Glimmer::Config.logger&.error e.full_message
+        raise e
       end
       
       def add_listener(underscored_listener_name, &block)

data/lib/glimmer/swt/widget_proxy.rb

@@ -61,6 +61,12 @@ module Glimmer
         swt_widget_class = self.class.swt_widget_class_for(underscored_widget_name)
         @swt_widget = swt_widget_class.new(parent.swt_widget, style(underscored_widget_name, styles), *extra_options)
         DEFAULT_INITIALIZERS[underscored_widget_name]&.call(@swt_widget)
+        parent.post_initialize_child(self)
+      end
+      
+      # Subclasses may override to perform post initialization work on an added child
+      def post_initialize_child(child)
+        # No Op by default
       end
 
       def extract_args(underscored_widget_name, args)
@@ -145,6 +151,23 @@ module Glimmer
                 observer.call(false)
               }
             end,
+            :selection => lambda do |observer|
+              on_widget_selected { |selection_event|
+                observer.call(@swt_widget.getSelection)
+              } if can_handle_observation_request?(:on_widget_selected)
+            end,
+            :text => lambda do |observer|
+              on_modify_text { |modify_event|
+                observer.call(@swt_widget.getText)
+              } if can_handle_observation_request?(:on_modify_text)
+            end,
+          },
+          Java::OrgEclipseSwtWidgets::Combo => {
+            :text => lambda do |observer|
+              on_modify_text { |modify_event|
+                observer.call(@swt_widget.getText)
+              }
+            end,
           },
           Java::OrgEclipseSwtWidgets::Text => {
             :text => lambda do |observer|
@@ -248,12 +271,12 @@ module Glimmer
           return nil
         end
         swt_widget_class
-      rescue NameError => e
-        Glimmer::Config.logger&.debug e.message
+      rescue SyntaxError, NameError => e
+        Glimmer::Config.logger&.debug e.full_message
         # Glimmer::Config.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
         nil
       rescue => e
-        Glimmer::Config.logger&.debug e.message
+        Glimmer::Config.logger&.debug e.full_message
         # Glimmer::Config.logger&.debug("#{e.message}\n#{e.backtrace.join("\n")}")
         nil
       end
@@ -289,9 +312,7 @@ module Glimmer
       def add_observer(observer, property_name)
         property_listener_installers = @swt_widget.class.ancestors.map {|ancestor| widget_property_listener_installers[ancestor]}.compact
         widget_listener_installers = property_listener_installers.map{|installer| installer[property_name.to_s.to_sym]}.compact if !property_listener_installers.empty?
-        widget_listener_installers.to_a.each do |widget_listener_installer|
-          widget_listener_installer.call(observer)
-        end
+        widget_listener_installers.to_a.first&.call(observer)
       end
 
       def remove_observer(observer, property_name)

data/lib/glimmer/ui/custom_widget.rb

@@ -137,8 +137,9 @@ module Glimmer
         execute_hooks('after_body')
         @swt_widget = @body_root.swt_widget
       end
-
+      
       def can_handle_observation_request?(observation_request)
+        observation_request = observation_request.to_s
         result = false
         if observation_request.start_with?('on_updated_')
           property = observation_request.sub(/^on_updated_/, '')
@@ -148,6 +149,7 @@ module Glimmer
       end
 
       def handle_observation_request(observation_request, &block)
+        observation_request = observation_request.to_s
         if observation_request.start_with?('on_updated_')
           property = observation_request.sub(/^on_updated_/, '') # TODO look into eliminating duplication from above
           add_observer(DataBinding::Observer.proc(&block), property) if can_add_observer?(property)
@@ -183,7 +185,9 @@ module Glimmer
 
       # This method ensures it has an instance method not coming from Glimmer DSL
       def has_instance_method?(method_name)
-        respond_to?(method_name) && !method(method_name)&.source_location&.first&.include?('glimmer/dsl/engine.rb')
+        respond_to?(method_name) && 
+          !method(method_name)&.source_location&.first&.include?('glimmer/dsl/engine.rb') && 
+          !method(method_name)&.source_location&.first&.include?('glimmer/swt/widget_proxy.rb')
       end
 
       def get_attribute(attribute_name)
@@ -224,13 +228,14 @@ module Glimmer
         end
       end
 
-      def dispose
-        body_root.dispose
-      end
-      
       def method_missing(method, *args, &block)
         body_root.send(method, *args, &block)
       end
+      
+      def respond_to?(method, *args, &block)
+        super or
+          body_root.respond_to?(method, *args, &block)
+      end
 
       private
 

metadata

@@ -1,21 +1,21 @@
 --- !ruby/object:Gem::Specification
 name: glimmer-dsl-swt
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.1
 platform: ruby
 authors:
 - AndyMaleh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-10 00:00:00.000000000 Z
+date: 2020-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: 0.9.5
   name: glimmer
   type: :runtime
   prerelease: false
@@ -23,7 +23,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.3
+        version: 0.9.5
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -256,7 +256,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.0
-description: Glimmer DSL for SWT (Desktop GUI)
+description: Glimmer DSL for SWT (Desktop GUI) - JRuby on SWT
 email: andy.am@gmail.com
 executables:
 - glimmer
@@ -285,6 +285,7 @@ files:
 - lib/glimmer/data_binding/widget_binding.rb
 - lib/glimmer/dsl/swt/async_exec_expression.rb
 - lib/glimmer/dsl/swt/bind_expression.rb
+- lib/glimmer/dsl/swt/block_property_expression.rb
 - lib/glimmer/dsl/swt/color_expression.rb
 - lib/glimmer/dsl/swt/column_properties_expression.rb
 - lib/glimmer/dsl/swt/combo_selection_data_binding_expression.rb
@@ -328,10 +329,12 @@ files:
 - lib/glimmer/swt/menu_proxy.rb
 - lib/glimmer/swt/message_box_proxy.rb
 - lib/glimmer/swt/packages.rb
+- lib/glimmer/swt/scrolled_composite_proxy.rb
 - lib/glimmer/swt/shell_proxy.rb
 - lib/glimmer/swt/style_constantizable.rb
 - lib/glimmer/swt/swt_proxy.rb
 - lib/glimmer/swt/tab_item_proxy.rb
+- lib/glimmer/swt/table_column_proxy.rb
 - lib/glimmer/swt/table_proxy.rb
 - lib/glimmer/swt/tree_proxy.rb
 - lib/glimmer/swt/widget_listener_proxy.rb