glimmer-dsl-opal 0.5.0 → 0.7.1

data/lib/glimmer-dsl-swt.rb

@@ -1,37 +1,22 @@
-class OS
-  class << self
-    def windows?
-      # No Op in Opal
-    end
-    
-    def mac?
-      # No Op in Opal
-    end
-    
-    def linux?
-      # No Op in Opal
-    end
-  end
-end
-
-class File
-  class << self
-    def read(*args, &block)
-      # TODO implement via asset downloads in the future
-      # No Op in Opal
-    end
-  end
-end
-
-class Display
-  class << self
-    def setAppName(app_name)
-      # No Op in Opal
-    end
-    def setAppVersion(version)
-      # No Op in Opal
-    end
-  end
-end
+# Copyright (c) 2020 Andy Maleh
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 require 'glimmer-dsl-opal'

data/lib/glimmer/data_binding/table_items_binding.rb

@@ -12,26 +12,32 @@ module Glimmer
       include DataBinding::Observer
 
       def initialize(parent, model_binding, column_properties)
-        @last_model_collection = nil
+        @last_populated_model_collection = nil
         @table = parent
         @model_binding = model_binding
         @column_properties = column_properties
-        if @table.respond_to?(:column_properties=)
-          @table.column_properties = @column_properties
-        ##else # assume custom widget
-        ##  @table.body_root.column_properties = @column_properties
-        end
-        call(@model_binding.evaluate_property)
-        model = model_binding.base_model
-        observe(model, model_binding.property_name_expression)
+        @table.data = @model_binding
         ##@table.on_widget_disposed do |dispose_event| # doesn't seem needed within Opal
         ##  unregister_all_observables
         ##end
+        if @table.respond_to?(:column_properties=)
+          @table.column_properties = @column_properties
+        else # assume custom widget
+         @table.body_root.column_properties = @column_properties
+        end
+        @table_observer_registration = observe(model_binding)
+        call
       end
 
       def call(new_model_collection=nil)
+        new_model_collection = @model_binding.evaluate_property # this ensures applying converters (e.g. :on_read)
+        table_cells = @table.items.map {|item| @table.column_properties.size.times.map {|i| item.get_text(i)} }
+        model_cells = new_model_collection.to_a.map {|m| @table.cells_for(m)}
+        return if table_cells == model_cells
         if new_model_collection and new_model_collection.is_a?(Array)
-          observe(new_model_collection, @column_properties)
+#           @table_items_observer_registration&.unobserve # TODO re-enable
+          @table_items_observer_registration = observe(new_model_collection, @column_properties)
+          add_dependent(@table_observer_registration => @table_items_observer_registration)
           @model_collection = new_model_collection
         end
         populate_table(@model_collection, @table, @column_properties)
@@ -39,8 +45,10 @@ module Glimmer
       end
       
       def populate_table(model_collection, parent, column_properties)
-        return if model_collection&.sort_by(&:hash) == @last_model_collection&.sort_by(&:hash)
-        @last_model_collection = model_collection
+        @skip_populate_table = model_collection&.sort_by(&:hash).map {|m| @table.column_properties.map {|p| m.send(p)}} == @last_populated_model_collection_properties
+        return if @skip_populate_table
+        @last_populated_model_collection = model_collection
+        @last_populated_model_collection_properties = model_collection&.sort_by(&:hash).map {|m| @table.column_properties.map {|p| m.send(p)}}
         # TODO improve performance
         selected_table_item_models = parent.selection.map(&:get_data)
         old_items = parent.items
@@ -55,16 +63,21 @@ module Glimmer
           table_item.id = old_item_ids_per_model[model.hash] if old_item_ids_per_model[model.hash]
         end
         selected_table_items = parent.search {|item| selected_table_item_models.include?(item.get_data) }
-        selected_table_items = [parent.items.first] if selected_table_items.empty? && !parent.items.empty?
-        parent.selection = selected_table_items unless selected_table_items.empty?
+        parent.selection = selected_table_items
         parent.redraw
       end
       
       def sort_table(model_collection, parent, column_properties)
-        return if model_collection == @last_model_collection
-        parent.items = parent.items.sort_by { |item| model_collection.index(item.get_data) }
-        @last_model_collection = model_collection
-      end      
+        return if model_collection == @last_sorted_model_collection
+        if model_collection == @last_populated_model_collection
+          # Reapply the last table sort. The model collection has just been populated since it diverged from what it was before
+          parent.sort!
+        else
+          # The model collection was sorted by the model, but beyond sorting, it did not change from the last populated model collection.
+          parent.items = parent.items.sort_by { |item| model_collection.index(item.get_data) }
+          @last_sorted_model_collection = @last_populated_model_collection = model_collection
+        end
+      end
     end
   end
 end

data/lib/glimmer/dsl/opal/block_property_expression.rb

@@ -0,0 +1,41 @@
+# Copyright (c) 2007-2020 Andy Maleh
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require 'glimmer/dsl/expression'
+
+module Glimmer
+  module DSL
+    module Opal
+      class BlockPropertyExpression < Expression
+        def can_interpret?(parent, keyword, *args, &block)
+          block_given? and
+            args.size == 0 and
+            parent.respond_to?("#{keyword}_block=")
+        end
+  
+        def interpret(parent, keyword, *args, &block)
+          parent.send("#{keyword}_block=", block)
+          nil
+        end
+      end
+    end
+  end
+end

data/lib/glimmer/dsl/opal/custom_widget_expression.rb

@@ -44,7 +44,7 @@ module Glimmer
         def interpret(parent, keyword, *args, &block)
           custom_widget_class = UI::CustomWidget.for(keyword)
           # TODO clean code by extracting methods into CustomShell
-          if !Glimmer::UI::CustomShell.requested? && custom_widget_class.ancestors.include?(Glimmer::UI::CustomShell)
+          if !Glimmer::UI::CustomShell.requested? && custom_widget_class&.ancestors&.to_a.include?(Glimmer::UI::CustomShell)
             if Glimmer::SWT::DisplayProxy.instance.shells.empty?
               custom_widget_class.new(parent, *args, {}, &block)
             else

data/lib/glimmer/dsl/opal/dsl.rb

@@ -25,6 +25,7 @@ require 'glimmer/dsl/opal/custom_widget_expression'
 require 'glimmer/dsl/opal/swt_expression'
 require 'glimmer/dsl/opal/radio_group_selection_data_binding_expression'
 require 'glimmer/dsl/opal/checkbox_group_selection_data_binding_expression'
+require 'glimmer/dsl/opal/block_property_expression'
 
 module Glimmer
   module DSL
@@ -42,6 +43,7 @@ module Glimmer
          data_binding
          font
          layout
+         block_property
          property
          widget
        ]

data/lib/glimmer/dsl/opal/shell_expression.rb

@@ -13,14 +13,14 @@ module Glimmer
         include TopLevelExpression
         include ParentExpression
 
-        def interpret(parent, keyword, *args, &block)          
+        def interpret(parent, keyword, *args, &block)
           if Glimmer::UI::CustomShell.requested_and_not_handled?
             parameters = Glimmer::UI::CustomShell.request_parameter_string.split("&").map {|str| str.split("=")}.to_h
             `history.pushState(#{parameters.merge('custom_shell_handled' => 'true')}, document.title, #{"?#{Glimmer::UI::CustomShell.encoded_request_parameter_string}&custom_shell_handled=true"})`
             custom_shell_keyword = parameters.delete('custom_shell')
             CustomWidgetExpression.new.interpret(nil, custom_shell_keyword, *[parameters])
             `history.pushState(#{parameters.reject {|k,v| k == 'custom_shell_handled'}}, document.title, #{"?#{Glimmer::UI::CustomShell.encoded_request_parameter_string.sub('&custom_shell_handled=true', '')}"})`
-            # just a placeholder that has an open method # TODO return an actual CustomShell in the future that does the work happening above in the #open method            
+            # just a placeholder that has an open method # TODO return an actual CustomShell in the future that does the work happening above in the #open method
             Glimmer::SWT::MakeShiftShellProxy.new
           else
             Glimmer::SWT::ShellProxy.new(*args)
@@ -30,6 +30,11 @@ module Glimmer
         def add_content(parent, &content)
           content.call(parent) if parent.is_a?(Glimmer::SWT::ShellProxy)
         end
+
+        def add_content(parent, &block)
+          super(parent, &block)
+          parent.post_add_content
+        end
       end
     end
   end

data/lib/glimmer/dsl/opal/widget_expression.rb

@@ -16,7 +16,16 @@ module Glimmer
         end
 
         def interpret(parent, keyword, *args, &block)
-          Glimmer::SWT::WidgetProxy.for(keyword, parent, args)
+          Glimmer::SWT::WidgetProxy.for(keyword, parent, args, block)
+        end
+
+        def add_content(parent, &block)
+          if parent.rendered?
+            super(parent, &block)
+            parent.post_add_content
+          else
+            parent.add_content_on_render(&block)
+          end
         end
       end
     end

data/lib/glimmer/engine.rb

@@ -0,0 +1,9 @@
+module Glimmer
+  class Engine < ::Rails::Engine
+    isolate_namespace Glimmer
+
+    initializer "glimmer.assets.precompile" do |app|
+      app.config.assets.precompile += %w( glimmer/glimmer.css )
+    end
+  end
+end

data/lib/glimmer/swt.rb

@@ -1,5 +1,5 @@
 # Copyright (c) 2020 Andy Maleh
-# 
+#
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
 # "Software"), to deal in the Software without restriction, including
@@ -7,10 +7,10 @@
 # distribute, sublicense, and/or sell copies of the Software, and to
 # permit persons to whom the Software is furnished to do so, subject to
 # the following conditions:
-# 
+#
 # The above copyright notice and this permission notice shall be
 # included in all copies or substantial portions of the Software.
-# 
+#
 # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 # EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 # MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND

data/lib/glimmer/swt/button_proxy.rb

@@ -6,13 +6,13 @@ module Glimmer
   module SWT
     class ButtonProxy < WidgetProxy
       class << self
-        def create(parent, args)
+        def create(keyword, parent, args, block)
           if args.to_a.include?(:radio)
-            RadioProxy.new(parent, args)
+            RadioProxy.new(parent, args, block)
           elsif args.to_a.include?(:check)
-            CheckboxProxy.new(parent, args)
+            CheckboxProxy.new(parent, args, block)
           else
-            new(parent, args)
+            new(parent, args, block)
           end
         end
       end
@@ -44,7 +44,7 @@ module Glimmer
         input_disabled = @enabled ? {} : {'disabled': 'disabled'}
         input_args = input_args.merge(type: 'password') if has_style?(:password)
         @dom ||= html {
-          button(input_args.merge(id: input_id, class: name, style: input_style, style: 'min-width: 27px; min-height: 27px;').merge(input_disabled)) {
+          button(input_args.merge(id: input_id, class: name, style: input_style, style: 'min-width: 32px; min-height: 32px;').merge(input_disabled)) {
             input_text.to_s == '' ? '&nbsp;' : input_text
           }
         }.to_s

data/lib/glimmer/swt/checkbox_proxy.rb

@@ -3,6 +3,7 @@ require 'glimmer/swt/widget_proxy'
 module Glimmer
   module SWT
     class CheckboxProxy < WidgetProxy
+      # TODO add a create method that ensures passing :check style in if not there
       STYLE=<<~CSS
         .checkbox {
           display: inline;

data/lib/glimmer/swt/color_proxy.rb

@@ -1,5 +1,5 @@
 # Copyright (c) 2020 Andy Maleh
-# 
+#
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
 # "Software"), to deal in the Software without restriction, including
@@ -7,10 +7,10 @@
 # distribute, sublicense, and/or sell copies of the Software, and to
 # permit persons to whom the Software is furnished to do so, subject to
 # the following conditions:
-# 
+#
 # The above copyright notice and this permission notice shall be
 # included in all copies or substantial portions of the Software.
-# 
+#
 # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
 # EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
 # MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
@@ -28,44 +28,44 @@ module Glimmer
     # Follows the Proxy Design Pattern
     class ColorProxy
       SWT_COLOR_TRANSLATION = {
-        "widget_foreground"                   => [0, 0, 0], 
-        "blue"                                => [0, 0, 255], 
-        "widget_dark_shadow"                  => [0, 0, 0], 
-        "title_foreground"                    => [0, 0, 0], 
-        "yellow"                              => [255, 255, 0], 
-        "widget_highlight_shadow"             => [255, 255, 255], 
-        "dark_cyan"                           => [0, 128, 128], 
-        "list_foreground"                     => [0, 0, 0], 
-        "dark_blue"                           => [0, 0, 128], 
-        "dark_yellow"                         => [128, 128, 0], 
-        "cyan"                                => [0, 255, 255], 
-        "info_background"                     => [236, 235, 236], 
-        "link_foreground"                     => [0, 104, 218], 
-        "title_inactive_foreground"           => [0, 0, 0], 
-        "title_background_gradient"           => [179, 215, 255], 
-        "red"                                 => [255, 0, 0], 
-        "title_inactive_background_gradient"  => [220, 220, 220], 
-        "transparent"                         => [255, 255, 255], 
-        "widget_light_shadow"                 => [232, 232, 232], 
-        "dark_magenta"                        => [128, 0, 128], 
-        "white"                               => [255, 255, 255], 
-        "list_selection"                      => [179, 215, 255], 
-        "gray"                                => [192, 192, 192], 
-        "widget_border"                       => [0, 0, 0], 
-        "widget_background"                   => [236, 236, 236], 
-        "info_foreground"                     => [0, 0, 0], 
-        "title_inactive_background"           => [220, 220, 220], 
-        "widget_disabled_foreground"          => [220, 220, 220], 
-        "list_background"                     => [255, 255, 255], 
-        "magenta"                             => [255, 0, 255], 
-        "title_background"                    => [0, 99, 225], 
-        "text_disabled_background"            => [255, 255, 255], 
-        "black"                               => [0, 0, 0], 
-        "dark_gray"                           => [128, 128, 128], 
-        "list_selection_text"                 => [0, 0, 0], 
-        "dark_red"                            => [128, 0, 0], 
-        "widget_normal_shadow"                => [159, 159, 159], 
-        "dark_green"                          => [0, 128, 0], 
+        "widget_foreground"                   => [0, 0, 0],
+        "blue"                                => [0, 0, 255],
+        "widget_dark_shadow"                  => [0, 0, 0],
+        "title_foreground"                    => [0, 0, 0],
+        "yellow"                              => [255, 255, 0],
+        "widget_highlight_shadow"             => [255, 255, 255],
+        "dark_cyan"                           => [0, 128, 128],
+        "list_foreground"                     => [0, 0, 0],
+        "dark_blue"                           => [0, 0, 128],
+        "dark_yellow"                         => [128, 128, 0],
+        "cyan"                                => [0, 255, 255],
+        "info_background"                     => [236, 235, 236],
+        "link_foreground"                     => [0, 104, 218],
+        "title_inactive_foreground"           => [0, 0, 0],
+        "title_background_gradient"           => [179, 215, 255],
+        "red"                                 => [255, 0, 0],
+        "title_inactive_background_gradient"  => [220, 220, 220],
+        "transparent"                         => [255, 255, 255],
+        "widget_light_shadow"                 => [232, 232, 232],
+        "dark_magenta"                        => [128, 0, 128],
+        "white"                               => [255, 255, 255],
+        "list_selection"                      => [179, 215, 255],
+        "gray"                                => [192, 192, 192],
+        "widget_border"                       => [0, 0, 0],
+        "widget_background"                   => [236, 236, 236],
+        "info_foreground"                     => [0, 0, 0],
+        "title_inactive_background"           => [220, 220, 220],
+        "widget_disabled_foreground"          => [220, 220, 220],
+        "list_background"                     => [255, 255, 255],
+        "magenta"                             => [255, 0, 255],
+        "title_background"                    => [0, 99, 225],
+        "text_disabled_background"            => [255, 255, 255],
+        "black"                               => [0, 0, 0],
+        "dark_gray"                           => [128, 128, 128],
+        "list_selection_text"                 => [0, 0, 0],
+        "dark_red"                            => [128, 0, 0],
+        "widget_normal_shadow"                => [159, 159, 159],
+        "dark_green"                          => [0, 128, 0],
         "green"                               => [0, 255, 0]
       }
     
@@ -87,19 +87,19 @@ module Glimmer
       # rgba is 4 arguments representing Red, Green, Blue, and Alpha numeric values
       #
       def initialize(*args)
-        @args = args        
+        @args = args
         case @args.size
         when 1
           @alpha = nil
-          if @args.first.is_a?(String) || @args.first.is_a?(Symbol)              
-            standard_color = @args.first.to_s.downcase.sub('COLOR_', '')             
+          if @args.first.is_a?(String) || @args.first.is_a?(Symbol)
+            standard_color = @args.first.to_s.downcase.sub('COLOR_', '')
             @red, @green, @blue = SWT_COLOR_TRANSLATION[standard_color]
           else
             @red, @green, @blue = [0, 0, 0]
           end
         when 3..4
           @red, @green, @blue, @alpha = @args
-        end        
+        end
       end
       
       def to_css