glimmer-dsl-opal 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a67315f8276add7f19a24f488c635567a39fe798e7e21e49ce23de2aeb6c0d2
-  data.tar.gz: e667498792a2522e9271a04ccd2051396c778e528dd77fbb593c6369eee971e2
+  metadata.gz: b56026edb0b7ab096e2b972afcc99f2914db153e52fa52616859b44e86d0ad8c
+  data.tar.gz: aa94ad9ded4e7cac3ec706db46a012861e9c1e3a0d0026cdcc7833f43733eba0
 SHA512:
-  metadata.gz: 02db0846e7e3b430387e693aa4981c2f01636a01b5ed5ba32646cbdac15991604ccbd5efa4d8e8b837027c69861c28b8d1917f5bef792121de9be8b86584e064
-  data.tar.gz: 5d07f4b44c97c81bcf554b18d423e0007efe14bf8cdaa8529f0c295581518654a94989dcc1a0e921e8626a7ca3ca243f572a4d163f3e4bd450fe81684303dae2
+  metadata.gz: 66e958ca4e486e0a33908fb21d72322c375da35774a86e0514898a50b214bff0ecd7e7f4f5ce930983394cf49d9386ddce45f9ddcc0eb5e0074c455e8ebb87c9
+  data.tar.gz: 9e57c5f9a2bb433f182e7f7ce392f19985796cd56f8f40bed01bfed2e7385a25b4bf3fb7b06c541dae0b77cda2a981ac71d2a094d21f0beede0f8867b3fd1333

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change Log
 
+## 0.0.9
+
+- Upgraded to glimmer gem v0.9.3
+- Fixed issue with missing Glimmer::Opal::ElementProxy#id=(value) method breaking Contact Manager sample Find feature
+
 ## 0.0.8
 
 - Contact Manager sample support

data/README.md

@@ -1,12 +1,10 @@
-# <img src="https://raw.githubusercontent.com/AndyObtiva/glimmer/master/images/glimmer-logo-hi-res.png" height=65 /> Glimmer DSL for Opal 0.0.8 (Webify Desktop Apps)
+# <img src="https://raw.githubusercontent.com/AndyObtiva/glimmer/master/images/glimmer-logo-hi-res.png" height=65 /> Glimmer DSL for Opal 0.0.9 (Webify Desktop Apps)
 [![Gem Version](https://badge.fury.io/rb/glimmer-dsl-opal.svg)](http://badge.fury.io/rb/glimmer-dsl-opal)
 [![Join the chat at https://gitter.im/AndyObtiva/glimmer](https://badges.gitter.im/AndyObtiva/glimmer.svg)](https://gitter.im/AndyObtiva/glimmer?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
-Glimmer DSL for Opal is a web GUI adaptor for webifying [Glimmer](https://github.com/AndyObtiva/glimmer) desktop apps (i.e. apps built with [Glimmer DSL for SWT](https://github.com/AndyObtiva/glimmer-dsl-swt)).
+Glimmer DSL for Opal is an experimental web GUI adaptor for [Glimmer](https://github.com/AndyObtiva/glimmer) desktop apps (i.e. apps built with [Glimmer](https://github.com/AndyObtiva/glimmer) [DSL for SWT](https://github.com/AndyObtiva/glimmer-dsl-swt)). It webifies them via [Rails](https://rubyonrails.org/) and [Opal](https://opalrb.com/), allowing Ruby desktop apps to run on the web without changing a line of code. Apps may then be custom-styled for the web via standard CSS.
 
-It enables running [Glimmer](https://github.com/AndyObtiva/glimmer) desktop apps on the web via [Rails](https://rubyonrails.org/) and [Opal](https://opalrb.com/) without changing a line of code. Apps may then be custom-styled for the web via standard CSS.
-
-NOTE: Alpha Version 0.0.8 only supports bare-minimum capabilities for the following [glimmer-dsl-swt](https://github.com/AndyObtiva/glimmer-dsl-swt) [samples](https://github.com/AndyObtiva/glimmer#samples):
+NOTE: Alpha Version 0.0.9 only supports bare-minimum capabilities for the following [glimmer-dsl-swt](https://github.com/AndyObtiva/glimmer-dsl-swt) [samples](https://github.com/AndyObtiva/glimmer#samples):
 - [Hello, World!](#hello-world)
 - [Hello, Combo!](#hello-combo)
 - [Hello, Computed!](#hello-computed)
@@ -70,7 +68,7 @@ Add the following to `Gemfile`:
 gem 'opal-rails', '~> 1.1.2'
 gem 'opal-async', '~> 1.1.0'
 gem 'opal-browser', '~> 0.2.0'
-gem 'glimmer-dsl-opal', '~> 0.0.8', require: false
+gem 'glimmer-dsl-opal', '~> 0.0.9', require: false
 ```
 
 Follow (opal-rails)[https://github.com/opal/opal-rails] instructions, basically the configuration of: config/initializers/assets.rb
@@ -94,7 +92,13 @@ Add more code to `app/assets/javascripts/application.rb` from one of the samples
 
 #### Hello, World!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/hello/hello_world'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 include Glimmer
@@ -126,7 +130,13 @@ You should see "Hello, World!"
 
 #### Hello, Combo!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/hello/hello_combo'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class Person
@@ -183,7 +193,14 @@ You should see "Hello, Combo!"
 
 #### Hello, Computed!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+
+```ruby
+require 'samples/hello/hello_computed'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class HelloComputed
@@ -295,7 +312,14 @@ You should see "Hello, Computed!"
 
 #### Hello, List Single Selection!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+
+```ruby
+require 'samples/hello/hello_list_single_selection'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class Person 
@@ -352,7 +376,13 @@ You should see "Hello, List Single Selection!"
 
 #### Hello, List Multi Selection!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/hello/hello_list_multi_selection'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class Person
@@ -419,7 +449,13 @@ You should see "Hello, List Multi Selection!"
 
 #### Hello, Browser!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/hello/hello_browser'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 include Glimmer
@@ -450,7 +486,13 @@ You should see "Hello, Browser!"
 
 #### Hello, Tab!
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/hello/hello_tab'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class HelloTab
@@ -501,7 +543,13 @@ You should see "Hello, Tab!"
 
 #### Login
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/elaborate/login'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 require "observer"
@@ -615,7 +663,13 @@ You should see "Login" dialog
 
 #### Tic Tac Toe
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/elaborate/tic_tac_toe'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class TicTacToe
@@ -844,7 +898,13 @@ You should see "Tic Tac Toe"
 
 #### Contact Manager
 
-Add the following Glimmer code to `app/assets/javascripts/application.rb`
+Add the following require statement to `app/assets/javascripts/application.rb`
+
+```ruby
+require 'samples/elaborate/contact_manager'
+```
+
+Or add the Glimmer code directly if you prefer to play around with it:
 
 ```ruby
 class ContactManager

data/VERSION

@@ -1 +1 @@
-0.0.8
+0.0.9

data/lib/glimmer/data_binding/table_items_binding.rb

@@ -43,6 +43,8 @@ module Glimmer
         @last_model_collection = model_collection
         # TODO improve performance
         selected_table_item_models = parent.selection.map(&:get_data)
+        old_items = parent.items
+        old_item_ids_per_model = old_items.reduce({}) {|hash, item| hash.merge(item.get_data.hash => item.id) }
         parent.remove_all
         model_collection.each do |model|
           table_item = Glimmer::Opal::TableItem.new(parent)
@@ -50,6 +52,7 @@ module Glimmer
             table_item.set_text(index, model.send(column_properties[index]).to_s)
           end
           table_item.set_data(model)
+          table_item.id = old_item_ids_per_model[model.hash] if old_item_ids_per_model[model.hash]
         end
         selected_table_items = parent.search {|item| selected_table_item_models.include?(item.get_data) }
         selected_table_items = [parent.items.first] if selected_table_items.empty? && !parent.items.empty?

data/lib/glimmer/opal/element_proxy.rb

@@ -7,6 +7,20 @@ module Glimmer
       include PropertyOwner
       attr_reader :parent, :args, :css_classes, :css, :children, :enabled
       
+      class << self
+        def next_id_number_for(name)
+          @max_id_numbers[name] = max_id_number_for(name) + 1
+        end
+        
+        def max_id_number_for(name)
+          @max_id_numbers[name] = max_id_numbers[name] || 0
+        end
+        
+        def max_id_numbers
+          @max_id_numbers ||= {}
+        end
+      end
+      
       def initialize(parent, args)
         @parent = parent
         @args = args
@@ -51,10 +65,14 @@ module Glimmer
       end
       
       def id
-        # TODO replace hash with autoincrement per name
-        "#{name}-#{hash}"
+        @id ||= "#{name}-#{ElementProxy.next_id_number_for(name)}"
       end
-      
+            
+      # Sets id explicitly. Useful in cases of wanting to maintain a stable id
+      def id=(value)
+        @id = value
+      end
+            
       # Subclasses can override with their own selector
       def selector
         "#{name}##{id}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glimmer-dsl-opal
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - AndyMaleh
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-26 00:00:00.000000000 Z
+date: 2020-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: glimmer
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 0.9.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
+        version: 0.9.3
 - !ruby/object:Gem::Dependency
   name: rspec-mocks
   requirement: !ruby/object:Gem::Requirement