glicko2 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b475b65a53c6af5c404f010b22a616f3f645617
-  data.tar.gz: d837d51c7cbc959b810140ea1139d4c654109a22
+  metadata.gz: b36e18b907d4edc5ea6cec402c3d800bd2727e03
+  data.tar.gz: 26eb8e5feb31138e0fc63fe195913eccd950d0dd
 SHA512:
-  metadata.gz: 560eba41bcbcc66ee5036a91be810b3916575c08d9ee5f03fa22514f42e779932ad3c41ecaa6b073f626eae8c36a8fdc07da9dc360a71797ec4ac8845dca2063
-  data.tar.gz: bf6ea3797d64d7735917ae1d25de400db48222ef581d40358e0e921138298edad882d79cc8d358445a7287d9e08b692f7fe3ab287253a3ee9b2b5c78095ed75b
+  metadata.gz: 45efeb808b62315d5bd8bca8dc21c3ea5aa76ec6acd1158e4393add484f85fb80648f7e8ded2ae770d522449f1f5b20816c3baf5d2fe83ac914fc725a2e0a2f5
+  data.tar.gz: 05dbc7c297933d55ec4738d5880908bb9f4a104bab787f9f9f6b0f2d0eb4390bd03f563446a773130a716c6c3727eba11bae21a55f0d3b012295af32ee6c88ce

data/lib/glicko2/rater.rb

@@ -22,18 +22,20 @@ module Glicko2
       delta2 = @delta_pre**2
       sd2 = rating.sd**2
       a = Math.log(rating.volatility**2)
-      f = lambda do |x|
-        expX = Math.exp(x)
-        (expX * (delta2 - sd2 - v - expX)) / (2 * (sd2 + v + expX)**2) - (x - a) / tau**2
+      if v.finite?
+        f = lambda do |x|
+          expX = Math.exp(x)
+          (expX * (delta2 - sd2 - v - expX)) / (2 * (sd2 + v + expX)**2) - (x - a) / tau**2
+        end
+        if delta2 > sd2 + v
+          b = Math.log(delta2 - sd2 - v)
+        else
+          k = 1
+          k += 1 while f.call(a - k * tau) < 0
+          b = a - k * tau
+        end
+        a = Util.illinois_method(a, b, &f)
       end
-      if delta2 > sd2 + v
-        b = Math.log(delta2 - sd2 - v)
-      else
-        k = 1
-        k += 1 while f.call(a - k * tau) < 0
-        b = a - k * tau
-      end
-      a = Util.illinois_method(a, b, &f)
       volatility = Math.exp(a / 2.0)
       sd_pre = Math.sqrt(sd2 + volatility**2)
       sd = 1 / Math.sqrt(1.0 / sd_pre**2 + 1 / v)

data/lib/glicko2/version.rb

@@ -1,3 +1,3 @@
 module Glicko2
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/rater_spec.rb

@@ -1,3 +1,4 @@
+require 'bigdecimal'
 require 'minitest_helper'
 
 class TestRater < Minitest::Test
@@ -6,17 +7,34 @@ class TestRater < Minitest::Test
     @rating1 = Glicko2::Rating.from_glicko_rating(1400, 30)
     @rating2 = Glicko2::Rating.from_glicko_rating(1550, 100)
     @rating3 = Glicko2::Rating.from_glicko_rating(1700, 300)
-    @rater = Glicko2::Rater.new(@rating)
   end
 
   def test_rate_matches_example
-    @rater.add(@rating1, 1.0)
-    @rater.add(@rating2, 0.0)
-    @rater.add(@rating3, 0.0)
-    rating = @rater.rate(0.5)
+    rater = Glicko2::Rater.new(@rating)
+    rater.add(@rating1, 1.0)
+    rater.add(@rating2, 0.0)
+    rater.add(@rating3, 0.0)
+    rating = rater.rate(0.5)
 
     assert_in_delta(-0.2069, rating.mean, 0.00005)
     assert_in_delta(0.8722, rating.sd, 0.00005)
     assert_in_delta(0.05999, rating.volatility, 0.00005)
   end
+
+  def test_rate_no_games
+    rating = Glicko2::Rater.new(@rating).rate(0.5)
+
+    assert_in_delta(@rating.mean, rating.mean, 0.00005)
+    assert_in_delta(Math.sqrt(@rating.sd**2 + @rating.volatility**2), rating.sd, 0.00005)
+    assert_in_delta(Glicko2::DEFAULT_VOLATILITY, rating.volatility, 0.00005)
+  end
+
+  def test_rate_no_games_big_decimal
+    @rating = Glicko2::Rating.from_glicko_rating(BigDecimal.new(1500), BigDecimal.new(200))
+    rating = Glicko2::Rater.new(@rating).rate(0.5)
+
+    assert_in_delta(@rating.mean, rating.mean, 0.00005)
+    assert_in_delta(Math.sqrt(@rating.sd**2 + @rating.volatility**2), rating.sd, 0.00005)
+    assert_in_delta(Glicko2::DEFAULT_VOLATILITY, rating.volatility, 0.00005)
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glicko2
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - James Fargher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-09 00:00:00.000000000 Z
+date: 2017-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler