glib-web 6.10.2 → 7.0.0.beta1

data/lib/generators/templates/snapshot_v2/add_snapshot_v2_columns.rb

@@ -1,18 +0,0 @@
-class AddSnapshotV2Columns < ActiveRecord::Migration[8.0]
-  def change
-    # PostgreSQL has jsonb (binary, indexable); SQLite (used by glib-web's dummy-app) and MySQL
-    # only have json. Pick the richest type the adapter supports so consumers on PG get indexable
-    # diffs while greenfield adopters on SQLite/MySQL still work without edits.
-    diff_type = connection.adapter_name.match?(/PostgreSQL/i) ? :jsonb : :json
-
-    change_table :snapshots, bulk: true do |t|
-      t.string  :action
-      t.integer :version
-      t.column  :diff, diff_type
-      t.string  :source
-    end
-
-    add_index :snapshots, [:action, :item_type, :item_id]
-    add_index :snapshots, [:item_type, :item_id, :version]
-  end
-end

data/lib/generators/templates/snapshot_v2/create_snapshot_blob_references.rb

@@ -1,10 +0,0 @@
-class CreateSnapshotBlobReferences < ActiveRecord::Migration[8.0]
-  def change
-    create_table :snapshot_blob_references do |t|
-      t.belongs_to :snapshot, null: false, foreign_key: { to_table: :snapshots }
-      t.belongs_to :blob, null: false, foreign_key: { to_table: :active_storage_blobs }
-      t.timestamps
-    end
-    add_index :snapshot_blob_references, [:snapshot_id, :blob_id], unique: true
-  end
-end

data/lib/glib/test/full_suite_rubocop.rb

@@ -1,87 +0,0 @@
-# frozen_string_literal: true
-
-require 'English'
-
-module Glib
-  module Test
-    # Suite-wide RuboCop auto-remediation, lifted from the per-project
-    # `test/linters/rubocop_test.rb` convention (originated in neowork-str) so
-    # projects get it from the gem via a CONSCIOUS opt-in: include
-    # Glib::Test::RubocopGuards once in the test setup. Never auto-require
-    # this from Glib::TestHelpers — that would enable a file-rewriting test
-    # in every project without a decision. It lints the WHOLE repo, so files
-    # nobody touches cannot silently accumulate offenses.
-    #
-    # Runs `rubocop -a` (safe autocorrect), which REWRITES files on disk to
-    # fix offenses, then asserts nothing remains AND nothing was rewritten.
-    # The mutation is deliberate (the repo's auto-remediation convention —
-    # i18n-tasks normalize runs the same way): a run that dirties a file is
-    # reported as a FAILURE so the rewrite cannot go unnoticed — that is the
-    # drift signal. Do NOT strip the `-a`; review the diff, keep the corrected
-    # output, and re-run. If a long-passing test suddenly breaks, investigate
-    # WHY first: usually a non-canonical file was committed, or a rubocop
-    # version bump changed a cop's rules.
-    #
-    # It self-registers with Minitest, so it runs on EVERY `rails test`
-    # invocation, single-file runs included. That is cheap on purpose: RuboCop
-    # caches per-file results, so a full-repo run on an unchanged tree costs
-    # about a second on a mid-size app.
-    #
-    # Deliberately does NOT skip under ENV['CI']: the local rails-test
-    # wrapper sets CI=true, and skipping here would silence this layer
-    # exactly where it runs. Opt out per-run with SKIP_FULL_SUITE_RUBOCOP=1.
-    class FullSuiteRubocop < ::ActiveSupport::TestCase
-      # `--format simple` offense lines: "C:  12:  3: [Correctable] Cop/Name: message"
-      # (line/column right-aligned to width 3, so the padding is 0-2 spaces).
-      OFFENSE_LINE = /^[A-Z]: *\d+: *\d+: /
-
-      def test_rubocop_autocorrect_then_clean
-        skip 'opted out via SKIP_FULL_SUITE_RUBOCOP' if ENV['SKIP_FULL_SUITE_RUBOCOP'] == '1'
-
-        # `scrub`: stderr is merged in, and one invalid byte would turn the
-        # scans below into an ArgumentError instead of a lint failure.
-        output = `bundle exec rubocop -a --format simple 2>&1`.scrub
-        clean = $CHILD_STATUS.success?
-
-        # Three distinct outcomes hide in one output, and each needs a
-        # different action — the message must say which, or an agent told
-        # only "offenses detected" reaches for a `rubocop:disable`:
-        #   [Corrected]   -a already rewrote it on disk (exit 0 if that's all)
-        #   [Correctable] survived -a because only the UNSAFE -A can fix it
-        #   neither       no autocorrect exists — semantic, read the cop
-        # Counted on the offense LINES only, so a cop message that happens to
-        # contain a marker cannot shift a bucket.
-        offenses = output.lines.grep(OFFENSE_LINE)
-        corrected = offenses.count { |line| line.include?('[Corrected]') }
-        unsafe = offenses.count { |line| line.include?('[Correctable]') }
-        semantic = offenses.size - corrected - unsafe
-
-        # A Proc message is built only on failure (Minitest calls it lazily).
-        assert(clean && corrected.zero?, -> { failure_message(output, corrected: corrected, unsafe: unsafe, semantic: semantic) })
-      end
-
-      private
-        def failure_message(output, corrected:, unsafe:, semantic:)
-          parts = []
-          if corrected.positive?
-            parts << "`rubocop -a` REWROTE #{corrected} offense(s) on disk (the [Corrected] lines below). That is the " \
-                     'drift signal, not a problem with this test: review `git diff`, keep the corrected output, ' \
-                     'and re-run — do not strip the -a.'
-          end
-          if unsafe.positive?
-            parts << "#{unsafe} offense(s) marked [Correctable] survived `-a` because their fix is UNSAFE: apply it " \
-                     'with `rubocop -A <file>` only after checking what it changes, or fix by hand.'
-          end
-          if semantic.positive?
-            parts << "#{semantic} offense(s) have NO autocorrect, so they are semantic, not mechanical: fix each the " \
-                     "way the cop's own message prescribes — DevDoc cops name their prescribed alternative in the " \
-                     "offense itself (full docs: the dev-doc repo's docs/cops/). A `rubocop:disable` is only for " \
-                     "the case a cop's own doc calls genuinely unavoidable; disables already present in a file are " \
-                     'narrow exceptions, not precedent.'
-          end
-          parts << 'RuboCop did not finish cleanly (see output below).' if parts.empty?
-          "#{parts.join("\n\n")}\n\n#{output}"
-        end
-    end
-  end
-end

data/lib/glib/test/rubocop_guards.rb

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-module Glib
-  module Test
-    # Conscious opt-in for the suite-time RuboCop guard. Including this module
-    # ONCE in the project's test setup IS the project's explicit decision to
-    # run it. It must stay a separate include precisely because
-    # Glib::TestHelpers is mixed in for unrelated reasons (crawlers, travel
-    # helpers): auto-requiring the guard from there would enable it without
-    # any conscious decision, and FullSuiteRubocop runs `rubocop -a`, which
-    # REWRITES files on disk.
-    #
-    #   class ActiveSupport::TestCase
-    #     include Glib::Test::RubocopGuards # opts in: full-suite `rubocop -a`
-    #   end
-    #
-    # This module is defined as soon as the gem loads (glib/test_helpers
-    # requires it at file level), so the include works on its own — in
-    # ActiveSupport::TestCase or in a single test class — with no ordering
-    # dependency on Glib::TestHelpers.
-    #
-    # What the include switches on: Glib::Test::FullSuiteRubocop — `rubocop -a`
-    # over the whole repo on every `rails test` invocation, failing when
-    # anything was rewritten or remains (runs under CI too).
-    #
-    # MIGRATION NOTE: in the published releases before this change (6.9.3 and
-    # earlier as released), Glib::TestHelpers auto-required a report-only
-    # ChangedFilesRubocop guard (working-tree edits only, skipped under CI),
-    # so every project had it without asking. That guard is retired:
-    # FullSuiteRubocop is a superset, and the local rails-test wrapper sets
-    # CI=true, where the old guard never ran anyway. A project bumping to the
-    # first release that contains this change must add the include line above
-    # or it silently has no suite-time RuboCop guard at all.
-    module RubocopGuards
-      extend ActiveSupport::Concern
-
-      included do
-        require 'glib/test/full_suite_rubocop'
-      end
-    end
-  end
-end