glib-web 5.0.9 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66abe13aca7ef703ab65bcbaeded784ff74339b4dcfd3659658bdefc99f0ec30
-  data.tar.gz: a8c90ab7a9684a4eeed86c8d6e25d3676281157c856ed07cd582b5ccdebfa622
+  metadata.gz: 9af6a7a8e8f3cd4b9a45446e58347ff9ecc2130d1ce4f715da68ead1c7646ab5
+  data.tar.gz: 3239c38d6b96f609eb961d5e427121bee47804430475bc0fe0be66a599dcf9ee
 SHA512:
-  metadata.gz: ef265df7cd0d8f0e3d951f384b574cf01e6c4039f774e0df286fb0617ce58be80551cb5e1ccbf05996af4b9127aaa8cfdccbac7f146d22b0816acc6690400814
-  data.tar.gz: e5ba874af4579d1310671a292404a2cb27b8ff89b609ff2a2c0f0ff3609a301a8566d8e3a86099d4a41c9ca6249a19cd00ce78a4cef30c8642e85efed260f07a
+  metadata.gz: 138e70c7c76dcb59f24715c31b6e322cd0bb8d3ee74ac4905f7e0d0ae7d206fc46481c5b47a76d970fc08a1f6a78aa17cb368ac43a79fe98c2251f29e1add74d
+  data.tar.gz: 8f92b011d2a6e1ee72547fcb8cba257accd972b2ff055eb88692c4701cdeabea00bf33bc4e0318e3cc9416078e587c1322911457c0f553ffde27f612bceb77c5

data/app/models/concerns/glib/enum_symbolization.rb

@@ -1,26 +1,80 @@
 module Glib
-  # Class-level helper that overrides one or more enum readers to return a
-  # symbol instead of Rails' default string form. Lets callers compare with
-  # `record.status == :active` without having to remember which form they're
-  # holding (see backend/01a_defensive_programming.md item 7).
+  # Class-level helper for declaring enums that read back as symbols, can never
+  # be persisted nil, and — crucially — know their attribute type even before
+  # the backing column exists.
   #
-  # Usage:
+  # Preferred form (declares everything in one call; use INSTEAD of a bare
+  # `enum`). Because it calls `attribute` before `enum`, the enum's type comes
+  # from the declared values rather than from column introspection, so a model
+  # loaded against a not-yet-migrated column (fresh deploy, eager-loaded CI, an
+  # un-migrated local DB) no longer raises "Undeclared attribute type for enum":
   #
   #   class Order < ApplicationRecord
-  #     enum :payment_status, { draft: 0, pending: 1, finalized: 2 }
-  #     enum :finalize_intent, { unknown: 0, charge: 1 }, prefix: true
+  #     include Glib::EnumSymbolization
   #
-  #     enum_symbolize :payment_status, :finalize_intent
+  #     enum_symbolize :payment_status, { draft: 0, pending: 1, finalized: 2 }
+  #     enum_symbolize :finalize_intent, { unknown: 0, charge: 1 }, prefix: true
   #   end
+  #
+  # The attribute type is inferred from the values: string values back a
+  # :string column, everything else (integer-keyed hashes, positional arrays)
+  # backs an :integer column. Pass the values as a *braced* hash — a bare
+  # `key: 0` list is parsed as keyword options, not values.
+  #
+  # Legacy form (attach presence + symbolized reader to enum(s) already declared
+  # above). Prefer the form above for new code:
+  #
+  #   enum :status, { draft: 0, published: 1 }
+  #   enum_symbolize :status
+  #
+  # Both forms add `validates :attr, presence: true` (a nil enum has no symbolic
+  # key and is almost always a bug) and override the reader to return a symbol,
+  # so callers can compare with `record.status == :active` without tracking
+  # which form they're holding (see backend/01a_defensive_programming.md item 7).
   module EnumSymbolization
     extend ActiveSupport::Concern
 
     class_methods do
-      def enum_symbolize(*attrs)
-        attrs.each do |attr|
-          define_method(attr) { super()&.to_sym }
+      def enum_symbolize(*attrs, **opts)
+        if attrs.size >= 2 && (attrs[1].is_a?(Hash) || attrs[1].is_a?(Array))
+          # Full form: enum_symbolize :name, { ... }[, **enum_opts]
+          name, values = attrs
+          # MUST precede `enum`, and is NOT redundant: `enum` resolves its type
+          # by introspecting the DB column, which raises "Undeclared attribute
+          # type for enum" (RuntimeError) when the column isn't there yet — a
+          # not-yet-migrated column loaded on deploy, eager-loaded CI, or an
+          # un-migrated local DB. Declaring the attribute first pins the type
+          # from the enum's own values, so it no longer needs the column. Do not
+          # remove or move below `enum`.
+          attribute name, Glib::EnumSymbolization.backing_type(values)
+          enum name, values, **opts
+          glib_symbolize_reader(name)
+        else
+          # Legacy form: enum_symbolize :a[, :b, ...] for enums already declared.
+          if opts.any?
+            raise ArgumentError,
+              "enum_symbolize: pass enum values as a braced hash, " \
+              "e.g. enum_symbolize :#{attrs.first}, { ... }"
+          end
+          attrs.each { |attr| glib_symbolize_reader(attr) }
         end
       end
+
+      private
+
+        def glib_symbolize_reader(attr)
+          validates attr, presence: true
+          define_method(attr) { super()&.to_sym }
+        end
+    end
+
+    # Infer the attribute type backing an enum from its declared values, so the
+    # type never depends on the (possibly not-yet-migrated) DB column. A hash
+    # whose values are strings backs a :string column; integer-keyed hashes and
+    # positional arrays back an :integer column.
+    def self.backing_type(values)
+      first = values.is_a?(Hash) ? values.values.first : nil
+      first.is_a?(String) ? :string : :integer
     end
   end
 end

metadata

@@ -1,10 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: glib-web
 version: !ruby/object:Gem::Version
-  version: 5.0.9
+  version: 5.1.0
 platform: ruby
 authors:
 - ''
+autorequire:
 bindir: bin
 cert_chain: []
 date: 2019-10-04 00:00:00.000000000 Z
@@ -149,6 +150,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+description:
 email: ''
 executables: []
 extensions: []
@@ -527,8 +529,10 @@ files:
 - lib/glib/value.rb
 - lib/glib/version.rb
 - lib/tasks/db.rake
+homepage:
 licenses: []
 metadata: {}
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -543,7 +547,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.6
+rubygems_version: 3.4.6
+signing_key:
 specification_version: 4
 summary: ''
 test_files: []