glib-web 4.39.0 → 4.39.2

data/lib/glib/rubocop/cops/json_ui/nested_block_parameter.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require_relative 'base_nested_parameter'
+
+module RuboCop
+  module Cop
+    module Glib
+      module JsonUi
+        # Enforces using the immediate block parameter instead of outer block variables
+        # in nested view blocks (childViews, content) in JsonUi templates.
+        #
+        # @example
+        #   # bad - using outer variable
+        #   scroll.panels_form childViews: ->(form) do
+        #     scroll.label text: 'TEST'  # using 'scroll' instead of 'form'
+        #   end
+        #
+        #   # good
+        #   scroll.panels_form childViews: ->(form) do
+        #     form.label text: 'TEST'
+        #   end
+        #
+        #   # bad - parameter shadowing
+        #   scroll.panels_form childViews: ->(form) do
+        #     form.panels_responsive childViews: ->(form) do  # shadows outer 'form'
+        #       form.fields_text name: 'user[field]'
+        #     end
+        #   end
+        #
+        #   # good
+        #   scroll.panels_form childViews: ->(form) do
+        #     form.panels_responsive childViews: ->(res) do
+        #       res.fields_text name: 'user[field]'
+        #     end
+        #   end
+        class NestedBlockParameter < BaseNestedParameter
+          private
+
+          def relevant_block?(block_node)
+            return false unless lambda_block?(block_node)
+
+            pair = hash_pair_parent(block_node)
+            return false unless pair
+
+            pair.key.sym_type? && [:childViews, :content].include?(pair.key.value)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/glib/rubocop/cops/multiline_method_call_style.rb

@@ -37,6 +37,7 @@ module RuboCop
           return unless multi_line_call_with_args?(node)
           return if proper_parentheses_style?(node)
           return if proper_backslash_style?(node) && allow_backslash?
+          return if inside_correctable_parent?(node)
 
           add_offense(node) do |corrector|
             autocorrect(corrector, node)
@@ -122,12 +123,28 @@ module RuboCop
           args
         end
 
+        def inside_correctable_parent?(node)
+          # Check if this node is inside a block that belongs to a multi-line call
+          # that will also be corrected. If so, skip this node to avoid conflicts.
+          current = node.parent
+
+          while current
+            if current.send_type? || current.csend_type?
+              if multi_line_call_with_args?(current) && !proper_parentheses_style?(current)
+                return true
+              end
+            end
+            current = current.parent
+          end
+
+          false
+        end
+
         def autocorrect(corrector, node)
           method_end_pos = node.loc.selector.end_pos
 
-          # Find the indentation of the method call
-          line_begin_pos = processed_source.buffer.line_range(node.loc.line).begin_pos
-          base_indent = node.source_range.begin_pos - line_begin_pos
+          # Calculate indentation based on the node's actual column position
+          base_indent = node.loc.column
           arg_indent = ' ' * (base_indent + 2)
 
           # Build the new argument list
@@ -137,7 +154,9 @@ module RuboCop
 
             if arg.hash_type?
               arg.pairs.each do |pair|
-                arg_parts << pair.source
+                # Re-indent pair if it contains a block
+                pair_source = reindent_pair_with_block(pair, arg_indent)
+                arg_parts << pair_source
               end
             else
               arg_parts << arg.source
@@ -151,7 +170,7 @@ module RuboCop
 
             # If there's a block, add it on the last argument line
             if node.block_literal?
-              block_source = node.block_literal.source
+              block_source = reindent_block(node.block_literal, arg_indent)
               replacement += " #{block_source}"
             end
 
@@ -175,6 +194,56 @@ module RuboCop
 
           corrector.replace(range, replacement)
         end
+
+        def reindent_pair_with_block(pair, base_indent)
+          # Check if the pair's value is a block
+          return pair.source unless pair.value.block_type?
+
+          # Format: "key: ->(param) do ... end"
+          key_source = pair.key.source
+          block_source = reindent_block(pair.value, base_indent)
+
+          "#{key_source}: #{block_source}"
+        end
+
+        def reindent_block(block_node, base_indent)
+          # Get block source lines
+          source = block_node.source
+          lines = source.lines
+
+          return source if lines.length == 1 # Single line block, no reindent needed
+
+          # Find the current indentation of the block's first line
+          # (this is usually where "do" appears)
+          first_line = lines[0]
+
+          # Process the block:
+          # Line 0: "->(param) do" - keep as is
+          # Lines 1..-2: block body - re-indent to base_indent + 2
+          # Last line: "end" - indent to base_indent
+
+          result_lines = []
+          block_body_indent = base_indent + ' ' * 2
+
+          lines.each_with_index do |line, index|
+            if index == 0
+              # First line: "->(param) do"
+              result_lines << line.rstrip
+            elsif index == lines.length - 1
+              # Last line: "end"
+              result_lines << "#{base_indent}#{line.strip}"
+            else
+              # Body lines: re-indent
+              # Remove existing indentation and add new indentation
+              stripped = line.lstrip
+              next if stripped.empty? # Skip blank lines
+
+              result_lines << "#{block_body_indent}#{stripped.rstrip}"
+            end
+          end
+
+          result_lines.join("\n")
+        end
       end
     end
   end

data/lib/glib/rubocop/cops/test_name_parentheses.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Glib
+      # Prevents test method names from containing parentheses which can cause issues with test runners
+      #
+      # @example
+      #   # bad
+      #   test 'user creation (with email)' do
+      #   end
+      #
+      #   # good
+      #   test 'user creation with email' do
+      #   end
+      class TestNameParentheses < Base
+        MSG = "Test name should not contain parentheses because for some reason, this will produce: 'Syntax error: \"(\" unexpected'."
+
+        def_node_matcher :test_method?, <<~PATTERN
+          (send nil? :test (str $_) ...)
+        PATTERN
+
+        def on_send(node)
+          test_method?(node) do |test_name|
+            if test_name.include?('(') || test_name.include?(')')
+              add_offense(node)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/glib/rubocop.rb

@@ -1,2 +1,6 @@
 require_relative 'rubocop/cops/localize'
 require_relative 'rubocop/cops/multiline_method_call_style'
+require_relative 'rubocop/cops/json_ui/base_nested_parameter'
+require_relative 'rubocop/cops/json_ui/nested_block_parameter'
+require_relative 'rubocop/cops/json_ui/nested_action_parameter'
+require_relative 'rubocop/cops/test_name_parentheses'

data/lib/glib/test/parallel_coverage.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Glib
+  module Test
+    # ParallelCoverage configures Rails parallel testing to work properly with SimpleCov.
+    #
+    # Without this configuration, SimpleCov reports inaccurate coverage (often very low, like 1-2%)
+    # when running tests with parallelization enabled, because it only captures data from one worker
+    # instead of merging results from all parallel workers.
+    #
+    # Usage:
+    #   class ActiveSupport::TestCase
+    #     include Glib::Test::ParallelCoverage
+    #   end
+    #
+    # This will:
+    # - Enable parallel test execution using all available processors
+    # - Configure SimpleCov to track each worker separately
+    # - Automatically merge coverage results from all workers
+    module ParallelCoverage
+      extend ActiveSupport::Concern
+
+      included do
+        # Set threshold for force parallelization.
+        parallelize(workers: :number_of_processors, threshold: 1)
+
+        # Configure SimpleCov to properly merge coverage from parallel workers
+        parallelize_setup do |worker|
+          SimpleCov.command_name "#{SimpleCov.command_name}-#{worker}"
+        end
+
+        parallelize_teardown do |_worker|
+          SimpleCov.result
+        end
+      end
+    end
+  end
+end

data/lib/glib/test_helpers.rb

@@ -83,6 +83,18 @@ module Glib
       "http://#{HOST}/users/sign_out.json"
     end
 
+    def glib_travel(*args, &block)
+      Timecop.travel(*args, &block)
+    end
+
+    def glib_travel_freeze(*args, &block)
+      Timecop.freeze(*args, &block)
+    end
+
+    def glib_travel_back
+      Timecop.return
+    end
+
     private
       def __execute_crawler(user, inspect_http:, log_file: nil, &block)
         auth_token = login user

data/lib/glib-web.rb

@@ -8,6 +8,7 @@ require 'glib/json_crawler'
 
 require 'glib/dynamic_text'
 require 'glib/test_helpers'
+require 'glib/test/parallel_coverage'
 require 'glib/integration_test'
 
 require 'glib/time_freezable_mailer'

data/lib/tasks/db.rake

@@ -63,7 +63,7 @@ namespace :db do
 
           entries.each do |a|
             attrs = Hash[a.attributes.sort]
-            attrs.delete_if { |k, v| v.nil? }
+            # attrs.delete_if { |k, v| v.nil? }
 
             id = if attrs.include?('id')
               [a.id]

data/lib/tasks/docs.rake

@@ -0,0 +1,59 @@
+namespace :glib do
+  namespace :docs do
+    desc 'Generate component documentation in YAML format'
+    task :generate do
+      require_relative '../glib/doc_generator'
+
+      generator = Glib::DocGenerator.new
+
+      # Generate documentation for different component categories
+      categories = [
+        {
+          name: 'panels',
+          file: 'app/helpers/glib/json_ui/view_builder/panels.rb',
+          output: 'doc/components/panels.yml'
+        },
+        {
+          name: 'fields',
+          file: 'app/helpers/glib/json_ui/view_builder/fields.rb',
+          output: 'doc/components/fields.yml'
+        },
+        {
+          name: 'views',
+          file: 'app/helpers/glib/json_ui/view_builder.rb',
+          output: 'doc/components/views.yml'
+        },
+        {
+          name: 'actions',
+          file: 'app/helpers/glib/json_ui/action_builder.rb',
+          output: 'doc/components/actions.yml'
+        }
+      ]
+
+      categories.each do |category|
+        puts "Generating documentation for #{category[:name]}..."
+        generator.generate_for_file(category[:file], category[:output])
+        puts "  -> #{category[:output]}"
+      end
+
+      # Also scan action subdirectories
+      Dir.glob('app/helpers/glib/json_ui/action_builder/*.rb').each do |file|
+        basename = File.basename(file, '.rb')
+        output = "doc/components/actions_#{basename}.yml"
+        puts "Generating documentation for actions/#{basename}..."
+        generator.generate_for_file(file, output)
+        puts "  -> #{output}"
+      end
+
+      puts "\nDocumentation generation complete!"
+    end
+
+    desc 'Validate YARD documentation'
+    task :validate do
+      puts "Validating YARD documentation..."
+      system('yard stats --list-undoc')
+      system('yard doc --fail-on-warning --no-output')
+      puts "\nValidation complete!"
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: glib-web
 version: !ruby/object:Gem::Version
-  version: 4.39.0
+  version: 4.39.2
 platform: ruby
 authors:
 - ''
@@ -156,6 +156,7 @@ files:
 - app/controllers/concerns/glib/json/traversal.rb
 - app/controllers/concerns/glib/json/ui.rb
 - app/controllers/concerns/glib/json/validation.rb
+- app/controllers/glib/api_docs_controller.rb
 - app/controllers/glib/blob_url_generators_controller.rb
 - app/controllers/glib/errors_controller.rb
 - app/controllers/glib/glib_direct_uploads_controller.rb
@@ -220,6 +221,9 @@ files:
 - app/validators/mutually_exclusive_with_validator.rb
 - app/validators/presence_only_if_validator.rb
 - app/validators/url_validator.rb
+- app/views/glib/api_docs/component.json.jbuilder
+- app/views/glib/api_docs/index.json.jbuilder
+- app/views/glib/api_docs/show.json.jbuilder
 - app/views/json_ui/garage/_nav_menu.json.jbuilder
 - app/views/json_ui/garage/actions/_commands.json.jbuilder
 - app/views/json_ui/garage/actions/_components.json.jbuilder
@@ -376,6 +380,7 @@ files:
 - app/views/json_ui/garage/test_page/form.json.jbuilder
 - app/views/json_ui/garage/test_page/form_dynamic.json.jbuilder
 - app/views/json_ui/garage/test_page/lifecycle.json.jbuilder
+- app/views/json_ui/garage/test_page/logics_set.json.jbuilder
 - app/views/json_ui/garage/test_page/multiupload.json.jbuilder
 - app/views/json_ui/garage/test_page/selectable.json.jbuilder
 - app/views/json_ui/garage/test_page/window.json.jbuilder
@@ -422,6 +427,7 @@ files:
 - lib/glib-web.rb
 - lib/glib/all_helpers.rb
 - lib/glib/crypt/utils.rb
+- lib/glib/doc_generator.rb
 - lib/glib/dynamic_text.rb
 - lib/glib/dynamic_text/config.rb
 - lib/glib/engine.rb
@@ -442,15 +448,21 @@ files:
 - lib/glib/json_crawler/router.rb
 - lib/glib/mailer_tester.rb
 - lib/glib/rubocop.rb
+- lib/glib/rubocop/cops/json_ui/base_nested_parameter.rb
+- lib/glib/rubocop/cops/json_ui/nested_action_parameter.rb
+- lib/glib/rubocop/cops/json_ui/nested_block_parameter.rb
 - lib/glib/rubocop/cops/localize.rb
 - lib/glib/rubocop/cops/multiline_method_call_style.rb
+- lib/glib/rubocop/cops/test_name_parentheses.rb
 - lib/glib/snapshot.rb
+- lib/glib/test/parallel_coverage.rb
 - lib/glib/test_helpers.rb
 - lib/glib/time_freezable_mailer.rb
 - lib/glib/time_returning_mailer.rb
 - lib/glib/value.rb
 - lib/glib/version.rb
 - lib/tasks/db.rake
+- lib/tasks/docs.rake
 homepage:
 licenses: []
 metadata: {}