glia-errors 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f938565ae0608918f0808c950e1d2621f7d8ef2d347cb9146a37fc1af461a519
-  data.tar.gz: 7d8d9672987fe83c77884532e052adee18e3e980462176b6482dd1a41fb755ec
+  metadata.gz: 5c7f5990ad3700b39cf8e730592d7a0e1bb41968015c54c648f341e329679852
+  data.tar.gz: 56963475888904d6d252deb42667536caeb1a7ff96c7bbb35d5204395f60723d
 SHA512:
-  metadata.gz: f09300cb765f7ce0fe8d57cce7f8259303acd5dec9ffd61a36307ba0afb9d89c17ca95eb8010526a442ab0028da8fc9c61821f7fbe3cd5727c5d0df2a33e3821
-  data.tar.gz: 8208ee1f6c9e00975df486a1d8fb3f1457f38a576970f15485191f9639340b0ff5247dbcf527f2474ef1f0696ff519994985e9917c91949c33c9e6bcbc9a3c42
+  metadata.gz: 7a09bd918e4be8fb7463523004703cf8d94e1a709f70f545f3b8f1d51384c5ba9a2be31c0a0b633042b9eec610003251b1fceb122d266c667ff18f4789487ef1
+  data.tar.gz: 4749bb8358fc6a1dc3f8940ae9ef5424cfdb65bef2361a529ea591890e86a8ec43a1b33207be110e7404c0ae270bd0cb197bfe11d744583ef698cce02cbbc3fe

data/glia-errors.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'glia-errors'
-  spec.version       = '0.7.0'
+  spec.version       = '0.8.0'
   spec.authors       = ['Glia TechMovers']
   spec.email         = ['techmovers@glia.com']
 

data/lib/glia/errors/client_errors.rb

@@ -19,7 +19,7 @@ module Glia
         super(
           type: INVALID_NUMBER_ERROR,
           ref: create_ref(INVALID_NUMBER_ERROR),
-          message: message || "#{humanize(field)} value is invalid"
+          message: message || "#{Naming.humanize(field)} value is invalid"
         )
       end
     end
@@ -29,7 +29,7 @@ module Glia
         super(
           type: INVALID_VALUE_ERROR,
           ref: create_ref(INVALID_VALUE_ERROR),
-          message: message || "#{humanize(field)} value is invalid"
+          message: message || "#{Naming.humanize(field)} value is invalid"
         )
       end
     end
@@ -39,7 +39,7 @@ module Glia
         super(
           type: INVALID_LENGTH_ERROR,
           ref: create_ref(INVALID_LENGTH_ERROR),
-          message: message || "#{humanize(field)} length is invalid"
+          message: message || "#{Naming.humanize(field)} length is invalid"
         )
       end
     end
@@ -54,13 +54,34 @@ module Glia
 
       def initialize(field:, format: nil, message: nil)
         default_message =
-          format ? "has invalid format, required format is #{format}" : 'has invalid format'
+          if format
+            "has invalid format, required format is #{humanize_format(format)}"
+          else
+            'has invalid format'
+          end
         super(
           type: INVALID_FORMAT_ERROR,
           ref: create_ref(INVALID_FORMAT_ERROR),
-          message: message || "#{humanize(field)} #{default_message}"
+          message: message || "#{Naming.humanize(field)} #{default_message}"
         )
       end
+
+      private
+
+      def humanize_format(format)
+        case format
+        when Formats::DATE
+          'ISO-8601 date'
+        when Formats::TIME
+          'ISO-8601 time'
+        when Formats::DATE_TIME
+          'ISO-8601 date and time'
+        when Formats::UUID
+          'UUID'
+        else
+          raise 'Unexpected InvalidFormatError format'
+        end
+      end
     end
 
     class InvalidTypeError < Error
@@ -77,7 +98,7 @@ module Glia
         super(
           type: INVALID_TYPE_ERROR,
           ref: create_ref(INVALID_TYPE_ERROR),
-          message: message || "#{humanize(field)} must be of type #{type}",
+          message: message || "#{Naming.humanize(field)} must be of type #{type}",
           error_details: { type: type }
         )
       end
@@ -88,7 +109,7 @@ module Glia
         super(
           type: MISSING_VALUE_ERROR,
           ref: create_ref(MISSING_VALUE_ERROR),
-          message: message || "#{humanize(field)} is missing"
+          message: message || "#{Naming.humanize(field)} is missing"
         )
       end
     end
@@ -98,7 +119,7 @@ module Glia
         super(
           type: UNKNOWN_ERROR,
           ref: create_ref(UNKNOWN_ERROR),
-          message: message || "#{humanize(field)} validation failed with unknown error"
+          message: message || "#{Naming.humanize(field)} validation failed with unknown error"
         )
       end
     end
@@ -110,7 +131,7 @@ module Glia
         super(
           type: RESOURCE_NOT_FOUND_ERROR,
           ref: create_ref(RESOURCE_NOT_FOUND_ERROR),
-          message: message || "#{humanize(resource)} not found",
+          message: message || "#{Naming.humanize(resource)} not found",
           error_details: { resource: resource }
         )
       end
@@ -123,7 +144,7 @@ module Glia
         super(
           type: NOT_VERIFIED_ERROR,
           ref: create_ref(NOT_VERIFIED_ERROR),
-          message: message || "#{humanize(resource)} is not verified",
+          message: message || "#{Naming.humanize(resource)} is not verified",
           error_details: { resource: resource }
         )
       end
@@ -136,25 +157,25 @@ module Glia
 
         default_message =
           "cannot be modified/deleted because it is associated to one or more #{
-            humanize(associated_resource)
+            Naming.humanize(associated_resource)
           }(s)"
         super(
           type: REMAINING_ASSOCIATION_ERROR,
           ref: create_ref(REMAINING_ASSOCIATION_ERROR),
-          message: message || "#{humanize(resource)} #{default_message}",
+          message: message || "#{Naming.humanize(resource)} #{default_message}",
           error_details: { resource: resource, associated_resource: associated_resource }
         )
       end
     end
 
-    class LimitExceededError < Error
+    class ResourceLimitExceededError < Error
       def initialize(resource:, max:, message: nil)
         assert_snake_case(resource)
 
         super(
           type: LIMIT_EXCEEDED_ERROR,
           ref: create_ref(LIMIT_EXCEEDED_ERROR),
-          message: message || "#{humanize(resource)} count must not exceed #{max}",
+          message: message || "#{Naming.humanize(resource)} count must not exceed #{max}",
           error_details: { resource: resource, max: max }
         )
       end
@@ -167,7 +188,7 @@ module Glia
         super(
           type: RESOURCE_ALREADY_EXISTS_ERROR,
           ref: create_ref(RESOURCE_ALREADY_EXISTS_ERROR),
-          message: message || "#{humanize(resource)} already exists",
+          message: message || "#{Naming.humanize(resource)} already exists",
           error_details: { resource: resource }
         )
       end
@@ -181,7 +202,7 @@ module Glia
         super(
           type: INVALID_RESOURCE_STATE_ERROR,
           ref: create_ref(INVALID_RESOURCE_STATE_ERROR),
-          message: message || "#{humanize(resource)} is in invalid state: #{state}",
+          message: message || "#{Naming.humanize(resource)} is in invalid state: #{state}",
           error_details: { resource: resource, state: state }
         )
       end
@@ -206,6 +227,26 @@ module Glia
         )
       end
     end
+
+    class RouteNotFoundError < Error
+      def initialize(message: nil)
+        super(
+          type: ROUTE_NOT_FOUND_ERROR,
+          ref: create_ref(ROUTE_NOT_FOUND_ERROR),
+          message: message || 'Route not found'
+        )
+      end
+    end
+
+    class MalformedInputError < Error
+      def initialize(message: nil)
+        super(
+          type: MALFORMED_INPUT_ERROR,
+          ref: create_ref(MALFORMED_INPUT_ERROR),
+          message: message || 'Request is malformed'
+        )
+      end
+    end
     # rubocop:enable Style/Documentation
   end
 end

data/lib/glia/errors/error.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative './naming'
+
 module Glia
   module Errors
     # Base error
@@ -43,12 +45,6 @@ module Glia
           [TrueClass, FalseClass, String, Integer, Float, Symbol].include?(details.class)
       end
 
-      # Converts from camel_case to capitalized more human readable value
-      # first_name => "First name"
-      def humanize(value)
-        value.to_s.capitalize.gsub('_', ' ')
-      end
-
       def assert_snake_case(value)
         return if value.to_s.match(SNAKE_CASE_REGEX)
 

data/lib/glia/errors/error_types.rb

@@ -19,6 +19,8 @@ module Glia
     INVALID_RESOURCE_STATE_ERROR = 'invalid_resource_state_error'
     AUTHORIZATION_ERROR = 'authorization_error'
     RECIPIENT_OPTED_OUT_ERROR = 'recipient_opted_out_error'
+    ROUTE_NOT_FOUND_ERROR = 'route_not_found_error'
+    MALFORMED_INPUT_ERROR = 'malformed_input_error'
 
     # Server errors
     INTERNAL_SERVER_ERROR = 'internal_server_error'

data/lib/glia/errors/naming.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module Glia
+  module Errors
+    # Utilities for variable and resouce names
+    module Naming
+      # Converts from camel_case to more human readable value
+      # first_name => "First name"
+      # site_id => "Site ID"
+      def self.humanize(value)
+        result = value.to_s.split('_').map { |word| upcase_if_abbreviation(word) }.join(' ')
+
+        upcase_first(result)
+      end
+
+      ABBREVIATIONS = %w[id uuid saml sip sms mms].freeze
+      PLURAL_ABBREVIATIONS = %w[ids uuids].freeze
+
+      private_class_method def self.upcase_if_abbreviation(value)
+        if ABBREVIATIONS.include?(value)
+          value.upcase
+        elsif PLURAL_ABBREVIATIONS.include?(value)
+          value[0..-2].upcase.concat('s')
+        else
+          value
+        end
+      end
+
+      private_class_method def self.upcase_first(value)
+        value[0].upcase.concat(value[1..-1])
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: glia-errors
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Glia TechMovers
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-05 00:00:00.000000000 Z
+date: 2021-03-12 00:00:00.000000000 Z
 dependencies: []
 description: ''
 email:
@@ -37,6 +37,7 @@ files:
 - lib/glia/errors/error.rb
 - lib/glia/errors/error_types.rb
 - lib/glia/errors/mapper.rb
+- lib/glia/errors/naming.rb
 - lib/glia/errors/server_errors.rb
 homepage:
 licenses: