glare 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7176b88b94cbb8eb1635f374010d3781c9abcb92
-  data.tar.gz: 23dfafaf1b6c0fd137615c3bf6671a43f9c28ec9
+  metadata.gz: 1375fe0ef33d737b01e0dece0f214b7fa235a8c6
+  data.tar.gz: d24dd0a4e9a7b2d6862fc111e835512390487c16
 SHA512:
-  metadata.gz: b48e09275b67e1246760bec68ec00a55e0ee59034bc6a09501e814c792ee532321170a3fdbda25d16c41c139f0802c1d6e537fe20fdf85259f63a1549fcdc5b7
-  data.tar.gz: 93b4c521285065f59d378dd0cc6713ba65ed3b724895097975a464b51b83c2e35aa5448a11d1f748f36500daff52c8e7161a9075837e29bb4356c185aa761bbc
+  metadata.gz: fa4b548a630e1166cb668829da854571655042ada1636edb7d874b712a8c22a4e8ad0df61054ba99cad206176cc5b031d1f48554467271154165cdf56528d7a4
+  data.tar.gz: 406d2c08de74f586c3007c50cc6fbea13738ca585cd5dbfaee7cce5ef22e91504c21bc25eedc2174d3a87f45500de549575a4e770355152bf1a184a324a97447

data/lib/glare/api_response.rb

@@ -1,3 +1,5 @@
+require 'glare/errors'
+
 module Glare
   class ApiResponse
     def initialize(response)
@@ -9,7 +11,7 @@ module Glare
     end
 
     def valid!
-      raise Glare::Errors::ApiError unless success?
+      raise Glare::Errors::ApiError.new(errors) unless success?
       self
     end
 
@@ -22,5 +24,9 @@ module Glare
     def content
       @response.content
     end
+
+    def errors
+      content['errors'].map { |e| e['message'] }.join(',')
+    end
   end
 end

data/lib/glare/version.rb

@@ -1,3 +1,3 @@
 module Glare
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.2.1'.freeze
 end

data/spec/fixtures/error_response.json

@@ -0,0 +1,17 @@
+{
+  "errors": [
+    {
+      "code": 1004,
+      "error_chain": [
+        {
+          "code": 9007,
+          "message": "Content for CNAME record is invalid"
+        }
+      ],
+      "message": "DNS Validation Error"
+    }
+  ],
+  "messages": [],
+  "result": null,
+  "success": false
+}

data/spec/spec_helper.rb

@@ -95,3 +95,9 @@ RSpec.configure do |config|
   # as the one that triggered the failure.
   Kernel.srand config.seed
 end
+
+def load_fixture(fixture)
+  fixture_dir = File.expand_path(File.join(File.dirname(__FILE__), 'fixtures'))
+  json = IO.read(File.join(fixture_dir, "#{fixture}.json"))
+  ::HTTP::Message.new_response(JSON.parse(json))
+end

data/spec/units/api_response_spec.rb

@@ -0,0 +1,30 @@
+require 'glare/api_response'
+require 'httpclient/http'
+
+RSpec.describe Glare::ApiResponse do
+  let(:error_response) { load_fixture('error_response') }
+  let(:empty_response) { load_fixture('empty_result') }
+
+  context 'when api returns success response' do
+    it 'returns api reponse' do
+      expect do
+        Glare::ApiResponse.new(empty_response).valid!
+      end.not_to raise_error
+    end
+  end
+
+  context 'when api returns error response' do
+    it 'raises an exception if api result is not success' do
+      expect do
+        Glare::ApiResponse.new(error_response).valid!
+      end.to raise_error(Glare::Errors::ApiError)
+    end
+
+    it 'shows error messages' do
+      expect do
+        Glare::ApiResponse.new(error_response).valid!
+      end.to raise_error(Glare::Errors::ApiError).
+        with_message('DNS Validation Error')
+    end
+  end
+end

data/spec/units/glare_spec.rb

@@ -220,10 +220,4 @@ RSpec.describe Glare do
       )
     end
   end
-
-  def load_fixture(fixture)
-    fixture_dir = File.expand_path(File.join(File.dirname(__FILE__), '..', 'fixtures'))
-    json = IO.read(File.join(fixture_dir, "#{fixture}.json"))
-    ::HTTP::Message.new_response(JSON.parse(json))
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: glare
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Jose Luis Salas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-28 00:00:00.000000000 Z
+date: 2016-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -109,10 +109,12 @@ files:
 - lib/glare/version.rb
 - spec/delete_domain_spec.rb
 - spec/fixtures/empty_result.json
+- spec/fixtures/error_response.json
 - spec/fixtures/list_zone.json
 - spec/fixtures/wadus_records.json
 - spec/resolve_domain_spec.rb
 - spec/spec_helper.rb
+- spec/units/api_response_spec.rb
 - spec/units/glare_spec.rb
 homepage: https://github.com/peertransfer/glare
 licenses:
@@ -139,6 +141,7 @@ signing_key:
 specification_version: 4
 summary: API client for CloudFlare v4 API
 test_files:
+- spec/units/api_response_spec.rb
 - spec/units/glare_spec.rb
 - spec/delete_domain_spec.rb
 - spec/resolve_domain_spec.rb
@@ -146,3 +149,4 @@ test_files:
 - spec/fixtures/wadus_records.json
 - spec/fixtures/empty_result.json
 - spec/fixtures/list_zone.json
+- spec/fixtures/error_response.json