gl_rubocop 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7ca20c8ca0cc4d308bc2d9e9c45163cefa6b31d0fcd180bec82709909ad821fb
-  data.tar.gz: 1e9b7359fa2212617b2bcc3873d47703e36e40c01afba7ce22ddfcc07684162d
+  metadata.gz: bf30e57276cc5fb133db57872ab6fbe5a3d0192b4c35f9df35646f5d9b7c05a1
+  data.tar.gz: 27f959d4840ffecab6af0ffd59bf93c521a416b66e8bc42bcae01294ae09b2a3
 SHA512:
-  metadata.gz: 962abd8241aec7d0c7f31ddf561c71c5237b502b59fe83e7902d3bd0e6d5920d29a2a17fcef81c4a9e11b1d0520c3e12f3ce91ba0f83fb6bb0ffa06ea6f595f0
-  data.tar.gz: 93079a33074a9dd74dda1a17aaee79452000cd40495ce03f9570260c9ad7aed86d88e8c68b09cd35b5f7937edfc6ccf30475402ffc698ffb568b0c41413d4e56
+  metadata.gz: 63e9e63133312891dbde83ab278c5e2339c236aaa68b06150a79c30964948a49ee7f3efa61ec9e693a9d7c416e3d8b1cbd83d5318c340a24e315ee992978cce9
+  data.tar.gz: 3c245249b4c1f8e1b83064c3fdee06cf142d60556f0774d419726743d154ab2692864916b0b02e77fceea66089f38f2f862abba9009adb1912a3eac8850eb8f5

data/default.yml

@@ -1,13 +1,18 @@
-require:
+plugins:
   - rubocop-performance
   - rubocop-rails
   - rubocop-rspec
-  - rubocop-magic_numbers
+  - rubocop-capybara
+  - rubocop-rspec_rails
+  - rubocop-factory_bot
   - rubocop-erb
   - rubocop-haml
   - rubocop-i18n
   - rubocop-rake
   - rubocop-sorbet
+
+require:
+  - rubocop-magic_numbers
   - ./lib/gl_rubocop/gl_cops/callback_method_names.rb
   - ./lib/gl_rubocop/gl_cops/consolidate_request_system_specs.rb
   - ./lib/gl_rubocop/gl_cops/interactor_inherits_from_interactor_base.rb
@@ -55,10 +60,7 @@ AllCops:
     - "vendor/**/*"
     - "bin/**/*"
 
-Capybara/ClickLinkOrButtonStyle:
-  EnforcedStyle: link_or_button
-
-Capybara/NegationMatcher:
+Capybara/RSpec/NegationMatcher:
   EnforcedStyle: not_to
 
 GLCops/CallbackMethodNames:
@@ -325,11 +327,6 @@ RSpec/ExampleLength:
     - "spec/serializers/**/*"
   Max: 30
 
-RSpec/FilePath:
-  Enabled: true
-  Exclude:
-    - "packs/*/spec/**/*" # Because of automatic namespacing
-
 RSpec/HookArgument:
   Exclude:
     - "spec/support/**/*"
@@ -434,6 +431,9 @@ Sorbet/AllowIncompatibleOverride:
 Sorbet/BindingConstantWithoutTypeAlias:
   Enabled: false
 
+Sorbet/BlockMethodDefinition:
+  Enabled: false
+
 Sorbet/BuggyObsoleteStrictMemoization:
   Enabled: false
 

data/gl_rubocop.gemspec

@@ -23,16 +23,19 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 1.62.1'
-  spec.add_dependency 'rubocop-erb'
-  spec.add_dependency 'rubocop-haml'
-  spec.add_dependency 'rubocop-i18n'
+  spec.add_dependency 'rubocop', '~> 1.90'
+  spec.add_dependency 'rubocop-capybara', '>= 2.23'
+  spec.add_dependency 'rubocop-erb', '>= 0.6'
+  spec.add_dependency 'rubocop-factory_bot', '>= 2.27'
+  spec.add_dependency 'rubocop-haml', '>= 0.3'
+  spec.add_dependency 'rubocop-i18n', '>= 3.2'
   spec.add_dependency 'rubocop-magic_numbers'
-  spec.add_dependency 'rubocop-performance'
-  spec.add_dependency 'rubocop-rails'
-  spec.add_dependency 'rubocop-rake'
-  spec.add_dependency 'rubocop-rspec', '~> 2.25'
-  spec.add_dependency 'rubocop-sorbet'
+  spec.add_dependency 'rubocop-performance', '>= 1.24'
+  spec.add_dependency 'rubocop-rails', '>= 2.30'
+  spec.add_dependency 'rubocop-rake', '>= 0.7'
+  spec.add_dependency 'rubocop-rspec', '~> 3.5'
+  spec.add_dependency 'rubocop-rspec_rails', '>= 2.31'
+  spec.add_dependency 'rubocop-sorbet', '>= 0.9'
 
   spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb

@@ -5,7 +5,7 @@ module GLRubocop
 
       def on_class(klass)
         return unless klass.instance_of?(RuboCop::AST::ClassNode)
-        return if klass.parent_class.present? || klass.identifier.short_name == :SidekiqJob
+        return if klass.parent_class || klass.identifier.short_name == :SidekiqJob
 
         add_offense(klass)
       end

data/lib/gl_rubocop/gl_cops/tailwind_no_contradicting_class_name.rb

@@ -19,7 +19,7 @@ module GLRubocop
     #   tw:h-5
     #   %button.tw:m-4.tw:p-8
 
-    # rubocop:disable Metrics/ClassLength
+    # rubocop:disable-next Metrics/ClassLength
     class TailwindNoContradictingClassName < RuboCop::Cop::Cop
       include GLRubocop::HamlContentHelper
       include GLRubocop::ErbContentHelper
@@ -240,7 +240,7 @@ module GLRubocop
         class_name.start_with?(GIVELIVELY_TAILWIND_CLASS_PREFIX)
       end
 
-      # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      # rubocop:disable-next Metrics/AbcSize, Metrics/MethodLength
       def find_contradicting_classes(classes)
         # Remove the 'tw:' prefix for property matching
         normalized_classes = classes.map { |class_name| class_name.sub(matcher, '') }
@@ -267,7 +267,6 @@ module GLRubocop
 
         contradictions
       end
-      # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
       def contradiction_found?(first_class_data, second_class_data)
         breakpoint_ranges_overlap?(first_class_data[:breakpoint_range],
@@ -310,7 +309,7 @@ module GLRubocop
         property && CONTRADICTION_GROUPS.any? { |_, group| group.include?(property) }
       end
 
-      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable-next Metrics/MethodLength
       def extract_css_property(class_name)
         # Remove container query prefix (e.g., @md:)
         class_without_container = class_name.sub(/^@([a-zA-Z0-9_-]+):/, '')
@@ -363,7 +362,6 @@ module GLRubocop
 
         nil
       end
-      # rubocop:enable Metrics/MethodLength
 
       def extract_breakpoint_range(class_name)
         # Extract breakpoint range (e.g., 'md', 'lg:max-xl', 'sm:max-md')
@@ -418,6 +416,5 @@ module GLRubocop
         first_prop_group.intersect?(second_prop_group)
       end
     end
-    # rubocop:enable Metrics/ClassLength
   end
 end

data/lib/gl_rubocop/gl_cops/unique_identifier.rb

@@ -50,7 +50,7 @@ module GLRubocop
       end
 
       def valid_method_name?(node)
-        node.method_name == :render || node.method_name == :template
+        %i[render template].include?(node.method_name)
       end
     end
   end

data/lib/gl_rubocop/gl_cops/view_component_class_naming.rb

@@ -20,16 +20,14 @@ module GLRubocop
       def on_class(node)
         parent_class = node.parent_class&.const_name
         if parent_class == 'ApplicationViewComponent'
-          return true if node.identifier.const_name == 'Component'
+          return if node.identifier.const_name == 'Component'
 
           add_offense(node, message: 'ViewComponent class names must be "Component".')
         end
-        if parent_class == 'ApplicationViewComponentPreview'
-          return true if node.identifier.const_name == 'ComponentPreview'
+        return unless parent_class == 'ApplicationViewComponentPreview'
+        return if node.identifier.const_name == 'ComponentPreview'
 
-          add_offense(node, message: 'ViewComponentPreview class names must be "ComponentPreview".')
-        end
-        true
+        add_offense(node, message: 'ViewComponentPreview class names must be "ComponentPreview".')
       end
     end
   end

data/lib/gl_rubocop/version.rb

@@ -1,3 +1,3 @@
 module GLRubocop
-  VERSION = '0.6.0'.freeze
+  VERSION = '0.7.0'.freeze
 end

metadata

@@ -1,13 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Give Lively
+autorequire:
 bindir: exe
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2026-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -15,56 +16,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.62.1
+        version: '1.90'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.62.1
+        version: '1.90'
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.23'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.23'
 - !ruby/object:Gem::Dependency
   name: rubocop-erb
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.6'
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.27'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.27'
 - !ruby/object:Gem::Dependency
   name: rubocop-haml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.3'
 - !ruby/object:Gem::Dependency
   name: rubocop-i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: rubocop-magic_numbers
   requirement: !ruby/object:Gem::Requirement
@@ -85,70 +114,86 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.24'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.24'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.30'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.30'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.25'
+        version: '3.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.25'
+        version: '3.5'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.31'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '2.31'
 - !ruby/object:Gem::Dependency
   name: rubocop-sorbet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -193,6 +238,7 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -207,7 +253,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.10
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: A shareable configuration of Give Lively's rubocop rules.
 test_files: []