gl_rubocop 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cfa3a041b813576c82945878a3a5b712cddc171ee7e490a562c8186c8a078122
-  data.tar.gz: 59c4a3a19c71605f920bb21ca0b76ef965385e94836d8965b9735164cf227b7c
+  metadata.gz: c142a90b62896eea7a2ef83f59c565463529eb5eec02d5f7e3d1f5c892f7ae4e
+  data.tar.gz: 2539a4287220284a0b69200f3a86b42d213bec3f8950667560f34fe37ca7a389
 SHA512:
-  metadata.gz: 240a0d83e8b317ef314783c0ff96c3f56cc1af17f144dda86d9048d791ecadb41d3408776831a5130ea8396467def9d65d524c778846539f32828565a742d2cc
-  data.tar.gz: d4870f2db16c75c7843df195c9a4f0a3b96e412ffedd20489368e7ad634a46933253ee56bd0f61f649edd35465b997d561d2f20618e8b1bcabae2977e7a1bcfe
+  metadata.gz: 3d7b1e1bbea93e8fb6427c79d16636f6a58ba376ee233189bdd18351cc6597f3b71338163e5d23477c2566c3ac3c91f7086cf5db819c6f6de9f429261f2bd8d0
+  data.tar.gz: a2739ce3a9419792deb3e42362e8f8ae454b7551c64695ac92e6859075db7927a9fc83409c5f854d079d966e829d2fed3bea87ac18adb29a29bed55c9e8841d0

data/default.yml

@@ -66,6 +66,10 @@ GLCops/SidekiqInheritsFromSidekiqJob:
     - "app/**/*_worker.rb"
     - "app/**/*_job.rb"
 
+GLCops/TailwindNoContradictingClassName:
+  # Disabling the tailwind no contradicting class name for some fixes
+  Enabled: false
+
 GLCops/UniqueIdentifier:
   Enabled: true
   Include:

data/lib/gl_rubocop/gl_cops/unique_identifier.rb

@@ -4,23 +4,18 @@ module GLRubocop
       # This cop ensures that view components include a data-test-id attribute.
       #
       # Good:
-      #   {data-test-id: 'unique-id'}
-      #   {data-test-id: @unique_id }
-      #   {'data-test-id': 'unique-id'}
-      #   {"data-test-id": "unique-id"}
-      #   {data: {test-id: 'unique-id'}}
-      #   {data: {'test-id': 'unique-id'}}
+      #   data-test-id="unique-id"
       #
       # Bad:
-      #   {data: {testId: "unique-id"}}
-      #   {data: {test: {id: "unique-id"}}
-
+      #   data-testid="unique-id"
+      #   data-testId="unique-id"
+      #   data-test_id="unique-id"
       MSG = 'View components must include a data-test-id attribute'.freeze
       EMPTY_MSG = 'data-test-id attribute must not be empty'.freeze
-      UNIQUE_IDENTIFIER = 'test-id'.freeze
+      UNIQUE_IDENTIFIER = 'data-test-id='.freeze
 
       def on_send(node)
-        return unless file_exists? && valid_method_name?(node)
+        return unless file_exists? && valid_file_name? && valid_method_name?(node)
 
         return add_offense(node) unless raw_content.include?(UNIQUE_IDENTIFIER)
 
@@ -33,6 +28,10 @@ module GLRubocop
         File.exist?(processed_source.file_path)
       end
 
+      def valid_file_name?
+        File.basename(processed_source.file_path) == 'component.html.erb'
+      end
+
       def identifiable_line
         line_number = raw_content.lines.find_index { |line| line.include?(UNIQUE_IDENTIFIER) }
         raw_content.lines[line_number]
@@ -42,18 +41,12 @@ module GLRubocop
         @raw_content ||= File.read(processed_source.file_path)
       end
 
-      def regex_for_indentifier_and_value
-        key = Regexp.quote(UNIQUE_IDENTIFIER)
-        /(?:["']?data-#{key}["']?|data:.?\{["']?#{key}["']?):\s*(["']([^"']*)["']|@\w+)/
-      end
-
       def test_id_value
-        match = identifiable_line.match(regex_for_indentifier_and_value)
+        str_match = identifiable_line[/data-test-id=('|")[^'|"]*/]
 
-        return '' unless match
+        return '' unless str_match
 
-        value = match[1]
-        value.start_with?('"', "'") ? value[1..-2] : value
+        str_match.gsub(/data-test-id=./, '')
       end
 
       def valid_method_name?(node)

data/lib/gl_rubocop/version.rb

@@ -1,3 +1,3 @@
 module GLRubocop
-  VERSION = '0.3.0'.freeze
+  VERSION = '0.3.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-10-31 00:00:00.000000000 Z
+date: 2025-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop