gl_rubocop 0.2.3 → 0.2.5
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/lib/gl_rubocop/gl_cops/unique_identifier.rb +9 -3
- data/lib/gl_rubocop/version.rb +1 -1
- metadata +2 -2
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 2cf48112bc9eafd596804f516e47f35112f8fe783c89824927baabe203358c36
|
|
4
|
+
data.tar.gz: 1f5b3d7bbdb11915a6afd5aaeca0bed5ea6432d8670161d7e8ff562aa563d1a4
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: fccd43ad5c6c29f83384b87c1b0bf2b01872ec0a5d311bb30954a4cfa9724f71cd8a96a9efeee76fb807f37f9e08b4db8f066f2c57fed60f5ce6065a9b96bf9a
|
|
7
|
+
data.tar.gz: 991618a3e4e97f685a4886ad2f392b813637dc7af86ac8332da4aab6dddd2751ca5648e447c3d96c8434a45fec3126b39a58712f351aad7321e6727d334593c4
|
|
@@ -4,7 +4,12 @@ module GLRubocop
|
|
|
4
4
|
# This cop ensures that view components include a data-test-id attribute.
|
|
5
5
|
#
|
|
6
6
|
# Good:
|
|
7
|
-
# {data-test-id:
|
|
7
|
+
# {data-test-id: 'unique-id'}
|
|
8
|
+
# {data-test-id: @unique_id }
|
|
9
|
+
# {'data-test-id': 'unique-id'}
|
|
10
|
+
# {"data-test-id": "unique-id"}
|
|
11
|
+
# {data: {test-id: 'unique-id'}}
|
|
12
|
+
# {data: {'test-id': 'unique-id'}}
|
|
8
13
|
#
|
|
9
14
|
# Bad:
|
|
10
15
|
# {data: {testId: "unique-id"}}
|
|
@@ -12,7 +17,7 @@ module GLRubocop
|
|
|
12
17
|
|
|
13
18
|
MSG = 'View components must include a data-test-id attribute'.freeze
|
|
14
19
|
EMPTY_MSG = 'data-test-id attribute must not be empty'.freeze
|
|
15
|
-
UNIQUE_IDENTIFIER = '
|
|
20
|
+
UNIQUE_IDENTIFIER = 'test-id'.freeze
|
|
16
21
|
|
|
17
22
|
def on_send(node)
|
|
18
23
|
return unless file_exists? && valid_method_name?(node)
|
|
@@ -38,7 +43,8 @@ module GLRubocop
|
|
|
38
43
|
end
|
|
39
44
|
|
|
40
45
|
def regex_for_indentifier_and_value
|
|
41
|
-
|
|
46
|
+
key = Regexp.quote(UNIQUE_IDENTIFIER)
|
|
47
|
+
/(?:["']?data-#{key}["']?|data:.?\{["']?#{key}["']?):\s*(["']([^"']*)["']|@\w+)/
|
|
42
48
|
end
|
|
43
49
|
|
|
44
50
|
def test_id_value
|
data/lib/gl_rubocop/version.rb
CHANGED
metadata
CHANGED
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: gl_rubocop
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 0.2.
|
|
4
|
+
version: 0.2.5
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Give Lively
|
|
8
8
|
autorequire:
|
|
9
9
|
bindir: exe
|
|
10
10
|
cert_chain: []
|
|
11
|
-
date: 2025-01-
|
|
11
|
+
date: 2025-01-16 00:00:00.000000000 Z
|
|
12
12
|
dependencies:
|
|
13
13
|
- !ruby/object:Gem::Dependency
|
|
14
14
|
name: rubocop
|