gl_rubocop 0.2.17 → 0.2.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '000623795bad5a89e554dbc2774b53e05ff5e032cbda1ae383c328ba4b47b288'
-  data.tar.gz: 73ba4a320bd8a2f3676cc8b4e491e65c0b4d7cb2605288fc51521c28c2ea9208
+  metadata.gz: bd4eb564bfaea4ae8ab15506ff2196070f55223989f1ac9504f281913a55dd6c
+  data.tar.gz: 931bb25c4f11632bacfada61d5cf99306dbfddf1d4ba056f9ee773f86a876e6c
 SHA512:
-  metadata.gz: 40220d47e0dfb92de08a9ecf69508a97d6b3cc53699c33cddb590f7a10b5f8681c7ad611c849f9025e040ceefcfc6c24838f4efef70abd0cda3deef5e669be8b
-  data.tar.gz: c7ad410f1a653213ec1f18e9b8fa1effb8ef895b1d46408985954042364ae4d5a0c9a9e6ba78843e8b1a853bb9c47c901e9342d1c7e02ff09cf26419d4667371
+  metadata.gz: 1db06adef9f18338c30d02177c993ef7c7978f4563683ac821c933f824170476f0088b90cc29ce87629d6b0d5bf76e335cacb8662d25a6583de074e5f92de18b
+  data.tar.gz: d2631001ed66f5f91ede31f60387f07edf95bb297cd999e2b2528b29b79c215c75bfa0c79771804505b25b3ccfc457c54b8a42f35cc615f5af9d621e8769b86e

data/default.yml

@@ -50,6 +50,8 @@ GLCops/LimitFlashOptions:
 
 GLCops/NoStubbingPerformAsync:
   Enabled: true
+  Include:
+    - "**/*spec.rb"
 
 GLCops/PreventErbFiles:
   Enabled: true
@@ -72,6 +74,11 @@ I18n/GetText:
 
 I18n/RailsI18n:
   Enabled: true
+  Exclude:
+    - "spec/**/*"
+    - "packs/*/spec/**/*"
+    - Gemfile
+    - "*.gemspec"
 
 Layout/ClassStructure:
   Enabled: true
@@ -157,8 +164,10 @@ Metrics/MethodLength:
   Max: 15
 
 Metrics/ParameterLists:
+  Max: 6
   Exclude:
     - "db/seeds/**/*"
+    - "app/components/**/*"
 
 Metrics/PerceivedComplexity:
   Exclude:
@@ -397,4 +406,4 @@ Style/HashAsLastArrayItem:
   Enabled: false
 
 Style/MultilineBlockChain:
-  Enabled: false
+  Enabled: false

data/gl_rubocop.gemspec

@@ -2,7 +2,6 @@
 
 require_relative 'lib/gl_rubocop/version'
 
-# rubocop:disable I18n/RailsI18n/DecorateString
 NON_GEM_FILES = ['Gemfile', 'Gemfile.lock', 'Guardfile', 'bin/lint'].freeze
 
 Gem::Specification.new do |spec|
@@ -38,4 +37,3 @@ Gem::Specification.new do |spec|
 
   spec.metadata['rubygems_mfa_required'] = 'true'
 end
-# rubocop:enable I18n/RailsI18n/DecorateString

data/lib/gl_rubocop/gl_cops/no_stubbing_perform_async.rb

@@ -16,43 +16,44 @@ module GLRubocop
       MSG = "Don't stub perform async. Use the rspec-sidekick matchers instead: " \
             'expect(JobClass).to have_enqueued_sidekiq_job'.freeze
 
-      # This pattern captures expectations for perform_async and perform_in
-      # expect(SomeWorker).not_to have_received(:perform_async)
-      # expect(SomeWorker).to have_received(:perform_async)
-      # expect(SomeWorker).to have_received(:perform_in)
-      def_node_matcher :perform_method_expectation?, <<~PATTERN
-        (send#{' '}
-          (send nil? :expect $_)#{' '}
-          {:not_to :to_not :to}#{' '}
-          (send nil? :have_received (sym {:perform_async :perform_in}) ...))
+      # Match have_received with perform_async or perform_in
+      def_node_matcher :have_received_perform?, <<~PATTERN
+        (send nil? :have_received (sym {:perform_async :perform_in}) ...)
       PATTERN
 
-      # This pattern captures allow statements for perform_async and perform_in
-      # allow(SomeWorker).to receive(:perform_async)
-      # allow(SomeWorker).to receive(:perform_in)
-      def_node_matcher :perform_method_allow?, <<~PATTERN
-        (send
-          (send nil? :allow $_)
-          :to
-          (send nil? :receive (sym {:perform_async :perform_in}) ...))
+      # Match receive with perform_async or perform_in
+      def_node_matcher :receive_perform?, <<~PATTERN
+        (send nil? :receive (sym {:perform_async :perform_in}) ...)
       PATTERN
 
       def on_send(node)
-        check_expectation(node) || check_allow(node)
+        return unless have_received_perform?(node) || receive_perform?(node)
+
+        # Find the expect or allow context
+        offense_node = find_offense_node(node)
+        add_offense(offense_node) if offense_node
       end
 
       private
 
-      def check_expectation(node)
-        perform_method_expectation?(node) { return add_offense(node) }
+      def find_offense_node(node)
+        current = node.parent
+        while current
+          return current if rspec_stubbing?(current)
 
-        false
+          current = current.parent
+        end
+        nil
       end
 
-      def check_allow(node)
-        perform_method_allow?(node) { return add_offense(node) }
+      def rspec_stubbing?(node)
+        return false unless node.send_type?
+        return false unless %i[to not_to to_not].include?(node.method_name)
+
+        receiver = node.receiver
+        return false unless receiver&.send_type?
 
-        false
+        %i[allow expect].include?(receiver.method_name)
       end
     end
   end

data/lib/gl_rubocop/version.rb

@@ -1,3 +1,3 @@
 module GLRubocop
-  VERSION = '0.2.17'.freeze
+  VERSION = '0.2.19'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.2.17
+  version: 0.2.19
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-09-03 00:00:00.000000000 Z
+date: 2025-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -177,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.27
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: A shareable configuration of Give Lively's rubocop rules.