gl_rubocop 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b7c0c391c5aa0eb1e4febae169ca5932322f78fccc85613be40eb1af4a8b79f
-  data.tar.gz: f4fd73808497ff42a67188ba0ef3c6bf9f0d7b054e950152b95bc83f1972204e
+  metadata.gz: d20b890fc0655b53c0dcc83817c48487dd7a30f62566cd4d05c9aecf4ff8b4b8
+  data.tar.gz: 7781b08914c2cdfba1265349799ef45f0b64ce585adb4ca0cfdb14212970e28c
 SHA512:
-  metadata.gz: 388def57e19d2aa78934a79d6508235764ac758c5bef028215d91a8f3e60db5a99632571da26c65040a4303660851fb4cb9049ea8922dc537067372670d407b1
-  data.tar.gz: 6aab3e2ea8352084f7ac29cfd3077df54d4503a3085c4e63cd35894dfab04570a3c1c6ccab7d22516e7260ddd81f580558b8b362f5fca68fbb24d040e5028e0d
+  metadata.gz: 2d526e27669d0c354503003303f2c86f6f51ce80d5428c81ce1a5abfd2bd94aa3ad76d3270d1d23ef1066d191f6b6d6e7fb55f34f7d0f777e51c6dccec7782be
+  data.tar.gz: 13b9fd998f8d22bb8f7ce7cbc3e71521ff2c17f13d7485ef44bcdc5f6c9f7617fce9d4d2998f03e35346558585649a00155d5ac0e96d40b4ee5149155d3ea779

data/default.yml

@@ -3,10 +3,13 @@ require:
   - rubocop-rails
   - rubocop-rspec
   - rubocop-magic_numbers
+  - rubocop-haml
   - ./lib/gl_rubocop/gl_cops/interactor_inherits_from_interactor_base.rb
   - ./lib/gl_rubocop/gl_cops/callback_method_names.rb
   - ./lib/gl_rubocop/gl_cops/prevent_erb_files.rb
   - ./lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb
+  - ./lib/gl_rubocop/gl_cops/unique_identifier.rb
+
 
 AllCops:
   SuggestExtensions: false
@@ -39,6 +42,11 @@ GLCops/SidekiqInheritsFromSidekiqJob:
     - 'app/**/*_worker.rb'
     - 'app/**/*_job.rb'
 
+GLCops/UniqueIdentifier:
+  Enabled: true
+  Include:
+    - 'app/components/**/*.haml'
+
 Layout/LineLength:
   Max: 100
   AllowedPatterns:
@@ -46,7 +54,7 @@ Layout/LineLength:
 
 Lint/MissingSuper:
   Exclude:
-    - /app/components/**/*
+    - 'app/components/**/*'
 
 MagicNumbers/NoAssignment:
   Enabled: false

data/gl_rubocop.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_dependency 'rubocop', '~> 1.62.0'
+  spec.add_dependency 'rubocop-haml', '~> 0.2.4'
   spec.add_dependency 'rubocop-magic_numbers'
   spec.add_dependency 'rubocop-performance'
   spec.add_dependency 'rubocop-rails'

data/lib/gl_rubocop/gl_cops/unique_identifier.rb

@@ -0,0 +1,58 @@
+module GLRubocop
+  module GLCops
+    class UniqueIdentifier < RuboCop::Cop::Base
+      # This cop ensures that view components include a data-test-id attribute.
+      #
+      # Good:
+      #   {data-test-id: "unique-id"}
+      #
+      # Bad:
+      #   {data: {testId: "unique-id"}}
+      #   {data: {test: {id: "unique-id"}}
+
+      MSG = 'View components must include a data-test-id attribute'.freeze
+      EMPTY_MSG = 'data-test-id attribute must not be empty'.freeze
+      UNIQUE_IDENTIFIER = 'data-test-id'.freeze
+
+      def on_send(node)
+        return unless file_exists? && valid_method_name?(node)
+
+        return add_offense(node) unless raw_content.include?(UNIQUE_IDENTIFIER)
+
+        add_offense(node, message: EMPTY_MSG) if test_id_value.strip.empty?
+      end
+
+      private
+
+      def file_exists?
+        File.exist?(processed_source.file_path)
+      end
+
+      def identifiable_line
+        line_number = raw_content.lines.find_index { |line| line.include?(UNIQUE_IDENTIFIER) }
+        raw_content.lines[line_number]
+      end
+
+      def raw_content
+        @raw_content ||= File.read(processed_source.file_path)
+      end
+
+      def regex_for_indentifier_and_value
+        /#{Regexp.quote(UNIQUE_IDENTIFIER)}:\s*(["']([^"']*)["']|@\w+)/
+      end
+
+      def test_id_value
+        match = identifiable_line.match(regex_for_indentifier_and_value)
+
+        return '' unless match
+
+        value = match[1]
+        value.start_with?('"', "'") ? value[1..-2] : value
+      end
+
+      def valid_method_name?(node)
+        node.method_name == :render || node.method_name == :template
+      end
+    end
+  end
+end

data/lib/gl_rubocop/version.rb

@@ -1,3 +1,3 @@
 module GLRubocop
-  VERSION = '0.2.1'.freeze
+  VERSION = '0.2.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_rubocop
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-02 00:00:00.000000000 Z
+date: 2025-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.62.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-haml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.4
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.4
 - !ruby/object:Gem::Dependency
   name: rubocop-magic_numbers
   requirement: !ruby/object:Gem::Requirement
@@ -110,6 +124,7 @@ files:
 - lib/gl_rubocop/gl_cops/interactor_inherits_from_interactor_base.rb
 - lib/gl_rubocop/gl_cops/prevent_erb_files.rb
 - lib/gl_rubocop/gl_cops/sidekiq_inherits_from_sidekiq_job.rb
+- lib/gl_rubocop/gl_cops/unique_identifier.rb
 - lib/gl_rubocop/version.rb
 homepage: https://github.com/givelively/gl_rubocop
 licenses: