gl_command 1.1.3 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '09bb7724a153ffb2e0f53a71bac270a2410df26bb4b145e776e381f41dff3fff'
-  data.tar.gz: 0a882a14125ac56b3dc132954382b01fa0722349ac1fd74605296f760167e751
+  metadata.gz: 705c23dec5e3038e7a6b4d0736f58589b775edd30ee53056d2478b8361f9a3d6
+  data.tar.gz: a547c64df86a0f2a533ad43ea5f1ee0a1e2dfcc8fe27e6f1c85b4a018ad75b39
 SHA512:
-  metadata.gz: 44e04e38a4537e47d8be1614e7d0b8e04c759f83f467a1aa9fde1d372b70ec000163277637b502254006f50f5f950c76a886012606c1c0396a74e9256b5742b2
-  data.tar.gz: f5b28a4e1933b2c89d33d7f435a552430bfe4c7bbe8464fba15e1fb6b9367a37e4e870a5f268d96a64a2fb736929b1a0805b8f5ee5102e5185d32816cf74377d
+  metadata.gz: b13e47c074cc18aeeb50cd0e874c088cd7c0091b52fc5d705b4b5b79ddbb18fa1b3d12b596bf2febd85264a1fe5f9e933fa0893444b21369a4a8cc4a3a33c64f
+  data.tar.gz: 25ac2f9a597e199fef77ebcd08442937615b63102bd8e071d0aea68ede1a2e83da085e902022f54ed32a41ddcf474510e9be811f3dc37941b78f7a2498a0c383

data/README.md

@@ -215,6 +215,24 @@ end
 ```
 
 
+## Publishing the gem to Rubygems
+
+1. As per our code agreements, all code changes to this gem are required to be made via pull request with final approval from at least one Give Lively engineer.
+
+2. When creating a pull request, ensure that your code changes include an update to the gem's [version number](https://github.com/givelively/gl_command/blob/main/lib/gl_command/version.rb) using [semantic versioning](https://semver.org/)
+
+3. After getting approval, merge your changes to `main`.
+
+4. Once your CI build finishes successfully, pull the latest version of `main` locally.
+
+5. Run the command `gem build`. This bundles the relevant files from the gem and prepares it to be published to [rubygems.org](https://rubygems.org/).
+
+6. This will create a new file locally that looks like `gl_command-<new_gem_version_number>.gem`.
+
+7. Run `gem push gl_command-<new_gem_version_number>.gem` to publish the new version
+
+**NOTE: only the gem owners listed on rubygems can publish new versions**
+
 ---
 
 This library is influenced by [interactors](https://github.com/collectiveidea/interactor) and inspired by the [Command Pattern](https://en.wikipedia.org/wiki/Command_pattern).

data/lib/gl_command/callable.rb

@@ -6,6 +6,8 @@ require 'gl_command/validatable'
 
 module GLCommand
   class Callable
+    include GLCommand::Validatable
+    ALWAYS_RAISE_ERRORS = ENV['GL_COMMAND_ALWAYS_RAISE'] == 'true'
     DEFAULT_OPTS = { raise_errors: false, skip_unknown_parameters: true, in_chain: false }.freeze
     RESERVED_WORDS = (DEFAULT_OPTS.keys + GLCommand::ChainableContext.reserved_words).sort.freeze
 
@@ -25,7 +27,7 @@ module GLCommand
 
         # DEFAULT_OPTS contains skip_unknown_parameters: true - so it raises on call
         # (rather than in context initialize) to make errors more legible
-        opts = DEFAULT_OPTS.merge(raise_errors: args.delete(:raise_errors),
+        opts = DEFAULT_OPTS.merge(raise_errors: args.delete(:raise_errors) || ALWAYS_RAISE_ERRORS,
                                   in_chain: args.delete(:in_chain)).compact
         # args are passed in in perform_call(args) so that invalid args raise in a legible place
         new(build_context(**args.merge(opts))).perform_call(args)
@@ -101,8 +103,6 @@ module GLCommand
       end
     end
 
-    include GLCommand::Validatable
-
     attr_reader :context
 
     def initialize(context = nil)

data/lib/gl_command/chainable.rb

@@ -41,7 +41,7 @@ module GLCommand
 
       commands.map do |command|
         cargs = context.chain_arguments_and_returns.slice(*command.arguments)
-                       .merge(context.opts_hash).merge(in_chain: true)
+                       .merge(context.opts_hash).merge(in_chain: context)
 
         # using _result to make sure it doesn't cause naming conflicts with other uses of result
         _result = command.call(**cargs)

data/lib/gl_command/context.rb

@@ -22,7 +22,7 @@ module GLCommand
       { raise_errors: raise_errors? }
     end
 
-    attr_reader :klass, :error
+    attr_reader :klass, :error, :in_chain
     attr_writer :full_error_message
 
     # If someone calls #errors, they expect to get the errors! Include the non-validation error, if it exists
@@ -35,10 +35,6 @@ module GLCommand
       false
     end
 
-    def in_chain?
-      @in_chain
-    end
-
     def returns
       @klass.returns.index_with { |rattr| send(rattr) }
     end

data/lib/gl_command/version.rb

@@ -1,3 +1,3 @@
 module GLCommand
-  VERSION = '1.1.3'.freeze
+  VERSION = '1.2.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gl_command
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - Give Lively
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-03 00:00:00.000000000 Z
+date: 2025-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord