gitx 4.1.1 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3794617867e08f0a15468dd3291883d22bed44fa9dfde0350cf120e5c5c8890c
-  data.tar.gz: 827802ca75c6a1f4243fa628a12dc3cc1e9b11afef91d587fc9fe4ae4a9b2b6e
+  metadata.gz: ba914d70cddc88a7a718f8c05ea238822c79b2a58c09f30576835473ff008a0e
+  data.tar.gz: c1079014ac0699cf9eea62857061a5932e8b083620241f401a13113761c8f6f2
 SHA512:
-  metadata.gz: ae00b7739d6b3488d0ae4ae588d776c1a004eeb36167587699d2c0dae2ec49902dfc78d122f1edcab7e9ce47a3cecfd36efe59491bce0d663562058e08975f57
-  data.tar.gz: 8727bf623a20f50a6de72088a0e1106e26ccd1ba974d66471e2ed0f8643ffe3c04ec299b6d4343df3816f8c881af3588497e7a2fd9806627c418d461933d24dc
+  metadata.gz: 334ef2afbffbe44668f8b97aa8f85f142292dfb5811fd7c37ff7233ed40ae85e6890b08928fa4006b814933e8e68df93d9b9f0017596829a4d6af96184f06a5c
+  data.tar.gz: eead42c4bb02d2d8738a057962f9f7c2e5bc2f2318003833b0e7a472ea592197b3f3948d9c06a063a69e58470d641bf77808d1aa266ec8f0f8fffbcd6128cff3

data/README.md

@@ -50,7 +50,7 @@ This setting is cleared when a reviewer approves or rejects the pull request.
 release the feature branch to the base branch (by default, main).  This operation will perform the following:
 
 * pull latest code from remote feature branch
-* pull latest code from the base branch
+* pull latest code from the base branch (unless `update_from_base_on_release` config is set to `false`)
 * prompt user to confirm they actually want to perform the release
 * check if pull request commit status is currently successful
 * merge current branch into the base branch (or add release label if configured)

data/lib/gitx/cli/release_command.rb

@@ -17,19 +17,9 @@ module Gitx
 
         assert_not_protected_branch!(branch, 'release')
         checkout_branch(branch)
-        run_git_cmd 'update'
+        run_git_cmd 'update' if config.update_from_base_on_release?
 
-        pull_request = find_or_create_pull_request(branch)
-
-        if (label = config.release_label)
-          label_pull_request pull_request, label
-        else
-          return unless confirm_branch_status?(branch)
-          checkout_branch config.base_branch
-          run_git_cmd 'pull', 'origin', config.base_branch
-          run_git_cmd 'merge', '--no-ff', '--message', commit_message(branch, pull_request), branch
-          run_git_cmd 'push', 'origin', 'HEAD'
-        end
+        perform_release(branch)
 
         after_release
       end
@@ -51,6 +41,21 @@ module Gitx
         end
       end
 
+      def perform_release(branch)
+        pull_request = find_or_create_pull_request(branch)
+
+        if (label = config.release_label)
+          label_pull_request pull_request, label
+        else
+          return unless confirm_branch_status?(branch)
+
+          checkout_branch config.base_branch
+          run_git_cmd 'pull', 'origin', config.base_branch
+          run_git_cmd 'merge', '--no-ff', '--message', commit_message(branch, pull_request), branch
+          run_git_cmd 'push', 'origin', 'HEAD'
+        end
+      end
+
       def after_release
         after_release_scripts = config.after_release_scripts.dup
         after_release_scripts << 'git cleanup' if options[:cleanup]

data/lib/gitx/configuration.rb

@@ -45,6 +45,10 @@ module Gitx
       taggable_branches.include?(branch)
     end
 
+    def update_from_base_on_release?
+      config.fetch(:update_from_base_on_release, true)
+    end
+
     def after_release_scripts
       config[:after_release]
     end

data/lib/gitx/version.rb

@@ -1,3 +1,3 @@
 module Gitx
-  VERSION = '4.1.1'.freeze
+  VERSION = '4.3.0'.freeze
 end

data/spec/gitx/cli/release_command_spec.rb

@@ -235,5 +235,37 @@ describe Gitx::Cli::ReleaseCommand do
         should meet_expectations
       end
     end
+    context 'when user confirms release with update_from_base_on_release config set to false' do
+      let(:gitx_config) do
+        {
+          'update_from_base_on_release' => false
+        }
+      end
+      before do
+        expect(repo).to receive(:workdir).and_return(temp_dir)
+        File.open(File.join(temp_dir, '.gitx.yml'), 'w') do |f|
+          f.puts gitx_config.to_yaml
+        end
+
+        expect(cli).to receive(:yes?).and_return(true)
+        expect(cli).to_not receive(:label_pull_request)
+        expect(executor).to_not receive(:execute).with('git', 'update')
+        allow(cli).to receive(:authorization_token).and_return(authorization_token)
+
+        expect(executor).to receive(:execute).with('git', 'checkout', 'feature-branch').ordered
+        expect(executor).to receive(:execute).with('git', 'checkout', 'main').ordered
+        expect(executor).to receive(:execute).with('git', 'pull', 'origin', 'main').ordered
+        expect(executor).to receive(:execute).with('git', 'merge', '--no-ff', '--message', "[gitx] Release feature-branch to main\n\nConnected to #10", 'feature-branch').ordered
+        expect(executor).to receive(:execute).with('git', 'push', 'origin', 'HEAD').ordered
+        expect(executor).to receive(:execute).with('git integrate --skip-pull-request').ordered
+
+        VCR.use_cassette('pull_request_does_exist_with_success_status') do
+          cli.release
+        end
+      end
+      it 'runs expected commands' do
+        should meet_expectations
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitx
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 4.3.0
 platform: ruby
 authors:
 - Ryan Sonnek
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-06 00:00:00.000000000 Z
+date: 2022-08-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit