giturl 1.3.4 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e43435dd2f65994223cba6a0102f6115be87e134fda05f1a3f3f9a070615f67a
-  data.tar.gz: 41ec81451225da88086dec1ecdd0cd497ea0af313b6697df7ea6304fe1b00925
+  metadata.gz: 573b19763ae39da18a0c44e608af15eb32e28ed76a1ec7a40330fdd6279a849a
+  data.tar.gz: c4af8e33c8a67d2c9f5e6459f0da798c5ad3ea315df2a2d1af61fe293d0f4707
 SHA512:
-  metadata.gz: 820f72055d3b78a15959da42539745736a8da5e0d7107ddab76f3841fa232e3bb8b4175fde24e98f91fae1200aa1656653a5f53fabfbcd210b39bfe6dd3e2505
-  data.tar.gz: cda6f2388376fd9e4d1174d236dfe10bc7671e38f44b537499a66793586bd71b24e73dfdb834c63b4ec312e25bc13f23ac7fd31f26f2e27248fadfd621477892
+  metadata.gz: 210f26eb0a8fa88f37e134bd3d133fc02d8a2a535d2e4fc982fc088f390846046b6ae63598322552cf8f0bfde53e0dd7ae3fe3f7ecd38df0e2ac5fb5d624e0ca
+  data.tar.gz: 66e722c6696b5e9d8ce8e44b889511a372fb501c34067e4d9fe1fa161bd12b3e1fc962c91b375e2e7db0cdb8d3743030c1a14ba6916af8f826b7430fe9607829

data/.github/workflows/ci.yml

@@ -0,0 +1,37 @@
+name: CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+
+jobs:
+  test:
+    name: rspec (ruby ${{ matrix.ruby }})
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['3.2', '3.3', '3.4', '4.0']
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Configure git identity for spec fixtures
+        run: |
+          git config --global user.email "ci@example.com"
+          git config --global user.name "CI"
+      - run: bundle exec rspec
+
+  rubocop:
+    name: rubocop
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '4.0'
+          bundler-cache: true
+      - run: bundle exec rubocop

data/.rubocop.yml

@@ -7,12 +7,13 @@
 # General guide-line is
 #  https://github.com/rubocop-hq/ruby-style-guide
 
-require:
+plugins:
   - rubocop-performance
   - rubocop-rspec
 
 AllCops:
   TargetRubyVersion: 2.3
+  NewCops: enable
 
 Layout/EndAlignment:
   Enabled: true
@@ -36,7 +37,7 @@ Lint/StructNewOverride:
 Metrics/BlockLength:
   Enabled: true
   Max: 30
-  ExcludedMethods: ['describe', 'context']
+  AllowedMethods: ['describe', 'context']
 
 Metrics/MethodLength:
   Enabled: true

data/.ruby-version

@@ -0,0 +1 @@
+4.0.6

data/CHANGELOG.md

@@ -1,6 +1,36 @@
 # Changelog
 
-## [v1.3.4](https://github.com/shinyaohtani/giturl/tree/v1.3.4 (2024-02-24)
+## [v1.3.6](https://github.com/shinyaohtani/giturl/tree/v1.3.6) (2026-09-03)
+
+[Full Changelog](https://github.com/shinyaohtani/giturl/compare/v1.3.5...v1.3.6)
+
+- Same code as v1.3.5. Re-released solely to link the fixes below to
+  the issues that describe them, which v1.3.5 shipped without.
+
+**Fixed bugs:**
+
+- bundle exec rubocop crashes on Ruby 4.0 \(LoadError: benchmark\) [\#36](https://github.com/shinyaohtani/giturl/issues/36)
+- rspec suite fails: fixture branch no longer exists on GitHub [\#35](https://github.com/shinyaohtani/giturl/issues/35)
+- giturl . outputs nothing at the repository root [\#34](https://github.com/shinyaohtani/giturl/issues/34)
+
+**Closed issues:**
+
+- Dependencies and Ruby version are far behind current releases [\#38](https://github.com/shinyaohtani/giturl/issues/38)
+- No CI workflow to catch regressions [\#37](https://github.com/shinyaohtani/giturl/issues/37)
+
+## [v1.3.5](https://github.com/shinyaohtani/giturl/tree/v1.3.5) (2026-09-03)
+
+[Full Changelog](https://github.com/shinyaohtani/giturl/compare/v1.3.4...v1.3.5)
+
+- Yanked: shipped without the tracking issues linked below, so it's
+  undiscoverable what this release actually fixed. Superseded by
+  v1.3.6, which has the same code plus the corrected changelog.
+
+**Merged pull requests:**
+
+- Fix root-dir bug, make specs hermetic, add CI, update all deps to latest [\#33](https://github.com/shinyaohtani/giturl/pull/33) ([shinyaohtani](https://github.com/shinyaohtani))
+
+## [v1.3.4](https://github.com/shinyaohtani/giturl/tree/v1.3.4) (2024-02-24)
 
 [Full Changelog](https://github.com/shinyaohtani/giturl/compare/v1.3.3...v1.3.4)
 

data/Gemfile

@@ -2,11 +2,16 @@
 
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in giturl.gemspec
+# Specify your gem's runtime dependency in giturl.gemspec
 gemspec
 
-gem 'rake', '~> 13.0'
-
-gem 'rspec', '~> 3.0'
-
-gem 'rubocop', '~> 1.21'
+# Development dependencies live here rather than in the gemspec
+# (see Gemspec/DevelopmentDependencies).
+gem 'github_changelog_generator', '>= 1.18.0'
+gem 'pry', '>= 0.16.0'
+gem 'pry-byebug', '>= 3.12.0'
+gem 'rake', '>= 13.4.2'
+gem 'rspec', '>= 3.13.2'
+gem 'rubocop', '>= 1.90.0'
+gem 'rubocop-performance', '>= 1.27.0'
+gem 'rubocop-rspec', '>= 3.10.2'

data/README.md

@@ -3,7 +3,7 @@
 
 ## What is giturl?
 
-`giturl`: A simple navigation tool for GitHub pages from local git-cloned directories Working deep in a git-cloned project and need to view its GitHub page? `giturl` simplifies this for you. A single command unveils your repository's URL. Want more? It also opens your browser and goes straight to the page -- no extra steps needed. `giturl` streamlines your workflow, merging simplicity with sophistication.
+`giturl`: A simple navigation tool for GitHub pages from local git-cloned directories. Working deep in a git-cloned project and need to view its GitHub page? `giturl` simplifies this for you. A single command unveils your repository's URL. Want more? It also opens your browser and goes straight to the page -- no extra steps needed. `giturl` streamlines your workflow, merging simplicity with sophistication.
 
 You can use `giturl` like:
 

data/giturl.gemspec

@@ -29,15 +29,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'launchy', '>= 2.5.0'
-
-  spec.add_development_dependency 'bundler', '~> 2.0'
-  spec.add_development_dependency 'github_changelog_generator', '>= 1.15.0'
-  spec.add_development_dependency 'pry', '>= 0.12.2'
-  spec.add_development_dependency 'pry-byebug', '>= 3.9.0'
-  spec.add_development_dependency 'rake', '>= 12.3.3'
-  spec.add_development_dependency 'rspec', '>= 3.9.0'
-  spec.add_development_dependency 'rubocop', '>= 0.80.1'
-  spec.add_development_dependency 'rubocop-performance', '>= 1.5.2'
-  spec.add_development_dependency 'rubocop-rspec', '>= 1.38.1'
+  spec.add_dependency 'launchy', '>= 3.1.1'
+
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/giturl/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Giturl
-  VERSION = '1.3.4'
+  VERSION = '1.3.6'
   DESCRIPTION = <<~DESC
     giturl: A simple navigation tool for GitHub pages from local git-cloned directories.
 

data/lib/giturl.rb

@@ -24,7 +24,7 @@ module Giturl
     # @return [Boolean] git-managed directory or not.
     def self.git_managed?(path)
       stderr_old = $stderr.dup
-      $stderr.reopen('/dev/null')
+      $stderr.reopen(File::NULL)
       inside = `git -C #{path} rev-parse --is-inside-work-tree`.chomp
       $stderr.flush
       $stderr.reopen stderr_old
@@ -36,16 +36,53 @@ module Giturl
     # @param path [String] path for a git-managed directory. Both relative and absolute forms are accepted.
     # @return [String] GitHub web page URL for the given git-managed directory
     def self.convert(path)
-      gitdir_prefix = `git -C #{path} rev-parse --show-prefix`.chomp
-      gitdir_branch = `git -C #{path} rev-parse --abbrev-ref HEAD`.chomp
-      remote_origin_url = `git -C #{path} config --get remote.origin.url`.chomp
-
-      # remote_origin_url:  git@github.com:shinyaohtani/giturl.git
-      baseurl = remote_origin_url.tr(':', '/').gsub(/^.*@/, 'https://').gsub(/\.git$/, '')
-      # gitdir_branch: feature/#1_user_named_branch
+      gitdir_prefix, gitdir_branch, remote_origin_url, ok = git_location_info(path)
+      unless ok
+        warn 'Git commands failed. Please check if the directory is a git repository.'
+        return ''
+      end
+      baseurl = construct_base_url(remote_origin_url)
       encoded_branch = gitdir_branch.split('/').map { |e| ERB::Util.url_encode(e) }.join('/')
-
       "#{baseurl}/tree/#{encoded_branch}/#{gitdir_prefix}"
     end
+
+    # Run the git commands needed to build the URL, and report whether they succeeded.
+    #
+    # @param path [String] path for a git-managed directory
+    # @return [Array(String, String, String, Boolean)] prefix, branch, remote origin URL, and
+    #   whether the info is usable. gitdir_prefix may legitimately be empty (path is the
+    #   repository root), so only command success and non-empty branch/remote are required.
+    def self.git_location_info(path)
+      prefix, prefix_ok = run_git(path, 'rev-parse', '--show-prefix')
+      branch, branch_ok = run_git(path, 'rev-parse', '--abbrev-ref', 'HEAD')
+      remote, remote_ok = run_git(path, 'config', '--get', 'remote.origin.url')
+      ok = prefix_ok && branch_ok && remote_ok && !branch.empty? && !remote.empty?
+      [prefix, branch, remote, ok]
+    end
+    private_class_method :git_location_info
+
+    def self.run_git(path, *args)
+      output = `git -C #{path} #{args.join(' ')}`.chomp
+      [output, $?.success?] # rubocop:disable Style/SpecialGlobalVars
+    end
+    private_class_method :run_git
+
+    def self.construct_base_url(remote_origin_url)
+      baseurl = remote_origin_url
+      if remote_origin_url =~ /@(.*?):/
+        host_alias = ::Regexp.last_match(1)
+        real_hostname = get_real_hostname(host_alias)
+        baseurl = remote_origin_url.sub(host_alias, real_hostname) if real_hostname && real_hostname != host_alias
+      end
+      baseurl.tr(':', '/').gsub(/^.*@/, 'https://').gsub(/\.git$/, '')
+    end
+
+    def self.get_real_hostname(host_alias)
+      ssh_output = `ssh -G #{host_alias} 2>#{File::NULL}`
+      real_hostname_line = ssh_output.lines.find { |line| line =~ /^hostname / }
+      return nil unless real_hostname_line
+
+      real_hostname_line.split[1]
+    end
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: giturl
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.6
 platform: ruby
 authors:
 - Shinya Ohtani (shinyaohtani@github)
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-02-24 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: launchy
@@ -16,140 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.0
+        version: 3.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.5.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: github_changelog_generator
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.15.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.15.0
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.12.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.12.2
-- !ruby/object:Gem::Dependency
-  name: pry-byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 12.3.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 12.3.3
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.9.0
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.80.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.80.1
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.5.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.5.2
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.38.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.38.1
+        version: 3.1.1
 description: |
   giturl: A simple navigation tool for GitHub pages from local git-cloned directories.
 
@@ -165,9 +38,11 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -189,7 +64,7 @@ metadata:
   homepage_uri: https://github.com/shinyaohtani/giturl/blob/master/README.md
   source_code_uri: https://github.com/shinyaohtani/giturl
   changelog_uri: https://github.com/shinyaohtani/giturl/blob/master/CHANGELOG.md
-post_install_message:
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -204,8 +79,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
-signing_key:
+rubygems_version: 4.0.16
 specification_version: 4
 summary: Show or open GitHub URL for your local directory
 test_files: []