giturl 1.1.5 → 1.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0cd0034eb1d5897662378ec2299ed0ebb78aae1847310f8f6926a1933d7e24ef
-  data.tar.gz: c253a97c533af3fea0f486a404de79bb10ab7d1a1494cb13140330e132be2b84
+  metadata.gz: fc8fdfa621eb908ed53215b27f9b2b6843d732d1632823a324e67fe34c9fa25a
+  data.tar.gz: 188bb25265cc309f3bff690773954bb3fbfd5d95f41afdee18a640dee750ab1d
 SHA512:
-  metadata.gz: 87484d6e3e5c4ba8a7ad1e673d2f6e1f740c07e60a8dbd8bd4d86c8881542c9238a1d8cde82d15305f102a2222692eb48aab84d7892900db17af176df809baec
-  data.tar.gz: 49097b99ce67f5dc95c125deed74d958e56188e5f7a6027c55f6b92585a97dba41c21fe5a4e2db180f677401932f0380643df6cf79afcc8d60d2b51aa5eee73a
+  metadata.gz: f442fa4c3ba58d96f8295ea4998cb50a7ce8ef312bbe0dcf5dd22833a4720e02faa9bf8a0b85a1605c552e6100b941d7a828ceddbb88638841233cf45438ba5c
+  data.tar.gz: c83343d8871c2147b11ef83ab3a5561b4eed94e006b8385a46b78f66fdb3c46a64594683310c9472c93192b18b46842c104a2ef313c89e95f64b75dd58b149b0

data/.gitignore

@@ -6,5 +6,6 @@
 /doc/
 /pkg/
 /spec/reports/
+/test/
 /tmp/
 Gemfile.lock

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/.rubocop.yml

@@ -7,6 +7,9 @@
 # General guide-line is
 #  https://github.com/rubocop-hq/ruby-style-guide
 
+require:
+  - rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 2.5
 
@@ -20,6 +23,15 @@ Layout/LineLength:
   AutoCorrect: false
   Max: 120
 
+Metrics/BlockLength:
+  Enabled: true
+  Max: 30
+  ExcludedMethods: ['describe', 'context']
+
+Metrics/MethodLength:
+  Enabled: true
+  Max: 30
+
 Style/HashEachMethods:
   Enabled: true
   AutoCorrect: true

data/CHANGELOG.md

@@ -1,8 +1,22 @@
 # Changelog
 
-## [1.1.5](https://github.com/shinyaohtani/giturl/tree/1.1.5) (2020-03-18)
+## [v1.1.6](https://github.com/shinyaohtani/giturl/tree/v1.1.6) (2020-03-23)
 
-[Full Changelog](https://github.com/shinyaohtani/giturl/compare/v1.1.4...1.1.5)
+[Full Changelog](https://github.com/shinyaohtani/giturl/compare/v1.1.5...v1.1.6)
+
+**Implemented enhancements:**
+
+- Test code should be prepared [\#3](https://github.com/shinyaohtani/giturl/issues/3)
+
+**Merged pull requests:**
+
+- Feature/\#3 test code [\#9](https://github.com/shinyaohtani/giturl/pull/9) ([shinyaohtani](https://github.com/shinyaohtani))
+
+# Changelog
+
+## [v1.1.5](https://github.com/shinyaohtani/giturl/tree/v1.1.5) (2020-03-18)
+
+[Full Changelog](https://github.com/shinyaohtani/giturl/compare/v1.1.4...v1.1.5)
 
 **Implemented enhancements:**
 

data/README.md

@@ -51,7 +51,7 @@ $ giturl --open --app="/Applications/any_browser_you_have.app" .
 
 ## Usecase
 
-Here is a example to open GitHub web page for current directory:
+The following is an example of opening a GitHub web page for the current directory:
 
 ```sh
 $ git clone git@github.com:shinyaohtani/giturl.git

data/Rakefile

@@ -1,13 +1,15 @@
 # frozen_string_literal: true
 
 require 'bundler/gem_tasks'
-task default: :spec
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
 
 require 'github_changelog_generator/task'
-
 GitHubChangelogGenerator::RakeTask.new :changelog do |config|
   config.user = 'shinyaohtani'
   config.project = 'giturl'
   config.base = 'CHANGELOG.md'
-  config.future_release = Giturl::VERSION
+  config.future_release = "v#{Giturl::VERSION}"
 end
+
+task default: :spec

data/bin/giturl

@@ -1,46 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require 'optparse'
-require 'giturl'
+require 'command_giturl'
 
-params = {}
-OptionParser.new do |opts|
-  opts.version = Giturl::VERSION
-  opts.on('-o', '--open', 'Open the URL in your browser. default: no') { |v| v }
-  opts.on('-a APPNAME', '--app=APPNAME', 'Specify a browser. "Safari.app"') { |v| v }
-  opts.on('-v', '--verbose', 'Verbose mode. default: no') { |v| v }
-  opts.on_tail('-h', '--help', 'Show this message') do
-    puts opts
-    exit
-  end
-  opts.on_tail('-V', '--version', 'Show version') do
-    puts opts.ver
-    exit
-  end
-  opts.banner = <<~BANNER
-
-    #{opts.ver}
-    A tiny utility that displays and opens GitHub URLs for your local directory.
-      visit: https://github.com/shinyaohtani/giturl
-
-    Usage: #{opts.program_name} [options] [dirs]
-     [options] are:
-  BANNER
-
-  opts.parse!(ARGV, into: params)
-end
-
-ARGV.each do |arg|
-  if Giturl::Giturl.git_managed?(arg)
-    url = Giturl::Giturl.convert(arg)
-    print "#{url}\n"
-    if params[:open]
-      comm = +"open #{url}"
-      comm << " -a #{params[:app]}" if params[:app]
-      system(comm)
-    end
-  elsif params[:verbose]
-    print "Not git-managed-dir:  #{arg}\n"
-  end
-end
+cg = Giturl::CommandGiturl.new
+cg.parse_options
+cg.run

data/giturl.gemspec

@@ -35,8 +35,10 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'github_changelog_generator', '>= 1.15.0'
-  spec.add_development_dependency 'irb'
-  spec.add_development_dependency 'pry'
+  spec.add_development_dependency 'pry', '>= 0.12.2'
+  spec.add_development_dependency 'pry-byebug', '>= 3.9.0'
   spec.add_development_dependency 'rake', '>= 12.3.3'
+  spec.add_development_dependency 'rspec', '>= 3.9.0'
   spec.add_development_dependency 'rubocop', '>= 0.80.1'
+  spec.add_development_dependency 'rubocop-rspec', '>= 1.38.1'
 end

data/lib/command_giturl.rb

@@ -0,0 +1,58 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+# converter module from path to url
+module Giturl
+  require 'optparse'
+  require 'giturl'
+
+  # command line wrapper
+  class CommandGiturl
+    attr_accessor :params
+
+    def parse_options
+      @params = {}
+      OptionParser.new do |opts|
+        opts.version = VERSION
+        opts.on('-o', '--open', 'Open the URL in your browser. default: no') { |v| v }
+        opts.on('-a APPNAME', '--app=APPNAME', 'Specify a browser. "Safari.app"') { |v| v }
+        opts.on('-v', '--verbose', 'Verbose mode. default: no') { |v| v }
+        opts.on_tail('-h', '--help', 'Show this message') do
+          puts opts
+          exit
+        end
+        opts.on_tail('-V', '--version', 'Show version') do
+          puts opts.ver
+          exit
+        end
+        opts.banner = <<~BANNER
+
+          #{opts.ver}
+          A tiny utility that displays and opens GitHub URLs for your local directory.
+            visit: https://github.com/shinyaohtani/giturl
+
+          Usage: #{opts.program_name} [options] [dirs]
+           [options] are:
+        BANNER
+
+        opts.parse!(ARGV, into: @params)
+      end
+    end
+
+    def run
+      ARGV.each do |arg|
+        if Giturl.git_managed?(arg)
+          url = Giturl.convert(arg)
+          print "#{url}\n"
+          if @params[:open]
+            comm = +"open #{url}"
+            comm << " -a #{@params[:app]}" if @params[:app]
+            system(comm)
+          end
+        elsif @params[:verbose]
+          print "Not git-managed-dir:  #{arg}\n"
+        end
+      end
+    end
+  end
+end

data/lib/giturl/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Giturl
-  VERSION = '1.1.5'
+  VERSION = '1.1.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: giturl
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.6
 platform: ruby
 authors:
 - Shinya Ohtani (shinyaohtani@github)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-18 00:00:00.000000000 Z
+date: 2020-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -39,33 +39,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.15.0
 - !ruby/object:Gem::Dependency
-  name: irb
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.12.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.12.2
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.9.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.9.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 12.3.3
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.9.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -94,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.80.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.38.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.38.1
 description: |
   Show or open GitHub URL for your local directory.
   You can use giturl to display the URL corresponding to the git-managed directory given as an argument, and you can open the URL directly in your browser if needed.
@@ -105,6 +133,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
@@ -115,6 +144,7 @@ files:
 - bin/giturl
 - bin/setup
 - giturl.gemspec
+- lib/command_giturl.rb
 - lib/giturl.rb
 - lib/giturl/version.rb
 homepage: https://github.com/shinyaohtani/giturl