gitlab_roulette 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a95ba8eb6a186d841f06c39f8e8e8e802f827f8b4c80b52431b0116a3706974
-  data.tar.gz: a27d73f5e631d4e079a32a6a40080ab91b9022988710fb4fbd7575523b0c64a5
+  metadata.gz: 45f174369a6c31888b7f3cedf4e1bd495ed8dce4ac7a7824a3c65c72eb47346d
+  data.tar.gz: f27f1e828800179dfd44bbe26f0d1012bd86827c8585629f9450ddffa13d40f4
 SHA512:
-  metadata.gz: 77a089247d88190d1b948f43489efa78129aa2f35bfc39bc5dcf036086ceb263c45e2a32b706ebf03d137dfadb9927bdf9f88aa33f6dad425ef66abad3d15c62
-  data.tar.gz: 6c335455cf9b888ca47e917fe3ba0a55255cae9019bcd0b5f5d5663dffb99066b110a97c2adaba83bb43383fdbe63c245605f29c76ace8887a7ddb2e6d749899
+  metadata.gz: e085b139aaaf319915fb7f5da03c5fdd3b64b3f691e88e538892556db69f06eefbadc6a0869b077f3c05cfda24ad287c2eb63e6c18550853469e77bdd973c901
+  data.tar.gz: 3adf52a215947057c817cc2696371c4d04a70deb509c1b1a3a63a074886673cefef61a91491c6dc82601fbe1de1e2a53a9a775f785edadd9709a841efe5e7ae6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_roulette (1.0.1)
+    gitlab_roulette (1.1.0)
 
 GEM
   remote: https://rubygems.org/

data/bin/console

@@ -2,6 +2,7 @@
 
 require "bundler/setup"
 require "gitlab_roulette"
+require "danger"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/lib/gitlab_roulette/version.rb

@@ -1,3 +1,3 @@
 module GitlabRoulette
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_roulette
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Andrei Merfu
@@ -90,7 +90,6 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - CODE_OF_CONDUCT.md
-- Dangerfile
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -98,9 +97,6 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- danger/plugins/helper.rb
-- danger/plugins/roulette.rb
-- danger/roulette/Dangerfile
 - gitlab_roulette.gemspec
 - lib/gitlab_roulette.rb
 - lib/gitlab_roulette/danger/helper.rb

data/Dangerfile

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'lib/gitlab_roulette/gitlab_danger'
-require_relative 'lib/gitlab_roulette/danger/request_helper'
-
-danger.import_plugin('danger/plugins/helper.rb')
-danger.import_plugin('danger/plugins/roulette.rb')
-
-danger.import_dangerfile(path: 'danger/roulette')

data/danger/plugins/helper.rb

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-require_relative '../../lib/gitlab_roulette/danger/helper'
-
-module Danger
-  # Common helper functions for our danger scripts. See Gitlab::Danger::Helper
-  # for more details
-  class Helper < Plugin
-    # Put the helper code somewhere it can be tested
-    include GitlabRoulette::Danger::Helper
-  end
-end

data/danger/plugins/roulette.rb

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-require_relative '../../lib/gitlab_roulette/danger/roulette'
-
-module Danger
-  class Roulette < Plugin
-    # Put the helper code somewhere it can be tested
-    include GitlabRoulette::Danger::Roulette
-  end
-end

data/danger/roulette/Dangerfile

@@ -1,95 +0,0 @@
-# frozen_string_literal: true
-
-require 'digest/md5'
-
-MESSAGE = <<MARKDOWN
-## Reviewer roulette
-
-Changes that require review have been detected! A merge request is normally
-reviewed by both a reviewer and a maintainer in its primary category (e.g.
-~frontend or ~backend), and by a maintainer in all other categories.
-MARKDOWN
-
-CATEGORY_TABLE_HEADER = <<MARKDOWN
-
-To spread load more evenly across eligible reviewers, Danger has randomly picked
-a candidate for each review slot. Feel free to override this selection if you
-think someone else would be better-suited, or the chosen person is unavailable.
-
-Once you've decided who will review this merge request, mention them as you
-normally would! Danger does not (yet?) automatically notify them for you.
-
-| Category | Reviewer | Maintainer |
-| -------- | -------- | ---------- |
-MARKDOWN
-
-UNKNOWN_FILES_MESSAGE = <<MARKDOWN
-
-These files couldn't be categorised, so Danger was unable to suggest a reviewer.
-Please consider creating a merge request to
-[add support](https://gitlab.com/gitlab-org/gitlab/blob/master/lib/gitlab/danger/helper.rb)
-for them.
-MARKDOWN
-
-NO_REVIEWER = 'No reviewer available'.freeze
-NO_MAINTAINER = 'No maintainer available'.freeze
-
-def spin_for_category(team, project, category, branch_name)
-  puts "team = #{team}\n project=#{project}\n category=#{category}\n branch_name=#{branch_name}\n"
-  random = roulette.new_random(branch_name)
-  labels = gitlab.mr_labels
-  puts "labels = #{labels}"
-
-  reviewers, traintainers, maintainers =
-    %i[reviewer? traintainer? maintainer?].map do |kind|
-      team.select do |member|
-        member.public_send(kind, project, category, labels) # rubocop:disable GitlabSecurity/PublicSend
-      end
-    end
-
-  # TODO: take CODEOWNERS into account?
-  # https://gitlab.com/gitlab-org/gitlab/issues/26723
-
-  puts "reviewers = #{reviewers}\n maintainers=#{maintainers}\n"
-  # Make traintainers have triple the chance to be picked as a reviewer
-  reviewer = roulette.spin_for_person(reviewers + traintainers + traintainers, random: random)
-  maintainer = roulette.spin_for_person(maintainers, random: random)
-
-  "| #{helper.label_for_category(category)} | #{reviewer&.markdown_name || NO_REVIEWER} | #{maintainer&.markdown_name || NO_MAINTAINER} |"
-end
-
-changes = helper.changes_by_category
-
-# Ignore any files that are known but uncategorized. Prompt for any unknown files
-changes.delete(:none)
-categories = changes.keys - [:unknown]
-
-# Ensure to spin for database reviewer/maintainer when ~database is applied (e.g. to review SQL queries)
-categories << :database if gitlab.mr_labels.include?('database') && !categories.include?(:database)
-
-# Single codebase MRs are reviewed using a slightly different process, so we
-# disable the review roulette for such MRs.
-# CSS Clean up MRs are reviewed using a slightly different process, so we
-# disable the review roulette for such MRs.
-if changes.any? && !gitlab.mr_labels.include?('single codebase') && !gitlab.mr_labels.include?('CSS cleanup')
-  # Strip leading and trailing CE/EE markers
-  canonical_branch_name =
-    roulette.canonical_branch_name(gitlab.mr_json['source_branch'])
-
-  team =
-    begin
-      roulette.project_team(helper.project_name)
-    rescue => err
-      warn("Reviewer roulette failed to load team data: #{err.message}")
-      []
-    end
-
-  project = helper.project_name
-  unknown = changes.fetch(:unknown, [])
-
-  rows = categories.map { |category| spin_for_category(team, project, category, canonical_branch_name) }
-
-  markdown(MESSAGE)
-  markdown(CATEGORY_TABLE_HEADER + rows.join("\n")) unless rows.empty?
-  markdown(UNKNOWN_FILES_MESSAGE + helper.markdown_list(unknown)) unless unknown.empty?
-end