gitlab_quality-test_tooling 3.21.2 → 3.21.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ae21eb1d647c738006ae06faef24f5268d61fe30d0b72bd9aeebaa6b4b7d93e
-  data.tar.gz: 934cd5bd6d0bdac314f7209d9fa212dafa4b14ec1daffb1f0dff77106bcbd0b0
+  metadata.gz: cc1eb2f60dd3f394c55bfbaff26309fbad61afd5eeceaa9c794092c1997f03eb
+  data.tar.gz: 5bfe5172b7ef0212b31b3eba7eb2483d1bebe57d2627d8b0863e0b5df61d7348
 SHA512:
-  metadata.gz: 0b2c9ab4651163565cda4e146487bfa7ffec5b9e4d47a289431d4427926e35a8b92d81f759f6838169b2d2572a5fcac6c7c48fc9250cd572219f77a60f96e5aa
-  data.tar.gz: 69479474c04e85f4ba6da8748af8d58fb7b85e7175ddae13c524fd2303f5e324af9c9d1dd9e07220509c52e107cb155545d0515ae4e49b9d75cb77df855a5a9b
+  metadata.gz: 9b892716ac4868efafa4dfebea723db41e0eb62d4bf036bbc2b36d0cd79f9e1fd3d58a6e8104f8a8ecf4999dae3315cd9f4103f3ef4e43556f28a0a0192062a7
+  data.tar.gz: 5c690dc16665ac12a38abb803af01399ded95c49c5b071127c7e0d67fc7e26dd1c9c87c9d122b8d3262f6e8ae7660a093238bbb8ba822d156caf9b6ed26f3abc

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (3.21.2)
+    gitlab_quality-test_tooling (3.21.4)
       activesupport (>= 7.0)
       amatch (~> 0.4.1)
       fog-google (~> 1.25)

data/lib/gitlab_quality/test_tooling/code_coverage/click_house/category_owners_table.rb

@@ -15,8 +15,10 @@ module GitlabQuality
 
           KNOWN_UNOWNED = %w[shared not_owned tooling].freeze
 
-          # SQL query to get the latest ownership record for each unique category+ownership combination
-          # Partitions by the full composite key to handle cases where a category has multiple ownerships
+          # Every owner a category has ever had, including ones it has moved off, one row per
+          # distinct owner and in no particular order. Only `push` reads this, to skip rows it
+          # has already stored. Deduping to one row per category here would make it re-insert
+          # old owners on every run.
           LATEST_RECORDS_QUERY = <<~SQL
             SELECT category, group, stage, section
             FROM (
@@ -27,6 +29,18 @@ module GitlabQuality
             WHERE rn = 1
           SQL
 
+          # The current owner of each category, one row per category, which is what `owners`
+          # and `owner_records` serve to callers. The table keeps every past owner as well, so
+          # the newest timestamp is what picks the current one. The owner columns after the
+          # timestamp in the ORDER BY break ties, so two rows sharing a category's newest
+          # timestamp always resolve the same way.
+          LATEST_OWNERS_QUERY = <<~SQL
+            SELECT category, group, stage, section
+            FROM %{table_name}
+            ORDER BY category, timestamp DESC, group, stage, section
+            LIMIT 1 BY category
+          SQL
+
           # Insert only new category ownership records that don't already exist
           # This avoids needing TRUNCATE permission
           def push(data)
@@ -71,7 +85,7 @@ module GitlabQuality
           private
 
           def records
-            @records ||= fetch_latest_records.each_with_object({}) do |record, hsh|
+            @records ||= fetch_latest_owners.each_with_object({}) do |record, hsh|
               hsh[record["category"]] = record.slice("group", "stage", "section")
             end
           end
@@ -114,6 +128,11 @@ module GitlabQuality
             client.query(query)
           end
 
+          def fetch_latest_owners
+            query = format(LATEST_OWNERS_QUERY, table_name: table_name)
+            client.query(query)
+          end
+
           def sanitized_data_record(record)
             {
               timestamp: time,

data/lib/gitlab_quality/test_tooling/code_coverage/click_house/test_file_mappings_table.rb

@@ -134,26 +134,21 @@ module GitlabQuality
           def fetch_existing_mappings(ci_project_path, records) # rubocop:disable Metrics/AbcSize
             # Query for ALL latest mappings for this project
             # We filter in Ruby rather than building dynamic SQL to avoid injection risks
+            # Aggregate rather than matching rows against a set of the latest timestamps.
+            # The set form has to materialise one tuple per stored mapping before it can
+            # filter anything, which exceeds the server's memory limit at this table's
+            # size; argMax streams and peaks at roughly a quarter of it.
             sql = <<~SQL
               SELECT
                 test_file,
                 source_file,
-                category,
-                `group`,
-                stage,
-                section
+                argMax(category, timestamp) AS category,
+                argMax(`group`, timestamp) AS `group`,
+                argMax(stage, timestamp) AS stage,
+                argMax(section, timestamp) AS section
               FROM #{full_table_name}
               WHERE ci_project_path = {project_path:String}
-                AND (ci_project_path, test_file, source_file, timestamp) IN (
-                  SELECT
-                    ci_project_path,
-                    test_file,
-                    source_file,
-                    MAX(timestamp) AS timestamp
-                  FROM #{full_table_name}
-                  WHERE ci_project_path = {project_path:String}
-                  GROUP BY ci_project_path, test_file, source_file
-                )
+              GROUP BY test_file, source_file
             SQL
 
             # Substitute project_path value using manual escaping (client doesn't support parameterized queries)

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "3.21.2"
+    VERSION = "3.21.4"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 3.21.2
+  version: 3.21.4
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-09-01 00:00:00.000000000 Z
+date: 2026-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control