gitlab_quality-test_tooling 2.13.0 → 2.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 886a32709ca918a9c86d8a770239f809fa51dce3392891b7712f2b085b52a409
-  data.tar.gz: 1ee8b80242894a606e11c395b23f498d9a5f8d5fcf65447b93ce21006ecb1aaa
+  metadata.gz: 0017f4373fb21a5d7313301ca050e381a4e462ec74a50a41aab37ab2afbd31d7
+  data.tar.gz: 10c3f5d6750b27058de16f482b3286b5bc96c57b3565f2494965d2d255512462
 SHA512:
-  metadata.gz: 5a23f34a8668c4a4d863aa2cfb16fbc1505c4534f2c06f2df43e257b71704f706e9977efa3c18a8dc81d9d2bb6dfa7c09dc65a5a993a50b79468e683022214d7
-  data.tar.gz: 4685c3fd432a26940b23a69d48e9214aa33950697f91ed43d0b9fa6ecd113f25dd68ab5d95a7cbbcdd129ebff3801cd83c8dcd0a52cabaf860bc332cb1f7f13d
+  metadata.gz: c4963020e2f5e405efd8e984966e918430eedb95ba354a6aff4fef068330cd3a152d68d5008b0d4325c5871654c54251206f11e2386f58fa34893e7338f5bb76
+  data.tar.gz: 5489a80567198e869517b5aca8e9f1d35871ec470d9e716f62c97e6b15e8afae7f5f7f7622e62e6273294f9268845e1874bcba9677c5f2f52bf5ccefb806774e

data/Gemfile.lock

@@ -1,17 +1,17 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (2.13.0)
+    gitlab_quality-test_tooling (2.16.0)
       activesupport (>= 7.0, < 7.3)
       amatch (~> 0.4.1)
       fog-google (~> 1.24, >= 1.24.1)
-      gitlab (>= 4.19, < 6.0)
+      gitlab (>= 4.19, < 7.0)
       http (~> 5.0)
       influxdb-client (~> 3.1)
       nokogiri (~> 1.10)
       parallel (>= 1, < 2)
       rainbow (>= 3, < 4)
-      rspec-parameterized (>= 1.0.0, < 3.0)
+      rspec-parameterized (>= 1.0, < 3.0)
       table_print (= 1.5.7)
       zeitwerk (>= 2, < 3)
 

data/lib/gitlab_quality/test_tooling/gitlab_client/issues_client.rb

@@ -175,7 +175,7 @@ module GitlabQuality
         def find_commit_parent(project, sha)
           handle_gitlab_client_exceptions do
             # In a merged results commit, the first parent is the one from
-            # the main branch, and the second parent is from the branch
+            # the default branch, and the second parent is from the branch
             # itself (more likely to have caused the issue)
             client.commit(project, sha).parent_ids.last
           end

data/lib/gitlab_quality/test_tooling/gitlab_client/issues_dry_client.rb

@@ -4,7 +4,7 @@ module GitlabQuality
   module TestTooling
     module GitlabClient
       class IssuesDryClient < IssuesClient
-        def create_issue(title:, description:, labels:, issue_type: 'issue', confidential: false)
+        def create_issue(title:, description:, labels:, issue_type: 'issue', _assignee_id: nil, _due_date: nil, confidential: false)
           attrs = { description: description, labels: labels, confidential: confidential }
 
           puts "The following #{issue_type} would have been created:"

data/lib/gitlab_quality/test_tooling/report/concerns/results_reporter.rb

@@ -36,7 +36,7 @@ module GitlabQuality
           end
 
           def new_issue_labels(_test)
-            %w[Quality status::automated]
+            %w[E2E status::automated]
           end
 
           def up_to_date_labels(test:, issue: nil, new_labels: Set.new)

data/lib/gitlab_quality/test_tooling/report/concerns/utils.rb

@@ -43,9 +43,9 @@ module GitlabQuality
             # Some of those run in their own project, so CI_PROJECT_NAME is the name we need. Those are:
             #   nightly, staging, canary, production, and preprod
             #
-            # MR, master/main, and gitlab tests run in gitlab-qa, but we only want to report tests run on
-            # master/main because the other pipelines will be monitored by the author of the MR that triggered them.
-            # So we assume that we're reporting a master/main pipeline if the project name is 'gitlab'.
+            # MR, master, and gitlab tests run in gitlab-qa, but we only want to report tests run on
+            # master because the other pipelines will be monitored by the author of the MR that triggered them.
+            # So we assume that we're reporting a master pipeline if the project name is 'gitlab'.
 
             @pipeline ||= Runtime::Env.pipeline_from_project_name
           end

data/lib/gitlab_quality/test_tooling/report/generate_test_session.rb

@@ -33,7 +33,7 @@ module GitlabQuality
           issue = gitlab.create_issue(
             title: "#{Time.now.strftime('%Y-%m-%d')} Test session report | #{Runtime::Env.qa_run_type}",
             description: generate_description(tests),
-            labels: ['automation:bot-authored', 'Quality', 'QA', 'triage report', pipeline_name_label],
+            labels: ['automation:bot-authored', 'E2E', 'triage report', pipeline_name_label],
             confidential: confidential
           )
 

data/lib/gitlab_quality/test_tooling/report/relate_failure_issue.rb

@@ -25,14 +25,21 @@ module GitlabQuality
 
         NEW_ISSUE_LABELS = Set.new(%w[test failure::new priority::2 automation:bot-authored type::maintenance]).freeze
         SCREENSHOT_IGNORED_ERRORS = ['500 Internal Server Error', 'fabricate_via_api!', 'Error Code 500'].freeze
-
+        FAILURE_ISSUE_GUIDE_URL = "https://handbook.gitlab.com/handbook/engineering/testing/guide-to-e2e-test-failure-issues/"
+        FAILURE_ISSUE_HANDBOOK_GUIDE = "**:rotating_light: [End-to-End Test Failure Issue Debugging Guide](#{FAILURE_ISSUE_GUIDE_URL}) :rotating_light:**\n".freeze
         # Map commits to security fork (gitlab-org/security/gitlab) for gitlab-org/gitlab since security patches exist
         # there before being released to the public repository
         DIFF_PROJECT_MAPPINGS = {
+          'gitlab-org/quality/e2e-test-issues' => 'gitlab-org/security/gitlab',
           'gitlab-org/gitlab' => 'gitlab-org/security/gitlab',
           'gitlab-org/customers-gitlab-com' => 'gitlab-org/customers-gitlab-com'
         }.freeze
 
+        # Don't use the E2E test issues project for commit parent
+        COMMIT_PROJECT_MAPPINGS = {
+          'gitlab-org/quality/e2e-test-issues' => 'gitlab-org/gitlab'
+        }.freeze
+
         # The project contains record of the deployments we use to determine the commit diff
         OPS_RELEASES_METADATA_PROJECT = 'gitlab-org/release/metadata'
 
@@ -179,7 +186,9 @@ module GitlabQuality
           end
 
           created_issue = super
-          test.failure_issue ||= created_issue.web_url
+
+          # On a dry run, created_issue may not be populated
+          test.failure_issue ||= created_issue&.web_url
 
           created_issue
         end
@@ -300,7 +309,7 @@ module GitlabQuality
         end
 
         def new_issue_description(test)
-          super + [
+          FAILURE_ISSUE_HANDBOOK_GUIDE + super + [
             "\n#{commit_diff_section}",
             "### Stack trace",
             "```\n#{test.full_stacktrace}\n```",
@@ -321,7 +330,7 @@ module GitlabQuality
             pipeline = ops_gitlab_client.find_pipeline(Runtime::Env.ci_project_path, Runtime::Env.ci_pipeline_id.to_i)
             generate_ops_gitlab_diff(pipeline)
           else
-            pipeline = gitlab.find_pipeline(project, Runtime::Env.ci_pipeline_id.to_i)
+            pipeline = gitlab.find_pipeline(Runtime::Env.ci_project_path, Runtime::Env.ci_pipeline_id.to_i)
             generate_gitlab_diff(pipeline)
           end
         end
@@ -429,7 +438,8 @@ module GitlabQuality
 
         def generate_gitlab_diff(pipeline)
           pipeline_sha = pipeline.sha
-          parent_sha = gitlab.find_commit_parent(project, pipeline_sha)
+          commit_project = COMMIT_PROJECT_MAPPINGS.fetch(project, project)
+          parent_sha = gitlab.find_commit_parent(commit_project, pipeline_sha)
           diff_project = if DIFF_PROJECT_MAPPINGS.key?(project)
                            DIFF_PROJECT_MAPPINGS[project]
                          else
@@ -544,6 +554,8 @@ module GitlabQuality
         end
 
         def screenshot_artifact_url(test)
+          return "" unless test.screenshot_image
+
           ci_job_url = test.ci_job_url
           screenshot_path = test.screenshot_image[%r{qa/.*$}]
 

data/lib/gitlab_quality/test_tooling/runtime/env.rb

@@ -46,7 +46,7 @@ module GitlabQuality
         end
 
         def default_branch
-          env_var_value_if_defined('QA_DEFAULT_BRANCH') || 'main'
+          'master'
         end
 
         def ci_api_v4_url

data/lib/gitlab_quality/test_tooling/test_meta/processor/add_to_blocking_processor.rb

@@ -97,7 +97,7 @@ module GitlabQuality
 
                   This MR was created based on data from reliable e2e test report: #{context.report_issue}
 
-                  /label ~"Quality" ~"QA" ~"type::maintenance"
+                  /label ~"E2E" ~"type::maintenance"
                   /label ~"devops::#{devops_stage}"
                   #{context.label_from_product_group(product_group)}
 

data/lib/gitlab_quality/test_tooling/test_meta/processor/add_to_quarantine_processor.rb

@@ -137,7 +137,7 @@ module GitlabQuality
                 - [ ] To ensure a faster turnaround, ask in the `#quality_maintainers` Slack channel for someone to review and merge the merge request, rather than assigning it directly.
 
                 <!-- Base labels. -->
-                /label ~"Quality" ~"QA" ~"type::maintenance" ~"maintenance::pipelines"
+                /label ~"E2E" ~"type::maintenance" ~"maintenance::pipelines"
 
                 <!--
                 Choose the stage that appears in the test path, e.g. ~"devops::create" for

data/lib/gitlab_quality/test_tooling/test_result/base_test_result.rb

@@ -14,7 +14,8 @@ module GitlabQuality
           "Error reference number: 502",
           "(502): `GitLab is not responding`",
           "<head><title>502 Bad Gateway</title></head>",
-          "14:connections to all backends failing"
+          "14:connections to all backends failing",
+          "gitlab_canary=true cookie was set in browser but 'Next' badge was not shown on UI"
         ].freeze
 
         SHARED_EXAMPLES_CALLERS = %w[include_examples it_behaves_like].freeze
@@ -114,7 +115,7 @@ module GitlabQuality
         end
 
         def file_base_url
-          @file_base_url ||= "https://gitlab.com/#{project}/-/blob/#{ref}/"
+          @file_base_url ||= "https://gitlab.com/#{project == 'gitlab-org/quality/e2e-test-issues' ? 'gitlab-org/gitlab' : project}/-/blob/#{ref}/"
         end
 
         def test_file_link
@@ -143,15 +144,23 @@ module GitlabQuality
         def files_client
           @files_client ||= GitlabClient::RepositoryFilesClient.new(
             token: token,
-            project: project,
+            project: mapped_project,
             file_path: file,
-            ref: ref)
+            ref: ref.nil? || ref.empty? ? 'master' : ref)
         end
 
         private
 
         attr_reader :token, :project, :ref
 
+        def mapped_project
+          if project == 'gitlab-org/quality/e2e-test-issues'
+            'gitlab-org/gitlab'
+          else
+            project
+          end
+        end
+
         def screenshot
           report.fetch('screenshot', nil)
         end

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "2.13.0"
+    VERSION = "2.16.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.16.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-05-23 00:00:00.000000000 Z
+date: 2025-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control
@@ -263,7 +263,7 @@ dependencies:
         version: '4.19'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -273,7 +273,7 @@ dependencies:
         version: '4.19'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6.0'
+        version: '7.0'
 - !ruby/object:Gem::Dependency
   name: http
   requirement: !ruby/object:Gem::Requirement