gitlab_quality-test_tooling 1.33.0 → 1.35.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19bea0cdd5a0f100cec11b00c6415c39f8ab637165f67171ad6edac7c33128b9
-  data.tar.gz: 9727a96a8ca06238ae89bacdb6f3cc88b66451a6190cac8df48fc82102e7c155
+  metadata.gz: af317c2353ed0cd5ac69cda95756183c9811e4b9983397e5658972cc2ec80853
+  data.tar.gz: 4ef83ce3161fe6560b6e3e9d7426673e50b80291973ccbff0a5051184dcc13a4
 SHA512:
-  metadata.gz: 5dfdfea69e7e2f3500b243d83489050e6d0f2a251a1657a43250206a3710c0b848bdbb38ac34e645a2ec1dc4fc19ce4df47afa21a8c038754ac76f6b606cb14f
-  data.tar.gz: 7aa7942d0f0f86c75a2f07eea937c70c9f725b4025302778176e0fb0b9a14db41acd983d1202f86b6a59ce6f00b1c6f85ba214d86deb1a947167a57ff82ad3a4
+  metadata.gz: 8a015884914a10e72b3ad2bada2ba48444a15dd701a752c54029fa5acf9906e3384ac0ca9d991c04657b31a9fc25d6ec5708ed128e232ac6c5e8a4e76563c1db
+  data.tar.gz: bec57b7c3f65ead2655c992ee9ac972551bbcff9454b81b2b76a5ae11479e7f441717244a3b853c857e3f5ac4377eafbfd116272cea75feca20fc7b1c0d43397

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gitlab_quality-test_tooling (1.33.0)
+    gitlab_quality-test_tooling (1.35.0)
       activesupport (>= 7.0, < 7.2)
       amatch (~> 0.4.1)
       gitlab (~> 4.19)

data/lib/gitlab_quality/test_tooling/report/health_problem_reporter.rb

@@ -20,6 +20,18 @@ module GitlabQuality
         FOUND_IN_MR_LABEL     = '~"found:in MR"'
         FOUND_IN_MASTER_LABEL = '~"found:master"'
 
+        def initialize(input_files: [], **kwargs)
+          super(input_files: input_files, **kwargs)
+        end
+
+        def most_recent_report_date_for_issue(issue_iid:)
+          if report_in_discussion?
+            most_recent_report_from_discussion(issue_iid: issue_iid)
+          else
+            most_recent_report_from_note(issue_iid: issue_iid)
+          end
+        end
+
         private
 
         def problem_type
@@ -62,6 +74,28 @@ module GitlabQuality
           found_label
         end
 
+        def most_recent_report_from_discussion(issue_iid:)
+          reports_discussion = existing_reports_discussion(issue_iid: issue_iid)
+          return unless reports_discussion
+
+          # We're skipping the first note of the discussion as this is the "non-collapsible note", aka
+          # the "header note", which doesn't contain any stack trace.
+          reports_discussion.notes[1..].filter_map do |reports_note|
+            most_recent_report_from_reports_note(reports_note)&.report_date
+          end.max
+        end
+
+        def most_recent_report_from_note(issue_iid:)
+          reports_note = existing_reports_note(issue_iid: issue_iid)
+          return unless reports_note
+
+          most_recent_report_from_reports_note(reports_note)&.report_date
+        end
+
+        def most_recent_report_from_reports_note(reports_note)
+          @most_recent_report_from_reports_note ||= report_lines(reports_note&.body.to_s).first
+        end
+
         def run!
           puts "Reporting tests in `#{files.join(',')}` as issues in project `#{project}` via the API at `#{Runtime::Env.gitlab_api_base}`."
 
@@ -102,11 +136,11 @@ module GitlabQuality
         def add_report_to_issue(issue:, test:, related_issues:) # rubocop:disable Metrics/AbcSize -- FIXME
           current_reports_note =
             if report_in_discussion?
-              reports_discussion = find_or_create_reports_discussion(issue: issue)
+              reports_discussion = find_or_create_reports_discussion(issue_iid: issue.iid)
 
               find_failure_discussion_note(issue: issue, test: test, reports_discussion: reports_discussion)
             else
-              existing_reports_note(issue: issue)
+              existing_reports_note(issue_iid: issue.iid)
             end
 
           new_reports_list = add_report_for_test(current_reports_content: current_reports_note&.body.to_s, test: test)
@@ -135,15 +169,15 @@ module GitlabQuality
           end
         end
 
-        def find_or_create_reports_discussion(issue:)
-          reports_discussion = existing_reports_discussion(issue: issue)
+        def find_or_create_reports_discussion(issue_iid:)
+          reports_discussion = existing_reports_discussion(issue_iid: issue_iid)
           return reports_discussion if reports_discussion
 
-          gitlab.create_issue_discussion(iid: issue.iid, note: report_section_header)
+          gitlab.create_issue_discussion(iid: issue_iid, note: report_section_header)
         end
 
-        def existing_reports_discussion(issue:)
-          gitlab.find_issue_discussions(iid: issue.iid).find do |discussion|
+        def existing_reports_discussion(issue_iid:)
+          gitlab.find_issue_discussions(iid: issue_iid).find do |discussion|
             next if discussion.individual_note
             next unless discussion.notes.first
 
@@ -151,8 +185,8 @@ module GitlabQuality
           end
         end
 
-        def existing_reports_note(issue:)
-          gitlab.find_issue_notes(iid: issue.iid).find do |note|
+        def existing_reports_note(issue_iid:)
+          gitlab.find_issue_notes(iid: issue_iid).find do |note|
             note.body.start_with?(report_section_header)
           end
         end

data/lib/gitlab_quality/test_tooling/report/knapsack_report_issue.rb

@@ -109,6 +109,10 @@ module GitlabQuality
             description: updated_description
           }
 
+          # We reopen closed issues to not lose any history
+          state_event = issue.state == 'closed' ? 'reopen' : nil
+          issue_attrs[:state_event] = state_event if state_event
+
           gitlab.edit_issue(iid: issue.iid, options: issue_attrs)
           puts "  => Added a report in #{issue.web_url}!"
         end

data/lib/gitlab_quality/test_tooling/test_meta/test_meta_updater.rb

@@ -11,7 +11,6 @@ module GitlabQuality
         attr_reader :project, :ref, :report_issue, :processed_commits
 
         TEST_PLATFORM_MAINTAINERS_SLACK_CHANNEL_ID = 'C0437FV9KBN' # test-platform-maintainers
-        BATCH_LIMIT = 10
 
         def initialize(token:, project:, specs_file:, processor:, ref: 'master', dry_run: false)
           @specs_file = specs_file
@@ -29,7 +28,7 @@ module GitlabQuality
 
             contents['specs'].each do |spec|
               processor.create_commit(spec, self)
-              break if processed_commits.keys.count >= BATCH_LIMIT
+              break if processed_commits.keys.count >= ENV.fetch('BATCH_LIMIT', 10)
             end
 
             processor.create_merge_requests(self)

data/lib/gitlab_quality/test_tooling/version.rb

@@ -2,6 +2,6 @@
 
 module GitlabQuality
   module TestTooling
-    VERSION = "1.33.0"
+    VERSION = "1.35.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gitlab_quality-test_tooling
 version: !ruby/object:Gem::Version
-  version: 1.33.0
+  version: 1.35.0
 platform: ruby
 authors:
 - GitLab Quality
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-26 00:00:00.000000000 Z
+date: 2024-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: climate_control